Received: (at 29272) by debbugs.gnu.org; 2 Dec 2017 08:14:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 02 03:14:09 2017 Received: from localhost ([127.0.0.1]:40953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eL2w3-00074L-82 for submit <at> debbugs.gnu.org; Sat, 02 Dec 2017 03:14:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eL2w0-00073k-TJ for 29272 <at> debbugs.gnu.org; Sat, 02 Dec 2017 03:14:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eL2vr-00035p-R4 for 29272 <at> debbugs.gnu.org; Sat, 02 Dec 2017 03:13:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_50,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eL2vd-0002xm-Ku; Sat, 02 Dec 2017 03:13:41 -0500 Received: from [176.228.60.248] (port=3849 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eL2vc-0000G3-Tr; Sat, 02 Dec 2017 03:13:41 -0500 Date: Sat, 02 Dec 2017 10:13:23 +0200 Message-Id: <83po7x1ra4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Drew Adams <drew.adams@HIDDEN> In-reply-to: <33ec5980-5590-4c4f-a4d1-25da55da8c2f@default> (message from Drew Adams on Fri, 1 Dec 2017 13:12:39 -0800 (PST)) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <<83shdjn3ju.fsf@HIDDEN>> <<83mv3rn02t.fsf@HIDDEN>> <<20171114205449.GA8025@ACM>> <<87fu8xnc17.fsf@HIDDEN>> <<83h8td4uw5.fsf@HIDDEN>> <<5A1E724A.5030507@HIDDEN>> <<20171129183717.GA8914@ACM>> <<83609s52xt.fsf@HIDDEN>> <<20171201165740.GE3840@ACM>> <<1c4abffb-e975-41b1-a368-29518bc3b360@default>> <<83y3mm1bfu.fsf@HIDDEN>> <33ec5980-5590-4c4f-a4d1-25da55da8c2f@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Fri, 1 Dec 2017 13:12:39 -0800 (PST) > From: Drew Adams <drew.adams@HIDDEN> > Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN > > > > I hate to say it, but we probably need a user option (or at > > > least a variable) for this. > > > > We already have it: double-click-time. This discussion is > > about users who customized that to "infinity". > > Well, I don't really want to get into a discussion here, > but to me, `double-click-time' should apply only to, well, > double-clicking. This is not the same thing, IIUC. > > But perhaps I missed something. May I suggest reading the thread, to avoid missing things? > What is the proposed `C-h k' behavior for users who have not > customized `double-click-time' to "infinity"? To wait that time for a next mouse gesture, before deciding on which sequence to produce help. Once again, please read the discussion, the information is there.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 1 Dec 2017 21:12:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 01 16:12:49 2017 Received: from localhost ([127.0.0.1]:40606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eKsc5-00053g-EJ for submit <at> debbugs.gnu.org; Fri, 01 Dec 2017 16:12:49 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:29097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <drew.adams@HIDDEN>) id 1eKsc4-00053R-3M for 29272 <at> debbugs.gnu.org; Fri, 01 Dec 2017 16:12:48 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vB1LCgTC004564 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2017 21:12:42 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vB1LCfue012926 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2017 21:12:41 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vB1LCe7F016229; Fri, 1 Dec 2017 21:12:41 GMT MIME-Version: 1.0 Message-ID: <33ec5980-5590-4c4f-a4d1-25da55da8c2f@default> Date: Fri, 1 Dec 2017 13:12:39 -0800 (PST) From: Drew Adams <drew.adams@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, Drew Adams <drew.adams@HIDDEN> Subject: RE: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <<83shdjn3ju.fsf@HIDDEN>> <<83mv3rn02t.fsf@HIDDEN>> <<20171114205449.GA8025@ACM>> <<87fu8xnc17.fsf@HIDDEN>> <<83h8td4uw5.fsf@HIDDEN>> <<5A1E724A.5030507@HIDDEN>> <<20171129183717.GA8914@ACM>> <<83609s52xt.fsf@HIDDEN>> <<20171201165740.GE3840@ACM>> <<1c4abffb-e975-41b1-a368-29518bc3b360@default>> <<83y3mm1bfu.fsf@HIDDEN>> In-Reply-To: <<83y3mm1bfu.fsf@HIDDEN>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 29272 Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > > I hate to say it, but we probably need a user option (or at > > least a variable) for this. >=20 > We already have it: double-click-time. This discussion is=20 > about users who customized that to "infinity". Well, I don't really want to get into a discussion here, but to me, `double-click-time' should apply only to, well, double-clicking. This is not the same thing, IIUC. But perhaps I missed something. What is the proposed `C-h k' behavior for users who have not customized `double-click-time' to "infinity"?
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 1 Dec 2017 19:43:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 01 14:43:57 2017 Received: from localhost ([127.0.0.1]:40517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eKrE4-0002xZ-Ne for submit <at> debbugs.gnu.org; Fri, 01 Dec 2017 14:43:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eKrE2-0002xM-VR for 29272 <at> debbugs.gnu.org; Fri, 01 Dec 2017 14:43:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eKrDt-0004PS-Vq for 29272 <at> debbugs.gnu.org; Fri, 01 Dec 2017 14:43:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_20,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eKrDl-0004KJ-VV; Fri, 01 Dec 2017 14:43:38 -0500 Received: from [176.228.60.248] (port=3321 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eKrDl-0007aJ-DB; Fri, 01 Dec 2017 14:43:37 -0500 Date: Fri, 01 Dec 2017 21:43:17 +0200 Message-Id: <83y3mm1bfu.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Drew Adams <drew.adams@HIDDEN> In-reply-to: <1c4abffb-e975-41b1-a368-29518bc3b360@default> (message from Drew Adams on Fri, 1 Dec 2017 11:18:05 -0800 (PST)) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN> <20171129183717.GA8914@ACM> <83609s52xt.fsf@HIDDEN> <20171201165740.GE3840@ACM> <1c4abffb-e975-41b1-a368-29518bc3b360@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Fri, 1 Dec 2017 11:18:05 -0800 (PST) > From: Drew Adams <drew.adams@HIDDEN> > Cc: 29272 <at> debbugs.gnu.org, npostavs@HIDDEN > > I hate to say it, but we probably need a user option (or at > least a variable) for this. We already have it: double-click-time. This discussion is about users who customized that to "infinity".
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 1 Dec 2017 19:18:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 01 14:18:18 2017 Received: from localhost ([127.0.0.1]:40500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eKqpF-0002ME-PP for submit <at> debbugs.gnu.org; Fri, 01 Dec 2017 14:18:17 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:51281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <drew.adams@HIDDEN>) id 1eKqpC-0002M1-P4 for 29272 <at> debbugs.gnu.org; Fri, 01 Dec 2017 14:18:15 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vB1JI71f022632 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2017 19:18:08 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vB1JI7sg021281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2017 19:18:07 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vB1JI7R5024565; Fri, 1 Dec 2017 19:18:07 GMT MIME-Version: 1.0 Message-ID: <1c4abffb-e975-41b1-a368-29518bc3b360@default> Date: Fri, 1 Dec 2017 11:18:05 -0800 (PST) From: Drew Adams <drew.adams@HIDDEN> To: Alan Mackenzie <acm@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Subject: RE: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN> <20171129183717.GA8914@ACM> <83609s52xt.fsf@HIDDEN> <20171201165740.GE3840@ACM> In-Reply-To: <20171201165740.GE3840@ACM> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 29272 Cc: 29272 <at> debbugs.gnu.org, npostavs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.1 (-) > > 10 seconds is too long, I think 1 sec is much better. >=20 > I hope I'm not bikeshedding, but 1 second may be too little. I'm > thinking about two use cases: (i) where a user's mouse button is almost > worn out, and it takes several attempted presses before one registers; > (ii) A disabled user who has physical difficulty in pressing the mouse > button, and needs that extra time to do so. Either of these may be a > reason for setting double-click-time to t. >=20 > Maybe not as long as 10s. How about compromising with the geometric > mean of 1s and 10s, namely 3.162s? I hate to say it, but we probably need a user option (or at least a variable) for this. Users are different. User hands are different. There is a reason that mouses are configurable wrt speeds and delays.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 1 Dec 2017 17:03:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 01 12:03:22 2017
Received: from localhost ([127.0.0.1]:40314 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eKoig-0003dC-5Q
for submit <at> debbugs.gnu.org; Fri, 01 Dec 2017 12:03:22 -0500
Received: from colin.muc.de ([193.149.48.1]:52207 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eKoif-0003d5-0J
for 29272 <at> debbugs.gnu.org; Fri, 01 Dec 2017 12:03:21 -0500
Received: (qmail 32600 invoked by uid 3782); 1 Dec 2017 17:03:17 -0000
Received: from acm.muc.de (p548C7BEF.dip0.t-ipconnect.de [84.140.123.239]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Fri, 01 Dec 2017 18:03:16 +0100
Received: (qmail 7087 invoked by uid 1000); 1 Dec 2017 16:57:40 -0000
Date: Fri, 1 Dec 2017 16:57:40 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171201165740.GE3840@ACM>
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN>
<83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN>
<20171129183717.GA8914@ACM> <83609s52xt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83609s52xt.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Wed, Nov 29, 2017 at 20:56:30 +0200,
Eli Zaretskii wrote: > > Date: Wed,
29 Nov 2017 18:37:17 +0000 > > Cc: Eli Zaretskii <eliz@HIDDEN>,
> > Noam Postavsky <npostavs@HIDDEN>, 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
-0.0 SPF_PASS SPF: sender matches SPF record
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: rudalics@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Wed, Nov 29, 2017 at 20:56:30 +0200, Eli Zaretskii
wrote: > > Date: Wed, 29 Nov 2017 18:37:17 +0000 > > Cc: Eli Zaretskii <eliz@HIDDEN>,
> > Noam Postavsky <npostavs@HIDDEN>, 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
-0.0 SPF_PASS SPF: sender matches SPF record
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli.
On Wed, Nov 29, 2017 at 20:56:30 +0200, Eli Zaretskii wrote:
> > Date: Wed, 29 Nov 2017 18:37:17 +0000
> > Cc: Eli Zaretskii <eliz@HIDDEN>,
> > Noam Postavsky <npostavs@HIDDEN>, 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN>
> > Personally, I think the value t is a bad idea, and we should obsolete
> > it.
> That's not going to fly. We have absolutely no reason for making this
> obsolete.
> in any case, this discussion is not about double-click-time's purpose,
> it's about what should "C-h k" when it is not a number. I proposed a
> practical solution; does anyone see a problem with it?
> > Maybe we should interpret t as a moderately long finite interval, say 10
> > seconds.
> 10 seconds is too long, I think 1 sec is much better.
I hope I'm not bikeshedding, but 1 second may be too little. I'm
thinking about two use cases: (i) where a user's mouse button is almost
worn out, and it takes several attempted presses before one registers;
(ii) A disabled user who has physical difficulty in pressing the mouse
button, and needs that extra time to do so. Either of these may be a
reason for setting double-click-time to t.
Maybe not as long as 10s. How about compromising with the geometric
mean of 1s and 10s, namely 3.162s?
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 30 Nov 2017 07:22:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 30 02:22:56 2017
Received: from localhost ([127.0.0.1]:37517 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eKJBQ-0004UP-BQ
for submit <at> debbugs.gnu.org; Thu, 30 Nov 2017 02:22:56 -0500
Received: from mout.gmx.net ([212.227.17.21]:54502)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rudalics@HIDDEN>) id 1eKJBH-0004Tk-7m
for 29272 <at> debbugs.gnu.org; Thu, 30 Nov 2017 02:22:47 -0500
Received: from [192.168.1.100] ([46.125.250.51]) by mail.gmx.com (mrgmx103
[212.227.17.168]) with ESMTPSA (Nemesis) id 0LfC4q-1evWan0YXo-00orqI; Thu, 30
Nov 2017 08:22:33 +0100
Message-ID: <5A1FB1AE.2040702@HIDDEN>
Date: Thu, 30 Nov 2017 08:22:22 +0100
From: martin rudalics <rudalics@HIDDEN>
MIME-Version: 1.0
To: Alan Mackenzie <acm@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
References: <83shdjn3ju.fsf@HIDDEN>
<83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM>
<87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN>
<5A1E724A.5030507@HIDDEN> <20171129183717.GA8914@ACM>
In-Reply-To: <20171129183717.GA8914@ACM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:vpNiy5XsrQPIaAw8/FVTBDtGKT1ybyI//X5CcD+P+JsAkiE1pgt
LFoZOK1lMgODqoMts56fdSpEe60KefxRJarrn8Uo7R/bqMBXYRwSk87nsOCwfMqUe1boaox
QO2ZgWjCDxBNdZGRL/+/GjN/Z7i920pgzn/MsLtABa6SSjmS8DayOhwDLNOqyQUizS215Vk
bGgZ5YHfYZpj5LzEOTHxw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:d592IibXmF0=:GLMoysxyYKXDKOKjBhZ1hU
Zf2XnuErcZasynsXlI9uQabRlwT3o+XgEEjxF5YA9IFt55EMBECjaeMSOORU+umEe853uv94l
R8IaYDNFzY1WzPCsq8397duIcpxJG+JjApyMFZpiTj47iVtO+IGwBmQYiE1IWEg+Lgyopad0h
V/KmsA01hVY5LL34tznUuT2b4LwQW/VNKIPeKMzqVMkubMmcXF4cnob4BNa3ISAq14e8sMQsV
ZMGE384yHOUVUZbqbo/vQ6+4Rp12ovU3vooh0W5dGOQA060bcBKe+9BvHQI1b2P8iOBk729BZ
DFmrFrMufm82181nri25SsDi5vI1+bPRtCg+3GSrxGqD7uI/CmKSXy2JqUYDZqeqx5Wi4I9L+
Q2aiIkqVXT7Z1f/McXxPs2HuXUUnpiwBl0yfHdkOB7NSilBN27TSN8HbdK8b/OBR7bgJ4ePLp
YhpguUgDhO0Y0kKTC/X7Pix7rzQUYIYLYC9v8YdjXtR5C+x8364vGw9eyCzrRJslbeKs1zH6Z
5LjyGC7ZW42AEr1cYAI3Gvs9NemeIjtqh+hz7/VZ33Ddg0C/JtsLhdCpksjBi2X/ssLHZbllr
Kj+kBRiCos+PNvNbGo0h3jr4ZycHVMPk5nakDOi14gcos5TAk9ue2wcN/4fTz1mGhMAmCCMAZ
6D50YSmivSeYd7H83vXkxJoMFAPcNGIWwW7JbXH9i1niBsJPhCx4ooAd2jq0KC9wMVrmcxkCL
6VSwlIdJ+WSAweZtz6cf0N+q0wcEuDON/JhSc1bpsq0tZPz0Ikx5b6BMiw8jTAR5jZIkxE0qI
RSajcvzLBe4KV1TVJ+m4LK7k5SlLwjotZjxsCoN9yBIuDo3WCA=
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: > This is very strange indeed. I wasn't aware of the t and
nil values for > double-click-time,
and of the six or seven uses of the variable
in the > Emacs Lisp code, there are at least two other uses, possibly more,
which > are likewise unaware of nil and t. [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server
[46.125.250.51 listed in dnsbl.sorbs.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(rudalics[at]gmx.at)
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust [212.227.17.21 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[212.227.17.21 listed in wl.mailspike.net]
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: Eli Zaretskii <eliz@HIDDEN>, 29272 <at> debbugs.gnu.org,
Noam Postavsky <npostavs@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: > This is very strange indeed. I wasn't aware of the t and
nil values for > double-click-time, and of the six or seven uses of the variable
in the > Emacs Lisp code, there are at least two other uses, possibly more,
which > are likewise unaware of nil and t. [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust
[212.227.17.21 listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[212.227.17.21 listed in wl.mailspike.net]
1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server
[46.125.250.51 listed in dnsbl.sorbs.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(rudalics[at]gmx.at)
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
> This is very strange indeed. I wasn't aware of the t and nil values for
> double-click-time, and of the six or seven uses of the variable in the
> Emacs Lisp code, there are at least two other uses, possibly more, which
> are likewise unaware of nil and t.
Filed as Bug#23419.
martin
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 30 Nov 2017 07:22:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 30 02:22:46 2017
Received: from localhost ([127.0.0.1]:37514 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eKJBG-0004Tw-35
for submit <at> debbugs.gnu.org; Thu, 30 Nov 2017 02:22:46 -0500
Received: from mout.gmx.net ([212.227.17.20]:59997)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rudalics@HIDDEN>) id 1eKJBD-0004Tg-Lr
for 29272 <at> debbugs.gnu.org; Thu, 30 Nov 2017 02:22:45 -0500
Received: from [192.168.1.100] ([46.125.250.51]) by mail.gmx.com (mrgmx101
[212.227.17.168]) with ESMTPSA (Nemesis) id 0LpObx-1enZyw3VkD-00fCW5; Thu, 30
Nov 2017 08:22:27 +0100
Message-ID: <5A1FB1A7.6000101@HIDDEN>
Date: Thu, 30 Nov 2017 08:22:15 +0100
From: martin rudalics <rudalics@HIDDEN>
MIME-Version: 1.0
To: Noam Postavsky <npostavs@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
References: <83shdjn3ju.fsf@HIDDEN>
<83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM>
<87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN>
<5A1E724A.5030507@HIDDEN> <87wp29jk7t.fsf@HIDDEN>
In-Reply-To: <87wp29jk7t.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:bGRLFinyp4MqMI+2/ocUuXS6UBtsc7p/O9OthMb/BB9kY+09OI/
drCvZ/KU3QFC350DCuo14jAwbRmVTKkQkyf6ZdMjmLXOOXW4Xn9aTlqu8XM130ayRrUromE
tOizgD6jMoqCpM1u7LtGvUkOO5ykOk55RJFv87BQP6PJbcV1xhZ8Xn+r1EX1oO0YgmRlbTx
mmkI8iZNrXYm1T0awIo6A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:VxL3w8RTz8g=:xYEuceuq0Li+48PLngKnVl
bR2ao6Wxgj66yNz0Fl/x3iiJeoixSt3G7A2Fuzbu2A7R6nJMWuBIzpwNFpG88eZTVwTD2dhZF
D+YBbxo5Hla5WpWyE4va4DqrRxjirJnuMM73OuTZzNgyCULwi7j/iBYSJdWWV7ni6A9aRhjHa
9ZSNvPXpxWMg4AXSC3UJuh3NHODOe3dl8Y2Pv8KeHu7uu9quemZLG577ryYxOdd3m+pnv3VO6
u0C261T4J05jhJBDpzhEa4eoGOCPqhLByYkNekWo5VSrYu//+Kjcyw2B5usXWY7K0ZmO9CIgK
JRwxtpSqDOoi06zFHgENRG8mlpkWUm4kZ1mjdNPzlwJjdPBr5MK5AStSVWcCxUEUETxJbIN07
1RgARGmh1H6e0LVKiH6SJE0uYXeTfXmi5Ge6zOum9C2XwXrwcDt40Q3BfpyhW9GuRa79jqz23
GbmhKXvkuoGde84O1VHd0NXLB4wGbHPY/WlMt9b4yAmgQ0kRNKKUB0Zo3n0hDJfGDvZJ6P4xB
bSukDsDHQPkiGhCoHmNgnkixvpaJZAuPrbWPO5CcEw14xNPKntTAzYL+tKVKawfpQ4fHz/VSS
SpbnjiUSA7KSZWOOh5a/ayY8WkEZWRihZImrDTcKyhVmWsT2o0PfMfgPq0TvGE7sZwPziP1xz
7SND/oOjwGXXE6lNJomz2oWiQ3N5sTdR1OTk7JvbXWydSCDm3cEdR2WvWShkGdrNd8QcPne+L
x3HrpwQTbUD9J4fIcr7nL6iLBeA2aImtiKW1sSqWHurg2Gvf4lccWiHq9A6e8IJrf9L4ROeEH
xTciKi8d3vj8o4HZM9WdugktM12sdE+DEFQNUKSCVGFT3dHlqU=
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: > The following > works for me in lucid and gtk: Works here
wherever I tried it. Thanks, martin [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.1 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[212.227.17.20 listed in wl.mailspike.net]
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust [212.227.17.20 listed in list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(rudalics[at]gmx.at)
1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server
[46.125.250.51 listed in dnsbl.sorbs.net]
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: acm@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: > The following > works for me in lucid and gtk: Works here
wherever I tried it. Thanks, martin [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust
[212.227.17.20 listed in list.dnswl.org]
-0.1 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[212.227.17.20 listed in wl.mailspike.net]
1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server
[46.125.250.51 listed in dnsbl.sorbs.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(rudalics[at]gmx.at)
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
> The following
> works for me in lucid and gtk:
Works here wherever I tried it.
Thanks, martin
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 18:56:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 29 13:56:56 2017 Received: from localhost ([127.0.0.1]:37301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eK7XU-0001cL-8G for submit <at> debbugs.gnu.org; Wed, 29 Nov 2017 13:56:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eK7XR-0001c7-VY for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 13:56:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eK7XI-0004Sz-9p for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 13:56:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_50,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eK7XI-0004St-5r; Wed, 29 Nov 2017 13:56:44 -0500 Received: from [176.228.60.248] (port=4192 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eK7XG-0008HW-FH; Wed, 29 Nov 2017 13:56:44 -0500 Date: Wed, 29 Nov 2017 20:56:30 +0200 Message-Id: <83609s52xt.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alan Mackenzie <acm@HIDDEN> In-reply-to: <20171129183717.GA8914@ACM> (message from Alan Mackenzie on Wed, 29 Nov 2017 18:37:17 +0000) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN> <20171129183717.GA8914@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: rudalics@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Wed, 29 Nov 2017 18:37:17 +0000 > Cc: Eli Zaretskii <eliz@HIDDEN>, > Noam Postavsky <npostavs@HIDDEN>, 29272 <at> debbugs.gnu.org > From: Alan Mackenzie <acm@HIDDEN> > > Personally, I think the value t is a bad idea, and we should obsolete > it. That's not going to fly. We have absolutely no reason for making this obsolete. in any case, this discussion is not about double-click-time's purpose, it's about what should "C-h k" when it is not a number. I proposed a practical solution; does anyone see a problem with it? > Maybe we should interpret t as a moderately long finite interval, say 10 > seconds. 10 seconds is too long, I think 1 sec is much better.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 18:42:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 29 13:42:33 2017
Received: from localhost ([127.0.0.1]:37267 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eK7JY-0001Eb-SU
for submit <at> debbugs.gnu.org; Wed, 29 Nov 2017 13:42:33 -0500
Received: from colin.muc.de ([193.149.48.1]:50406 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eK7JX-0001ER-3G
for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 13:42:31 -0500
Received: (qmail 8202 invoked by uid 3782); 29 Nov 2017 18:42:29 -0000
Received: from acm.muc.de (p548C768C.dip0.t-ipconnect.de [84.140.118.140]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Wed, 29 Nov 2017 19:42:28 +0100
Received: (qmail 9043 invoked by uid 1000); 29 Nov 2017 18:37:17 -0000
Date: Wed, 29 Nov 2017 18:37:17 +0000
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171129183717.GA8914@ACM>
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN>
<83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5A1E724A.5030507@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Martin. On Wed, Nov 29, 2017 at 09:39:38 +0100, martin
rudalics wrote: [ .... ] [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
-0.0 SPF_PASS SPF: sender matches SPF record
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: Eli Zaretskii <eliz@HIDDEN>, 29272 <at> debbugs.gnu.org,
Noam Postavsky <npostavs@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Martin. On Wed, Nov 29, 2017 at 09:39:38 +0100, martin
rudalics wrote: [ .... ] [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
-0.0 SPF_PASS SPF: sender matches SPF record
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Martin.
On Wed, Nov 29, 2017 at 09:39:38 +0100, martin rudalics wrote:
[ .... ]
> BTW: Could someone please fix that
> (not (sit-for (/ double-click-time 1000.0) t))
> form so it handles at least those values of `double-click-time'
> described in its documentation:
> Maximum time between mouse clicks to make a double-click.
> Measured in milliseconds. The value nil means disable double-click
> recognition; t means double-clicks have no time limit and are detected
> by position only.
This is very strange indeed. I wasn't aware of the t and nil values for
double-click-time, and of the six or seven uses of the variable in the
Emacs Lisp code, there are at least two other uses, possibly more, which
are likewise unaware of nil and t.
Looking at the change log, double-click-time was changed into a Lisp
variable, complete with values nil and t, by Jim Blandy in 1993, which
is hardly recent. The documentation seems OK.
So why have so many programmers been oblivious to these values?
> I'm not sure what `sit-for' is supposed to return in those cases.
Presumably we shouldn't be calling sit-for for double-click-time nil and
t. But, when does a key sequence consisting of mouse buttons end when
d-c-t is t? This is a more important question, I think, for C-h c and
C-h k than for actually running commands.
Personally, I think the value t is a bad idea, and we should obsolete
it. I can't see the use case. Anybody who wants an indefinitely long
double-click-time can use a near infinite integer, in which case
anything that happens (or fails to happen) in C-h c and C-h k is her own
fault. Surely, nobody is going to want to click the mouse, go off for a
cup of coffee, come back, then complete a double click.
Maybe we should interpret t as a moderately long finite interval, say 10
seconds. That still leaves anybody the option of using a larger
interval.
> Thanks, martin
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 17:55:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 29 12:55:33 2017 Received: from localhost ([127.0.0.1]:37255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eK6a4-0008Pa-SI for submit <at> debbugs.gnu.org; Wed, 29 Nov 2017 12:55:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eK6a2-0008PM-Ma for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 12:55:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eK6Zv-0006Fr-EO for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 12:55:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_50,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eK6Zv-0006FW-8X; Wed, 29 Nov 2017 12:55:23 -0500 Received: from [176.228.60.248] (port=4002 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eK6Zt-0002AM-Hq; Wed, 29 Nov 2017 12:55:23 -0500 Date: Wed, 29 Nov 2017 19:55:07 +0200 Message-Id: <83a7z53r7o.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: martin rudalics <rudalics@HIDDEN> In-reply-to: <5A1E724A.5030507@HIDDEN> (message from martin rudalics on Wed, 29 Nov 2017 09:39:38 +0100) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org, npostavs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Wed, 29 Nov 2017 09:39:38 +0100 > From: martin rudalics <rudalics@HIDDEN> > CC: acm@HIDDEN, 29272 <at> debbugs.gnu.org > > > What happens in the Lucid build? > > Here menus with Lucid, Motif and pure X (without toolkit) builds behave > differently from GTK/Windows ones: They are immediately pulled down when > I release the mouse button. So I have to continuously keep a mouse > button pressed during menu interaction (although I'm free to release any > modifier key). Also, at least here, menu tooltips are broken - they > show an empty line only. Only after the menu is pulled down, a correct > tooltip might appear, see below. > > Else not much happens - I see in the echo area > > Describe the following key, mouse click, or menu item: C-down-mouse-3- > > and moving the mouse to some selectable item replaces that text by > > Describe the following key, mouse click, or menu item: > > sometimes resizing the echo area to two lines and displaying the correct > tooltip text after the menu was pulled down. `view-lossage' doesn't > show anything of interest. That means the same problem probably exists in a non-toolkit build.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 17:54:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 29 12:54:24 2017 Received: from localhost ([127.0.0.1]:37251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eK6Yy-0008NZ-FV for submit <at> debbugs.gnu.org; Wed, 29 Nov 2017 12:54:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eK6Yw-0008NK-Ju for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 12:54:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eK6Ym-0004U6-IF for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 12:54:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_50,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eK6Ym-0004Tu-Eb; Wed, 29 Nov 2017 12:54:12 -0500 Received: from [176.228.60.248] (port=3998 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eK6Yk-00023n-W2; Wed, 29 Nov 2017 12:54:12 -0500 Date: Wed, 29 Nov 2017 19:53:57 +0200 Message-Id: <83bmjl3r9m.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noam Postavsky <npostavs@HIDDEN> In-reply-to: <87wp29jk7t.fsf@HIDDEN> (message from Noam Postavsky on Wed, 29 Nov 2017 08:19:34 -0500) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN> <87wp29jk7t.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: rudalics@HIDDEN, 29272 <at> debbugs.gnu.org, acm@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > From: Noam Postavsky <npostavs@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, acm@HIDDEN, 29272 <at> debbugs.gnu.org > Date: Wed, 29 Nov 2017 08:19:34 -0500 > > > The following works for me in lucid and gtk: > > --- c/lisp/help.el > +++ i/lisp/help.el > @@ -726,19 +726,19 @@ help-read-key-sequence > (while > (pcase (setq key (read-key-sequence "\ > Describe the following key, mouse click, or menu item: ")) > - ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0)) > - (guard (symbolp key0)) (let keyname (symbol-name key0))) > - (or > - (and no-mouse-movement > - (string-match "mouse-movement" keyname)) > - (and (string-match "\\(mouse\\|down\\|click\\|drag\\)" > - keyname) > - (progn > - ;; Discard events (e.g. <help-echo>) which might > - ;; spuriously trigger the `sit-for'. > - (sleep-for 0.01) > - (while (read-event nil nil 0.01)) > - (not (sit-for (/ double-click-time 1000.0) t)))))))) > + (`[(,key0 . ,_)] > + (or (and no-mouse-movement (eq key0 'mouse-movement)) > + ;; Wait long enough to fully read a double click event. > + ;; FIXME: How to handle double-click-time = t? > + (and (numberp double-click-time) > + (string-match "\\(mouse\\|down\\|click\\|drag\\)" > + (symbol-name key0)) > + (progn > + ;; Discard events (e.g. <help-echo>) which might > + ;; spuriously trigger the `sit-for'. > + (sleep-for 0.01) > + (while (read-event nil nil 0.01)) > + (not (sit-for (/ double-click-time 1000.0) t)))))))) > (list > key > ;; If KEY is a down-event, read and include the > LGTM, thanks > > BTW: Could someone please fix that > > > > (not (sit-for (/ double-click-time 1000.0) t)) > > > > form so it handles at least those values of `double-click-time' > > described in its documentation: > > > > Maximum time between mouse clicks to make a double-click. > > Measured in milliseconds. The value nil means disable double-click > > recognition; t means double-clicks have no time limit and are detected > > by position only. > > > > I'm not sure what `sit-for' is supposed to return in those cases. > > I don't know how to handle the double-click-time = t case though. I think we should use some fixed time in that case.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 13:19:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 29 08:19:45 2017
Received: from localhost ([127.0.0.1]:35774 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eK2HB-0006Ge-Ic
for submit <at> debbugs.gnu.org; Wed, 29 Nov 2017 08:19:45 -0500
Received: from mail-it0-f54.google.com ([209.85.214.54]:36843)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <npostavs@HIDDEN>) id 1eK2H9-0006GQ-BZ
for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 08:19:43 -0500
Received: by mail-it0-f54.google.com with SMTP id d16so4067325itj.1
for <29272 <at> debbugs.gnu.org>; Wed, 29 Nov 2017 05:19:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=sender:from:to:cc:subject:references:date:in-reply-to:message-id
:user-agent:mime-version;
bh=cQ0FKuAjymTWXZF7ppvpFalgnp7hA6jkmsl4AuCT66k=;
b=uRrOe9xcoBxSQHGPxzzwPjhEm/dBhOGdH/RiiaPirLGBgGeG6qflBrZdu2ZL0VEX0s
zMG2cWznnLR3KVggp1bLz56YbEqSBK9GHYRhgs7dlt4Ie6ut/vNUE6g0WxrsvNO8iOyR
RLJa5VyemJIxGQ20fU8GHZ096hrXy8UIEcLj5pqkoFKmpSxKnfz4vysTuANIz0jy1o1J
uWE7iTMEC1S3cjVjq/d+lysi9AkocyU7kIB5WZqMRydzmRzTuEZ6LiC4nap6+FFqviDf
Low3FDXrx0pxp+umPLgLBqNtpMhHvobnquwAX5au1/iltju8z8XaxYBkRnyGkLTW9oIM
aDFg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:sender:from:to:cc:subject:references:date
:in-reply-to:message-id:user-agent:mime-version;
bh=cQ0FKuAjymTWXZF7ppvpFalgnp7hA6jkmsl4AuCT66k=;
b=p6f39CHW7ELV5IuAiiRt361pdHPaBVnPfrNZcCBrOZP/aIXvXAAn/y19MxRcmg3bdQ
q6BLP9NgOm0poq0uPrpBuKXler4zNCIef/R93vy2/DCIzXn+AjTS50b0Y5dUXDFVnkxr
YJV1/o/foMMjOZ6zIj3UAkvRhNC5Ze2/Md7yrE5CbZvcWdNx6PmSwVg6Zry48nuRKF75
RBXSdsK/VpCbPATb+/aXtU9Z6N3WqAXhZ4JDLa+fgJVEPKcB2n5QfH1UNU0DfxilAZ4+
+uCI4V5XuPcC/9vR4HZnF/sfWdZRx6tUjnOE8BsfQ+tV4acFRMg9QabcTKgCQdEhnGsJ
8JWw==
X-Gm-Message-State: AJaThX57Vgrh9YM4CEqV9A12obc7FrQ5ULgXxqJzSjmk1L2xWWRk4SHL
gs3HdrwrCxa2DIca4MCUsFFy5rv5
X-Google-Smtp-Source: AGs4zMZQTcWE2HQRdcefZwgFkz2N2EVwGYBVb9Tg63cLgerhMQ78Jl0wKGorNZm+Z5UbbHFWglPYDw==
X-Received: by 10.36.101.140 with SMTP id u134mr7147165itb.108.1511961577513;
Wed, 29 Nov 2017 05:19:37 -0800 (PST)
Received: from zebian ([45.2.119.34])
by smtp.googlemail.com with ESMTPSA id c65sm781097ioj.23.2017.11.29.05.19.34
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Wed, 29 Nov 2017 05:19:36 -0800 (PST)
From: Noam Postavsky <npostavs@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#29272: 26.0.90;
"C-h k C-mouse-3" followed by menu selection asks for more keys
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN>
<83h8td4uw5.fsf@HIDDEN> <5A1E724A.5030507@HIDDEN>
Date: Wed, 29 Nov 2017 08:19:34 -0500
In-Reply-To: <5A1E724A.5030507@HIDDEN> (martin rudalics's message of "Wed, 29
Nov 2017 09:39:38 +0100")
Message-ID: <87wp29jk7t.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 29272
Cc: acm@HIDDEN, Eli Zaretskii <eliz@HIDDEN>, 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.7 (/)
From what I can tell, we should only need to wait for a double click
when we get a single mouse event; when clicking in a menu,
read-key-sequence returns [(C-down-mouse-3 (#<window ...> ...)) the-command]. The following
works for me in lucid and gtk:
--- c/lisp/help.el
+++ i/lisp/help.el
@@ -726,19 +726,19 @@ help-read-key-sequence
(while
(pcase (setq key (read-key-sequence "\
Describe the following key, mouse click, or menu item: "))
- ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0))
- (guard (symbolp key0)) (let keyname (symbol-name key0)))
- (or
- (and no-mouse-movement
- (string-match "mouse-movement" keyname))
- (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
- keyname)
- (progn
- ;; Discard events (e.g. <help-echo>) which might
- ;; spuriously trigger the `sit-for'.
- (sleep-for 0.01)
- (while (read-event nil nil 0.01))
- (not (sit-for (/ double-click-time 1000.0) t))))))))
+ (`[(,key0 . ,_)]
+ (or (and no-mouse-movement (eq key0 'mouse-movement))
+ ;; Wait long enough to fully read a double click event.
+ ;; FIXME: How to handle double-click-time = t?
+ (and (numberp double-click-time)
+ (string-match "\\(mouse\\|down\\|click\\|drag\\)"
+ (symbol-name key0))
+ (progn
+ ;; Discard events (e.g. <help-echo>) which might
+ ;; spuriously trigger the `sit-for'.
+ (sleep-for 0.01)
+ (while (read-event nil nil 0.01))
+ (not (sit-for (/ double-click-time 1000.0) t))))))))
(list
key
;; If KEY is a down-event, read and include the
martin rudalics <rudalics@HIDDEN> writes:
> BTW: Could someone please fix that
>
> (not (sit-for (/ double-click-time 1000.0) t))
>
> form so it handles at least those values of `double-click-time'
> described in its documentation:
>
> Maximum time between mouse clicks to make a double-click.
> Measured in milliseconds. The value nil means disable double-click
> recognition; t means double-clicks have no time limit and are detected
> by position only.
>
> I'm not sure what `sit-for' is supposed to return in those cases.
I don't know how to handle the double-click-time = t case though.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 08:40:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 29 03:40:08 2017 Received: from localhost ([127.0.0.1]:35649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eJxua-0006Iq-Fa for submit <at> debbugs.gnu.org; Wed, 29 Nov 2017 03:40:08 -0500 Received: from mout.gmx.net ([212.227.15.19]:51686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rudalics@HIDDEN>) id 1eJxuV-0006IF-Ra for 29272 <at> debbugs.gnu.org; Wed, 29 Nov 2017 03:40:05 -0500 Received: from [192.168.1.100] ([212.95.7.236]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MN0jA-1eDMCJ1voW-006eZv; Wed, 29 Nov 2017 09:39:47 +0100 Message-ID: <5A1E724A.5030507@HIDDEN> Date: Wed, 29 Nov 2017 09:39:38 +0100 From: martin rudalics <rudalics@HIDDEN> MIME-Version: 1.0 To: Eli Zaretskii <eliz@HIDDEN>, Noam Postavsky <npostavs@HIDDEN> Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> <83h8td4uw5.fsf@HIDDEN> In-Reply-To: <83h8td4uw5.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:O8vtWBDjf8YaiZPuZQOTGya9E+SJ3zIRUp1boY88JR2hFW0zStN WIAn/N0ZXkN/Gi3GgvjGHoHGfAQk4My6N9OZqtdjd7Gr60gr9L7uuPKnVXcEbBDMouKtWHI QuCTd798rXDwTaQHrI4uXaWPimmBRlH9VmNzoCIMOJPoPce0Q21TiSNe6AfMJCfPYgtbsVm Nvs7p32QJHaRfSIcIPLpQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MFzfV0bXED0=:sHZkimpm8bkm9jfZXckzzn 6BC9//f+xVodh7DwTqMiKfyFNQP5i+NIFG2wMd/KDudTGPzwCz1QNgrDhko0AjRohc6uIZ81y cMkl6FTvK0LCd4N9wVMXNBq1yFaOpnQDMLRzK2JZOc1449c7gI8VBH14+trp9riKtsReYHN02 GSmUWnCpkdrdM8nXE17aowUe+vwxYuwIreIR8Vh/lZJgvVBuBuVnJHCBgofkgyGAhz5ZWpxZW 9JOd5NluwW4dzLSWz5j3f50halIH0klQAyXmkcfURTwAaqSb+nUB4bIu28ntM1dJ8MkYJJGSa yYqNDVZxaxJiM+KTy48yamQfnz7g1aJmHr8UJmc6ZckpE0XT24YnmfgO0i68HzZb9Zo9h5CZ3 ob7Y9NW6zS+XIDmloBMZga4A1nesjTw6vgrkmeQHjA5pfcCRj+Wi12f3jplD5dwOyQd3Bi+TM 4p/PAK3xzoLZME/SBY/bpQSsk3+Bze8x0Wg4MfGTB+9hqTSg1buwzvkVlIR8jC5bC1Yfh1etz GCk5h47RzFWWqv/5XR1wOQlKfrYowloHtny1uZiyhxEDJHdRqp05Pj8hozo2hWDL2gqZin4Cm sSV6Qz4H1YJ76zmUOzEF9YQoXW5B2MMtF1RTiu3oZNVTV7MS6O30ail5bQzeXfhDXZw3PIGXt IfWq9pQFrtQ5HHKAfbMESiyAGAyQwXflm5QQZcrMblKqdO4dc6/EEJyyO85ZBjyqu3r5mL6sR CsadPFvQCsxZ7V52Jh+QB8ffXF/763UJW9jfblb4C2rI4sgX5SIoT+uxQkDXMkso2ZHJUqPuv 655/WV/GITcXSTnxt5wt9xTnGVM5ORXMa3DcYfKu059pWvPlzEX4at1FpDFRv4rU0rdfjzK X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 29272 Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.6 (/) > What happens in the Lucid build? Here menus with Lucid, Motif and pure X (without toolkit) builds behave differently from GTK/Windows ones: They are immediately pulled down when I release the mouse button. So I have to continuously keep a mouse button pressed during menu interaction (although I'm free to release any modifier key). Also, at least here, menu tooltips are broken - they show an empty line only. Only after the menu is pulled down, a correct tooltip might appear, see below. Else not much happens - I see in the echo area Describe the following key, mouse click, or menu item: C-down-mouse-3- and moving the mouse to some selectable item replaces that text by Describe the following key, mouse click, or menu item: sometimes resizing the echo area to two lines and displaying the correct tooltip text after the menu was pulled down. `view-lossage' doesn't show anything of interest. BTW: Could someone please fix that (not (sit-for (/ double-click-time 1000.0) t)) form so it handles at least those values of `double-click-time' described in its documentation: Maximum time between mouse clicks to make a double-click. Measured in milliseconds. The value nil means disable double-click recognition; t means double-clicks have no time limit and are detected by position only. I'm not sure what `sit-for' is supposed to return in those cases. Thanks, martin
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 03:38:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 22:38:21 2017 Received: from localhost ([127.0.0.1]:35524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eJtCX-0007B1-4S for submit <at> debbugs.gnu.org; Tue, 28 Nov 2017 22:38:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eJtCV-0007An-PG for 29272 <at> debbugs.gnu.org; Tue, 28 Nov 2017 22:38:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eJtCN-0002gO-EW for 29272 <at> debbugs.gnu.org; Tue, 28 Nov 2017 22:38:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eJtCN-0002gK-Bb; Tue, 28 Nov 2017 22:38:11 -0500 Received: from [176.228.60.248] (port=3623 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eJtCM-0000YA-FQ; Tue, 28 Nov 2017 22:38:11 -0500 Date: Wed, 29 Nov 2017 05:38:02 +0200 Message-Id: <83h8td4uw5.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noam Postavsky <npostavs@HIDDEN> In-reply-to: <87fu8xnc17.fsf@HIDDEN> (message from Noam Postavsky on Tue, 28 Nov 2017 19:50:28 -0500) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <87fu8xnc17.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: acm@HIDDEN, 29272 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > From: Noam Postavsky <npostavs@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 29272 <at> debbugs.gnu.org > Date: Tue, 28 Nov 2017 19:50:28 -0500 > > I've tested this after it was applied to emacs-26 [1: 22ff46e6d8]; the > bug is fixed in --with-x-toolkit=gtk build and w32 builds, but not in a > --with-x-toolkit=lucid build. What happens in the Lucid build? I don't understand why Lucid is different: the change is in the platform-independent part of the code, AFAIU.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 29 Nov 2017 00:50:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 19:50:38 2017
Received: from localhost ([127.0.0.1]:35349 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eJqaE-0001s7-3q
for submit <at> debbugs.gnu.org; Tue, 28 Nov 2017 19:50:38 -0500
Received: from mail-it0-f49.google.com ([209.85.214.49]:33921)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <npostavs@HIDDEN>) id 1eJqaC-0001ru-BX
for 29272 <at> debbugs.gnu.org; Tue, 28 Nov 2017 19:50:36 -0500
Received: by mail-it0-f49.google.com with SMTP id m11so24764487iti.1
for <29272 <at> debbugs.gnu.org>; Tue, 28 Nov 2017 16:50:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=sender:from:to:cc:subject:references:date:in-reply-to:message-id
:user-agent:mime-version;
bh=XrEyLdwAXNof1/bYARxh4GWASIfNcnrCWDatTw/TeUw=;
b=GvJ3NZihLzMUDL8+E7M7RgSjo9TaLfm71M2ktvCzLRyQ+BHVbfsi8Vv+mOXxE7EfZc
kwtDjwqy0kaJtprdQftKu+drRg5RDz/0sRsLIifb6rEMVowqoDy1BgDjDFM5wupv+Df9
l5aYbZIIfxQTz+jUabxKI/IdMDscDsZWCRX9KuZcY6gaMtrHZWZFJIkzF+x71CZ+MKWf
DWAS+igL/VAPe3ividdslIWkpH//rFwPfRWYtE0L+To5O6HpKHAxWdmMT/nlr3JQYUdg
ph5gzeXaTFoyAlmvY/OtAZ7+rTNPotx2NjPPZxHq5SA1zYqxD9ZyK8vT1VU6wzJ7jxp5
IGXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:sender:from:to:cc:subject:references:date
:in-reply-to:message-id:user-agent:mime-version;
bh=XrEyLdwAXNof1/bYARxh4GWASIfNcnrCWDatTw/TeUw=;
b=gy6G08tn8K/7DuBz1sHBMjh37wDEkfCiMPiFCEfaPtWlwamKq2eHZatEe/j6bv9fQ3
qCfDKfHWvjCx0SgFm9rV+PAT620MtlI435Zy9fC39YIoJKY/TqMpXosYG2/osQBye5RM
ZmVpDBuo43jvAYwICPRt4bJ+s3QpprMyR7U6cioJaofbk5+ELqZs2xTkyiAjcv1t71B4
67NkaJ5iHo7Tju1GIEvSN4VyXVcr/07rOe0UK3twJ8a0mAuFERAA6W/oxRmTkVPYEe4V
IPHs8TBDvh7/PjwLDtWukCyNY/8veMCHzqwKgJPlcUArLfMbARRkPwplEVazwlIH1hU7
d4xA==
X-Gm-Message-State: AJaThX4zqfc2A7w+48kVtKAIyCd+MCgtUClitxhSWST6RMdWLWV/c3j9
+D/MZXNnTJ+YQZqcyJ3GbR205w==
X-Google-Smtp-Source: AGs4zMYGwDYeuEbI3gNXloHqvuMQGt527AzSaKV4PPLaq98kYqST7qvDfzP8otV1Y2g2k8wIiTWjPQ==
X-Received: by 10.36.108.83 with SMTP id w80mr5100777itb.3.1511916630535;
Tue, 28 Nov 2017 16:50:30 -0800 (PST)
Received: from zebian ([45.2.119.34])
by smtp.googlemail.com with ESMTPSA id p134sm232929iop.75.2017.11.28.16.50.29
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 28 Nov 2017 16:50:29 -0800 (PST)
From: Noam Postavsky <npostavs@HIDDEN>
To: Alan Mackenzie <acm@HIDDEN>
Subject: Re: bug#29272: 26.0.90;
"C-h k C-mouse-3" followed by menu selection asks for more keys
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM>
Date: Tue, 28 Nov 2017 19:50:28 -0500
In-Reply-To: <20171114205449.GA8025@ACM> (Alan Mackenzie's message of "Tue, 14
Nov 2017 20:54:49 +0000")
Message-ID: <87fu8xnc17.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Alan Mackenzie <acm@HIDDEN> writes: > The following patch
attempts to catch and filter out obtrusive events. > Could you try it out,
please, even though it's not perfect (see below). > It's based on the emacs-26
branch: > > > > diff --git a/lisp/help.el b/lisp/help.el > index
fbb9fc8cbe..d119615180
100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -728,11 +728,17 @@
help-read-key-sequence > Describe the following key, mouse click, or menu
item: ")) > ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0)) > (guard
(symbolp key0)) (let keyname (symbol-name key0))) > - (if no-mouse-movement
> - (string-match "mouse-movement" keyname) > - (and (string-match
"\\(mouse\\|down\\|click\\|drag\\)"
> - keyname) > - (not (sit-for (/ double-click-time 1000.0) t))))))) > +
(or > + (and no-mouse-movement > + (string-match "mouse-movement" keyname))
> + (and (string-match "\\(mouse\\|down\\|click\\|drag\\)" > + keyname) >
+ (progn > + ; ; Discard events (e.g. <help-echo>) which might > + ; ;
spuriously
trigger the `sit-for'. > + (sleep-for 0.001) > + (while (read-event nil nil
0.001)) > + (not (sit-for (/ double-click-time 1000.0) t)))))))) [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(npostavs[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail
domains are different
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.214.49 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no
trust [209.85.214.49 listed in list.dnswl.org]
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid
0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom
freemail headers are different
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
X-Debbugs-Envelope-To: 29272
Cc: Eli Zaretskii <eliz@HIDDEN>, 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Alan Mackenzie <acm@HIDDEN> writes: > The following patch
attempts to catch and filter out obtrusive events. > Could you try it out,
please, even though it's not perfect (see below). > It's based on the emacs-26
branch: > > > > diff --git a/lisp/help.el b/lisp/help.el > index fbb9fc8cbe..d119615180
100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -728,11 +728,17 @@
help-read-key-sequence > Describe the following key, mouse click, or menu
item: ")) > ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0)) > (guard
(symbolp key0)) (let keyname (symbol-name key0))) > - (if no-mouse-movement
> - (string-match "mouse-movement" keyname) > - (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
> - keyname) > - (not (sit-for (/ double-click-time 1000.0) t))))))) > +
(or > + (and no-mouse-movement > + (string-match "mouse-movement" keyname))
> + (and (string-match "\\(mouse\\|down\\|click\\|drag\\)" > + keyname) >
+ (progn > + ;; Discard events (e.g. <help-echo>) which might > + ;; spuriously
trigger the `sit-for'. > + (sleep-for 0.001) > + (while (read-event nil nil
0.001)) > + (not (sit-for (/ double-click-time 1000.0) t)))))))) [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.214.49 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no
trust
[209.85.214.49 listed in list.dnswl.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(npostavs[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail
domains are different
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid
0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom
freemail headers are different
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
Alan Mackenzie <acm@HIDDEN> writes:
> The following patch attempts to catch and filter out obtrusive events.
> Could you try it out, please, even though it's not perfect (see below).
> It's based on the emacs-26 branch:
>
>
>
> diff --git a/lisp/help.el b/lisp/help.el
> index fbb9fc8cbe..d119615180 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -728,11 +728,17 @@ help-read-key-sequence
> Describe the following key, mouse click, or menu item: "))
> ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0))
> (guard (symbolp key0)) (let keyname (symbol-name key0)))
> - (if no-mouse-movement
> - (string-match "mouse-movement" keyname)
> - (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
> - keyname)
> - (not (sit-for (/ double-click-time 1000.0) t)))))))
> + (or
> + (and no-mouse-movement
> + (string-match "mouse-movement" keyname))
> + (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
> + keyname)
> + (progn
> + ;; Discard events (e.g. <help-echo>) which might
> + ;; spuriously trigger the `sit-for'.
> + (sleep-for 0.001)
> + (while (read-event nil nil 0.001))
> + (not (sit-for (/ double-click-time 1000.0) t))))))))
I've tested this after it was applied to emacs-26 [1: 22ff46e6d8]; the
bug is fixed in --with-x-toolkit=gtk build and w32 builds, but not in a
--with-x-toolkit=lucid build.
[1: 22ff46e6d8]: 2017-11-27 19:28:28 -0500
; Fix some comment typos
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=22ff46e6d85e3f023eb84ef7e8fe3de8947caf81
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Noam Postavsky <npostavs@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 19 Nov 2017 20:29:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 15:29:52 2017
Received: from localhost ([127.0.0.1]:47970 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eGWDw-0001Is-4X
for submit <at> debbugs.gnu.org; Sun, 19 Nov 2017 15:29:52 -0500
Received: from ocolin.muc.de ([193.149.48.4]:55368 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eGWDv-0001Ik-3b
for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 15:29:51 -0500
Received: (qmail 37974 invoked by uid 3782); 19 Nov 2017 20:29:46 -0000
Received: from acm.muc.de (p548C7514.dip0.t-ipconnect.de [84.140.117.20]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Sun, 19 Nov 2017 21:29:45 +0100
Received: (qmail 19008 invoked by uid 1000); 19 Nov 2017 20:26:48 -0000
Date: Sun, 19 Nov 2017 20:26:48 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171119202648.GD9922@ACM>
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN>
<20171119161943.GA9922@ACM> <83lgj2dtfs.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83lgj2dtfs.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli On Sun, Nov 19, 2017 at 20:17:27 +0200,
Eli Zaretskii
wrote: > > Date: Sun, 19 Nov 2017 16:19:43 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > > I only see this in a text-mode
frame (in my case it's "<mouse-1> > > > <indent-pp-sexp>"). On GUI frame,
there's no "translation". [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli On Sun, Nov 19, 2017 at 20:17:27 +0200, Eli Zaretskii
wrote: > > Date: Sun, 19 Nov 2017 16:19:43 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > > I only see this in a text-mode
frame (in my case it's "<mouse-1> > > > <indent-pp-sexp>"). On GUI frame,
there's no "translation". [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli
On Sun, Nov 19, 2017 at 20:17:27 +0200, Eli Zaretskii wrote:
> > Date: Sun, 19 Nov 2017 16:19:43 +0000
> > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN>
> > > I only see this in a text-mode frame (in my case it's "<mouse-1>
> > > <indent-pp-sexp>"). On GUI frame, there's no "translation".
> > Not on an X-Windows frame - X seems to handle all the mouse-movement and
> > intermediate click events itself.
> Crystal ball says that your "X-Windows" is an Emacs build with some
> toolkit.
Indeed. The default GTK, I believe. I usually work on a tty, so I've
never bothered too much about it.
> I'm guessing that a non-toolkit build on X will have the same problem
> as we see on text-mode frames, because in a non-toolkit build Emacs
> handles all the mouse clicks in a menu.
I suppose so.
Still, we're getting fixed on master. I agree with you that it's too
big a change, and too small a bug to justify putting it on the release
branch.
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 19 Nov 2017 18:17:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 13:17:51 2017 Received: from localhost ([127.0.0.1]:47908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eGUAB-0006nU-HF for submit <at> debbugs.gnu.org; Sun, 19 Nov 2017 13:17:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eGUAA-0006nH-S2 for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 13:17:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eGU9z-0004r1-Fm for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 13:17:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_40,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eGU9z-0004qv-CX; Sun, 19 Nov 2017 13:17:39 -0500 Received: from [176.228.60.248] (port=2155 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eGU9y-0000QH-D4; Sun, 19 Nov 2017 13:17:39 -0500 Date: Sun, 19 Nov 2017 20:17:27 +0200 Message-Id: <83lgj2dtfs.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alan Mackenzie <acm@HIDDEN> In-reply-to: <20171119161943.GA9922@ACM> (message from Alan Mackenzie on Sun, 19 Nov 2017 16:19:43 +0000) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN> <20171119161943.GA9922@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: 29272 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Sun, 19 Nov 2017 16:19:43 +0000 > Cc: 29272 <at> debbugs.gnu.org > From: Alan Mackenzie <acm@HIDDEN> > > > I only see this in a text-mode frame (in my case it's "<mouse-1> > > <indent-pp-sexp>"). On GUI frame, there's no "translation". > > Not on an X-Windows frame - X seems to handle all the mouse-movement and > intermediate click events itself. Crystal ball says that your "X-Windows" is an Emacs build with some toolkit. I'm guessing that a non-toolkit build on X will have the same problem as we see on text-mode frames, because in a non-toolkit build Emacs handles all the mouse clicks in a menu.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 19 Nov 2017 17:57:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 12:57:27 2017
Received: from localhost ([127.0.0.1]:47779 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eGTqQ-0006Bv-VZ
for submit <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:57:27 -0500
Received: from ocolin.muc.de ([193.149.48.4]:20991 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eGTqP-0006Bn-D5
for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:57:25 -0500
Received: (qmail 93597 invoked by uid 3782); 19 Nov 2017 17:57:24 -0000
Received: from acm.muc.de (p548C7514.dip0.t-ipconnect.de [84.140.117.20]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Sun, 19 Nov 2017 18:57:23 +0100
Received: (qmail 10576 invoked by uid 1000); 19 Nov 2017 17:54:26 -0000
Date: Sun, 19 Nov 2017 17:54:26 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171119175426.GC9922@ACM>
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN>
<20171119161943.GA9922@ACM> <83shdadwsy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83shdadwsy.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sun, Nov 19, 2017 at 19:04:45 +0200,
Eli Zaretskii
wrote: > > Date: Sun, 19 Nov 2017 16:19:43 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > > In any case, this is a much more
minor bug than the one I reported, so > > > please install your changes on
the release branch. Bonus points if > > > you can find where does the
"translation" come from. [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sun, Nov 19, 2017 at 19:04:45 +0200, Eli Zaretskii
wrote: > > Date: Sun, 19 Nov 2017 16:19:43 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > > In any case, this is a much more
minor bug than the one I reported, so > > > please install your changes on
the release branch. Bonus points if > > > you can find where does the "translation"
come from. [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli.
On Sun, Nov 19, 2017 at 19:04:45 +0200, Eli Zaretskii wrote:
> > Date: Sun, 19 Nov 2017 16:19:43 +0000
> > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN>
> > > In any case, this is a much more minor bug than the one I reported, so
> > > please install your changes on the release branch. Bonus points if
> > > you can find where does the "translation" come from.
> > I claim my prize. :-)
> > The following patch (which absolutely requires the patch to bug #29349
> > "read_key_sequence is only partially recursive. This is a bug." to work)
> > fixes the above glitch on Linux tty (and possibly on other platforms).
> > It works by disregarding the "intermediate" events in UNTRANSLATED when
> > comparing the processed key sequence with the UNTRANSLATED string of
> > events:
> OK, but I still would like to understand where did that "translation"
> come from. I don't think I get that from the above description.
It comes from the menu processing with GPM. Each mouse click (but I'm
not sure about mouse movements) in a menu is entered into
read_key_sequence's raw event buffer. This happens in the recursive call
of read_key_sequence which happens when r_k_s calls read_key, and a menu
gets processed.
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 19 Nov 2017 17:45:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 12:45:08 2017 Received: from localhost ([127.0.0.1]:47764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eGTeW-0005v7-AB for submit <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:45:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eGTeV-0005uw-6B for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eGTeK-0003bz-Rv for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:45:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_05,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eGTeK-0003bv-OJ; Sun, 19 Nov 2017 12:44:56 -0500 Received: from [176.228.60.248] (port=2130 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eGTeK-0007d4-1y; Sun, 19 Nov 2017 12:44:56 -0500 Date: Sun, 19 Nov 2017 19:44:46 +0200 Message-Id: <83po8eduy9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: acm@HIDDEN In-reply-to: <83shdadwsy.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 19 Nov 2017 19:04:45 +0200) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN> <20171119161943.GA9922@ACM> <83shdadwsy.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: 29272 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Sun, 19 Nov 2017 19:04:45 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > Cc: 29272 <at> debbugs.gnu.org > > OK, but I still would like to understand where did that "translation" > come from. I don't think I get that from the above description. Specifically, can you walk me through help-key-description, and tell what values do you see there. For example, where did mouse-1 come from, if the original mouse click was C-mouse-3? Isn't that the root cause?
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 19 Nov 2017 17:05:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 12:05:06 2017 Received: from localhost ([127.0.0.1]:47732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eGT1m-00051Z-FP for submit <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:05:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eGT1l-00050z-4E for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:05:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eGT1b-0002ha-I9 for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 12:05:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_40,GAPPY_SUBJECT, T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eGT1b-0002hU-EU; Sun, 19 Nov 2017 12:04:55 -0500 Received: from [176.228.60.248] (port=2106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eGT1a-0002uV-V7; Sun, 19 Nov 2017 12:04:55 -0500 Date: Sun, 19 Nov 2017 19:04:45 +0200 Message-Id: <83shdadwsy.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alan Mackenzie <acm@HIDDEN> In-reply-to: <20171119161943.GA9922@ACM> (message from Alan Mackenzie on Sun, 19 Nov 2017 16:19:43 +0000) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN> <20171119161943.GA9922@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: 29272 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Sun, 19 Nov 2017 16:19:43 +0000 > Cc: 29272 <at> debbugs.gnu.org > From: Alan Mackenzie <acm@HIDDEN> > > > In any case, this is a much more minor bug than the one I reported, so > > please install your changes on the release branch. Bonus points if > > you can find where does the "translation" come from. > > I claim my prize. :-) > > The following patch (which absolutely requires the patch to bug #29349 > "read_key_sequence is only partially recursive. This is a bug." to work) > fixes the above glitch on Linux tty (and possibly on other platforms). > It works by disregarding the "intermediate" events in UNTRANSLATED when > comparing the processed key sequence with the UNTRANSLATED string of > events: OK, but I still would like to understand where did that "translation" come from. I don't think I get that from the above description. Thanks.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 19 Nov 2017 16:22:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 19 11:22:48 2017
Received: from localhost ([127.0.0.1]:47706 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eGSMo-000449-6B
for submit <at> debbugs.gnu.org; Sun, 19 Nov 2017 11:22:48 -0500
Received: from ocolin.muc.de ([193.149.48.4]:15858 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eGSMm-000441-S5
for 29272 <at> debbugs.gnu.org; Sun, 19 Nov 2017 11:22:45 -0500
Received: (qmail 67421 invoked by uid 3782); 19 Nov 2017 16:22:41 -0000
Received: from acm.muc.de (p548C7514.dip0.t-ipconnect.de [84.140.117.20]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Sun, 19 Nov 2017 17:22:40 +0100
Received: (qmail 10004 invoked by uid 1000); 19 Nov 2017 16:19:43 -0000
Date: Sun, 19 Nov 2017 16:19:43 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171119161943.GA9922@ACM>
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83r2svg72w.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sat, Nov 18, 2017 at 13:27:35 +0200,
Eli Zaretskii
wrote: > > Date: Tue, 14 Nov 2017 20:54:49 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > The following patch attempts to
catch and filter out obtrusive events. > > Could you try it out, please,
even though it's not perfect (see below). > > It's based on the emacs-26
branch: [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sat, Nov 18, 2017 at 13:27:35 +0200, Eli Zaretskii
wrote: > > Date: Tue, 14 Nov 2017 20:54:49 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > The following patch attempts to
catch and filter out obtrusive events. > > Could you try it out, please,
even though it's not perfect (see below). > > It's based on the emacs-26 branch:
[...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli.
On Sat, Nov 18, 2017 at 13:27:35 +0200, Eli Zaretskii wrote:
> > Date: Tue, 14 Nov 2017 20:54:49 +0000
> > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN>
> > The following patch attempts to catch and filter out obtrusive events.
> > Could you try it out, please, even though it's not perfect (see below).
> > It's based on the emacs-26 branch:
> Thanks, this seems to fix the problem. I take it that you've verified
> it doesn't re-introduce the original bug?
> > However, the problem is that in C-h k C-mouse-3
> > <select-something-from-the-menus>, we get a spurious "translation"
> > message in *Help*, looking something like:
> > <C-down-mouse-3> <file> <new-file> (translated from <mouse-1> <new-file>) at
> > that spot runs the command find-file (found in global-map), which is an
> > interactive compiled Lisp function in `files.el'.
> > That was from a Linux tty session using gpm. In X, I got the message
> > .... (translated from <C-down-mouse-3> <C-down-mouse-3> ....)
> I only see this in a text-mode frame (in my case it's "<mouse-1>
> <indent-pp-sexp>"). On GUI frame, there's no "translation".
Not on an X-Windows frame - X seems to handle all the mouse-movement and
intermediate click events itself. On a linux tty with GPM, you do indeed
see these intermediate events.
> > . I don't believe this glitch has to do with my patch - I think it's
> > been there for some while, but this bug has prevented it being seen
> > before.
> I think you are right, as I see the same problem in Emacs 24.5.
> In any case, this is a much more minor bug than the one I reported, so
> please install your changes on the release branch. Bonus points if
> you can find where does the "translation" come from.
I claim my prize. :-)
The following patch (which absolutely requires the patch to bug #29349
"read_key_sequence is only partially recursive. This is a bug." to work)
fixes the above glitch on Linux tty (and possibly on other platforms).
It works by disregarding the "intermediate" events in UNTRANSLATED when
comparing the processed key sequence with the UNTRANSLATED string of
events:
diff --git a/lisp/help.el b/lisp/help.el
index 212e3679da..f5192e1902 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -583,14 +583,66 @@ where-is
(princ string)))))
nil)
+(defun help--equivalent-sequence-p (key untranslated)
+ "Is KEY a (possibly translated) version of UNTRANSLATED?
+If so return t, otherwise return nil.
+
+KEY is a key sequence, either a string or a vector. UNTRANSLATED
+is a vector of events which gave rise to KEY, typically the output from
+`this-single-command-raw-keys'.
+
+The idea here is that for menu structure key sequences,
+UNTRANSLATED in certain environments contains things like
+<mouse-movement> and intermediate mouse button presses. These
+will be disregarded in the comparison between KEY and
+UNTRANSLATED."
+ (let* ((len-key (length key))
+ (len-unt (length untranslated))
+ (key-idx 0)
+ (unt-idx 0)
+ key-elt unt-elt mods)
+ (cond
+ ((and (stringp key)
+ (eq len-key len-unt))
+ (while (and (< key-idx len-key)
+ (eq (aref key key-idx)
+ (aref untranslated key-idx)))
+ (setq key-idx (1+ key-idx)))
+ (eq key-idx len-key))
+ ((vectorp key)
+ ;; In this while go round one elt of `key' each time round
+ (while
+ (and (< key-idx len-key)
+ (< unt-idx len-unt)
+ (progn
+ (setq key-elt (aref key key-idx))
+ ;; In this while, skip an intermediate mouse click, etc.
+ ;; from `untranslated' each time round.
+ (while
+ (and
+ (< unt-idx len-unt)
+ (progn
+ (setq unt-elt (aref untranslated unt-idx))
+ (not (eq unt-elt key-elt)))
+ (progn
+ (setq mods (event-modifiers unt-elt))
+ (or (eq (car-safe unt-elt) 'mouse-movement)
+ (cl-intersection '(click double triple drag down)
+ mods))))
+ (setq unt-idx (1+ unt-idx)))
+ (eq unt-elt key-elt)))
+ (setq key-idx (1+ key-idx)
+ unt-idx (1+ unt-idx)))
+ (eq key-idx len-key)))))
+
(defun help-key-description (key untranslated)
(let ((string (key-description key)))
(if (or (not untranslated)
(and (eq (aref untranslated 0) ?\e) (not (eq (aref key 0) ?\e))))
string
- (let ((otherstring (key-description untranslated)))
- (if (equal string otherstring)
- string
+ (if (help--equivalent-sequence-p key untranslated)
+ string
+ (let ((otherstring (key-description untranslated)))
(format "%s (translated from %s)" string otherstring))))))
(defun help--analyze-key (key untranslated)
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 18 Nov 2017 15:18:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 10:18:37 2017
Received: from localhost ([127.0.0.1]:46503 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eG4tA-0000uR-RH
for submit <at> debbugs.gnu.org; Sat, 18 Nov 2017 10:18:37 -0500
Received: from ocolin.muc.de ([193.149.48.4]:54565 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eG4t8-0000uH-9u
for 29272 <at> debbugs.gnu.org; Sat, 18 Nov 2017 10:18:34 -0500
Received: (qmail 45366 invoked by uid 3782); 18 Nov 2017 15:18:30 -0000
Received: from acm.muc.de (p548C78EA.dip0.t-ipconnect.de [84.140.120.234]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Sat, 18 Nov 2017 16:18:29 +0100
Received: (qmail 17938 invoked by uid 1000); 18 Nov 2017 15:15:41 -0000
Date: Sat, 18 Nov 2017 15:15:41 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171118151541.GB3819@ACM>
References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN>
<20171114205449.GA8025@ACM> <83r2svg72w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83r2svg72w.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sat, Nov 18, 2017 at 13:27:35 +0200,
Eli Zaretskii
wrote: > > Date: Tue, 14 Nov 2017 20:54:49 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > The following patch attempts to
catch and filter out obtrusive events. > > Could you try it out, please,
even though it's not perfect (see below). > > It's based on the emacs-26
branch: [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sat, Nov 18, 2017 at 13:27:35 +0200, Eli Zaretskii
wrote: > > Date: Tue, 14 Nov 2017 20:54:49 +0000 > > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN> > > The following patch attempts to
catch and filter out obtrusive events. > > Could you try it out, please,
even though it's not perfect (see below). > > It's based on the emacs-26 branch:
[...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli.
On Sat, Nov 18, 2017 at 13:27:35 +0200, Eli Zaretskii wrote:
> > Date: Tue, 14 Nov 2017 20:54:49 +0000
> > Cc: 29272 <at> debbugs.gnu.org
> > From: Alan Mackenzie <acm@HIDDEN>
> > The following patch attempts to catch and filter out obtrusive events.
> > Could you try it out, please, even though it's not perfect (see below).
> > It's based on the emacs-26 branch:
> Thanks, this seems to fix the problem. I take it that you've verified
> it doesn't re-introduce the original bug?
> > However, the problem is that in C-h k C-mouse-3
> > <select-something-from-the-menus>, we get a spurious "translation"
> > message in *Help*, looking something like:
> > <C-down-mouse-3> <file> <new-file> (translated from <mouse-1> <new-file>) at
> > that spot runs the command find-file (found in global-map), which is an
> > interactive compiled Lisp function in `files.el'.
> > That was from a Linux tty session using gpm. In X, I got the message
> > .... (translated from <C-down-mouse-3> <C-down-mouse-3> ....)
> I only see this in a text-mode frame (in my case it's "<mouse-1>
> <indent-pp-sexp>"). On GUI frame, there's no "translation".
> > . I don't believe this glitch has to do with my patch - I think it's
> > been there for some while, but this bug has prevented it being seen
> > before.
> I think you are right, as I see the same problem in Emacs 24.5.
> In any case, this is a much more minor bug than the one I reported, so
> please install your changes on the release branch.
DONE. Though I changed the timeout from 0.001s to 0.01s, because I'd had
a bit of trouble with the shorter timeout with edebug in operation.
> Bonus points if you can find where does the "translation" come from.
I understand that, now. If I can fix bug #29349 (the one I reported this
morning about read_key_sequence not being properly recursive), I can fix
the problems here with C-mouse-3 on Linux TTYs with GPM. There might
also be problems on MS-Windows, though I haven't been able to verify or
test this at all.
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at 29272) by debbugs.gnu.org; 18 Nov 2017 11:27:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 18 06:27:59 2017 Received: from localhost ([127.0.0.1]:45604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eG1Hz-00024n-6U for submit <at> debbugs.gnu.org; Sat, 18 Nov 2017 06:27:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eG1Hx-00024Z-Fl for 29272 <at> debbugs.gnu.org; Sat, 18 Nov 2017 06:27:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eG1Hp-0001dc-5g for 29272 <at> debbugs.gnu.org; Sat, 18 Nov 2017 06:27:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,GAPPY_SUBJECT, RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eG1Hp-0001dS-2D; Sat, 18 Nov 2017 06:27:49 -0500 Received: from [176.228.60.248] (port=4656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eG1Ho-00063k-9E; Sat, 18 Nov 2017 06:27:48 -0500 Date: Sat, 18 Nov 2017 13:27:35 +0200 Message-Id: <83r2svg72w.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alan Mackenzie <acm@HIDDEN> In-reply-to: <20171114205449.GA8025@ACM> (message from Alan Mackenzie on Tue, 14 Nov 2017 20:54:49 +0000) Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys References: <83shdjn3ju.fsf@HIDDEN> <83mv3rn02t.fsf@HIDDEN> <20171114205449.GA8025@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 29272 Cc: 29272 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) > Date: Tue, 14 Nov 2017 20:54:49 +0000 > Cc: 29272 <at> debbugs.gnu.org > From: Alan Mackenzie <acm@HIDDEN> > > You're not kidding about the refactoring. ;-) No, not at all. > The following patch attempts to catch and filter out obtrusive events. > Could you try it out, please, even though it's not perfect (see below). > It's based on the emacs-26 branch: Thanks, this seems to fix the problem. I take it that you've verified it doesn't re-introduce the original bug? > However, the problem is that in C-h k C-mouse-3 > <select-something-from-the-menus>, we get a spurious "translation" > message in *Help*, looking something like: > > <C-down-mouse-3> <file> <new-file> (translated from <mouse-1> <new-file>) at > that spot runs the command find-file (found in global-map), which is an > interactive compiled Lisp function in `files.el'. > > That was from a Linux tty session using gpm. In X, I got the message > > .... (translated from <C-down-mouse-3> <C-down-mouse-3> ....) I only see this in a text-mode frame (in my case it's "<mouse-1> <indent-pp-sexp>"). On GUI frame, there's no "translation". > . I don't believe this glitch has to do with my patch - I think it's > been there for some while, but this bug has prevented it being seen > before. I think you are right, as I see the same problem in Emacs 24.5. In any case, this is a much more minor bug than the one I reported, so please install your changes on the release branch. Bonus points if you can find where does the "translation" come from. Thanks.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 14 Nov 2017 20:56:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 14 15:56:57 2017
Received: from localhost ([127.0.0.1]:40619 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eEiGP-00030b-Cl
for submit <at> debbugs.gnu.org; Tue, 14 Nov 2017 15:56:57 -0500
Received: from ocolin.muc.de ([193.149.48.4]:14615 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eEiGO-00030T-8q
for 29272 <at> debbugs.gnu.org; Tue, 14 Nov 2017 15:56:57 -0500
Received: (qmail 9709 invoked by uid 3782); 14 Nov 2017 20:56:52 -0000
Received: from acm.muc.de (p548C6DFA.dip0.t-ipconnect.de [84.140.109.250]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Tue, 14 Nov 2017 21:56:51 +0100
Received: (qmail 8132 invoked by uid 1000); 14 Nov 2017 20:54:49 -0000
Date: Tue, 14 Nov 2017 20:54:49 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171114205449.GA8025@ACM>
References: <83shdjn3ju.fsf@HIDDEN>
<83mv3rn02t.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83mv3rn02t.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sun, Nov 12, 2017 at 14:38:50 +0200,
Eli Zaretskii
wrote: > > Date: Sun, 12 Nov 2017 13:23:49 +0200 > > From: Eli Zaretskii
<eliz@HIDDEN> > > To reproduce: [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sun, Nov 12, 2017 at 14:38:50 +0200, Eli Zaretskii
wrote: > > Date: Sun, 12 Nov 2017 13:23:49 +0200 > > From: Eli Zaretskii
<eliz@HIDDEN> > > To reproduce: [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli.
On Sun, Nov 12, 2017 at 14:38:50 +0200, Eli Zaretskii wrote:
> > Date: Sun, 12 Nov 2017 13:23:49 +0200
> > From: Eli Zaretskii <eliz@HIDDEN>
> > To reproduce:
> > emacs -Q
> > C-h k C-mouse-3
> > This pops up a Lisp Interaction Mode menu. Select some item from the
> > menu. The expected result is to show in *Help* the description of the
> > command selected from the menu. Instead, you are prompted again for a
> > key or a mouse click.
> > "C-h l" shows this:
> > C-h k [describe-key]
> > <C-down-mouse-3> <indent-pp-sexp> <help-echo> <help-echo>
> > (I'm guessing help-echo comes from the menu items traversed by the
> > mouse while selecting the item.)
I would think so, too.
> I think those help-echo events are the reason. We have this in
> help-read-key-sequence:
> (while
> (pcase (setq key (read-key-sequence "\
> Describe the following key, mouse click, or menu item: "))
> ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0))
> (guard (symbolp key0)) (let keyname (symbol-name key0)))
> (if no-mouse-movement
> (string-match "mouse-movement" keyname)
> (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
> keyname)
> (not (sit-for (/ double-click-time 1000.0) t)))))))
> What I think happens is that after the mouse-click event we get a
> help-echo event, which causes sit-for to exit with nil value, and we
> keep looping, because the loop expects only mouse events.
Yes.
> Alan, could you please take a look? I think this was introduced by
> your changes in 10c0e1c (which you, no doubt, will have hard time
> recognizing among the code that meanwhile was completely refactored),
> which I think was an attempt to fix bug#22731 (not mentioned in the
> log message). I think the changes failed to consider mouse clicks
> that invoke menu items.
You're not kidding about the refactoring. ;-)
The following patch attempts to catch and filter out obtrusive events.
Could you try it out, please, even though it's not perfect (see below).
It's based on the emacs-26 branch:
diff --git a/lisp/help.el b/lisp/help.el
index fbb9fc8cbe..d119615180 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -728,11 +728,17 @@ help-read-key-sequence
Describe the following key, mouse click, or menu item: "))
((and (pred vectorp) (let `(,key0 . ,_) (aref key 0))
(guard (symbolp key0)) (let keyname (symbol-name key0)))
- (if no-mouse-movement
- (string-match "mouse-movement" keyname)
- (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
- keyname)
- (not (sit-for (/ double-click-time 1000.0) t)))))))
+ (or
+ (and no-mouse-movement
+ (string-match "mouse-movement" keyname))
+ (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
+ keyname)
+ (progn
+ ;; Discard events (e.g. <help-echo>) which might
+ ;; spuriously trigger the `sit-for'.
+ (sleep-for 0.001)
+ (while (read-event nil nil 0.001))
+ (not (sit-for (/ double-click-time 1000.0) t))))))))
(list
key
;; If KEY is a down-event, read and include the
I think I've corrected what looks like a bug, there; even when
`no-mouse-movement' is non-nil (i.e. in C-h c), it should still check for
double clicks.
However, the problem is that in C-h k C-mouse-3
<select-something-from-the-menus>, we get a spurious "translation"
message in *Help*, looking something like:
<C-down-mouse-3> <file> <new-file> (translated from <mouse-1> <new-file>) at
that spot runs the command find-file (found in global-map), which is an
interactive compiled Lisp function in `files.el'.
That was from a Linux tty session using gpm. In X, I got the message
.... (translated from <C-down-mouse-3> <C-down-mouse-3> ....)
. I don't believe this glitch has to do with my patch - I think it's
been there for some while, but this bug has prevented it being seen
before.
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 12 Nov 2017 13:25:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 08:25:53 2017
Received: from localhost ([127.0.0.1]:36152 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eDsGm-0008Uf-Qs
for submit <at> debbugs.gnu.org; Sun, 12 Nov 2017 08:25:53 -0500
Received: from ocolin.muc.de ([193.149.48.4]:31893 helo=mail.muc.de)
by debbugs.gnu.org with smtp (Exim 4.84_2)
(envelope-from <acm@HIDDEN>) id 1eDsGl-0008UW-7i
for 29272 <at> debbugs.gnu.org; Sun, 12 Nov 2017 08:25:51 -0500
Received: (qmail 23564 invoked by uid 3782); 12 Nov 2017 13:25:45 -0000
Received: from acm.muc.de (p548C60E3.dip0.t-ipconnect.de [84.140.96.227]) by
colin.muc.de (tmda-ofmipd) with ESMTP;
Sun, 12 Nov 2017 14:25:44 +0100
Received: (qmail 11995 invoked by uid 1000); 12 Nov 2017 13:24:08 -0000
Date: Sun, 12 Nov 2017 13:24:08 +0000
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#29272: 26.0.90; "C-h k C-mouse-3" followed by menu selection
asks for more keys
Message-ID: <20171112132408.GA20916@ACM>
References: <83shdjn3ju.fsf@HIDDEN>
<83mv3rn02t.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83mv3rn02t.fsf@HIDDEN>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sun, Nov 12, 2017 at 14:38:50 +0200,
Eli Zaretskii
wrote: > > Date: Sun, 12 Nov 2017 13:23:49 +0200 > > From: Eli Zaretskii
<eliz@HIDDEN> > > To reproduce: [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hello, Eli. On Sun, Nov 12, 2017 at 14:38:50 +0200, Eli Zaretskii
wrote: > > Date: Sun, 12 Nov 2017 13:23:49 +0200 > > From: Eli Zaretskii
<eliz@HIDDEN> > > To reproduce: [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain
1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t
Hello, Eli.
On Sun, Nov 12, 2017 at 14:38:50 +0200, Eli Zaretskii wrote:
> > Date: Sun, 12 Nov 2017 13:23:49 +0200
> > From: Eli Zaretskii <eliz@HIDDEN>
> > To reproduce:
> > emacs -Q
> > C-h k C-mouse-3
> > This pops up a Lisp Interaction Mode menu. Select some item from the
> > menu. The expected result is to show in *Help* the description of the
> > command selected from the menu. Instead, you are prompted again for a
> > key or a mouse click.
> > "C-h l" shows this:
> > C-h k [describe-key]
> > <C-down-mouse-3> <indent-pp-sexp> <help-echo> <help-echo>
> > (I'm guessing help-echo comes from the menu items traversed by the
> > mouse while selecting the item.)
> I think those help-echo events are the reason. We have this in
> help-read-key-sequence:
> (while
> (pcase (setq key (read-key-sequence "\
> Describe the following key, mouse click, or menu item: "))
> ((and (pred vectorp) (let `(,key0 . ,_) (aref key 0))
> (guard (symbolp key0)) (let keyname (symbol-name key0)))
> (if no-mouse-movement
> (string-match "mouse-movement" keyname)
> (and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
> keyname)
> (not (sit-for (/ double-click-time 1000.0) t)))))))
> What I think happens is that after the mouse-click event we get a
> help-echo event, which causes sit-for to exit with nil value, and we
> keep looping, because the loop expects only mouse events.
> Alan, could you please take a look?
Will do.
> I think this was introduced by your changes in 10c0e1c (which you, no
> doubt, will have hard time recognizing among the code that meanwhile
> was completely refactored), which I think was an attempt to fix
> bug#22731 (not mentioned in the log message). I think the changes
> failed to consider mouse clicks that invoke menu items.
That could well be the case. I'll be looking at it.
--
Alan Mackenzie (Nuremberg, Germany).
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
Received: (at 29272) by debbugs.gnu.org; 12 Nov 2017 12:39:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 07:39:02 2017
Received: from localhost ([127.0.0.1]:36126 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1eDrXQ-0007PE-Qs
for submit <at> debbugs.gnu.org; Sun, 12 Nov 2017 07:39:02 -0500
Received: from eggs.gnu.org ([208.118.235.92]:46765)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1eDrXO-0007P2-IM
for 29272 <at> debbugs.gnu.org; Sun, 12 Nov 2017 07:38:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <eliz@HIDDEN>) id 1eDrXE-000523-3z
for 29272 <at> debbugs.gnu.org; Sun, 12 Nov 2017 07:38:53 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: **
X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,GAPPY_SUBJECT,
RP_MATCHES_RCVD autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40605)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
id 1eDrXE-00051w-0U; Sun, 12 Nov 2017 07:38:48 -0500
Received: from [176.228.60.248] (port=3932 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <eliz@HIDDEN>)
id 1eDrXC-0004tn-6p; Sun, 12 Nov 2017 07:38:47 -0500
Date: Sun, 12 Nov 2017 14:38:50 +0200
Message-Id: <83mv3rn02t.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Alan Mackenzie <acm@HIDDEN>
In-reply-to: <83shdjn3ju.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 12
Nov 2017 13:23:49 +0200)
Subject: Re: bug#29272: 26.0.90;
"C-h k C-mouse-3" followed by menu selection asks for more keys
References: <83shdjn3ju.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -3.7 (---)
X-Debbugs-Envelope-To: 29272
Cc: 29272 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.7 (---)
> Date: Sun, 12 Nov 2017 13:23:49 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
>
> To reproduce:
>
> emacs -Q
> C-h k C-mouse-3
>
> This pops up a Lisp Interaction Mode menu. Select some item from the
> menu. The expected result is to show in *Help* the description of the
> command selected from the menu. Instead, you are prompted again for a
> key or a mouse click.
>
> "C-h l" shows this:
>
> C-h k [describe-key]
> <C-down-mouse-3> <indent-pp-sexp> <help-echo> <help-echo>
>
> (I'm guessing help-echo comes from the menu items traversed by the
> mouse while selecting the item.)
I think those help-echo events are the reason. We have this in
help-read-key-sequence:
(while
(pcase (setq key (read-key-sequence "\
Describe the following key, mouse click, or menu item: "))
((and (pred vectorp) (let `(,key0 . ,_) (aref key 0))
(guard (symbolp key0)) (let keyname (symbol-name key0)))
(if no-mouse-movement
(string-match "mouse-movement" keyname)
(and (string-match "\\(mouse\\|down\\|click\\|drag\\)"
keyname)
(not (sit-for (/ double-click-time 1000.0) t)))))))
What I think happens is that after the mouse-click event we get a
help-echo event, which causes sit-for to exit with nil value, and we
keep looping, because the loop expects only mouse events.
Alan, could you please take a look? I think this was introduced by
your changes in 10c0e1c (which you, no doubt, will have hard time
recognizing among the code that meanwhile was completely refactored),
which I think was an attempt to fix bug#22731 (not mentioned in the
log message). I think the changes failed to consider mouse clicks
that invoke menu items.
bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 12 Nov 2017 11:24:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 12 06:24:01 2017 Received: from localhost ([127.0.0.1]:36073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1eDqMq-0003fD-P2 for submit <at> debbugs.gnu.org; Sun, 12 Nov 2017 06:24:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1eDqMo-0003ez-OM for submit <at> debbugs.gnu.org; Sun, 12 Nov 2017 06:23:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eDqMi-0003xE-Fm for submit <at> debbugs.gnu.org; Sun, 12 Nov 2017 06:23:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,GAPPY_SUBJECT, RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eDqMi-0003x8-CA for submit <at> debbugs.gnu.org; Sun, 12 Nov 2017 06:23:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eDqMh-0003Dt-7q for bug-gnu-emacs@HIDDEN; Sun, 12 Nov 2017 06:23:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eDqMc-0003rw-9t for bug-gnu-emacs@HIDDEN; Sun, 12 Nov 2017 06:23:51 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1eDqMc-0003rq-5q for bug-gnu-emacs@HIDDEN; Sun, 12 Nov 2017 06:23:46 -0500 Received: from [176.228.60.248] (port=3857 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1eDqMb-00047o-JX for bug-gnu-emacs@HIDDEN; Sun, 12 Nov 2017 06:23:46 -0500 Date: Sun, 12 Nov 2017 13:23:49 +0200 Message-Id: <83shdjn3ju.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 26.0.90; "C-h k C-mouse-3" followed by menu selection asks for more keys X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.7 (---) To reproduce: emacs -Q C-h k C-mouse-3 This pops up a Lisp Interaction Mode menu. Select some item from the menu. The expected result is to show in *Help* the description of the command selected from the menu. Instead, you are prompted again for a key or a mouse click. "C-h l" shows this: C-h k [describe-key] <C-down-mouse-3> <indent-pp-sexp> <help-echo> <help-echo> (I'm guessing help-echo comes from the menu items traversed by the mouse while selecting the item.) This works in Emacs 25.2, so it's a recent regression. In GNU Emacs 26.0.90 (build 1, i686-pc-mingw32) of 2017-10-12 built on HOME-C4E4A596F7 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Type C-x 1 to delete the help window. Configured using: 'configure --prefix=/d/usr --with-wide-int --with-modules --enable-checking=yes,glyphs 'CFLAGS=-Og -gdwarf-4 -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES LCMS2 Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-extra help-fns radix-tree help-mode easymenu cl-loaddefs cl-lib elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 103039 10652) (symbols 56 21441 1) (miscs 48 40 97) (strings 16 32209 1748) (string-bytes 1 779452) (vectors 16 14316) (vector-slots 8 648524 8150) (floats 8 52 222) (intervals 40 292 114) (buffers 880 12))
Eli Zaretskii <eliz@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#29272; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.