GNU bug report logs - #29277
Symlink test failure on macOS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29277 in the body.
You can then email your comments to 29277 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Symlink test failure on macOS
Date: Sun, 12 Nov 2017 22:48:49 +0000

I just noticed a new test failure on macOS. I’m not sure when it
started as I haven’t run make test in quite a while.

F fileio-tests--odd-symlink-chars
    Check that any non-NULL ASCII character can appear in a symlink.
    (ert-test-failed
     ((should
       (equal nil
	      (fileio-tests--symlink-failure)))
      :form
      (equal nil
	     (string-equal "
" "
"))
      :value nil :explanation
      (different-types nil
		       (string-equal "
" "
"))))


The ‘different‐types’ bit above has ^M in the first position and ^J in
the second (at least according to describe‐char).

My completely unscientific thought is that something is converting ^M
in filenames to ^J and it looks suspiciously like an old‐school
mac‐>unix line ending conversion.
-- 
Alan Third

Message #8 received at 29277 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: 29277 <at> debbugs.gnu.org
Subject: Re: bug#29277: Symlink test failure on macOS
Date: Wed, 15 Nov 2017 00:04:28 +0000

On Sun, Nov 12, 2017 at 10:48:49PM +0000, Alan Third wrote:
> I just noticed a new test failure on macOS. I’m not sure when it
> started as I haven’t run make test in quite a while.

It appears that fileio-tests.el was added recently, so this is
probably a long‐standing issue.

83f0d60e498c9cab59e098af6d9c403631ad645c
Author:     Paul Eggert <eggert <at> cs.ucla.edu>
AuthorDate: Sat Aug 19 17:15:52 2017 -0700
Commit:     Paul Eggert <eggert <at> cs.ucla.edu>
CommitDate: Sat Aug 19 17:17:09 2017 -0700

Parent:     1c382c096b Make list-processes support display-line-numbers
Merged:     concurrency emacs-25 visible-bell
Containing: emacs-26 master nsimage scrolling
Follows:    emacs-25.1 (129792)

Don’t adjust CRLF in file names

* doc/misc/gnus.texi (Non-ASCII Group Names):
* etc/NEWS:
* test/lisp/net/tramp-tests.el (tramp--test-utf8):
Use utf-8-unix, not utf-8, for default-file-name-coding-system, so
that CRLF in file names is left alone.
* lisp/international/mule-cmds.el (set-default-coding-systems):
Do not alter CRLF in file name coding systems.
(prefer-coding-system): Ignore differences in CRLF processing when
checking whether we used the user-specified file name coding system.
* test/src/fileio-tests.el: New file.

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.