GNU bug report logs - #29301
[PATCH] substitute* hard-coded paths with paths from "out"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29301 in the body.
You can then email your comments to 29301 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kristofer Buffington <kristoferbuffington <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] substitute* hard-coded paths with paths from "out"
Date: Tue, 14 Nov 2017 19:41:36 -0500

* gnu/packages/guile.scm
used substitute* to correct some hardcoded paths in the artanis package
---
 gnu/packages/guile.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index abcefd32e..b7c2dd4c7 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2017 Theodoros Foradis <theodoros <at> foradis.org>
 ;;; Copyright © 2017 ng0 <ng0 <at> infotropique.org>
+;;; Copyright © 2017 Kristofer Buffington <kristoferbuffington <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -431,7 +432,8 @@ program can be installed in one go.")
                                       post)))
                     (substitute* "artanis/artanis.scm"
                       (("[[:punct:][:space:]]+->json-string[[:punct:][:space:]]+")
-                       ""))))))
+                       ""))
+                    ))))
       (build-system gnu-build-system)
       ;; TODO: Add guile-dbi and guile-dbd optional dependencies.
       (inputs `(("guile" ,guile-2.2)
@@ -458,6 +460,14 @@ program can be installed in one go.")
                    ((" /etc/bash.bashrc") " /dev/null"))
                  (substitute* "Makefile"   ;set the root of config files to OUT
                    ((" /etc") (string-append " " out "/etc")))
+                 (substitute* "artanis/config.scm"
+                   (("/etc/artanis/artanis.conf")
+                    (string-append out "/etc/artanis.conf"))
+                   (("/etc/artanis/pages")
+                    (string-append out "/etc/artanis")))
+                 (substitute* "etc/artanis/artanis.conf"
+                   (("/etc/artanis/pages")
+                    (string-append out "/etc/artanis")))
                  (mkdir-p (string-append out "/bin")) ;for the `art' executable
                  #t)))
            (add-after 'install 'wrap-art
-- 
2.15.0
Message-ID: <877euscq0y.fsf <at> gmail.com>

Message #8 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kristofer Buffington <kristoferbuffington <at> gmail.com>
Cc: 29301 <at> debbugs.gnu.org
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Thu, 23 Nov 2017 22:59:26 +0100

Hi Kristofer,

Kristofer Buffington <kristoferbuffington <at> gmail.com> skribis:

> * gnu/packages/guile.scm
> used substitute* to correct some hardcoded paths in the artanis package

[...]

> +                 (substitute* "artanis/config.scm"
> +                   (("/etc/artanis/artanis.conf")
> +                    (string-append out "/etc/artanis.conf"))
> +                   (("/etc/artanis/pages")
> +                    (string-append out "/etc/artanis")))
> +                 (substitute* "etc/artanis/artanis.conf"
> +                   (("/etc/artanis/pages")
> +                    (string-append out "/etc/artanis")))

Shouldn’t we instead configure it with --sysconfdir=/etc?  That would
allow users to provide custom configuration files, whereas currently
OUTPUT/etc/artanis contains immutable configuration files.

WDYT?

Thanks,
Ludo’.

Message #11 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: Kristofer Buffington <kristoferbuffington <at> gmail.com>
To: 29301 <at> debbugs.gnu.org
Subject: Fwd: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Sun, 26 Nov 2017 20:31:52 -0500

[Message part 1 (text/plain, inline)]

---------- Forwarded message ----------
From: Kristofer Buffington <kristoferbuffington <at> gmail.com>
Date: Sun, Nov 26, 2017 at 8:30 PM
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths
from "out"
To: Ludovic Courtès <ludo <at> gnu.org>


I will investigate. There are some hard coded paths in artanis/config.scm
looking for the configuration file in /etc/artanis/artanis.conf -- I don't
believe the --sysconfdir flag will have any impact on the hard-coded paths.
Perhaps I should send a patch upstream to eliminate the hard paths? Then
the substitute* would be unnecessary?

Thanks!
Kris

On Thu, Nov 23, 2017 at 4:59 PM, Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Kristofer,
>
> Kristofer Buffington <kristoferbuffington <at> gmail.com> skribis:
>
> > * gnu/packages/guile.scm
> > used substitute* to correct some hardcoded paths in the artanis package
>
> [...]
>
> > +                 (substitute* "artanis/config.scm"
> > +                   (("/etc/artanis/artanis.conf")
> > +                    (string-append out "/etc/artanis.conf"))
> > +                   (("/etc/artanis/pages")
> > +                    (string-append out "/etc/artanis")))
> > +                 (substitute* "etc/artanis/artanis.conf"
> > +                   (("/etc/artanis/pages")
> > +                    (string-append out "/etc/artanis")))
>
> Shouldn’t we instead configure it with --sysconfdir=/etc?  That would
> allow users to provide custom configuration files, whereas currently
> OUTPUT/etc/artanis contains immutable configuration files.
>
> WDYT?
>
> Thanks,
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #14 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kristofer Buffington <kristoferbuffington <at> gmail.com>
Cc: 29301 <at> debbugs.gnu.org
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Mon, 27 Nov 2017 09:51:56 +0100

Hi,

(Please always keep the bug Cc’d.)

Kristofer Buffington <kristoferbuffington <at> gmail.com> skribis:

> I will investigate. There are some hard coded paths in artanis/config.scm
> looking for the configuration file in /etc/artanis/artanis.conf -- I don't
> believe the --sysconfdir flag will have any impact on the hard-coded paths.
> Perhaps I should send a patch upstream to eliminate the hard paths? Then
> the substitute* would be unnecessary?

--sysconfdir would not change the hard-coded file names, but it would
actually make those hard-coded file names valid.  And again, using /etc
as the sysconfdir would allow people to have a writable artanis.conf
file, for instance, so that’s definitely something we should do.

Thanks,
Ludo’.

Message #17 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: Kristofer Buffington <kristoferbuffington <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29301 <at> debbugs.gnu.org
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Tue, 28 Nov 2017 16:10:35 -0500

[Message part 1 (text/plain, inline)]

Cool! I am not very familiar with autotools. I appreciate the help! I will
follow up with a new patch.

Thanks
Kris

On Nov 27, 2017 3:52 AM, "Ludovic Courtès" <ludo <at> gnu.org> wrote:

> Hi,
>
> (Please always keep the bug Cc’d.)
>
> Kristofer Buffington <kristoferbuffington <at> gmail.com> skribis:
>
> > I will investigate. There are some hard coded paths in artanis/config.scm
> > looking for the configuration file in /etc/artanis/artanis.conf -- I
> don't
> > believe the --sysconfdir flag will have any impact on the hard-coded
> paths.
> > Perhaps I should send a patch upstream to eliminate the hard paths? Then
> > the substitute* would be unnecessary?
>
> --sysconfdir would not change the hard-coded file names, but it would
> actually make those hard-coded file names valid.  And again, using /etc
> as the sysconfdir would allow people to have a writable artanis.conf
> file, for instance, so that’s definitely something we should do.
>
> Thanks,
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #20 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kristofer Buffington <kristoferbuffington <at> gmail.com>
Cc: 29301 <at> debbugs.gnu.org
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Tue, 06 Feb 2018 16:13:49 +0100

Hi Kristofer,

Kristofer Buffington <kristoferbuffington <at> gmail.com> skribis:

> Cool! I am not very familiar with autotools. I appreciate the help! I will
> follow up with a new patch.

Any update on this?  :-)

Ludo’.

Message #23 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: Kristofer Buffington <kristoferbuffington <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29301 <at> debbugs.gnu.org
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Fri, 9 Feb 2018 09:15:07 -0500

[Message part 1 (text/plain, inline)]

Sorry I haven't had a stable internet connection since early december and
haven't been coding much as a result. I will be back at the computer in
about 3 weeks to revisit this.

Kristofer

On Feb 6, 2018 10:13 AM, "Ludovic Courtès" <ludo <at> gnu.org> wrote:

> Hi Kristofer,
>
> Kristofer Buffington <kristoferbuffington <at> gmail.com> skribis:
>
> > Cool! I am not very familiar with autotools. I appreciate the help! I
> will
> > follow up with a new patch.
>
> Any update on this?  :-)
>
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #26 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 29301 <at> debbugs.gnu.org
Cc: kristoferbuffington <at> gmail.com
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Fri, 27 Sep 2019 15:07:07 +0200

[Message part 1 (text/plain, inline)]

Kristofer Buffington 写道：
> I will be back at the computer in about 3 weeks to revisit this.

…ping :-)  Is this still relevant?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 29301 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29301 <at> debbugs.gnu.org, Kristofer Buffington <kristoferbuffington <at> gmail.com>
Subject: Re: bug#29301: [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Thu, 13 Jan 2022 16:56:44 +0100

Hi,

The patch #29301 [1] had been submitted on 2017 and…

On Tue, 06 Feb 2018 at 16:13, ludo <at> gnu.org (Ludovic Courtès) wrote:

> Any update on this?  :-)

…this last message is from 2018.  I am proposing to close.


1: <http://issues.guix.gnu.org/issue/29301>

Cheers,
simon

Message #34 received at 29301-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 29301-done <at> debbugs.gnu.org,
 Kristofer Buffington <kristoferbuffington <at> gmail.com>
Subject: Re: bug#29301: [PATCH] substitute* hard-coded paths with paths from
 "out"
Date: Mon, 17 Jan 2022 14:18:27 +0100

Hi,

zimoun <zimon.toutoune <at> gmail.com> skribis:

> The patch #29301 [1] had been submitted on 2017 and…
>
> On Tue, 06 Feb 2018 at 16:13, ludo <at> gnu.org (Ludovic Courtès) wrote:
>
>> Any update on this?  :-)
>
> …this last message is from 2018.  I am proposing to close.
>
>
> 1: <http://issues.guix.gnu.org/issue/29301>

Agreed, and done (it may not even apply to current Artanis).

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.