GNU bug report logs - #29306
network-manager-vpnc

Previous Next

Package: guix-patches;

Reported by: ng0 <ng0 <at> infotropique.org>

Date: Wed, 15 Nov 2017 10:46:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29306 in the body.
You can then email your comments to 29306 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#29306; Package guix-patches. (Wed, 15 Nov 2017 10:46:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to ng0 <ng0 <at> infotropique.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 15 Nov 2017 10:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: network-manager-vpnc
Date: Wed, 15 Nov 2017 10:45:14 +0000
[Message part 1 (text/plain, inline)]
This adds the vpnc plugin for NetworkManager.

I should add a note why the substitute happens
and why the tests are enabled.
Anything I've missed in this first crude patch,
let me know. This is just to provide a base to
help people reproduce the the current NM problem.
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dl.n0.is/dist/keys/
  WWW: https://we.make.ritual.n0.is
[0001-gnu-Add-network-manager-vpnc.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#29306; Package guix-patches. (Thu, 16 Nov 2017 09:26:02 GMT) Full text and rfc822 format available.

Message #8 received at 29306 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: ng0 <ng0 <at> infotropique.org>
Cc: 29306 <at> debbugs.gnu.org
Subject: Re: [bug#29306] network-manager-vpnc
Date: Thu, 16 Nov 2017 10:25:27 +0100
Heya ng0,

ng0 <ng0 <at> infotropique.org> skribis:

> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 15 Nov 2017 10:40:46 +0000
> Subject: [PATCH] gnu: Add network-manager-vpnc.
>
> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.

I don’t think this patch is crude.  :-)

Minor issues:

> +    (arguments
> +     '(#:tests? #f ;test-import-export is failing

Do you think you could investigate a bit?

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-Makefile
> +           (lambda _
> +             (substitute* "nm-vpnc-service.conf"
> +               (("own_prefix")
> +                "own")))))))

Please add a comment explaining what this does.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("pkg-config" ,pkg-config)
> +       ("libtool" ,libtool)
> +       ("intltool" ,intltool)))

Autoconf/Automake/Libtool are probably unnecessary.

Otherwise LGTM, thanks!

Ludo’.




Added tag(s) patch. Request was from Christopher Baines <mail <at> cbaines.net> to control <at> debbugs.gnu.org. (Mon, 19 Mar 2018 08:03:01 GMT) Full text and rfc822 format available.

Added tag(s) moreinfo. Request was from Christopher Baines <mail <at> cbaines.net> to control <at> debbugs.gnu.org. (Mon, 19 Mar 2018 08:03:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#29306; Package guix-patches. (Mon, 17 Jun 2019 10:27:01 GMT) Full text and rfc822 format available.

Message #15 received at 29306 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>, ng0 <ng0 <at> infotropique.org>
Cc: 29306 <at> debbugs.gnu.org
Subject: Re: [bug#29306] network-manager-vpnc
Date: Mon, 17 Jun 2019 12:26:53 +0200
Heya folks,

ludo <at> gnu.org (Ludovic Courtès) writes:

> Heya ng0,
>
> ng0 <ng0 <at> infotropique.org> skribis:
>
>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0 <at> infotropique.org>
>> Date: Wed, 15 Nov 2017 10:40:46 +0000
>> Subject: [PATCH] gnu: Add network-manager-vpnc.
>>
>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.

Is this still being worked on/relevant? If so, I would like to verify
that it does what we want it to do, and get it merged :-).

Regards,
Jelle




Information forwarded to guix-patches <at> gnu.org:
bug#29306; Package guix-patches. (Mon, 17 Jun 2019 13:38:03 GMT) Full text and rfc822 format available.

Message #18 received at 29306 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: ng0 <ng0 <at> infotropique.org>, 29306 <at> debbugs.gnu.org
Subject: Re: [bug#29306] network-manager-vpnc
Date: Mon, 17 Jun 2019 15:37:05 +0200
Heya,

Jelle Licht <jlicht <at> fsfe.org> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Heya ng0,
>>
>> ng0 <ng0 <at> infotropique.org> skribis:
>>
>>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
>>> From: ng0 <ng0 <at> infotropique.org>
>>> Date: Wed, 15 Nov 2017 10:40:46 +0000
>>> Subject: [PATCH] gnu: Add network-manager-vpnc.
>>>
>>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
>
> Is this still being worked on/relevant? If so, I would like to verify
> that it does what we want it to do, and get it merged :-).

Please give it a spin!  It’s sad to see patches bitrot.

Cheers,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#29306; Package guix-patches. (Mon, 17 Jun 2019 14:09:02 GMT) Full text and rfc822 format available.

Message #21 received at 29306 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> n0.is>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Jelle Licht <jlicht <at> fsfe.org>, ng0 <ng0 <at> n0.is>, 29306 <at> debbugs.gnu.org
Subject: Re: [bug#29306] network-manager-vpnc
Date: Mon, 17 Jun 2019 14:05:50 +0000
Hi Ludovic and Jelle,

Ludovic Courts transcribed 654 bytes:
> Heya,
> 
> Jelle Licht <jlicht <at> fsfe.org> skribis:
> 
> > ludo <at> gnu.org (Ludovic Courtès) writes:
> >
> >> Heya ng0,
> >>
> >> ng0 <ng0 <at> infotropique.org> skribis:
> >>
> >>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> >>> From: ng0 <ng0 <at> infotropique.org>
> >>> Date: Wed, 15 Nov 2017 10:40:46 +0000
> >>> Subject: [PATCH] gnu: Add network-manager-vpnc.
> >>>
> >>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
> >
> > Is this still being worked on/relevant? If so, I would like to verify
> > that it does what we want it to do, and get it merged :-).

Feel free to take on this. I have started publishing my old patches,
so there could be some progress in there.
Consider all my open patches here (I have no idea how many) up for
taking (leaving me as co/author), since I'm mainly doing NetBSD and
GNUnet these days.

The last known state of this patch is here:
https://c.n0.is/infotropique/p2/infotropiqueOScore/ports-wip/file/tip/ports/net/network-manager-vpnc/network-manager-vpnc.scm


Cheers,
ng0
 
> Please give it a spin!  It’s sad to see patches bitrot.
> 
> Cheers,
> Ludo’.




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Sun, 15 Mar 2020 16:23:02 GMT) Full text and rfc822 format available.

Notification sent to ng0 <ng0 <at> infotropique.org>:
bug acknowledged by developer. (Sun, 15 Mar 2020 16:23:02 GMT) Full text and rfc822 format available.

Message #26 received at 29306-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 29306-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>,
 ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#29306] network-manager-vpnc
Date: Sun, 15 Mar 2020 12:22:41 -0400
Jelle Licht <jlicht <at> fsfe.org> writes:

> Heya folks,
>
> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Heya ng0,
>>
>> ng0 <ng0 <at> infotropique.org> skribis:
>>
>>> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
>>> From: ng0 <ng0 <at> infotropique.org>
>>> Date: Wed, 15 Nov 2017 10:40:46 +0000
>>> Subject: [PATCH] gnu: Add network-manager-vpnc.
>>>
>>> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
>
> Is this still being worked on/relevant? If so, I would like to verify
> that it does what we want it to do, and get it merged :-).

Closing, since you contributed a package for network-manager-vpnc back
in July of last year, with commit d376129f0b2 :-).

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 13 Apr 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 349 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.