GNU bug report logs - #29415
[PATCH] gnu: python-axolotl: Update to 0.1.39 and fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29415 in the body.
You can then email your comments to 29415 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix build.
Date: Thu, 23 Nov 2017 15:04:46 -0500

Patch taken from the debian package for python-axolotl-0.1.39.

python-axolotl has been failing since March,
https://hydra.gnu.org/job/gnu/master/python-axolotl-0.1.35.x86_64-linux

This also fixes the OMEMO and OTR plugins for Gajim work.

---
 ...olotl-removes-IV-parameter-at-AES-creation.patch | 21 +++++++++++++++++++++
 gnu/packages/python-crypto.scm                      |  6 ++++--
 2 files changed, 25 insertions(+), 2 deletions(-)
 create mode 100644 gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch

diff --git a/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
new file mode 100644
index 000000000..b25806ca2
--- /dev/null
+++ b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
@@ -0,0 +1,21 @@
+Description: Removes IV paramenter from AES constructor, since it is not necessary for ctr mode.
+Author: Josue Ortega <josue <at> debian.org>
+Last-Update: 2017-04-13
+
+--- a/axolotl/sessioncipher.py
++++ b/axolotl/sessioncipher.py
+@@ -228,13 +228,7 @@
+         # counterint = struct.unpack(">L", counterbytes)[0]
+         # counterint = int.from_bytes(counterbytes, byteorder='big')
+         ctr = Counter.new(128, initial_value=counter)
+-
+-        # cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
+-        ivBytes = bytearray(16)
+-        ByteUtil.intToByteArray(ivBytes, 0, counter)
+-
+-        cipher = AES.new(key, AES.MODE_CTR, IV=bytes(ivBytes), counter=ctr)
+-
++        cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
+         return cipher
+ 
+ 
diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index 77409d86d..3ffa477fe 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -430,7 +430,7 @@ python-axolotl.")
 (define-public python-axolotl
   (package
     (name "python-axolotl")
-    (version "0.1.35")
+    (version "0.1.39")
     (source
      (origin
        (method url-fetch)
@@ -438,8 +438,10 @@ python-axolotl.")
              "https://github.com/tgalal/python-axolotl/archive/"
              version ".tar.gz"))
        (file-name (string-append name "-" version ".tar.gz"))
+       (patches (search-patches
+                 "python-axolotl-removes-IV-parameter-at-AES-creation.patch"))
        (sha256
-        (base32 "1z8d89p7v40p4bwywjm9h4z28fdvra79ddw06azlkrfjbl7dxmz8"))))
+        (base32 "0badsgkgz0ir3hqynxzsfjgacppi874syvvmgccc6j164053x6zm"))))
     (build-system python-build-system)
     (arguments
      `(#:phases
-- 
2.15.0

Message #8 received at 29415 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 29415 <at> debbugs.gnu.org
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and
 fix build.
Date: Fri, 24 Nov 2017 19:09:52 -0500

[Message part 1 (text/plain, inline)]

On Thu, Nov 23, 2017 at 03:04:46PM -0500, Adam Van Ymeren wrote:

Hi,

> Patch taken from the debian package for python-axolotl-0.1.39.
> 
> python-axolotl has been failing since March,
> https://hydra.gnu.org/job/gnu/master/python-axolotl-0.1.35.x86_64-linux
> 
> This also fixes the OMEMO and OTR plugins for Gajim work.

Thanks for looking into this and sending the patch.

> diff --git a/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
> new file mode 100644
> index 000000000..b25806ca2
> --- /dev/null
> +++ b/gnu/packages/patches/python-axolotl-removes-IV-parameter-at-AES-creation.patch
> @@ -0,0 +1,21 @@
> +Description: Removes IV paramenter from AES constructor, since it is not necessary for ctr mode.
> +Author: Josue Ortega <josue <at> debian.org>
> +Last-Update: 2017-04-13
> +
> +--- a/axolotl/sessioncipher.py
> ++++ b/axolotl/sessioncipher.py
> +@@ -228,13 +228,7 @@
> +         # counterint = struct.unpack(">L", counterbytes)[0]
> +         # counterint = int.from_bytes(counterbytes, byteorder='big')
> +         ctr = Counter.new(128, initial_value=counter)
> +-
> +-        # cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
> +-        ivBytes = bytearray(16)
> +-        ByteUtil.intToByteArray(ivBytes, 0, counter)
> +-
> +-        cipher = AES.new(key, AES.MODE_CTR, IV=bytes(ivBytes), counter=ctr)
> +-
> ++        cipher = AES.new(key, AES.MODE_CTR, counter=ctr)
> +         return cipher

I think this change should be submitted upstream, which is here:

https://github.com/tgalal/python-axolotl

Can you do that? We wouldn't have to wait for a new release of
python-axolotl, but we should wait to hear what the upstream maintainer
thinks.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 29415 <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: Leo Famulari <leo <at> famulari.name>
Cc: 29415 <at> debbugs.gnu.org
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix
 build.
Date: Mon, 27 Nov 2017 10:00:01 -0500

Leo Famulari <leo <at> famulari.name> writes:
> I think this change should be submitted upstream, which is here:
>
> https://github.com/tgalal/python-axolotl
>
> Can you do that? We wouldn't have to wait for a new release of
> python-axolotl, but we should wait to hear what the upstream maintainer
> thinks.

Pull request sent.

There is also a pull request pending from someone else that updates
pyton-axolotl to use a newer python cryptography library rather than the
deprecated python-pycrypto library.  That would also fix this issue and
is a much better long term fix but also a more intrusive change.

Message #14 received at 29415 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 29415 <at> debbugs.gnu.org
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and
 fix build.
Date: Mon, 27 Nov 2017 13:09:59 -0500

[Message part 1 (text/plain, inline)]

On Mon, Nov 27, 2017 at 10:00:01AM -0500, Adam Van Ymeren wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> There is also a pull request pending from someone else that updates
> pyton-axolotl to use a newer python cryptography library rather than the
> deprecated python-pycrypto library.  That would also fix this issue and
> is a much better long term fix but also a more intrusive change.

I noticed that as well. Pycrypto is no longer maintained and has an
extremely serious bug that was never fixed in a released version:

https://github.com/dlitz/pycrypto/issues/176

And the author seems to implicitly agree that people should stop using
it:

https://github.com/dlitz/pycrypto/issues/173

So I added a TODO comment to the package, saying that we should remove
it:

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/python-crypto.scm?id=12a130b0118c3f56e6337e011dc4a89f2671359a#n186

So, I recommend being careful how you use any package that depends on
pycrypto.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 29415 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 29415 <at> debbugs.gnu.org
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and
 fix build.
Date: Mon, 27 Nov 2017 13:10:24 -0500

[Message part 1 (text/plain, inline)]

On Mon, Nov 27, 2017 at 10:00:01AM -0500, Adam Van Ymeren wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> > I think this change should be submitted upstream, which is here:
> >
> > https://github.com/tgalal/python-axolotl
> >
> > Can you do that? We wouldn't have to wait for a new release of
> > python-axolotl, but we should wait to hear what the upstream maintainer
> > thinks.
> 
> Pull request sent.

Great, please ping us when they respond or if they never do :)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 29415 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 29415 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix
 build.
Date: Tue, 30 Jan 2018 22:16:39 +0100

Hi Adam,

Adam Van Ymeren <adam <at> vany.ca> skribis:

> Leo Famulari <leo <at> famulari.name> writes:
>> I think this change should be submitted upstream, which is here:
>>
>> https://github.com/tgalal/python-axolotl
>>
>> Can you do that? We wouldn't have to wait for a new release of
>> python-axolotl, but we should wait to hear what the upstream maintainer
>> thinks.
>
> Pull request sent.
>
> There is also a pull request pending from someone else that updates
> pyton-axolotl to use a newer python cryptography library rather than the
> deprecated python-pycrypto library.  That would also fix this issue and
> is a much better long term fix but also a more intrusive change.

Any update on this?  :-)

Thanks in advance,
Ludo’.

Message #23 received at 29415 <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29415 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix
 build.
Date: Wed, 31 Jan 2018 09:38:14 -0500

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Adam,
>
> Adam Van Ymeren <adam <at> vany.ca> skribis:
>
>> Leo Famulari <leo <at> famulari.name> writes:
>>> I think this change should be submitted upstream, which is here:
>>>
>>> https://github.com/tgalal/python-axolotl
>>>
>>> Can you do that? We wouldn't have to wait for a new release of
>>> python-axolotl, but we should wait to hear what the upstream maintainer
>>> thinks.
>>
>> Pull request sent.
>>
>> There is also a pull request pending from someone else that updates
>> pyton-axolotl to use a newer python cryptography library rather than the
>> deprecated python-pycrypto library.  That would also fix this issue and
>> is a much better long term fix but also a more intrusive change.
>
> Any update on this?  :-)

Haven't heard anything from the maintainer :/.

We could just go ahead and apply my patch anways :).  Or remove the
package from guix entirely.  As it stands the package has been broken
for over a year in guix.

https://hydra.gnu.org/job/gnu/master/python-axolotl-0.1.35.x86_64-linux

>
> Thanks in advance,
> Ludo’.

Message #28 received at 29415-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 29415-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29415] [PATCH] gnu: python-axolotl: Update to 0.1.39 and fix
 build.
Date: Wed, 31 Jan 2018 17:37:49 +0100

Hi Adam,

Adam Van Ymeren <adam <at> vany.ca> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>> Any update on this?  :-)
>
> Haven't heard anything from the maintainer :/.
>
> We could just go ahead and apply my patch anways :).  Or remove the
> package from guix entirely.  As it stands the package has been broken
> for over a year in guix.
>
> https://hydra.gnu.org/job/gnu/master/python-axolotl-0.1.35.x86_64-linux

Indeed.  I adjusted the patch and commit log and pushed it as commit
51f887f33d08a805fa62c726c81904ce54a540ac.

Sorry for taking so long!

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.