GNU bug report logs - #29478
26.0.90; `C-h k' followed by mouse clicks no longer shows down event

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Drew Adams <drew.adams@HIDDEN>; Keywords: confirmed; dated Mon, 27 Nov 2017 23:23:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 29478 <at> debbugs.gnu.org:


Received: (at 29478) by debbugs.gnu.org; 28 Nov 2017 17:11:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 28 12:11:59 2017
Received: from localhost ([127.0.0.1]:34924 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eJjQM-0001tL-OO
	for submit <at> debbugs.gnu.org; Tue, 28 Nov 2017 12:11:59 -0500
Received: from eggs.gnu.org ([208.118.235.92]:47159)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1eJjQI-0001t5-Km
 for 29478 <at> debbugs.gnu.org; Tue, 28 Nov 2017 12:11:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1eJjQA-0004Ro-Cx
 for 29478 <at> debbugs.gnu.org; Tue, 28 Nov 2017 12:11:49 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48962)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1eJjQA-0004Rk-9d; Tue, 28 Nov 2017 12:11:46 -0500
Received: from [176.228.60.248] (port=3172 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1eJjQ9-00063m-NH; Tue, 28 Nov 2017 12:11:46 -0500
Date: Tue, 28 Nov 2017 19:11:38 +0200
Message-Id: <83zi7649bp.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Noam Postavsky <npostavs@HIDDEN>
In-reply-to: <871skjnpd8.fsf@HIDDEN> (message from Noam
 Postavsky on Mon, 27 Nov 2017 20:50:11 -0500)
Subject: Re: bug#29478: 26.0.90;
 `C-h k' followed by mouse clicks no longer shows down event
References: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default>
 <871skjnpd8.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 29478
Cc: acm@HIDDEN, 29478 <at> debbugs.gnu.org, drew.adams@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Noam Postavsky <npostavs@HIDDEN>
> Date: Mon, 27 Nov 2017 20:50:11 -0500
> Cc: Alan Mackenzie <acm@HIDDEN>, 29478 <at> debbugs.gnu.org
> 
> Drew Adams <drew.adams@HIDDEN> writes:
> 
> > The down mouse-button event is no longer listed along with the up
> > event when you use `C-h k' with a click event.  Dunno whether this was
> > by design or is an oversight.
> 
> Looks like oversight.  Possibly related to Bug#29272.  The following
> seems to fix it for me, but I'm having trouble convincing myself that
> it's the right thing.
> 
> --- c/lisp/help.el
> +++ i/lisp/help.el
> @@ -738,7 +738,7 @@ help-read-key-sequence
>                           ;; spuriously trigger the `sit-for'.
>                           (sleep-for 0.01)
>                           (while (read-event nil nil 0.01))
> -                         (not (sit-for (/ double-click-time 1000.0) t))))))))
> +                         (sit-for (/ double-click-time 1000.0) t)))))))
>            (list
>             key
>             ;; If KEY is a down-event, read and include the
> 

Not an oversight: the above patch brings back bug#29272.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#29478; Package emacs. Full text available.
Added tag(s) confirmed. Request was from Noam Postavsky <npostavs@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 29478 <at> debbugs.gnu.org:


Received: (at 29478) by debbugs.gnu.org; 28 Nov 2017 01:50:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 27 20:50:21 2017
Received: from localhost ([127.0.0.1]:33254 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eJV2T-0007bb-9s
	for submit <at> debbugs.gnu.org; Mon, 27 Nov 2017 20:50:21 -0500
Received: from mail-io0-f170.google.com ([209.85.223.170]:34915)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>)
 id 1eJV2R-0007bI-Eq; Mon, 27 Nov 2017 20:50:19 -0500
Received: by mail-io0-f170.google.com with SMTP id i38so38581580iod.2;
 Mon, 27 Nov 2017 17:50:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=bRdloU3VHU+EdqWboL6r8SU91oEHNAFCUUueyfVu3kY=;
 b=PvkZrGK34Z/nYhgXVOUz6Vkwtp8uSwZydaMycytkFtMv8Vp1Os59Km/Sn16nWvekrz
 +LaNdocxX7bqylbULSfhZMNae9VEBb2rtpIeFqK6+Jen4jdEPYJ5kxY/bFPXTVg2BQtN
 6s3PYYxeUelUstM5kBZpE7rP51jlysfRZSb+5eGNq9y8YqIL1XElJEXjkCp1dPFFz1Iq
 CUNG4kwTSGY4esye4zmeNtYKHnkGayt/s9kvCSweyfWlM0ClTXxeMk5I0dZDLThphkSE
 Lc6WMtTgaNSt1VA2ACo8k58i2DPpmbA5U0xB2MlZIiIoxOxTbbJKKZQTKyIXqlmzXUfb
 kl/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:references:date
 :in-reply-to:message-id:user-agent:mime-version;
 bh=bRdloU3VHU+EdqWboL6r8SU91oEHNAFCUUueyfVu3kY=;
 b=ppgX9WAfgX3GcKMVomuDZaL4OXOSeuz4tmNZhmevrQVdtyB/gSLQpDS0oTdKoqCEfz
 wIYKSCPfXuKXG/3F5PKxkU6lrvKDJ+w5OZtJUDk0FZFO+alBdjewfIvc5OSN5eQhRKGi
 awuW/u0SyBBxdVQFz7WcTvYrvxw2X4FYfwaOljqAPuyx5Y2MjcYkUk+xu88mSlIom75E
 EGG1z2vucvTQZvX7D4RnTmrjYd/cL4/lfvRK5F3azW+0UV5OvwvivqivK1EEUZdimXmx
 Fr8xhBix8f7BN0LoLuF/YQ2QbQ6574SoK+zV/Viau0ocRSqNiq4orESNWTstDImm2gJN
 CiRg==
X-Gm-Message-State: AJaThX7MzGn533JsxX0L/XykkxF48chgrPmNTVSde5+38H5cGLoE6t3E
 Pup/R/TXE7Yif4B3nQkHqEimUQ==
X-Google-Smtp-Source: AGs4zMaBmKzIytGWy+drnAH/iwF3AwYr2MSyBZ+Xutu/5goqdw/Zrr9ZmU694XOvbRJN0gXBBc1HsQ==
X-Received: by 10.107.184.212 with SMTP id i203mr9876023iof.17.1511833813592; 
 Mon, 27 Nov 2017 17:50:13 -0800 (PST)
Received: from zebian ([45.2.119.34])
 by smtp.googlemail.com with ESMTPSA id w68sm11835010iow.18.2017.11.27.17.50.12
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 27 Nov 2017 17:50:12 -0800 (PST)
From: Noam Postavsky <npostavs@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#29478: 26.0.90;
 `C-h k' followed by mouse clicks no longer shows down event
References: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default>
Date: Mon, 27 Nov 2017 20:50:11 -0500
In-Reply-To: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default> (Drew Adams's
 message of "Mon, 27 Nov 2017 15:21:43 -0800 (PST)")
Message-ID: <871skjnpd8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 29478
Cc: Alan Mackenzie <acm@HIDDEN>, 29478 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.1 (/)

tags 29272 + confirmed
quit

Drew Adams <drew.adams@HIDDEN> writes:

> The down mouse-button event is no longer listed along with the up
> event when you use `C-h k' with a click event.  Dunno whether this was
> by design or is an oversight.

Looks like oversight.  Possibly related to Bug#29272.  The following
seems to fix it for me, but I'm having trouble convincing myself that
it's the right thing.

--- c/lisp/help.el
+++ i/lisp/help.el
@@ -738,7 +738,7 @@ help-read-key-sequence
                          ;; spuriously trigger the `sit-for'.
                          (sleep-for 0.01)
                          (while (read-event nil nil 0.01))
-                         (not (sit-for (/ double-click-time 1000.0) t))))))))
+                         (sit-for (/ double-click-time 1000.0) t)))))))
           (list
            key
            ;; If KEY is a down-event, read and include the


Alan, I believe you've been working on this code recently, any thoughts?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#29478; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Nov 2017 23:22:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 27 18:22:03 2017
Received: from localhost ([127.0.0.1]:33199 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eJSix-00044L-25
	for submit <at> debbugs.gnu.org; Mon, 27 Nov 2017 18:22:03 -0500
Received: from eggs.gnu.org ([208.118.235.92]:52460)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1eJSiv-00043r-Eg
 for submit <at> debbugs.gnu.org; Mon, 27 Nov 2017 18:22:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1eJSip-0005ZG-Du
 for submit <at> debbugs.gnu.org; Mon, 27 Nov 2017 18:21:56 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:56982)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <drew.adams@HIDDEN>)
 id 1eJSip-0005ZC-Af
 for submit <at> debbugs.gnu.org; Mon, 27 Nov 2017 18:21:55 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43418)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1eJSio-0007NO-8x
 for bug-gnu-emacs@HIDDEN; Mon, 27 Nov 2017 18:21:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1eJSij-0005X3-As
 for bug-gnu-emacs@HIDDEN; Mon, 27 Nov 2017 18:21:54 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:50132)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <drew.adams@HIDDEN>)
 id 1eJSij-0005WW-44
 for bug-gnu-emacs@HIDDEN; Mon, 27 Nov 2017 18:21:49 -0500
Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])
 by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 vARNLjR8022077
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
 for <bug-gnu-emacs@HIDDEN>; Mon, 27 Nov 2017 23:21:47 GMT
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])
 by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vARNLiIR026718
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
 for <bug-gnu-emacs@HIDDEN>; Mon, 27 Nov 2017 23:21:45 GMT
Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])
 by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vARNLi0B028474
 for <bug-gnu-emacs@HIDDEN>; Mon, 27 Nov 2017 23:21:44 GMT
MIME-Version: 1.0
Message-ID: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default>
Date: Mon, 27 Nov 2017 15:21:43 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1  (1003210) [OL
 16.0.4615.0 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

The down mouse-button event is no longer listed along with the up
event when you use `C-h k' with a click event.  Dunno whether this was
by design or is an oversight.

Seems to me like it was better before.  When you click a mouse button
sometimes the action you're interested in is actually bound to the down
event, not the up event.  And sometimes you're interested in
descriptions of both events.

And how else can you get to see the help for the command bound to the
down-button event?  I don't see how to do that now.

Also, I don't see anything in NEWS about this.  I do see this, however,
for `describe-key-briefly' (which is not what `C-h k' does) - perhaps it
is related to this undocumented change?

** 'describe-key-briefly' now ignores mouse movement events.


In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
 of 2017-10-13 built on LAPHROAIG
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window.




Acknowledgement sent to Drew Adams <drew.adams@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#29478; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 28 Nov 2017 17:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.