GNU bug report logs - #29585
26.0.90; Elint gives spurious warning with condition-case-unless-debug

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29585 in the body.
You can then email your comments to 29585 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <johnw <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; Elint gives spurious warning with condition-case-unless-debug
Date: Tue, 05 Dec 2017 14:26:08 -0800

Wherever condition-case-unless-debug is used, elint will complain with:

use-package-core.el:1292:Warning: Not an error symbol in error handler: debug

This is due to the definition of condition-case-unless-debug:

--8<---------------cut here---------------start------------->8---
(defmacro condition-case-unless-debug (var bodyform &rest handlers)
  "Like `condition-case' except that it does not prevent debugging.
More specifically if `debug-on-error' is set then the debugger will be invoked
even if this catches the signal."
  (declare (debug condition-case) (indent 2))
  `(condition-case ,var
       ,bodyform
     ,@(mapcar (lambda (handler)
                 `((debug ,@(if (listp (car handler)) (car handler)
                              (list (car handler))))
                   ,@(cdr handler)))
               handlers)))
--8<---------------cut here---------------end--------------->8---

Maybe elint needs to be taught about this case?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Message #8 received at 29585 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 29585 <at> debbugs.gnu.org
Subject: Re: bug#29585: 26.0.90; Elint gives spurious warning with
 condition-case-unless-debug
Date: Sun, 14 Jul 2019 20:24:57 +0200

"John Wiegley" <johnw <at> gnu.org> writes:

> Wherever condition-case-unless-debug is used, elint will complain with:
>
> use-package-core.el:1292:Warning: Not an error symbol in error handler: debug
>
> This is due to the definition of condition-case-unless-debug:

I've now added the macro to the elint definitions.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.