GNU logs - #29669, boring messages

Message sent to bug-guile@HIDDEN:

Subject: bug#29669: repl-print - requet for iprovement
Resent-From: David Pirotte <david@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Mon, 11 Dec 2017 23:37:02 +0000
Resent-Message-ID: <handler.29669.B.15130354137482 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 29669 <at> debbugs.gnu.org
Date: Mon, 11 Dec 2017 21:36:15 -0200
From: David Pirotte <david@HIDDEN>
Message-ID: <20171211213615.7bca6fc8@capac>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/=0aYe51spe+FEu_=iimBBBM"; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--Sig_/=0aYe51spe+FEu_=iimBBBM
Content-Type: multipart/mixed; boundary="MP_/3_CeIukwMjOqsIcI//WtyiF"

--MP_/3_CeIukwMjOqsIcI//WtyiF
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hello,

Attached a patch so repl-print becomes 'friendly' wrt large (huge) lists,
arrays, srfi-4 bytevectors ...

	I looked at the documentation but I could not spot anything/places where
	things would need to be changed wrt the above patch?

	Dito wrt tests?

Thanks,
David

--MP_/3_CeIukwMjOqsIcI//WtyiF
Content-Type: text/x-patch
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename=0001-Updating-repl-print-to-use-truncated-print.patch

=46rom d920d22efe3e77d23004122e21cec420c402f531 Mon Sep 17 00:00:00 2001
From: David Pirotte <david@HIDDEN>
Date: Mon, 11 Dec 2017 21:28:24 -0200
Subject: [PATCH] Updating repl-print to use truncated-print

* module/system/repl/common.scm (repl-print): Use (truncated-print val),
  not (write val).  With this update, repl-print becomes 'friendly' wrt
  large (huge) lists, arrays, srfi-4 butevoectors ...
---
 module/system/repl/common.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/module/system/repl/common.scm b/module/system/repl/common.scm
index 42d5c24ae..47799957d 100644
--- a/module/system/repl/common.scm
+++ b/module/system/repl/common.scm
@@ -1,6 +1,6 @@
 ;;; Repl common routines
=20
-;; Copyright (C) 2001, 2008-2016  Free Software Foundation, Inc.
+;; Copyright (C) 2001, 2008-2017  Free Software Foundation, Inc.
=20
 ;;; This library is free software; you can redistribute it and/or
 ;;; modify it under the terms of the GNU Lesser General Public
@@ -28,6 +28,7 @@
   #:autoload (language tree-il optimize) (optimize)
   #:use-module (ice-9 control)
   #:use-module (ice-9 history)
+  #:use-module (ice-9 pretty-print)
   #:export (<repl> make-repl repl-language repl-options
             repl-tm-stats repl-gc-stats repl-debug
             repl-welcome repl-prompt
@@ -223,7 +224,7 @@ See <http://www.gnu.org/licenses/lgpl.html>, for more d=
etails.")
           ;; should be printed with the generic printer, `write'. The
           ;; language-printer is something else: it prints expressions of
           ;; a given language, not the result of evaluation.
-          (write val)
+          (truncated-print val)
           (newline))))))
=20
 (define (repl-option-ref repl key)
--=20
2.15.1


--MP_/3_CeIukwMjOqsIcI//WtyiF--

--Sig_/=0aYe51spe+FEu_=iimBBBM
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEhCJlRZtBM3furJHe83T9k6MFetcFAlovFm8ACgkQ83T9k6MF
etf9BQgA21hwx0jQLQgsepGPFXk8I0st3d0KQ58I3qf3UeBm2tASoWCXIjre+/y2
ims7yMoQQN+zrKq/hV0WrSIiV/tiQfOicvgYzd81MPe2/priiFWFrYS6+2JpfVrs
CMZCCT7rdBMTyDZIzh6HRWUICkGgHLz7HG0BzQDHweMP6ZvFGFdWcEU7S1DJAkel
esDptu1vfWQHs/mXvxQYxn/MFLXSWs5uw+gaSV02SQgl/o9/YfDk67aVNG34ejI7
Q2ourKhq8Oki4QBJHix97/rZPQNMthdc88WtHP/apjs96tbeBZWWFy9gWTjCptZ5
MyQ8zOdYRzHvuZ7KH8x+bFvKTkyGUw==
=xcgm
-----END PGP SIGNATURE-----

--Sig_/=0aYe51spe+FEu_=iimBBBM--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: David Pirotte <david@HIDDEN>
Subject: bug#29669: Acknowledgement (repl-print - requet for iprovement)
Message-ID: <handler.29669.B.15130354137482.ack <at> debbugs.gnu.org>
References: <20171211213615.7bca6fc8@capac>
X-Gnu-PR-Message: ack 29669
X-Gnu-PR-Package: guile
Reply-To: 29669 <at> debbugs.gnu.org
Date: Mon, 11 Dec 2017 23:37:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guile@HIDDEN

If you wish to submit further information on this problem, please
send it to 29669 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
29669: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29669
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guile@HIDDEN:

Subject: bug#29669: repl-print - requet for iprovement
Resent-From: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sun, 01 Jul 2018 16:28:02 +0000
Resent-Message-ID: <handler.29669.B29669.153046245931347 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: David Pirotte <david@HIDDEN>
Cc: Andy Wingo <wingo@HIDDEN>, Mark H Weaver <mhw@HIDDEN>, 29669 <at> debbugs.gnu.org
From: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171211213615.7bca6fc8@capac>
Date: Sun, 01 Jul 2018 18:26:37 +0200
In-Reply-To: <20171211213615.7bca6fc8@capac> (David Pirotte's message of "Mon, 
 11 Dec 2017 21:36:15 -0200")
Message-ID: <87r2kmrkg2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

David Pirotte <david@HIDDEN> skribis:

> From d920d22efe3e77d23004122e21cec420c402f531 Mon Sep 17 00:00:00 2001
> From: David Pirotte <david@HIDDEN>
> Date: Mon, 11 Dec 2017 21:28:24 -0200
> Subject: [PATCH] Updating repl-print to use truncated-print
>
> * module/system/repl/common.scm (repl-print): Use (truncated-print val),
>   not (write val).  With this update, repl-print becomes 'friendly' wrt
>   large (huge) lists, arrays, srfi-4 butevoectors ...

Note that it=E2=80=99s already possible to do this:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use (ice-9 pretty-print)
scheme@(guile-user)> ,o print (lambda (repl obj) (truncated-print obj) (new=
line))
scheme@(guile-user)> (iota 500)
$20 =3D (0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2=
5 26 27 # =E2=80=A6)
--8<---------------cut here---------------end--------------->8---

So the question becomes: should we change the default?

I have a slight preference for keeping the default as it is to avoid
surprises, but no strong opinion.

Andy, Mark, others, WDYT?

Ludo=E2=80=99.

Message sent to bug-guile@HIDDEN:

Subject: bug#29669: repl-print - requet for iprovement
Resent-From: Andy Wingo <wingo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Thu, 05 Jul 2018 07:50:01 +0000
Resent-Message-ID: <handler.29669.B29669.153077696031660 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Cc: Mark H Weaver <mhw@HIDDEN>, 29669 <at> debbugs.gnu.org, David Pirotte <david@HIDDEN>
From: Andy Wingo <wingo@HIDDEN>
References: <20171211213615.7bca6fc8@capac> <87r2kmrkg2.fsf@HIDDEN>
Date: Thu, 05 Jul 2018 09:49:04 +0200
In-Reply-To: <87r2kmrkg2.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 01 Jul 2018 18:26:37 +0200")
Message-ID: <87po02jf67.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sun 01 Jul 2018 18:26, ludo@HIDDEN (Ludovic Court=C3=A8s) writes:

> Hello,
>
> David Pirotte <david@HIDDEN> skribis:
>
>> From d920d22efe3e77d23004122e21cec420c402f531 Mon Sep 17 00:00:00 2001
>> From: David Pirotte <david@HIDDEN>
>> Date: Mon, 11 Dec 2017 21:28:24 -0200
>> Subject: [PATCH] Updating repl-print to use truncated-print
>>
>> * module/system/repl/common.scm (repl-print): Use (truncated-print val),
>>   not (write val).  With this update, repl-print becomes 'friendly' wrt
>>   large (huge) lists, arrays, srfi-4 butevoectors ...
>
> Note that it=E2=80=99s already possible to do this:
>
> scheme@(guile-user)> ,use (ice-9 pretty-print)
> scheme@(guile-user)> ,o print (lambda (repl obj) (truncated-print obj) (n=
ewline))
> scheme@(guile-user)> (iota 500)
> $20 =3D (0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24=
 25 26 27 # =E2=80=A6)
>
> So the question becomes: should we change the default?
>
> I have a slight preference for keeping the default as it is to avoid
> surprises, but no strong opinion.
>
> Andy, Mark, others, WDYT?

Hoo, I don't know.  If we were to do this it should be controllable by
REPL options, I think; we'd need the ability to go back and forth.  But
if we have the option I think it could make sense for it to be on by
default, like what GDB does.  Thing is, truncated-print does its job
only OK, not great, so it's a hard sell to standardize on it.  You
probably do want multi-line prints sometimes...

Andy

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#29669: repl-print - requet for iprovement
Resent-From: David Pirotte <david@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sat, 04 Aug 2018 02:38:02 +0000
Resent-Message-ID: <handler.29669.B29669.153335023419990 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 29669
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: Andy Wingo <wingo@HIDDEN>
Cc: Mark H Weaver <mhw@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 29669 <at> debbugs.gnu.org
Received: via spool by 29669-submit <at> debbugs.gnu.org id=B29669.153335023419990
          (code B ref 29669); Sat, 04 Aug 2018 02:38:02 +0000
Received: (at 29669) by debbugs.gnu.org; 4 Aug 2018 02:37:14 +0000
Received: from localhost ([127.0.0.1]:40343 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1flmRO-0005CM-0j
	for submit <at> debbugs.gnu.org; Fri, 03 Aug 2018 22:37:14 -0400
Received: from maximusconfessor.all2all.org ([79.99.200.102]:40526)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <david@HIDDEN>) id 1flmRK-0005CB-QR
 for 29669 <at> debbugs.gnu.org; Fri, 03 Aug 2018 22:37:12 -0400
Received: from localhost (localhost [127.0.0.1])
 by maximusconfessor.all2all.org (Postfix) with ESMTP id 552171BE00E8;
 Sat,  4 Aug 2018 04:37:10 +0200 (CEST)
Received: from maximusconfessor.all2all.org ([127.0.0.1])
 by localhost (maximusconfessor.all2all.org [127.0.0.1]) (amavisd-new,
 port 10024)
 with ESMTP id MNqDvQsoMMWv; Sat,  4 Aug 2018 04:37:10 +0200 (CEST)
Received: from capac (unknown [189.122.100.197])
 by maximusconfessor.all2all.org (Postfix) with ESMTPSA id 0E1181BE00E5;
 Sat,  4 Aug 2018 04:37:08 +0200 (CEST)
Date: Fri, 3 Aug 2018 23:37:03 -0300
From: David Pirotte <david@HIDDEN>
Message-ID: <20180803233703.6bdc69e3@capac>
In-Reply-To: <87po02jf67.fsf@HIDDEN>
References: <20171211213615.7bca6fc8@capac> <87r2kmrkg2.fsf@HIDDEN>
 <87po02jf67.fsf@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/hr2RLn.d69/Z/iMtGa0J/Ww"; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--Sig_/hr2RLn.d69/Z/iMtGa0J/Ww
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Ludo,
Andy,

> > scheme@(guile-user)> ,use (ice-9 pretty-print)
> > scheme@(guile-user)> ,o print (lambda (repl obj) (truncated-print obj) =
(newline))
> > scheme@(guile-user)> (iota 500)
> > $20 =3D (0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 =
24 25 26 27
> > # =E2=80=A6)
> >
> > So the question becomes: should we change the default?

Why not? then who would want multi-line prints would do the 'oppoite' of th=
e above,
right?

	scheme@(guile-user)> ,use (ice-9 pretty-print)
	scheme@(guile-user)> ,o print (lambda (repl obj) (write obj) (newline))

Or, as I do in Guile-CV, implement a specific display method for 'their
objects' (im-display in guile-cv, and the manual says 'to be used with caut=
ion...)

> > I have a slight preference for keeping the default as it is to avoid
> > surprises, but no strong opinion.

What surprise(s)? :),
I mean, what sort of code or who's the one of us who would rely on the repl=
 print
'layout' in any sort of way(s)?

> > Andy, Mark, others, WDYT? =20

> Hoo, I don't know.  If we were to do this it should be controllable by
> REPL options, I think; we'd need the ability to go back and forth.  But
> if we have the option I think it could make sense for it to be on by
> default, like what GDB does.=20

It seems to me it is a yes :)

	note that (just not to forgot), we need this to be done both for the repl
	_and_ exception printers as well ... it is as essential if not more then
	within the repl

> Thing is, truncated-print does its job  only OK, not great, so it's a har=
d sell to
> standardize on it.  You probably do want multi-line prints sometimes...

I'm actually using truncated-print all the time, since it is simply impossi=
ble
otherwise to use/develop guile-v, and I never spotted any 'problem' (not to=
 say I
can guarantee there is none of course, but that did not happen in years).  =
Then we
could always improve when someone report a problem ...

Thanks,
David

--Sig_/hr2RLn.d69/Z/iMtGa0J/Ww
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEhCJlRZtBM3furJHe83T9k6MFetcFAltlEU8ACgkQ83T9k6MF
eteBngf+Nk8dmmR/oXj3OO+8ubVHHc2oU2u2VONLofx4WrhbgdWNIZzOsEF/ZcvB
0PoOdmcFUk4JlWtUFMD09214SApYcfKVxMP5V7fuY1v/CSQwnYXlfYZCsCcDlvEU
ZjV5qz3l9/C0PYOkCEHku/gKns5vfAIsPrMI76ok2NHQtI2N500QTkEqVJ4tj18P
8T6E9+VcQlDfBsIIAfMS4ROKK6mRlwXYndbrv9UFNskfL/lPdyB6vv5zeE3MWlSv
gb31xxcNca/VEcooiP0mx3w0xqkchP/8Dr2476yFYPCb+oXBxAYMCg8FxMsWKry5
kVMfx0JPoPaM9DXjBUWUqrF70C53Fw==
=vynO
-----END PGP SIGNATURE-----

--Sig_/hr2RLn.d69/Z/iMtGa0J/Ww--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.