GNU bug report logs - #29738
Add support for HTTP/2 to curl

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29738 in the body.
You can then email your comments to 29738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: guix-patches <at> gnu.org
Subject: Add support for HTTP/2 to curl
Date: Sat, 16 Dec 2017 19:12:12 +0100

Hi,
this patch adds HTTP/2 support to curl, this is a prerequisite to
closing bug#29733. I am aware that this will trigger about 2500 rebuilt
packages, but having HTTP/2 in curl seems to be worth the hassle.

Cheers, Mark

-- 
  Mark Meyer
  mark <at> ofosos.org

Message #8 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: 29738 <at> debbugs.gnu.org
Subject: Patch was missing
Date: Sat, 16 Dec 2017 19:14:02 +0100

[Message part 1 (text/plain, inline)]

The patch is attached to this message.

Cheers, Mark

-- 
  Mark Meyer
  mark <at> ofosos.org

[0001-gnu-Add-http2-support-to-curl.patch (text/x-patch, attachment)]

Message #11 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mark Meyer <mark <at> ofosos.org>
Cc: 29738 <at> debbugs.gnu.org
Subject: Re: [bug#29738] Add support for HTTP/2 to curl
Date: Sun, 17 Dec 2017 07:31:52 +0100

Hi Mark,

> this patch adds HTTP/2 support to curl, this is a prerequisite to
> closing bug#29733. I am aware that this will trigger about 2500 rebuilt
> packages, but having HTTP/2 in curl seems to be worth the hassle.

We would make this change on the core-updates branch to avoid disrupting
the availability of substitutes, so rebuilding a large number of
packages is not a big problem.  Does this patch apply on top of
core-updates?

About the patch: it would be better to separate the two changes.  One
commit would add the nghttp2 package, the other would modify the curl
package.  Could you please split the patch?

Since curl is used by a great number of packages we need to pay
attention to the size of the closure.  How does adding nghttp2 to curl
affect the size of the closure of the curl package?  (You can check with
“guix size”.)

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #14 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 29738 <at> debbugs.gnu.org
Subject: Re: [bug#29738] Add support for HTTP/2 to curl
Date: Sun, 17 Dec 2017 09:35:18 +0100

[Message part 1 (text/plain, inline)]

Hi Ricardo,
thanks for you feedback. The closure changes from 223.7 MiB to 224.5
MiB.

The patches attached apply cleanly to core-updates and split the change
into two components.

Cheers, Mark

On Sun, Dec 17, 2017, at 07:31, Ricardo Wurmus wrote:
> 
> Hi Mark,
> 
> > this patch adds HTTP/2 support to curl, this is a prerequisite to
> > closing bug#29733. I am aware that this will trigger about 2500 rebuilt
> > packages, but having HTTP/2 in curl seems to be worth the hassle.
> 
> We would make this change on the core-updates branch to avoid disrupting
> the availability of substitutes, so rebuilding a large number of
> packages is not a big problem.  Does this patch apply on top of
> core-updates?
> 
> About the patch: it would be better to separate the two changes.  One
> commit would add the nghttp2 package, the other would modify the curl
> package.  Could you please split the patch?
> 
> Since curl is used by a great number of packages we need to pay
> attention to the size of the closure.  How does adding nghttp2 to curl
> affect the size of the closure of the curl package?  (You can check with
> “guix size”.)
> 
> --
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 
> 


-- 
  Mark Meyer
  mark <at> ofosos.org

[0001-gnu-Add-nghttp2-support.patch (text/x-patch, attachment)]

[0002-gnu-Add-http2-support-to-curl.patch (text/x-patch, attachment)]

Message #17 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: 29738 <at> debbugs.gnu.org
Subject: Next core-updates cycle
Date: Thu, 04 Jan 2018 18:29:58 +0100

Hi,
will this patch make it into the next core-updates cycle?

Cheers, Mark

-- 
  Mark Meyer
  mark <at> ofosos.org

Message #20 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mark Meyer <mark <at> ofosos.org>
Cc: 29738 <at> debbugs.gnu.org
Subject: Re: [bug#29738] Next core-updates cycle
Date: Thu, 4 Jan 2018 12:53:33 -0500

[Message part 1 (text/plain, inline)]

On Thu, Jan 04, 2018 at 06:29:58PM +0100, Mark Meyer wrote:
> Hi,
> will this patch make it into the next core-updates cycle?

I saved them on my local core-updates-next staging branch, along with
some other changes for the next round.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: leo <at> famulari.name, mark <at> ofosos.org
Cc: 29738 <at> debbugs.gnu.org
Subject: Re: [bug#29738] Next core-updates cycle
Date: Fri, 5 Jan 2018 01:54:02 +0100

[Message part 1 (text/plain, inline)]

Mark, Leo,

Leo Famulari wrote on 04/01/18 at 18:53:
> On Thu, Jan 04, 2018 at 06:29:58PM +0100, Mark Meyer wrote:
>> Hi,
>> will this patch make it into the next core-updates cycle?
> 
> I saved them on my local core-updates-next staging branch, along with
> some other changes for the next round.

So this week I decided to finally get my local h2 branch into shape (I'd
started it in November, but life gets in the way) and send it in. I'd
somehow missed Mark's original message in the meantime. I apologise;
duplicated work really sucks.

Now... I'm going to gingerly attach my version anyway, since it makes a
few different choices. And I spent too much time on that description,
damn it! :-)

Most importantly, this builds the entire nghttp2 package, not only the
core library required by curl. The tools that use it aren't just toys or
examples as in some other packages. I use them regularly.

By splitting it into multiple outputs, the closure size for curl with
HTTP/2 support only increases by .5 MiB (same as Mark's patch).

I put nghttp2 in web.scm, since it's not curl-related. In any case,
adding nghttp2 itself doesn't need to pass through core-updates first.

Also note that the licence is really l:expat, not l:non-copyleft.

Thanks for working on this, and sorry again for not noticing it sooner,

T G-R

[0001-gnu-Add-nghttp2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #26 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 29738 <at> debbugs.gnu.org
Subject: Re: [bug#29738] Next core-updates cycle
Date: Fri, 5 Jan 2018 02:59:16 +0100

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice wrote on 05/01/18 at 01:54:
> So this week I decided to finally get my local h2 branch into shape

Sigh. Now with the correct, up-to-date patch and gnurl support.

Kind regards,

T G-R

[0001-gnu-Add-nghttp2.patch (text/x-patch, attachment)]

[0002-gnu-gnurl-Add-HTTP-2-support.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #29 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 29738 <at> debbugs.gnu.org, mark <at> ofosos.org
Subject: Re: [bug#29738] Next core-updates cycle
Date: Sat, 6 Jan 2018 13:59:37 -0500

[Message part 1 (text/plain, inline)]

On Fri, Jan 05, 2018 at 01:54:02AM +0100, Tobias Geerinckx-Rice wrote:
> So this week I decided to finally get my local h2 branch into shape (I'd
> started it in November, but life gets in the way) and send it in. I'd
> somehow missed Mark's original message in the meantime. I apologise;
> duplicated work really sucks.

No worries!

> Now... I'm going to gingerly attach my version anyway, since it makes a
> few different choices. And I spent too much time on that description,
> damn it! :-)
> 
> Most importantly, this builds the entire nghttp2 package, not only the
> core library required by curl. The tools that use it aren't just toys or
> examples as in some other packages. I use them regularly.

Okay, this sounds like a more complete package.

Can you keep it yourself for the next core-updates cycle? And I'll
remove Mark's from my branch.

Mark, what do you think of Tobias's patch?

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: Leo Famulari <leo <at> famulari.name>, "Tobias Geerinckx-Rice" <me <at> tobias.gr>
Cc: 29738 <at> debbugs.gnu.org
Subject: Re: [bug#29738] Next core-updates cycle
Date: Sat, 06 Jan 2018 20:03:17 +0100

Looks good!

Thanks for the work.

Cheers, Mark

On Sat, Jan 6, 2018, at 19:59, Leo Famulari wrote:
> On Fri, Jan 05, 2018 at 01:54:02AM +0100, Tobias Geerinckx-Rice wrote:
> > So this week I decided to finally get my local h2 branch into shape (I'd
> > started it in November, but life gets in the way) and send it in. I'd
> > somehow missed Mark's original message in the meantime. I apologise;
> > duplicated work really sucks.
> 
> No worries!
> 
> > Now... I'm going to gingerly attach my version anyway, since it makes a
> > few different choices. And I spent too much time on that description,
> > damn it! :-)
> > 
> > Most importantly, this builds the entire nghttp2 package, not only the
> > core library required by curl. The tools that use it aren't just toys or
> > examples as in some other packages. I use them regularly.
> 
> Okay, this sounds like a more complete package.
> 
> Can you keep it yourself for the next core-updates cycle? And I'll
> remove Mark's from my branch.
> 
> Mark, what do you think of Tobias's patch?
> Email had 1 attachment:
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark <at> ofosos.org

Message #35 received at 29738 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: leo <at> famulari.name
Cc: 29738 <at> debbugs.gnu.org, mark <at> ofosos.org
Subject: Re: [bug#29738] Next core-updates cycle
Date: Sat, 6 Jan 2018 22:23:29 +0100

[Message part 1 (text/plain, inline)]

Mark, Leo,

Leo Famulari wrote on 06/01/18 at 19:59:
> On Fri, Jan 05, 2018 at 01:54:02AM +0100, Tobias Geerinckx-Rice wrote:
>> Most importantly, this builds the entire nghttp2 package, not only the
>> core library required by curl. The tools that use it aren't just toys or
>> examples as in some other packages. I use them regularly.
> 
> Okay, this sounds like a more complete package.
> 
> Can you keep it yourself for the next core-updates cycle? And I'll
> remove Mark's from my branch.

OK. I'll push nghttp2 and the gnurl patch to master in a few days, and
keep HTTP/2 curl in my core-updates-next. Thanks!

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Message #40 received at 29738-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 29738-done <at> debbugs.gnu.org
Subject: Re: Add support for HTTP/2 to curl
Date: Wed, 14 Mar 2018 18:17:40 +0100

Done: HTTP/2 support is enabled for curl in core-updates now that 
nghttp2 has landed there.

Kind regards,

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.