GNU bug report logs - #29819
gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

Previous Next

Package: guix-patches;

Reported by: Roel Janssen <roel <at> gnu.org>

Date: Fri, 22 Dec 2017 22:15:01 UTC

Severity: normal

Tags: patch

Done: Roel Janssen <roel <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29819 in the body.
You can then email your comments to 29819 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#29819; Package guix-patches. (Fri, 22 Dec 2017 22:15:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Roel Janssen <roel <at> gnu.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 22 Dec 2017 22:15:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.
Date: Fri, 22 Dec 2017 23:13:45 +0100
[Message part 1 (text/plain, inline)]
Dear Guix,

I'd like to squeeze the most performance out of virtuoso, as well as add
some of the VAD packages to extend its functionality.

I attached the patch, but I have a question about the -m64 flag.  My
impression is that this flag will force a 64-bit build.  Since only
64-bit architectures are supported for this package anyway, I think this
should be fine.  Now, my question is: Does this flag have any effect on
the build?

Thanks for your time!

Kind regards,
Roel Janssen

[0001-gnu-virtuoso-ose-Enable-fct-isparql-and-ods-plugins.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#29819; Package guix-patches. (Sat, 23 Dec 2017 21:31:02 GMT) Full text and rfc822 format available.

Message #8 received at 29819 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Roel Janssen <roel <at> gnu.org>
Cc: 29819 <at> debbugs.gnu.org
Subject: Re: [bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods
 plugins.
Date: Sat, 23 Dec 2017 22:30:18 +0100
In my limited understanding "-m64" and "-m32" are for multiarch gccs and we don't support that anyway in Guix gcc, so I don't think it does anything for us.




Information forwarded to guix-patches <at> gnu.org:
bug#29819; Package guix-patches. (Thu, 11 Jan 2018 09:45:01 GMT) Full text and rfc822 format available.

Message #11 received at 29819 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 29819 <at> debbugs.gnu.org, Roel Janssen <roel <at> gnu.org>
Subject: Re: [bug#29819] gnu: virtuoso-ose: Enable fct, isparql,
 and ods plugins.
Date: Thu, 11 Jan 2018 10:44:19 +0100
Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> In my limited understanding "-m64" and "-m32" are for multiarch gccs and we don't support that anyway in Guix gcc, so I don't think it does anything for us.

Indeed.  Using -m32 on x86_64-linux won't work with our toolchain.

Ludo’.




Added tag(s) patch. Request was from Christopher Baines <mail <at> cbaines.net> to control <at> debbugs.gnu.org. (Mon, 19 Mar 2018 08:02:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#29819; Package guix-patches. (Mon, 07 May 2018 09:57:01 GMT) Full text and rfc822 format available.

Message #16 received at 29819 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 29819 <at> debbugs.gnu.org
Subject: Re: [bug#29819] gnu: virtuoso-ose: Enable fct, isparql,
 and ods plugins.
Date: Mon, 07 May 2018 11:55:49 +0200
Hi Roel,

Roel Janssen <roel <at> gnu.org> skribis:

>>From ffab36dc96d7c17ab699b1e5fa641386ae87f681 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Fri, 22 Dec 2017 23:03:36 +0100
> Subject: [PATCH] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.
>
> * gnu/packages/databases.scm (virtuoso-ose): Enable fct, isparql, and ods
>   plugins.  Also compile with optimization level 2, and compile 64-bit only.
> ---
>  gnu/packages/databases.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index a6a7c3178..d802a35c7 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -1962,10 +1962,16 @@ implementation for Python.")
>          (base32 "12dqam1gc1v93l0bj0vlpvjqppki6y1hqrlznywxnw0rrz9pb002"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:tests? #f)) ; Tests require a network connection.
> +     `(#:tests? #f ; Tests require a network connection.
> +       #:configure-flags '("--with-readline"
> +                           "--enable-fct-vad"
> +                           "--enable-isparql-vad"
> +                           "--enable-ods-vad"
> +                           "CFLAGS=-O2 -m64")))
>      (inputs
>       `(("openssl" ,openssl)
> -       ("net-tools" ,net-tools)))
> +       ("net-tools" ,net-tools)
> +       ("readline" ,readline)))

This patch without the CFLAGS bit would be fine, if you still need it.

Thoughts?

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#29819; Package guix-patches. (Mon, 07 May 2018 12:45:02 GMT) Full text and rfc822 format available.

Message #19 received at 29819 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29819 <at> debbugs.gnu.org
Subject: Re: [bug#29819] gnu: virtuoso-ose: Enable fct, isparql,
 and ods plugins.
Date: Mon, 07 May 2018 14:44:29 +0200
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Roel,
>
> Roel Janssen <roel <at> gnu.org> skribis:
>
>>>From ffab36dc96d7c17ab699b1e5fa641386ae87f681 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Fri, 22 Dec 2017 23:03:36 +0100
>> Subject: [PATCH] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.
>>
>> * gnu/packages/databases.scm (virtuoso-ose): Enable fct, isparql, and ods
>>   plugins.  Also compile with optimization level 2, and compile 64-bit only.
>> ---
>>  gnu/packages/databases.scm | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index a6a7c3178..d802a35c7 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -1962,10 +1962,16 @@ implementation for Python.")
>>          (base32 "12dqam1gc1v93l0bj0vlpvjqppki6y1hqrlznywxnw0rrz9pb002"))))
>>      (build-system gnu-build-system)
>>      (arguments
>> -     `(#:tests? #f)) ; Tests require a network connection.
>> +     `(#:tests? #f ; Tests require a network connection.
>> +       #:configure-flags '("--with-readline"
>> +                           "--enable-fct-vad"
>> +                           "--enable-isparql-vad"
>> +                           "--enable-ods-vad"
>> +                           "CFLAGS=-O2 -m64")))
>>      (inputs
>>       `(("openssl" ,openssl)
>> -       ("net-tools" ,net-tools)))
>> +       ("net-tools" ,net-tools)
>> +       ("readline" ,readline)))
>
> This patch without the CFLAGS bit would be fine, if you still need it.
>
> Thoughts?

In commit 6d09a7b5e I added --with-readline.  I couldn't find the bug
report, but I believe the extra plugins (ODS and facetted browser
(FCT)) cannot be activated due to a bug in Virtuoso's plugin loading
function.  This bug has been resolved, but the fix isn't present in this
released version.

So I guess we can close this one and wait for the next release to
re-evaluate whether we can build these extra plugins.

WDYT?

Kind regards,
Roel Janssen





Information forwarded to guix-patches <at> gnu.org:
bug#29819; Package guix-patches. (Mon, 07 May 2018 16:07:02 GMT) Full text and rfc822 format available.

Message #22 received at 29819 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 29819 <at> debbugs.gnu.org
Subject: Re: [bug#29819] gnu: virtuoso-ose: Enable fct, isparql,
 and ods plugins.
Date: Mon, 07 May 2018 18:06:19 +0200
Roel Janssen <roel <at> gnu.org> skribis:

> So I guess we can close this one and wait for the next release to
> re-evaluate whether we can build these extra plugins.
>
> WDYT?

Sounds good.  I just wanted to make sure we weren’t forgetting about
it.  :-)

Ludo’.




Reply sent to Roel Janssen <roel <at> gnu.org>:
You have taken responsibility. (Thu, 10 May 2018 20:34:02 GMT) Full text and rfc822 format available.

Notification sent to Roel Janssen <roel <at> gnu.org>:
bug acknowledged by developer. (Thu, 10 May 2018 20:34:02 GMT) Full text and rfc822 format available.

Message #27 received at 29819-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29819-done <at> debbugs.gnu.org
Subject: Re: [bug#29819] gnu: virtuoso-ose: Enable fct, isparql,
 and ods plugins.
Date: Thu, 10 May 2018 22:32:44 +0200
Ludovic Courtès <ludo <at> gnu.org> writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> So I guess we can close this one and wait for the next release to
>> re-evaluate whether we can build these extra plugins.
>>
>> WDYT?
>
> Sounds good.  I just wanted to make sure we weren’t forgetting about
> it.  :-)
>
> Ludo’.

Marked this as done as all *working* changes that I wanted to apply here
have been applied in another patch.

Thanks for bringing this to my attention!

Kind regards,
Roel Janssen




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 08 Jun 2018 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 295 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.