GNU bug report logs - #29925
[PATCH 3/5] guix package: Disable profile hooks on dry runs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29925 in the body.
You can then email your comments to 29925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> member.fsf.org>
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH 3/5] guix package: Disable profile hooks on dry runs.
Date: Mon,  1 Jan 2018 18:33:34 +0800

Profile hooks will access the content of manifest inputs before return the
profile derivation, disable them so we don't get inputs bulit on dry runs.

* guix/scripts/package.scm (build-and-use-profile): Disable profile hooks when
a dry-run parameter is given.
---
 guix/scripts/package.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
index 617e102d9..ce0031551 100644
--- a/guix/scripts/package.scm
+++ b/guix/scripts/package.scm
@@ -203,7 +203,7 @@ specified in MANIFEST, a manifest object."
 
   (let* ((prof-drv (run-with-store store
                      (profile-derivation manifest
-                                         #:hooks (if bootstrap?
+                                         #:hooks (if (or bootstrap? dry-run?)
                                                      '()
                                                      %default-profile-hooks)
                                          #:locales? (not bootstrap?))))
-- 
2.13.3

Message #8 received at 29925 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 宋文武 <iyzsong <at> member.fsf.org>
Cc: 29925 <at> debbugs.gnu.org
Subject: Re: [bug#29925] [PATCH 3/5] guix package: Disable profile hooks on
 dry runs.
Date: Mon, 1 Jan 2018 14:36:34 +0100

LGTM!

Message #23 received at 29925-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 29925-done <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> member.fsf.org>
Subject: Re: [PATCH 0/5] Optimize profile hooks
Date: Wed, 12 May 2021 19:12:01 +0800

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> merge 29928 29926
> merge 29928 29927
> thanks
>
> This series (29928 29926 29927 29925 29929 29930) has by now slept on
> the mailing list for more than three years.
> Should we still try to merge it?  If so, could you send an updated
> version, that is not spread across six threads?

Hello, thoes patches are obsoleted, should be rewrite to use
`with-build-handler` (I haven't figure it out how yet).

Look like they were all merged as #29925, I think we can close it for
now, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.