GNU bug report logs - #29928
[PATCH 0/5] Optimize profile hooks

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: 宋文武 <iyzsong@HIDDEN>; Keywords: patch; merged with #29927; dated Mon, 1 Jan 2018 10:34:06 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Merged 29927 29928. Request was from ludo@HIDDEN (Ludovic Courtès) to control <at> debbugs.gnu.org. Full text available.

Message received at 29928 <at> debbugs.gnu.org:


Received: (at 29928) by debbugs.gnu.org; 20 Jan 2018 12:52:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 20 07:52:38 2018
Received: from localhost ([127.0.0.1]:35668 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ecsdR-00040h-Ty
	for submit <at> debbugs.gnu.org; Sat, 20 Jan 2018 07:52:38 -0500
Received: from rezeros.cc ([45.76.207.221]:50276)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iyzsong@HIDDEN>) id 1ecsdP-00040W-Hb
 for 29928 <at> debbugs.gnu.org; Sat, 20 Jan 2018 07:52:36 -0500
Received: from localhost (125.118.227.31 [125.118.227.31])
 by rezeros.cc (OpenSMTPD) with ESMTPSA id 015a45cc
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Sat, 20 Jan 2018 12:52:24 +0000 (UTC)
Received: from gift (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 2110f067;
 Sat, 20 Jan 2018 12:52:26 +0000 (UTC)
From: iyzsong@HIDDEN (=?utf-8?B?5a6L5paH5q2m?=)
To: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [bug#29928] [PATCH 0/5] Optimize profile hooks
References: <20180101103336.8613-1-iyzsong@HIDDEN>
 <876088m2vd.fsf@HIDDEN> <87vafxvrj7.fsf@HIDDEN>
 <87o9lp3kdl.fsf@HIDDEN>
Date: Sat, 20 Jan 2018 20:52:26 +0800
In-Reply-To: <87o9lp3kdl.fsf@HIDDEN> ("Ludovic
 \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
 \=\?utf-8\?Q\?s\?\= message of "Fri, 19 Jan 2018 17:04:38 +0100")
Message-ID: <87wp0cvgj9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 29928
Cc: 29928 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

ludo@HIDDEN (Ludovic Court=C3=A8s) writes:

> Hi,
>
> iyzsong@HIDDEN (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:
>
>> ludo@HIDDEN (Ludovic Court=C3=A8s) writes:
>
> [...]
>
>>>> One drawback is 'guix package --dry-run' no longer report the derivati=
ons of
>>>> profile hooks, and the derivation of profile it reports is not the rea=
l one.
>>>> Addition files will be built when the profiles hooks are run.
>>>
>>> FWIW I=E2=80=99m not entirely convinced by the approach.
>>
>> Well.. these patches modify package hooks to:
>>
>> 1. build all manifest inputs first.
>>
>> 2. filter manifest inputs to get interested ones.
>>
>> 3. run hook with its interested inputs.
>>
>> I think reducing the inputs of hook from the whole manifest to its
>> interested ones is the only way to avoid unneeded reruns.
>
> Agreed.
>
>>> As discussed earlier, I=E2=80=99d like to experiment with a notion of =
=E2=80=9Cbuild
>>> rounds=E2=80=9D: the first round would build a profile without any hook=
s, the
>>> second round would, depending on what the profile contains, rebuild it
>>> with certain hooks.
>>
>> I think "build rounds" would improve the UI/UX, and by changing inputs
>> from manifest inputs to a built profile, it would simply the current
>> implementations of profile hooks, but it won't avoid unneeded reruns
>> compare to the filtered interested inputs way.
>>
>> Is my understanding correct?
>
> A =E2=80=9Cbuild round=E2=80=9D is something that computes derivations ba=
sed on the
> output of previously-built derivations.  So it=E2=80=99s just another way=
 to
> structure steps 1/2/3 above; it should not reduce expressivity.
>
> Build rounds would allow us to ensure that =E2=80=98build-derivations=E2=
=80=99 is not
> called right in the middle of Guix, and is instead always under the
> control of the =E2=80=9Ctop level=E2=80=9D.
>

I see, looking forward it, thanks!




Information forwarded to guix-patches@HIDDEN:
bug#29928; Package guix-patches. Full text available.

Message received at 29928 <at> debbugs.gnu.org:


Received: (at 29928) by debbugs.gnu.org; 19 Jan 2018 16:04:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 19 11:04:44 2018
Received: from localhost ([127.0.0.1]:35149 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ecZ9n-0003dR-R7
	for submit <at> debbugs.gnu.org; Fri, 19 Jan 2018 11:04:44 -0500
Received: from hera.aquilenet.fr ([185.233.100.1]:54184)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1ecZ9l-0003dH-LU
 for 29928 <at> debbugs.gnu.org; Fri, 19 Jan 2018 11:04:42 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 85BB2109EE;
 Fri, 19 Jan 2018 17:04:40 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ajZ1uigbHaT7; Fri, 19 Jan 2018 17:04:39 +0100 (CET)
Received: from ribbon (unknown [193.50.110.135])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 05AAA1056F;
 Fri, 19 Jan 2018 17:04:38 +0100 (CET)
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: iyzsong@HIDDEN (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [bug#29928] [PATCH 0/5] Optimize profile hooks
References: <20180101103336.8613-1-iyzsong@HIDDEN>
 <876088m2vd.fsf@HIDDEN> <87vafxvrj7.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 30 =?utf-8?Q?Niv=C3=B4se?= an 226 de la =?utf-8?Q?R?=
 =?utf-8?Q?=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Fri, 19 Jan 2018 17:04:38 +0100
In-Reply-To: <87vafxvrj7.fsf@HIDDEN> (=?utf-8?B?IuWui+aWh+atpiIn?=
 =?utf-8?B?cw==?= message of "Fri, 19 Jan 2018 22:42:36 +0800")
Message-ID: <87o9lp3kdl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 29928
Cc: 29928 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

Hi,

iyzsong@HIDDEN (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> ludo@HIDDEN (Ludovic Court=C3=A8s) writes:

[...]

>>> One drawback is 'guix package --dry-run' no longer report the derivatio=
ns of
>>> profile hooks, and the derivation of profile it reports is not the real=
 one.
>>> Addition files will be built when the profiles hooks are run.
>>
>> FWIW I=E2=80=99m not entirely convinced by the approach.
>
> Well.. these patches modify package hooks to:
>
> 1. build all manifest inputs first.
>
> 2. filter manifest inputs to get interested ones.
>
> 3. run hook with its interested inputs.
>
> I think reducing the inputs of hook from the whole manifest to its
> interested ones is the only way to avoid unneeded reruns.

Agreed.

>> As discussed earlier, I=E2=80=99d like to experiment with a notion of =
=E2=80=9Cbuild
>> rounds=E2=80=9D: the first round would build a profile without any hooks=
, the
>> second round would, depending on what the profile contains, rebuild it
>> with certain hooks.
>
> I think "build rounds" would improve the UI/UX, and by changing inputs
> from manifest inputs to a built profile, it would simply the current
> implementations of profile hooks, but it won't avoid unneeded reruns
> compare to the filtered interested inputs way.
>
> Is my understanding correct?

A =E2=80=9Cbuild round=E2=80=9D is something that computes derivations base=
d on the
output of previously-built derivations.  So it=E2=80=99s just another way to
structure steps 1/2/3 above; it should not reduce expressivity.

Build rounds would allow us to ensure that =E2=80=98build-derivations=E2=80=
=99 is not
called right in the middle of Guix, and is instead always under the
control of the =E2=80=9Ctop level=E2=80=9D.

Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#29928; Package guix-patches. Full text available.

Message received at 29928 <at> debbugs.gnu.org:


Received: (at 29928) by debbugs.gnu.org; 19 Jan 2018 14:42:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 19 09:42:50 2018
Received: from localhost ([127.0.0.1]:34208 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ecXsY-0007i8-FK
	for submit <at> debbugs.gnu.org; Fri, 19 Jan 2018 09:42:50 -0500
Received: from rezeros.cc ([45.76.207.221]:50258)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iyzsong@HIDDEN>) id 1ecXsW-0007hy-OV
 for 29928 <at> debbugs.gnu.org; Fri, 19 Jan 2018 09:42:49 -0500
Received: from localhost (36.24.38.1 [36.24.38.1])
 by rezeros.cc (OpenSMTPD) with ESMTPSA id e813be35
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Fri, 19 Jan 2018 14:42:38 +0000 (UTC)
Received: from gift (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id ba6b85a4;
 Fri, 19 Jan 2018 14:42:41 +0000 (UTC)
From: iyzsong@HIDDEN (=?utf-8?B?5a6L5paH5q2m?=)
To: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [bug#29928] [PATCH 0/5] Optimize profile hooks
References: <20180101103336.8613-1-iyzsong@HIDDEN>
 <876088m2vd.fsf@HIDDEN>
Date: Fri, 19 Jan 2018 22:42:36 +0800
In-Reply-To: <876088m2vd.fsf@HIDDEN> ("Ludovic
 \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
 \=\?utf-8\?Q\?s\?\= message of "Thu, 11 Jan 2018 23:45:10 +0100")
Message-ID: <87vafxvrj7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 29928
Cc: 29928 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

ludo@HIDDEN (Ludovic Court=C3=A8s) writes:

> Hello!
>
> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@HIDDEN> skribis:
>
>> Hello, these patches make each profile hook run upon its specified inter=
ested
>> inputs, eg: the 'info-dir-file' hook only get inputs with info manuals,
>> install a package without info files won't trigger it.  Thus reduce the =
chance
>> and time to rerun them when your profile changed.
>
> That=E2=80=99s an area in need of improvements, thanks for looking into i=
t!
>
>> One drawback is 'guix package --dry-run' no longer report the derivation=
s of
>> profile hooks, and the derivation of profile it reports is not the real =
one.
>> Addition files will be built when the profiles hooks are run.
>
> FWIW I=E2=80=99m not entirely convinced by the approach.

Well.. these patches modify package hooks to:

1. build all manifest inputs first.

2. filter manifest inputs to get interested ones.

3. run hook with its interested inputs.

I think reducing the inputs of hook from the whole manifest to its
interested ones is the only way to avoid unneeded reruns.


> As discussed earlier, I=E2=80=99d like to experiment with a notion of =E2=
=80=9Cbuild
> rounds=E2=80=9D: the first round would build a profile without any hooks,=
 the
> second round would, depending on what the profile contains, rebuild it
> with certain hooks.

I think "build rounds" would improve the UI/UX, and by changing inputs
from manifest inputs to a built profile, it would simply the current
implementations of profile hooks, but it won't avoid unneeded reruns
compare to the filtered interested inputs way.

Is my understanding correct?




Information forwarded to guix-patches@HIDDEN:
bug#29928; Package guix-patches. Full text available.

Message received at 29928 <at> debbugs.gnu.org:


Received: (at 29928) by debbugs.gnu.org; 11 Jan 2018 22:45:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 11 17:45:16 2018
Received: from localhost ([127.0.0.1]:52649 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eZlb2-0006Fo-J0
	for submit <at> debbugs.gnu.org; Thu, 11 Jan 2018 17:45:16 -0500
Received: from hera.aquilenet.fr ([185.233.100.1]:36006)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1eZlaz-0006Fe-Aq
 for 29928 <at> debbugs.gnu.org; Thu, 11 Jan 2018 17:45:14 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 68A161021D;
 Thu, 11 Jan 2018 23:45:12 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id bNlmkXDkM4HG; Thu, 11 Jan 2018 23:45:11 +0100 (CET)
Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 4C3E1101EA;
 Thu, 11 Jan 2018 23:45:11 +0100 (CET)
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>
Subject: Re: [bug#29928] [PATCH 0/5] Optimize profile hooks
References: <20180101103336.8613-1-iyzsong@HIDDEN>
Date: Thu, 11 Jan 2018 23:45:10 +0100
In-Reply-To: <20180101103336.8613-1-iyzsong@HIDDEN>
 (=?utf-8?B?IuWui+aWh+atpiIncw==?=
 message of "Mon, 1 Jan 2018 18:33:31 +0800")
Message-ID: <876088m2vd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 29928
Cc: 29928 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

Hello!

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@HIDDEN> skribis:

> Hello, these patches make each profile hook run upon its specified intere=
sted
> inputs, eg: the 'info-dir-file' hook only get inputs with info manuals,
> install a package without info files won't trigger it.  Thus reduce the c=
hance
> and time to rerun them when your profile changed.

That=E2=80=99s an area in need of improvements, thanks for looking into it!

> One drawback is 'guix package --dry-run' no longer report the derivations=
 of
> profile hooks, and the derivation of profile it reports is not the real o=
ne.
> Addition files will be built when the profiles hooks are run.

FWIW I=E2=80=99m not entirely convinced by the approach.  As discussed earl=
ier,
I=E2=80=99d like to experiment with a notion of =E2=80=9Cbuild rounds=E2=80=
=9D: the first round
would build a profile without any hooks, the second round would,
depending on what the profile contains, rebuild it with certain hooks.

I don=E2=80=99t have anything to show yet, though=E2=80=A6

Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#29928; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 1 Jan 2018 10:34:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 01 05:34:00 2018
Received: from localhost ([127.0.0.1]:59253 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eVxPr-0000tS-V9
	for submit <at> debbugs.gnu.org; Mon, 01 Jan 2018 05:34:00 -0500
Received: from eggs.gnu.org ([208.118.235.92]:57809)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iyzsong@HIDDEN>) id 1eVxPp-0000sZ-SK
 for submit <at> debbugs.gnu.org; Mon, 01 Jan 2018 05:33:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <iyzsong@HIDDEN>) id 1eVxPj-0004Q4-Uw
 for submit <at> debbugs.gnu.org; Mon, 01 Jan 2018 05:33:52 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:42783)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <iyzsong@HIDDEN>)
 id 1eVxPj-0004Pu-SV
 for submit <at> debbugs.gnu.org; Mon, 01 Jan 2018 05:33:51 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48727)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <iyzsong@HIDDEN>) id 1eVxPi-0006LC-GF
 for guix-patches@HIDDEN; Mon, 01 Jan 2018 05:33:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <iyzsong@HIDDEN>) id 1eVxPf-0004Mr-BP
 for guix-patches@HIDDEN; Mon, 01 Jan 2018 05:33:50 -0500
Received: from rezeros.cc ([2001:19f0:7001:2f3e:5400:ff:fe84:e55d]:35544)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <iyzsong@HIDDEN>)
 id 1eVxPe-0004Km-TE
 for guix-patches@HIDDEN; Mon, 01 Jan 2018 05:33:47 -0500
Received: from localhost (36.24.33.173 [36.24.33.173])
 by rezeros.cc (OpenSMTPD) with ESMTPSA id 05d0b206
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Mon, 1 Jan 2018 10:33:15 +0000 (UTC)
Received: from localhost.localdomain (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 6abf0649;
 Mon, 1 Jan 2018 10:33:37 +0000 (UTC)
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/5] Optimize profile hooks
Date: Mon,  1 Jan 2018 18:33:31 +0800
Message-Id: <20180101103336.8613-1-iyzsong@HIDDEN>
X-Mailer: git-send-email 2.14.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

Hello, these patches make each profile hook run upon its specified interested
inputs, eg: the 'info-dir-file' hook only get inputs with info manuals,
install a package without info files won't trigger it.  Thus reduce the chance
and time to rerun them when your profile changed.


One drawback is 'guix package --dry-run' no longer report the derivations of
profile hooks, and the derivation of profile it reports is not the real one.
Addition files will be built when the profiles hooks are run.


Sou Bunnbu (宋文武) (5):
  gexp: Add 'eval-gexp'.
  profiles: info-dir-file: Don't consider unwanted manifest entries.
  guix package: Disable profile hooks on dry runs.
  profiles: Filter out unwanted manifest entries for profile hooks.
  profiles: Sort manifest inputs for profile hooks.

 guix/gexp.scm            |  16 ++++
 guix/profiles.scm        | 188 ++++++++++++++++++++++++++++++++---------------
 guix/scripts/package.scm |   2 +-
 3 files changed, 146 insertions(+), 60 deletions(-)

--
2.13.3




Acknowledgement sent to 宋文武 <iyzsong@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#29928; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 7 Mar 2018 14:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.