GNU bug report logs - #30123
claws-mail plugins not updated

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Reported by: julien lepiller <julien@HIDDEN>; dated Mon, 15 Jan 2018 13:53:01 UTC; Maintainer for guix is bug-guix@HIDDEN.

Message received at 30123 <at> debbugs.gnu.org:


Received: (at 30123) by debbugs.gnu.org; 21 Jan 2018 18:25:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 13:25:29 2018
Received: from localhost ([127.0.0.1]:37337 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1edKJ7-0005IH-0C
	for submit <at> debbugs.gnu.org; Sun, 21 Jan 2018 13:25:29 -0500
Received: from lepiller.eu ([89.234.186.109]:49042)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1edKJ5-0005I6-9J
 for 30123 <at> debbugs.gnu.org; Sun, 21 Jan 2018 13:25:27 -0500
Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79])
 by lepiller.eu (OpenSMTPD) with ESMTPSA id 495b478f
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
 for <30123 <at> debbugs.gnu.org>; Sun, 21 Jan 2018 18:25:51 +0000 (UTC)
Date: Sun, 21 Jan 2018 19:25:21 +0100
From: Julien Lepiller <julien@HIDDEN>
To: 30123 <at> debbugs.gnu.org
Subject: Re: bug#30123: claws-mail plugins not updated
Message-ID: <20180121192521.6673ab9c@HIDDEN>
In-Reply-To: <20180121154440.6c93cc8d@HIDDEN>
References: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
 <20180115171838.1440a62d@HIDDEN>
 <20180119175554.1252b190@HIDDEN>
 <20180121125937.2912f737@HIDDEN>
 <20180121143459.1e4ee122@HIDDEN>
 <20180121154440.6c93cc8d@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 30123
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Le Sun, 21 Jan 2018 15:44:40 +0100,
Danny Milosavljevic <dannym@HIDDEN> a =C3=A9crit :

> > Loading a module adds the directory part in clawsrc. =20
>=20
> Is it a /gnu/store directory or a user profile directory?

still the same /gnu/store directory.




Information forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.

Message received at 30123 <at> debbugs.gnu.org:


Received: (at 30123) by debbugs.gnu.org; 21 Jan 2018 14:44:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 09:44:52 2018
Received: from localhost ([127.0.0.1]:36695 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1edGrc-0006VU-D5
	for submit <at> debbugs.gnu.org; Sun, 21 Jan 2018 09:44:52 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:59680)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1edGra-0006VL-Gu
 for 30123 <at> debbugs.gnu.org; Sun, 21 Jan 2018 09:44:50 -0500
Received: from localhost (178.113.130.241.wireless.dyn.drei.com
 [178.113.130.241])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id BA2D43360350;
 Sun, 21 Jan 2018 15:44:48 +0100 (CET)
Date: Sun, 21 Jan 2018 15:44:40 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: Julien Lepiller <julien@HIDDEN>
Subject: Re: bug#30123: claws-mail plugins not updated
Message-ID: <20180121154440.6c93cc8d@HIDDEN>
In-Reply-To: <20180121143459.1e4ee122@HIDDEN>
References: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
 <20180115171838.1440a62d@HIDDEN>
 <20180119175554.1252b190@HIDDEN>
 <20180121125937.2912f737@HIDDEN>
 <20180121143459.1e4ee122@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 30123
Cc: 30123 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

> Loading a module adds the directory part in clawsrc.

Is it a /gnu/store directory or a user profile directory?




Information forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.

Message received at 30123 <at> debbugs.gnu.org:


Received: (at 30123) by debbugs.gnu.org; 21 Jan 2018 13:35:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 08:35:11 2018
Received: from localhost ([127.0.0.1]:36636 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1edFmA-000330-O5
	for submit <at> debbugs.gnu.org; Sun, 21 Jan 2018 08:35:10 -0500
Received: from lepiller.eu ([89.234.186.109]:49040)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1edFm8-00032p-K6
 for 30123 <at> debbugs.gnu.org; Sun, 21 Jan 2018 08:35:09 -0500
Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79])
 by lepiller.eu (OpenSMTPD) with ESMTPSA id c08121a8
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
 for <30123 <at> debbugs.gnu.org>; Sun, 21 Jan 2018 13:35:30 +0000 (UTC)
Date: Sun, 21 Jan 2018 14:34:59 +0100
From: Julien Lepiller <julien@HIDDEN>
To: 30123 <at> debbugs.gnu.org
Subject: Re: bug#30123: claws-mail plugins not updated
Message-ID: <20180121143459.1e4ee122@HIDDEN>
In-Reply-To: <20180121125937.2912f737@HIDDEN>
References: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
 <20180115171838.1440a62d@HIDDEN>
 <20180119175554.1252b190@HIDDEN>
 <20180121125937.2912f737@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 30123
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Le Sun, 21 Jan 2018 12:59:37 +0100,
Danny Milosavljevic <dannym@HIDDEN> a =C3=A9crit :

> > This is the end of my claswrc:
> >=20
> > [Plugins_GTK2]
> > /gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws=
-mail/plugins/pgpcore.so
> > /gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws=
-mail/plugins/pgpinline.so
> > /gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws=
-mail/plugins/pgpmime.so =20
>=20
> Please close claws-mail, make a backup of clawsrc and then remove the
> directory parts of these entries in clawsrc.
>=20
> Then start claws-mail again and close it again.  Then check clawsrc.
> The directory part should stay off.

Indeed, this seems to work.

>=20
> Also, please open claws-mail, enter the menu Configuration -> Plugins
> and remove and add some plugin there.  Then close claws-mail.  Does
> it have a directory part in clawsrc now?

Loading a module adds the directory part in clawsrc.




Information forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.

Message received at 30123 <at> debbugs.gnu.org:


Received: (at 30123) by debbugs.gnu.org; 21 Jan 2018 11:59:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 06:59:46 2018
Received: from localhost ([127.0.0.1]:36580 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1edEHp-00077I-VL
	for submit <at> debbugs.gnu.org; Sun, 21 Jan 2018 06:59:46 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:47048)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1edEHn-000777-Pt
 for 30123 <at> debbugs.gnu.org; Sun, 21 Jan 2018 06:59:44 -0500
Received: from localhost (178.113.130.241.wireless.dyn.drei.com
 [178.113.130.241])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id E4BA7336063D;
 Sun, 21 Jan 2018 12:59:41 +0100 (CET)
Date: Sun, 21 Jan 2018 12:59:37 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: Julien Lepiller <julien@HIDDEN>
Subject: Re: bug#30123: claws-mail plugins not updated
Message-ID: <20180121125937.2912f737@HIDDEN>
In-Reply-To: <20180119175554.1252b190@HIDDEN>
References: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
 <20180115171838.1440a62d@HIDDEN>
 <20180119175554.1252b190@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 30123
Cc: 30123 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

> This is the end of my claswrc:
> 
> [Plugins_GTK2]
> /gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws-mail/plugins/pgpcore.so
> /gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws-mail/plugins/pgpinline.so
> /gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws-mail/plugins/pgpmime.so

Please close claws-mail, make a backup of clawsrc and then remove the directory parts of these entries in clawsrc.

Then start claws-mail again and close it again.  Then check clawsrc.  The directory part should stay off.

Also, please open claws-mail, enter the menu Configuration -> Plugins and remove and add some plugin there.  Then close claws-mail.  Does it have a directory part in clawsrc now?




Information forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.

Message received at 30123 <at> debbugs.gnu.org:


Received: (at 30123) by debbugs.gnu.org; 19 Jan 2018 16:56:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 19 11:56:07 2018
Received: from localhost ([127.0.0.1]:35176 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ecZxT-0006uP-Rd
	for submit <at> debbugs.gnu.org; Fri, 19 Jan 2018 11:56:07 -0500
Received: from lepiller.eu ([89.234.186.109]:49036)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1ecZxR-0006tr-JS
 for 30123 <at> debbugs.gnu.org; Fri, 19 Jan 2018 11:56:02 -0500
Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79])
 by lepiller.eu (OpenSMTPD) with ESMTPSA id cc1ce6f4
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
 for <30123 <at> debbugs.gnu.org>; Fri, 19 Jan 2018 16:56:23 +0000 (UTC)
Date: Fri, 19 Jan 2018 17:55:54 +0100
From: Julien Lepiller <julien@HIDDEN>
To: 30123 <at> debbugs.gnu.org
Subject: Re: bug#30123: claws-mail plugins not updated
Message-ID: <20180119175554.1252b190@HIDDEN>
In-Reply-To: <20180115171838.1440a62d@HIDDEN>
References: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
 <20180115171838.1440a62d@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 30123
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Le Mon, 15 Jan 2018 17:18:38 +0100,
Danny Milosavljevic <dannym@HIDDEN> a =C3=A9crit :

> Hi Julien,
>=20
> On Mon, 15 Jan 2018 14:52:30 +0100
> julien lepiller <julien@HIDDEN> wrote:
>=20
> > claws-mail has a plugin system to add functionnality. For instance,
> > to add PGP support, one has to load 3 plugins from the claws-mail
> > package. By default, claws-mail looks in its store directory to
> > propose available plugins.
> >=20
> > When upgrading claws-mail, the configuration doesn't change.
> > Plugins are still looked for in the old store location, so old
> > plugins are still used. This is bad for security and compatibility.
> > Another issue is when running guix gc afterwards: the old plugins
> > are deleted and claws-mail issues an error message on startup
> > because it cannot find them anymore. =20
>=20
> I wonder how that happened.
>=20
> claws-mail already makes sure not to include the name of the plugin
> directory in entries in clawsrc:
>=20
> static gchar * plugin_canonical_name(const Plugin *plugin)
> {
>         if (plugin->in_prefix_dir =3D=3D TRUE) {
>                 if (plugin_filename_is_standard_dir(plugin->filename)
> =3D=3D TRUE) { gchar *plugin_name =3D g_path_get_basename(plugin->filenam=
e);
>                         return plugin_name;
>                 }
>         }
>         return g_strdup(plugin->filename);
> }
>=20
> And after the update it SHOULD take the plugins from the new
> installation directory.
>=20
> There's a Makefile variable PLUGINDIR which we could set, but as far
> as I can see it should already work fine (in claws-mail 3.16.0).
>=20
> Do your ~/.claws-mail/clawsrc entries include the directory name?

This is the end of my claswrc:

[Plugins_GTK2]
/gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws-mai=
l/plugins/pgpcore.so
/gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws-mai=
l/plugins/pgpinline.so
/gnu/store/5p5bs3na24af02hqpm9nmg817k9h97iz-claws-mail-3.16.0/lib/claws-mai=
l/plugins/pgpmime.so

>=20
> If it's actually broken, the easiest fix would be to make
> get_plugin_dir() return the plugin directory in the profile instead.
> If the user then configures the plugins, he'll (hopefully) take the
> ones from the profile directory (instead of the ones directly in the
> store).  The function above then stores only the basenames - and on a
> later update of claws-mail files with these basenames should be
> looked up in the new installation directory.  And even if the
> function should not work, claws-mail would take the plugins from the
> profile directory - which would be the new ones in the case of an
> update.
>=20
> But I'd rather get to the bottom of this problem before making the
> claws-mail package so defensive.





Information forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.

Message received at 30123 <at> debbugs.gnu.org:


Received: (at 30123) by debbugs.gnu.org; 15 Jan 2018 16:18:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 11:18:49 2018
Received: from localhost ([127.0.0.1]:57690 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eb7TF-0006G2-Aq
	for submit <at> debbugs.gnu.org; Mon, 15 Jan 2018 11:18:49 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:49890)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1eb7TC-0006Ft-SK
 for 30123 <at> debbugs.gnu.org; Mon, 15 Jan 2018 11:18:48 -0500
Received: from localhost (178.113.219.86.wireless.dyn.drei.com
 [178.113.219.86])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id 07D843360719;
 Mon, 15 Jan 2018 17:18:44 +0100 (CET)
Date: Mon, 15 Jan 2018 17:18:38 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: julien lepiller <julien@HIDDEN>
Subject: Re: bug#30123: claws-mail plugins not updated
Message-ID: <20180115171838.1440a62d@HIDDEN>
In-Reply-To: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
References: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 30123
Cc: 30123 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Hi Julien,

On Mon, 15 Jan 2018 14:52:30 +0100
julien lepiller <julien@HIDDEN> wrote:

> claws-mail has a plugin system to add functionnality. For instance, to 
> add PGP support, one has to load 3 plugins from the claws-mail package. 
> By default, claws-mail looks in its store directory to propose available 
> plugins.
> 
> When upgrading claws-mail, the configuration doesn't change. Plugins are 
> still looked for in the old store location, so old plugins are still 
> used. This is bad for security and compatibility. Another issue is when 
> running guix gc afterwards: the old plugins are deleted and claws-mail 
> issues an error message on startup because it cannot find them anymore.

I wonder how that happened.

claws-mail already makes sure not to include the name of the plugin directory in entries in clawsrc:

static gchar * plugin_canonical_name(const Plugin *plugin)
{
        if (plugin->in_prefix_dir == TRUE) {
                if (plugin_filename_is_standard_dir(plugin->filename) == TRUE) {
                        gchar *plugin_name = g_path_get_basename(plugin->filename);
                        return plugin_name;
                }
        }
        return g_strdup(plugin->filename);
}

And after the update it SHOULD take the plugins from the new installation directory.

There's a Makefile variable PLUGINDIR which we could set, but as far as I can see it should already work fine (in claws-mail 3.16.0).

Do your ~/.claws-mail/clawsrc entries include the directory name?

If it's actually broken, the easiest fix would be to make get_plugin_dir() return the plugin directory in the profile instead.  If the user then configures the plugins, he'll (hopefully) take the ones from the profile directory (instead of the ones directly in the store).  The function above then stores only the basenames - and on a later update of claws-mail files with these basenames should be looked up in the new installation directory.  And even if the function should not work, claws-mail would take the plugins from the profile directory - which would be the new ones in the case of an update.

But I'd rather get to the bottom of this problem before making the claws-mail package so defensive.




Information forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 15 Jan 2018 13:52:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 08:52:50 2018
Received: from localhost ([127.0.0.1]:56799 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eb5By-0005Io-0Y
	for submit <at> debbugs.gnu.org; Mon, 15 Jan 2018 08:52:50 -0500
Received: from eggs.gnu.org ([208.118.235.92]:38486)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1eb5Bw-0005Ic-ET
 for submit <at> debbugs.gnu.org; Mon, 15 Jan 2018 08:52:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <julien@HIDDEN>) id 1eb5Bq-00067n-OK
 for submit <at> debbugs.gnu.org; Mon, 15 Jan 2018 08:52:43 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:50861)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <julien@HIDDEN>) id 1eb5Bq-00067g-LA
 for submit <at> debbugs.gnu.org; Mon, 15 Jan 2018 08:52:42 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57685)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <julien@HIDDEN>) id 1eb5Bp-0004Ey-GK
 for bug-guix@HIDDEN; Mon, 15 Jan 2018 08:52:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <julien@HIDDEN>) id 1eb5Bl-00064M-H5
 for bug-guix@HIDDEN; Mon, 15 Jan 2018 08:52:41 -0500
Received: from lepiller.eu ([89.234.186.109]:41142)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <julien@HIDDEN>) id 1eb5Bl-00062X-7S
 for bug-guix@HIDDEN; Mon, 15 Jan 2018 08:52:37 -0500
Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr
 [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id af5f5033
 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <bug-guix@HIDDEN>;
 Mon, 15 Jan 2018 13:52:46 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 15 Jan 2018 14:52:30 +0100
From: julien lepiller <julien@HIDDEN>
To: bug-guix@HIDDEN
Subject: claws-mail plugins not updated
Message-ID: <34ab5e819160ccb1afaa37d8dfa1612f@HIDDEN>
X-Sender: julien@HIDDEN
User-Agent: Roundcube Webmail/1.3.3
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

Hi,

claws-mail has a plugin system to add functionnality. For instance, to 
add PGP support, one has to load 3 plugins from the claws-mail package. 
By default, claws-mail looks in its store directory to propose available 
plugins.

When upgrading claws-mail, the configuration doesn't change. Plugins are 
still looked for in the old store location, so old plugins are still 
used. This is bad for security and compatibility. Another issue is when 
running guix gc afterwards: the old plugins are deleted and claws-mail 
issues an error message on startup because it cannot find them anymore.




Acknowledgement sent to julien lepiller <julien@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#30123; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.