GNU bug report logs - #30181
[PATCH] gnu: Add golly.

Previous Next

Package: guix-patches;

Reported by: Kei Kebreau <kkebreau <at> posteo.net>

Date: Sat, 20 Jan 2018 04:57:01 UTC

Severity: normal

Tags: patch

Done: Kei Kebreau <kkebreau <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30181 in the body.
You can then email your comments to 30181 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#30181; Package guix-patches. (Sat, 20 Jan 2018 04:57:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kei Kebreau <kkebreau <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 20 Jan 2018 04:57:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: Add golly.
Date: Fri, 19 Jan 2018 23:52:25 -0500
* gnu/packages/games.scm (golly): New variable.
---
 gnu/packages/games.scm | 90 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 89 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 1213d87a5..e5d9aae3e 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -19,7 +19,7 @@
 ;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;; Copyright © 2016, 2017 ng0 <ng0 <at> n0.is>
 ;;; Copyright © 2016 Albin Söderqvist <albin <at> fripost.org>
-;;; Copyright © 2016, 2017 Kei Kebreau <kkebreau <at> posteo.net>
+;;; Copyright © 2016, 2017, 2018 Kei Kebreau <kkebreau <at> posteo.net>
 ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke <at> gnu.org>
@@ -363,6 +363,94 @@ played.  Freedoom complements the Doom engine with free levels, artwork, sound
 effects and music to make a completely free game.")
    (license license:bsd-3)))
 
+(define-public golly
+  (package
+    (name "golly")
+    (version "3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/golly/golly-"
+                                  version "/golly-" version
+                                  "-src.tar.gz"))
+              (sha256
+               (base32
+                "0dn74k3rylhx023n047lz4z6qrqijfcxi0b6jryqklhmm2n532f7"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:make-flags (list "CC=gcc"
+                          (string-append "GOLLYDIR="
+                                         (assoc-ref %outputs "out")
+                                         "/share/golly"))
+       #:tests? #f ; no check target
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key inputs #:allow-other-keys)
+             ;; For some reason, setting the PYTHON_SHLIB make flag doesn't
+             ;; properly set the path to the Python shared library. This
+             ;; substitution acheives the same end by different means.
+             (substitute* "gui-wx/wxprefs.cpp"
+               (("pythonlib = wxT\\(STRINGIFY\\(PYTHON_SHLIB\\)\\)")
+                (string-append "pythonlib = \""
+                               (assoc-ref inputs "python")
+                               "/lib/libpython-2.7.so\"")))
+             #t))
+         (replace 'build
+           (lambda* (#:key make-flags outputs #:allow-other-keys)
+             (with-directory-excursion "gui-wx"
+               (apply invoke `("make" ,@make-flags "-f" "makefile-gtk")))))
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin"))
+                    (doc (string-append out "/share/doc/golly"))
+                    (pixmaps (string-append out "/share/pixmaps"))
+                    (share (string-append out "/share/golly")))
+               (for-each (lambda (binary)
+                           (install-file binary bin))
+                         '("bgolly" "golly"))
+               (for-each (lambda (document)
+                           (install-file
+                            (string-append "docs/" document ".html")
+                            doc))
+                         '("License" "ReadMe" "ToDo"))
+               (install-file "gui-wx/icons/appicon.xpm" pixmaps)
+               (for-each (lambda (folder)
+                           (copy-recursively
+                            folder
+                            (string-append share "/" folder)))
+                         '("Help" "Patterns" "Rules" "Scripts")))
+             #t)))))
+    (native-inputs
+     `(("lua" ,lua)))
+    (inputs
+     `(("glu" ,glu)
+       ("mesa" ,mesa)
+       ("python" ,python-2)
+       ("wxwidgets" ,wxwidgets-gtk2)
+       ("zlib" ,zlib)))
+    (home-page "http://golly.sourceforge.net/")
+    (synopsis "Software for exploring cellular automata")
+    (description
+     "Golly simulates Conway's Game of Life and many other types of cellular
+automata.  The following features are available:
+@enumerate
+@item Support for bounded and unbounded universes, with cells of up to 256
+  states.
+@item Support for multiple algorithms, including Bill Gosper's Hashlife
+  algorithm.
+@item Loading patterns from BMP, PNG, GIF and TIFF image files.
+@item Reading RLE, macrocell, Life 1.05/1.06, dblife and MCell files.
+@item Scriptable via Lua or Python.
+@item Extracting patterns, rules and scripts from zip files.
+@item Downloading patterns, rules and scripts from online archives.
+@item Pasting patterns from the clipboard.
+@item Unlimited undo/redo.
+@item Configurable keyboard shortcuts.
+@item Auto fit option to keep patterns within the view.
+@end enumerate.")
+    (license license:gpl2+)))
+
 (define-public meandmyshadow
   (package
     (name "meandmyshadow")
-- 
2.15.1





Information forwarded to guix-patches <at> gnu.org:
bug#30181; Package guix-patches. (Sun, 28 Jan 2018 22:38:01 GMT) Full text and rfc822 format available.

Message #8 received at 30181 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 30181 <at> debbugs.gnu.org
Subject: Re: [bug#30181] [PATCH] gnu: Add golly.
Date: Sun, 28 Jan 2018 23:37:24 +0100
Kei Kebreau <kkebreau <at> posteo.net> skribis:

> * gnu/packages/games.scm (golly): New variable.

[...]

> +    (description
> +     "Golly simulates Conway's Game of Life and many other types of cellular
> +automata.  The following features are available:
> +@enumerate
> +@item Support for bounded and unbounded universes, with cells of up to 256
> +  states.
> +@item Support for multiple algorithms, including Bill Gosper's Hashlife
> +  algorithm.
> +@item Loading patterns from BMP, PNG, GIF and TIFF image files.
> +@item Reading RLE, macrocell, Life 1.05/1.06, dblife and MCell files.
> +@item Scriptable via Lua or Python.
> +@item Extracting patterns, rules and scripts from zip files.
> +@item Downloading patterns, rules and scripts from online archives.
> +@item Pasting patterns from the clipboard.
> +@item Unlimited undo/redo.
> +@item Configurable keyboard shortcuts.
> +@item Auto fit option to keep patterns within the view.
> +@end enumerate.")
                 ^
I think this period is not syntactically valid and must be removed.

Apart from that it LGTM, thanks!

Ludo’.




Reply sent to Kei Kebreau <kkebreau <at> posteo.net>:
You have taken responsibility. (Mon, 29 Jan 2018 00:02:02 GMT) Full text and rfc822 format available.

Notification sent to Kei Kebreau <kkebreau <at> posteo.net>:
bug acknowledged by developer. (Mon, 29 Jan 2018 00:02:03 GMT) Full text and rfc822 format available.

Message #13 received at 30181-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 30181-done <at> debbugs.gnu.org
Subject: Re: [bug#30181] [PATCH] gnu: Add golly.
Date: Sun, 28 Jan 2018 19:00:11 -0500
[Message part 1 (text/plain, inline)]
ludo <at> gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> * gnu/packages/games.scm (golly): New variable.
>
> [...]
>
>> +    (description
>> +     "Golly simulates Conway's Game of Life and many other types of cellular
>> +automata.  The following features are available:
>> +@enumerate
>> +@item Support for bounded and unbounded universes, with cells of up to 256
>> +  states.
>> +@item Support for multiple algorithms, including Bill Gosper's Hashlife
>> +  algorithm.
>> +@item Loading patterns from BMP, PNG, GIF and TIFF image files.
>> +@item Reading RLE, macrocell, Life 1.05/1.06, dblife and MCell files.
>> +@item Scriptable via Lua or Python.
>> +@item Extracting patterns, rules and scripts from zip files.
>> +@item Downloading patterns, rules and scripts from online archives.
>> +@item Pasting patterns from the clipboard.
>> +@item Unlimited undo/redo.
>> +@item Configurable keyboard shortcuts.
>> +@item Auto fit option to keep patterns within the view.
>> +@end enumerate.")
>                  ^
> I think this period is not syntactically valid and must be removed.

You are correct.

>
> Apart from that it LGTM, thanks!
>
> Ludo’.

Pushed with corrections. Thanks for reviewing!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 26 Feb 2018 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 33 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.