GNU bug report logs - #30191
[PATCH] gnu: gnunet: Use invoke.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30191 in the body.
You can then email your comments to 30191 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0+guixpatches <at> n0.is
To: guix-patches <at> gnu.org
Cc: ng0 <ng0 <at> n0.is>
Subject: [PATCH] gnu: gnunet: Use invoke.
Date: Sun, 21 Jan 2018 12:57:43 +0000

From: ng0 <ng0 <at> n0.is>

* gnu/packages/gnunet.scm (gnurl)[arguments]: Substitute invoke for system*.
(guile-gnunet)[arguments]: Likewise.
---
 gnu/packages/gnunet.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 2d238febc..759bc847e 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2015, 2017 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2016 Mark H Weaver <mhw <at> netris.org>
-;;; Copyright © 2016, 2017 ng0 <ng0 <at> n0.is>
+;;; Copyright © 2016, 2017, 2018 ng0 <ng0 <at> n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -226,7 +226,7 @@ authentication and support for SSL3 and TLS.")
               (("/bin/sh") (which "sh")))
 
             ;; Make test output more verbose.
-            (zero? (system* "make" "-C" "tests" "test"))
+            (invoke "make" "-C" "tests" "test")
             #t)))))
    (synopsis "Microfork of cURL with support for the HTTP/HTTPS/GnuTLS subset of cURL")
    (description
@@ -325,7 +325,7 @@ kinds of basic applications for the foundation of a GNU internet.")
        '(#:phases (modify-phases %standard-phases
                     (add-after 'unpack 'bootstrap
                       (lambda _
-                        (zero? (system* "autoreconf" "-vfi")))))))
+                        (invoke "autoreconf" "-vfi"))))))
       (native-inputs `(("pkg-config" ,pkg-config)
                        ("autoconf" ,(autoconf-wrapper))
                        ("automake" ,automake)))
-- 
2.15.1

Message #8 received at 30191 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: ng0+guixpatches <at> n0.is
Cc: 30191 <at> debbugs.gnu.org, ng0 <ng0 <at> n0.is>
Subject: Re: [bug#30191] [PATCH] gnu: gnunet: Use invoke.
Date: Sun, 21 Jan 2018 14:04:39 +0100

>              ;; Make test output more verbose.
> -            (zero? (system* "make" "-C" "tests" "test"))
> +            (invoke "make" "-C" "tests" "test")
>              #t)))))

Please remove "#t".

Message #13 received at 30191-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: ng0+guixpatches <at> n0.is
Cc: 30191-done <at> debbugs.gnu.org, ng0 <ng0 <at> n0.is>
Subject: Re: [bug#30191] [PATCH] gnu: gnunet: Use invoke.
Date: Tue, 23 Jan 2018 12:17:16 +0100

Applied patch to master with minimal changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.