GNU bug report logs - #30305
[PATCH] gnu: Add python-send2trash.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30305 in the body.
You can then email your comments to 30305 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-send2trash.
Date: Wed, 31 Jan 2018 16:28:37 +0300

[0001-gnu-Add-python-send2trash.patch (text/x-patch, inline)]

From 0e5058622c1291059fbf85b5949fb49cf0682dfd Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Wed, 31 Jan 2018 16:27:33 +0300
Subject: [PATCH] gnu: Add python-send2trash.

* gnu/packages/python.scm (python-send2trash): New public variable.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 94551da33..67c9a7665 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -12395,6 +12395,33 @@ and works only with Python 2 and NumPy < 1.9.")
 (define-public python2-phonenumbers
   (package-with-python2 python-phonenumbers))
 
+(define-public python-send2trash
+  (package
+    (name "python-send2trash")
+    (version "1.4.2")
+    (source
+     (origin (method url-fetch)
+             ;; Source tarball on PyPI doesn't include tests.
+             (uri (string-append "https://github.com/hsoft/send2trash/archive/"
+                                 version ".tar.gz"))
+             (sha256
+              (base32
+               "0ffyhwjyx61slkdy38iwjc4gmj7fj9gs2q58f075gwvq630pzm9z"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'pre-check
+           (lambda _
+             (mkdir-p "/tmp/foo")
+             (setenv "HOME" "/tmp/foo")
+             #t)))))
+    (home-page "https://github.com/hsoft/send2trash")
+    (synopsis "Send file to trash")
+    (description
+     "This package provides a Python library to send files to trash.")
+    (license license:bsd-3)))
+
 (define-public python-yapf
   (package
     (name "python-yapf")
-- 
2.15.1

Message #8 received at 30305 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 30305 <at> debbugs.gnu.org
Subject: Re: [bug#30305] [PATCH] gnu: Add python-send2trash.
Date: Tue, 06 Feb 2018 16:24:15 +0100

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

>>From 0e5058622c1291059fbf85b5949fb49cf0682dfd Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Wed, 31 Jan 2018 16:27:33 +0300
> Subject: [PATCH] gnu: Add python-send2trash.
>
> * gnu/packages/python.scm (python-send2trash): New public variable.

[...]

> +    (synopsis "Send file to trash")
> +    (description
> +     "This package provides a Python library to send files to trash.")

s/to trash/to the trash/

Perhaps in the description you can add more details as to what “the
trash” is (is it ~/Trash, or what?).

Is there a reason for not providing a Python 2.x variant?  If there is
one, please add a comment.

OK with these changes, thank you!

Ludo’.

Message #11 received at 30305 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 30305 <at> debbugs.gnu.org
Subject: Re: [bug#30305] [PATCH] gnu: Add python-send2trash.
Date: Fri, 09 Feb 2018 23:21:00 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Thank you for review!

ludo <at> gnu.org (Ludovic Courtès) writes:

  > Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
 
  >> +    (synopsis "Send file to trash")
  >> +    (description
  >> +     "This package provides a Python library to send files to the trash.")
 
  > Perhaps in the description you can add more details as to what “the
  > trash” is (is it ~/Trash, or what?).

Yes, “~/Trash”.

  > Is there a reason for not providing a Python 2.x variant?  If there is
  > one, please add a comment.

Yes, I had an issue to build it with Python 2 because tests failed.
Solved in the new attached patch.
 
  > OK with these changes, thank you!

The new synopsis, description and builded with Python 2.

[0001-gnu-Add-python-send2trash.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 30305 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 30305 <at> debbugs.gnu.org
Subject: Re: [bug#30305] [PATCH] gnu: Add python-send2trash.
Date: Fri, 09 Feb 2018 23:03:43 +0100

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From b4327af5b9c72c107b9764addd4b409a3a2cb351 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Wed, 31 Jan 2018 16:27:33 +0300
> Subject: [PATCH] gnu: Add python-send2trash.
>
> * gnu/packages/python.scm (python-send2trash): New public variable.

+ python2-send2trash.

> +    (synopsis "Send files to the user's Trash directory")

s/Trash/trash/

> +    (description "This package provides a Python library to send files to the
> +user's Trash directory.")

s/Trash/@file{~/Trash}/

You’d also need to set the ‘python2-variant’ property here because your
python2 variant is not a direct translation (see other packages in this
file as an example).

OK with these changes.

Thanks,
Ludo’.

Message #17 received at 30305 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 30305 <at> debbugs.gnu.org
Subject: Re: [bug#30305] [PATCH] gnu: Add python-send2trash.
Date: Sat, 10 Feb 2018 11:46:09 +0300

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:
 
  >> +    (description "This package provides a Python library to send files to the
  >> +user's Trash directory.")
  > 
  > s/Trash/@file{~/Trash}/

Maybe “@file{@var{XDG_DATA_HOME}/Trash}”?  Could be not a “~”, because
the library uses “XDG_DATA_HOME” variable.  From the source tarball:
--8<---------------cut here---------------start------------->8---
./send2trash/plat_other.py:49:HOMETRASH_B = op.join(XDG_DATA_HOME, b'Trash')
--8<---------------cut here---------------end--------------->8---

  > You’d also need to set the ‘python2-variant’ property here because your
  > python2 variant is not a direct translation (see other packages in this
  > file as an example).

--8<---------------cut here---------------start------------->8---
(define-public python2-send2trash
  (package
    …
    (properties `((python2-variant . ,(delay python-send2trash))))))
--8<---------------cut here---------------end--------------->8---

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 30305 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 30305 <at> debbugs.gnu.org
Cc: go.wigust <at> gmail.com
Subject: gnu: Add python-send2trash.
Date: Fri, 22 Jun 2018 21:47:58 +0200

[Message part 1 (text/plain, inline)]

This look like a good candidate for inclusion to guix 0.15.0. Could you
send an updated patch, or push it with the proposed modifications?

[Message part 2 (text/html, inline)]

Message #23 received at 30305 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: 30305 <at> debbugs.gnu.org, 30305-done <at> debbugs.gnu.org
Subject: Re: [bug#30305] gnu: Add python-send2trash.
Date: Sat, 23 Jun 2018 19:52:18 +0300

[Message part 1 (text/plain, inline)]

Hello Gábor,

Gábor Boskovits <boskovits <at> gmail.com> writes:

> This look like a good candidate for inclusion to guix 0.15.0. Could you
> send an updated patch, or push it with the proposed modifications?

Pushed as 02e2d18297c9352d5f12abe128a82e579d9be278

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.