Package: guix-patches;
Reported by: Danny Milosavljevic <dannym <at> scratchpost.org>
Date: Mon, 5 Feb 2018 08:17:02 UTC
Severity: normal
Tags: patch
Done: Danny Milosavljevic <dannym <at> scratchpost.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30355 in the body.
You can then email your comments to 30355 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
guix-patches <at> gnu.org:bug#30355; Package guix-patches.
(Mon, 05 Feb 2018 08:17:02 GMT) Full text and rfc822 format available.Danny Milosavljevic <dannym <at> scratchpost.org>:guix-patches <at> gnu.org.
(Mon, 05 Feb 2018 08:17:02 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Danny Milosavljevic <dannym <at> scratchpost.org> To: guix-patches <at> gnu.org Cc: Danny Milosavljevic <dannym <at> scratchpost.org> Subject: [PATCH] services: agetty: Make tty optional and add agetty instance to base services. Date: Mon, 5 Feb 2018 09:15:53 +0100
* gnu/system/install.scm (agetty-default-service): Delete variable.
(beaglebone-black-installation-os): Do not specify tty.
(a20-olinuxino-lime-installation-os): Do not specify tty.
(a20-olinuxino-lime2-emmc-installation-os): Do not specify tty.
(a20-olinuxino-micro-installation-os): Do not specify tty.
(banana-pi-m2-ultra-installation-os): Do not specify tty.
(nintendo-nes-classic-edition-installation-os): Do not specify tty.
(embedded-installation-os): Move agetty-service instantiation to...
* gnu/services/base.scm (%base-services): ...here.
(default-serial-port): New variable.
(agetty-shepherd-service): Make tty optional, default to the above.
* doc/guix.texi (agetty-configuration): Update "tty" documentation.
---
doc/guix.texi | 15 +++++++++-
gnu/services/base.scm | 77 ++++++++++++++++++++++++++++++++++++++++----------
gnu/system/install.scm | 37 ++++++++----------------
3 files changed, 88 insertions(+), 41 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 2b27a675c..4e5d9e33f 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -9621,7 +9621,20 @@ man page for more information.
@item @code{tty}
The name of the console this agetty runs on, as a string---e.g.,
-@code{"ttyS0"}. This argument is mandatory.
+@code{"ttyS0"}. This argument is optional, it will default to
+a reasonable default serial port used by Linux.
+
+For this, if there is a value for an option "agetty.tty" in the Linux
+command line, agetty will extract the device name of the serial port
+from it and use that.
+
+If not and if there is a value for an option "console" with a tty in
+the Linux command line, agetty will extract the device name of the
+serial port from it and use that.
+
+In both cases, agetty will leave the other serial device settings
+(baud rate etc) alone - in the hope that Linux pinned them to the
+correct values.
@item @code{baud-rate} (default: @code{#f})
A string containing a comma-separated list of one or more baud rates, in
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 8e30bcd34..8e740bf6c 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -817,7 +817,7 @@ the message of the day, among other things."
agetty-configuration?
(agetty agetty-configuration-agetty ;<package>
(default util-linux))
- (tty agetty-configuration-tty) ;string
+ (tty agetty-configuration-tty) ;string | #f
(term agetty-term ;string | #f
(default #f))
(baud-rate agetty-baud-rate ;string | #f
@@ -890,6 +890,42 @@ the message of the day, among other things."
;;; (default #f))
)
+(define (default-serial-port)
+ "Return a gexp that determines a reasonable default serial port
+to use as the tty. This is primarily useful for headless systems."
+ #~(begin
+ ;; console=device,options
+ ;; device: can be tty0, ttyS0, lp0, ttyUSB0 (serial).
+ ;; options: BBBBPNF. P n|o|e, N number of bits,
+ ;; F flow control (r RTS)
+ (use-modules (gnu build linux-boot))
+ (let* ((not-comma (char-set-complement (char-set #\,)))
+ (command (linux-command-line))
+ (agetty-specs (find-long-options "agetty.tty" command))
+ (console-specs (filter (lambda (spec)
+ (not (or
+ (string-prefix? "tty0" spec)
+ (string-prefix? "tty1" spec)
+ (string-prefix? "tty2" spec)
+ (string-prefix? "tty3" spec)
+ (string-prefix? "tty4" spec)
+ (string-prefix? "tty5" spec)
+ (string-prefix? "tty6" spec)
+ (string-prefix? "tty7" spec)
+ (string-prefix? "tty8" spec)
+ (string-prefix? "tty9" spec))))
+ (filter
+ (lambda (spec)
+ (string-prefix? "tty" spec))
+ (find-long-options "console" command))))
+ (specs (append agetty-specs console-specs))
+ (spec (if (null? specs)
+ #f
+ (car specs))))
+ (and spec
+ ;; Extract device name.
+ (car (string-tokenize spec not-comma))))))
+
(define agetty-shepherd-service
(match-lambda
(($ <agetty-configuration> agetty tty term baud-rate auto-login
@@ -901,7 +937,7 @@ the message of the day, among other things."
(list
(shepherd-service
(documentation "Run agetty on a tty.")
- (provision (list (symbol-append 'term- (string->symbol tty))))
+ (provision (list (symbol-append 'term- (string->symbol (or tty "auto")))))
;; Since the login prompt shows the host name, wait for the 'host-name'
;; service to be done. Also wait for udev essentially so that the tty
@@ -946,6 +982,9 @@ the message of the day, among other things."
('always "--local-line=always")
('never "-local-line=never")))
#~())
+ #$@(if tty
+ #~()
+ #~("--keep-baud"))
#$@(if extract-baud?
#~("--extract-baud")
#~())
@@ -1009,7 +1048,7 @@ the message of the day, among other things."
#$@(if login-pause?
#~("--login-pause")
#~())
- #$tty
+ #$(or tty (default-serial-port))
#$@(if baud-rate
#~(#$baud-rate)
#~())
@@ -1058,18 +1097,21 @@ the tty to run, among other things."
;; text is not lost in the middle of kernel messages (XXX).
(requirement '(user-processes host-name udev))
- (start #~(make-forkexec-constructor
- (list #$(file-append mingetty "/sbin/mingetty")
- "--noclear" #$tty
- #$@(if auto-login
- #~("--autologin" #$auto-login)
- #~())
- #$@(if login-program
- #~("--loginprog" #$login-program)
- #~())
- #$@(if login-pause?
- #~("--loginpause")
- #~()))))
+ (start #~(let ((tty #$(default-serial-port)))
+ (if tty
+ (make-forkexec-constructor
+ (list #$(file-append mingetty "/sbin/mingetty")
+ "--noclear" #$tty
+ #$@(if auto-login
+ #~("--autologin" #$auto-login)
+ #~())
+ #$@(if login-program
+ #~("--loginprog" #$login-program)
+ #~())
+ #$@(if login-pause?
+ #~("--loginpause")
+ #~())))
+ (const #f)))) ; never start.
(stop #~(make-kill-destructor)))))))
(define mingetty-service-type
@@ -2012,6 +2054,11 @@ This service is not part of @var{%base-services}."
(cons tty %default-console-font))
'("tty1" "tty2" "tty3" "tty4" "tty5" "tty6")))
+ (agetty-service (agetty-configuration
+ (extra-options '("-L")) ; no carrier detect
+ (term "vt100")
+ (tty #f))) ; automatic
+
(mingetty-service (mingetty-configuration
(tty "tty1")))
(mingetty-service (mingetty-configuration
diff --git a/gnu/system/install.scm b/gnu/system/install.scm
index e4b2e8237..db06b7a52 100644
--- a/gnu/system/install.scm
+++ b/gnu/system/install.scm
@@ -381,19 +381,10 @@ You have been warned. Thanks for being so brave.\x1b[0m
nvi ;:wq!
%base-packages))))
-(define* (agetty-default-service #:optional (tty "ttyS0"))
- "Return an agetty-service on the given TTY"
- (agetty-service (agetty-configuration
- (extra-options '("-L"))
- (baud-rate "115200")
- (term "vt100")
- (tty tty))))
-
-(define* (embedded-installation-os bootloader bootloader-target tty
+(define* (embedded-installation-os bootloader bootloader-target
#:key (extra-modules '()))
"Return an installation os for embedded systems.
The initrd gets the extra modules EXTRA-MODULES.
-A getty is provided on TTY.
The bootloader BOOTLOADER is installed to BOOTLOADER-TARGET."
(operating-system
(inherit installation-os)
@@ -404,43 +395,39 @@ The bootloader BOOTLOADER is installed to BOOTLOADER-TARGET."
(initrd (lambda (fs . rest)
(apply base-initrd fs
#:extra-modules extra-modules
- rest)))
- (services (cons* (agetty-default-service tty)
- (operating-system-user-services installation-os)))))
+ rest)))))
(define beaglebone-black-installation-os
(embedded-installation-os u-boot-beaglebone-black-bootloader
"/dev/sda"
- "ttyO0"
#:extra-modules
;; This module is required to mount the sd card.
'("omap_hsmmc")))
-
(define a20-olinuxino-lime-installation-os
(embedded-installation-os u-boot-a20-olinuxino-lime-bootloader
- "/dev/mmcblk0" ; SD card storage
- "ttyS0"))
+ ;; SD card storage
+ "/dev/mmcblk0"))
(define a20-olinuxino-lime2-emmc-installation-os
(embedded-installation-os u-boot-a20-olinuxino-lime2-bootloader
- "/dev/mmcblk1" ; eMMC storage
- "ttyS0"))
+ ;; eMMC storage
+ "/dev/mmcblk1"))
(define a20-olinuxino-micro-installation-os
(embedded-installation-os u-boot-a20-olinuxino-micro-bootloader
- "/dev/mmcblk0" ; SD card storage
- "ttyS0"))
+ ;; SD card storage
+ "/dev/mmcblk0"))
(define banana-pi-m2-ultra-installation-os
(embedded-installation-os u-boot-banana-pi-m2-ultra-bootloader
- "/dev/mmcblk1" ; eMMC storage
- "ttyS0"))
+ ;; eMMC storage
+ "/dev/mmcblk1"))
(define nintendo-nes-classic-edition-installation-os
(embedded-installation-os u-boot-nintendo-nes-classic-edition-bootloader
- "/dev/mmcblk0" ; SD card (solder it yourself)
- "ttyS0"))
+ ;; SD card storage (solder it yourself)
+ "/dev/mmcblk0"))
;; Return the default os here so 'guix system' can consume it directly.
installation-os
guix-patches <at> gnu.org:bug#30355; Package guix-patches.
(Fri, 09 Feb 2018 13:52:02 GMT) Full text and rfc822 format available.Message #8 received at 30355 <at> debbugs.gnu.org (full text, mbox):
From: ludo <at> gnu.org (Ludovic Courtès) To: Danny Milosavljevic <dannym <at> scratchpost.org> Cc: 30355 <at> debbugs.gnu.org Subject: Re: [bug#30355] [PATCH] services: agetty: Make tty optional and add agetty instance to base services. Date: Fri, 09 Feb 2018 14:51:12 +0100
Hi,
Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> * gnu/system/install.scm (agetty-default-service): Delete variable.
> (beaglebone-black-installation-os): Do not specify tty.
> (a20-olinuxino-lime-installation-os): Do not specify tty.
> (a20-olinuxino-lime2-emmc-installation-os): Do not specify tty.
> (a20-olinuxino-micro-installation-os): Do not specify tty.
> (banana-pi-m2-ultra-installation-os): Do not specify tty.
> (nintendo-nes-classic-edition-installation-os): Do not specify tty.
> (embedded-installation-os): Move agetty-service instantiation to...
> * gnu/services/base.scm (%base-services): ...here.
> (default-serial-port): New variable.
> (agetty-shepherd-service): Make tty optional, default to the above.
> * doc/guix.texi (agetty-configuration): Update "tty" documentation.
I would prefer the install.scm part to be a separate patch, if that’s
not too much of a burden for you.
I have a few minor comments:
> @item @code{tty}
> The name of the console this agetty runs on, as a string---e.g.,
> -@code{"ttyS0"}. This argument is mandatory.
> +@code{"ttyS0"}. This argument is optional, it will default to
> +a reasonable default serial port used by Linux.
s/Linux/the kernel Linux/ (to avoid ambiguities…)
> +For this, if there is a value for an option "agetty.tty" in the Linux
> +command line, agetty will extract the device name of the serial port
> +from it and use that.
> +
> +If not and if there is a value for an option "console" with a tty in
> +the Linux command line, agetty will extract the device name of the
> +serial port from it and use that.
@code{agetty.tty}, @code{console}, etc.
Write “kernel command line” instead of “Linux command line”.
> +In both cases, agetty will leave the other serial device settings
> +(baud rate etc) alone - in the hope that Linux pinned them to the
> +correct values.
s/etc/etc./
s/alone - in the hope/alone---in the hope/
(The three hyphens map to an em dash in the output.)
> +(define (default-serial-port)
> + "Return a gexp that determines a reasonable default serial port
> +to use as the tty. This is primarily useful for headless systems."
> + #~(begin
> + ;; console=device,options
> + ;; device: can be tty0, ttyS0, lp0, ttyUSB0 (serial).
> + ;; options: BBBBPNF. P n|o|e, N number of bits,
> + ;; F flow control (r RTS)
> + (use-modules (gnu build linux-boot))
> + (let* ((not-comma (char-set-complement (char-set #\,)))
> + (command (linux-command-line))
> + (agetty-specs (find-long-options "agetty.tty" command))
> + (console-specs (filter (lambda (spec)
> + (not (or
> + (string-prefix? "tty0" spec)
> + (string-prefix? "tty1" spec)
> + (string-prefix? "tty2" spec)
> + (string-prefix? "tty3" spec)
> + (string-prefix? "tty4" spec)
> + (string-prefix? "tty5" spec)
> + (string-prefix? "tty6" spec)
> + (string-prefix? "tty7" spec)
> + (string-prefix? "tty8" spec)
> + (string-prefix? "tty9" spec))))
> + (filter
> + (lambda (spec)
> + (string-prefix? "tty" spec))
> + (find-long-options "console" command))))
Please make that a single ‘filter’ or ‘remove’ call, for clarity.
> + (specs (append agetty-specs console-specs))
> + (spec (if (null? specs)
> + #f
> + (car specs))))
> + (and spec
> + ;; Extract device name.
> + (car (string-tokenize spec not-comma))))))
Rather:
(match (append agetty-specs console-specs)
(() #f)
((spec _ ...)
(string-tokenize spec not-comma)))
The rest LGTM. OK to push with these changes!
Thanks,
Ludo’.
guix-patches <at> gnu.org:bug#30355; Package guix-patches.
(Fri, 09 Feb 2018 19:50:01 GMT) Full text and rfc822 format available.Message #11 received at 30355 <at> debbugs.gnu.org (full text, mbox):
From: Danny Milosavljevic <dannym <at> scratchpost.org> To: ludo <at> gnu.org (Ludovic Courtès) Cc: 30355 <at> debbugs.gnu.org Subject: Re: [bug#30355] [PATCH] services: agetty: Make tty optional and add agetty instance to base services. Date: Fri, 9 Feb 2018 20:49:12 +0100
> Please make that a single ‘filter’ or ‘remove’ call, for clarity.
OK!
> Rather:
>
> (match (append agetty-specs console-specs)
> (() #f)
> ((spec _ ...)
> (string-tokenize spec not-comma)))
Crashes boot process with form error ().
I can't get "match" to work at all in this location.
It works fine when I start guile on a normally running system, but
in this initrd guile thing, (use-modules (ice-9 match)) doesn't help
either. What does help is (@ (ice-9 match) match). Why?
(define (default-serial-port)
"Return a gexp that determines a reasonable default serial port
to use as the tty. This is primarily useful for headless systems."
#~(begin
;; console=device,options
;; device: can be tty0, ttyS0, lp0, ttyUSB0 (serial).
;; options: BBBBPNF. P n|o|e, N number of bits,
;; F flow control (r RTS)
(use-modules (gnu build linux-boot))
(let* ((not-comma (char-set-complement (char-set #\,)))
(command (linux-command-line))
(agetty-specs (find-long-options "agetty.tty" command))
(console-specs (filter (lambda (spec)
(and (string-prefix? "tty" spec)
(not (or
(string-prefix? "tty0" spec)
(string-prefix? "tty1" spec)
(string-prefix? "tty2" spec)
(string-prefix? "tty3" spec)
(string-prefix? "tty4" spec)
(string-prefix? "tty5" spec)
(string-prefix? "tty6" spec)
(string-prefix? "tty7" spec)
(string-prefix? "tty8" spec)
(string-prefix? "tty9" spec)))))
(find-long-options "console" command)))
(specs (append agetty-specs console-specs)))
(use-modules (ice-9 match))
(match specs
(() #f) ; form error here
((spec _ ...) ; underscore is undefined
;; Extract device name from first spec.
(match (string-tokenize spec not-comma)
((device-name _ ...) ; underscore is undefined
device-name)))))))
Works just fine if I execute it in a running system, mind you...
guix-patches <at> gnu.org:bug#30355; Package guix-patches.
(Fri, 09 Feb 2018 22:01:02 GMT) Full text and rfc822 format available.Message #14 received at 30355 <at> debbugs.gnu.org (full text, mbox):
From: ludo <at> gnu.org (Ludovic Courtès) To: Danny Milosavljevic <dannym <at> scratchpost.org> Cc: 30355 <at> debbugs.gnu.org Subject: Re: [bug#30355] [PATCH] services: agetty: Make tty optional and add agetty instance to base services. Date: Fri, 09 Feb 2018 23:00:27 +0100
Danny Milosavljevic <dannym <at> scratchpost.org> skribis: >> Please make that a single ‘filter’ or ‘remove’ call, for clarity. > > OK! > >> Rather: >> >> (match (append agetty-specs console-specs) >> (() #f) >> ((spec _ ...) >> (string-tokenize spec not-comma))) > > Crashes boot process with form error (). > > I can't get "match" to work at all in this location. > > It works fine when I start guile on a normally running system, but > in this initrd guile thing, (use-modules (ice-9 match)) doesn't help > either. What does help is (@ (ice-9 match) match). Why? > > (define (default-serial-port) > "Return a gexp that determines a reasonable default serial port > to use as the tty. This is primarily useful for headless systems." > #~(begin > ;; console=device,options > ;; device: can be tty0, ttyS0, lp0, ttyUSB0 (serial). > ;; options: BBBBPNF. P n|o|e, N number of bits, > ;; F flow control (r RTS) > (use-modules (gnu build linux-boot)) > (let* ((not-comma (char-set-complement (char-set #\,))) > (command (linux-command-line)) > (agetty-specs (find-long-options "agetty.tty" command)) > (console-specs (filter (lambda (spec) > (and (string-prefix? "tty" spec) > (not (or > (string-prefix? "tty0" spec) > (string-prefix? "tty1" spec) > (string-prefix? "tty2" spec) > (string-prefix? "tty3" spec) > (string-prefix? "tty4" spec) > (string-prefix? "tty5" spec) > (string-prefix? "tty6" spec) > (string-prefix? "tty7" spec) > (string-prefix? "tty8" spec) > (string-prefix? "tty9" spec))))) > (find-long-options "console" command))) > (specs (append agetty-specs console-specs))) > (use-modules (ice-9 match)) > (match specs > (() #f) ; form error here > ((spec _ ...) ; underscore is undefined > ;; Extract device name from first spec. > (match (string-tokenize spec not-comma) > ((device-name _ ...) ; underscore is undefined > device-name))))))) Try moving the ‘use-modules’ form at the top so you have: (use-modules (gnu build linux-boot) (ice-9 match)) The inner ‘use-modules’ you had cannot work because the expander doesn’t “see” it when compiling, and thus the ‘match’ macro is missing at expansion time (thus the compiler assumes that code is calling a ‘match’ procedure that’ll be define at run time.) However it can work when you interpret it instead of compiling because the compiler will have expansion and execution intermingled. HTH, Ludo’.
guix-patches <at> gnu.org:bug#30355; Package guix-patches.
(Sat, 10 Feb 2018 22:08:03 GMT) Full text and rfc822 format available.Message #17 received at 30355 <at> debbugs.gnu.org (full text, mbox):
From: Danny Milosavljevic <dannym <at> scratchpost.org> To: ludo <at> gnu.org (Ludovic Courtès) Cc: 30355 <at> debbugs.gnu.org Subject: Re: [bug#30355] [PATCH] services: agetty: Make tty optional and add agetty instance to base services. Date: Sat, 10 Feb 2018 23:07:11 +0100
Hi Ludo,
I tried this now:
(define (default-serial-port)
"Return a gexp that determines a reasonable default serial port
to use as the tty. This is primarily useful for headless systems."
#~(begin
;; console=device,options
;; device: can be tty0, ttyS0, lp0, ttyUSB0 (serial).
;; options: BBBBPNF. P n|o|e, N number of bits,
;; F flow control (r RTS)
(use-modules (gnu build linux-boot) (ice-9 match))
(let* ((not-comma (char-set-complement (char-set #\,)))
(command (linux-command-line))
(agetty-specs (find-long-options "agetty.tty" command))
(console-specs (filter (lambda (spec)
(and (string-prefix? "tty" spec)
(not (or
(string-prefix? "tty0" spec)
(string-prefix? "tty1" spec)
(string-prefix? "tty2" spec)
(string-prefix? "tty3" spec)
(string-prefix? "tty4" spec)
(string-prefix? "tty5" spec)
(string-prefix? "tty6" spec)
(string-prefix? "tty7" spec)
(string-prefix? "tty8" spec)
(string-prefix? "tty9" spec)))))
(find-long-options "console" command)))
(specs (append agetty-specs console-specs)))
(match specs
(() #f)
((spec _ ...)
;; Extract device name from first spec.
(match (string-tokenize spec not-comma)
((device-name _ ...)
device-name)))))))
I get
$ ./pre-inst-env guix system reconfigure /etc/config.scm --fallback
...
guix system: error: exception caught while executing 'eval' on service 'root':
ERROR: Syntax error:
unknown location: unexpected syntax in form ()
(works totally fine with (@ (ice-9 match) match) instead)
Maybe (ice-9 match) was imported already and the use-module is ignored.
I get the same effect when I do the following in a new guile interpreter:
,use (ice-9 match)
(define match 42)
,use (ice-9 match)
(match #t (() #f))
So maybe there's a "match" variable captured from somewhere. Icky...
guix-patches <at> gnu.org:bug#30355; Package guix-patches.
(Tue, 13 Feb 2018 22:05:02 GMT) Full text and rfc822 format available.Message #20 received at 30355 <at> debbugs.gnu.org (full text, mbox):
From: ludo <at> gnu.org (Ludovic Courtès) To: Danny Milosavljevic <dannym <at> scratchpost.org> Cc: 30355 <at> debbugs.gnu.org Subject: Re: [bug#30355] [PATCH] services: agetty: Make tty optional and add agetty instance to base services. Date: Tue, 13 Feb 2018 23:04:10 +0100
Heya,
Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> I tried this now:
>
> (define (default-serial-port)
> "Return a gexp that determines a reasonable default serial port
> to use as the tty. This is primarily useful for headless systems."
> #~(begin
> ;; console=device,options
> ;; device: can be tty0, ttyS0, lp0, ttyUSB0 (serial).
> ;; options: BBBBPNF. P n|o|e, N number of bits,
> ;; F flow control (r RTS)
> (use-modules (gnu build linux-boot) (ice-9 match))
[...]
> (match specs
> (() #f)
> ((spec _ ...)
> ;; Extract device name from first spec.
> (match (string-tokenize spec not-comma)
> ((device-name _ ...)
> device-name)))))))
>
> I get
>
> $ ./pre-inst-env guix system reconfigure /etc/config.scm --fallback
> ...
> guix system: error: exception caught while executing 'eval' on service 'root':
> ERROR: Syntax error:
> unknown location: unexpected syntax in form ()
That’s a sign that the outermost ‘match’ wasn’t macro-expanded, hence
the error about ().
I got it: that’s because this gexp is spliced in a non-top-level
context. The end result is something like:
(let ((foo bar)
(baz (begin (use-modules …) …)))
…)
and the ‘use-modules’ there doesn’t have the desired effect.
The fix is to remove this ‘use-modules’ form and instead to pass the
modules as the ‘modules’ field of ‘shepherd-service’:
(shepherd-service
(modules '((ice-9 match) …))
;; …
)
Does that work for you?
Sorry for overlooking this before!
Ludo’.
Danny Milosavljevic <dannym <at> scratchpost.org>
to control <at> debbugs.gnu.org.
(Sun, 10 Feb 2019 21:13:02 GMT) Full text and rfc822 format available.Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
(Mon, 11 Mar 2019 11:24:06 GMT) Full text and rfc822 format available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.