GNU bug report logs - #30362
[PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30362 in the body.
You can then email your comments to 30362 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.
Date: Mon,  5 Feb 2018 17:44:58 -0500

* gnu/packages/webkit.scm (webkitgtk-2.4): Remove variable.
(webkitgtk/gtk+-2): Move the package to ...
* gnu/packages/gnucash.scm: ... here, and make it private.
---
 gnu/packages/gnucash.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 gnu/packages/webkit.scm  | 47 -----------------------------------------------
 2 files changed, 40 insertions(+), 47 deletions(-)

diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index 25200e3f9..ee97790e4 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -28,8 +28,10 @@
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages documentation)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages glib)
@@ -244,3 +246,41 @@ OFX DirectConnect, YellowNet, GeldKarte, and DTAUS discs are currently
 supported.  AqBanking is used by GnuCash, KMyMoney, and QBankManager.")
     ;; AqBanking is licensed under the GPLv2 or GPLv3
     (license (list license:gpl2 license:gpl3))))
+
+;; Latest release of the stable 2.4 series, with WebKit1 support. Also the last
+;; GTK+2 port. This package is unmaintained upstream and not safe to use with
+;; untrusted input. However, it is still required by GnuCash.
+;; TODO Remove this package once GnuCash has been updated.
+(define webkitgtk/gtk+-2
+  (package (inherit webkitgtk)
+    (name "webkitgtk-gtk2")
+    (version "2.4.11")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.webkitgtk.org/releases/"
+                                  "webkitgtk-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1xsvnvyvlywwyf6m9ainpsg87jkxjmd37q6zgz9cxb7v3c2ym2jq"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; no tests
+       ;; FIXME: Disabling parallel building is a quick hack to avoid the
+       ;; failure described in
+       ;; https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00837.html
+       ;; A more structural fix is needed.
+       #:parallel-build? #f
+       #:configure-flags
+       '("--enable-webkit2=no"
+         "--with-gtk=2.0")
+       #:phases (modify-phases %standard-phases
+                  (add-after
+                   'unpack 'set-gcc
+                   (lambda _ (setenv "CC" "gcc") #t)))))
+    (native-inputs
+     `(("flex" ,flex)
+       ("which" ,which)
+       ,@(package-native-inputs webkitgtk)))
+    (propagated-inputs
+     `(("gtk+-2" ,gtk+-2)
+       ("libsoup" ,libsoup)))))
diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index 340221640..c08ba9176 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -142,50 +142,3 @@ HTML/CSS applications to full-fledged web browsers.")
                    license:lgpl2.1+
                    license:bsd-2
                    license:bsd-3))))
-
-;; Latest release of the stable 2.4 series, with WebKit1 support.
-(define-public webkitgtk-2.4
-  (package (inherit webkitgtk)
-    (name "webkitgtk")
-    (version "2.4.11")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "http://www.webkitgtk.org/releases/"
-                                  name "-" version ".tar.xz"))
-              (sha256
-               (base32
-                "1xsvnvyvlywwyf6m9ainpsg87jkxjmd37q6zgz9cxb7v3c2ym2jq"))))
-    (build-system gnu-build-system)
-    (arguments
-     '(#:tests? #f ; no tests
-       ;; FIXME: Disabling parallel building is a quick hack to avoid the
-       ;; failure described in
-       ;; https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00837.html
-       ;; A more structural fix is needed.
-       #:parallel-build? #f
-       #:phases (modify-phases %standard-phases
-                  (add-after
-                   'unpack 'set-gcc
-                   (lambda _ (setenv "CC" "gcc") #t)))))
-    (native-inputs
-     `(("flex" ,flex)
-       ("which" ,which)
-       ,@(package-native-inputs webkitgtk)))))
-
-;; Last GTK+2 port, required by GnuCash.
-(define-public webkitgtk/gtk+-2
-  (package (inherit webkitgtk-2.4)
-    (name "webkitgtk-gtk2")
-    (arguments
-     `(;; FIXME: Disabling parallel building is a quick hack to avoid the
-       ;; failure described in
-       ;; https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00837.html
-       ;; A more structural fix is needed.
-       #:parallel-build? #f
-       #:configure-flags
-       '("--enable-webkit2=no"
-         "--with-gtk=2.0")
-       ,@(package-arguments webkitgtk-2.4)))
-    (propagated-inputs
-     `(("gtk+-2" ,gtk+-2)
-       ("libsoup" ,libsoup)))))
-- 
2.16.1

Message #8 received at 30362 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 30362 <at> debbugs.gnu.org
Subject: Re: [bug#30362] [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.
Date: Tue, 6 Feb 2018 08:51:40 +0100

LGTM!

Message #11 received at 30362 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 30362 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#30362] [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.
Date: Mon, 23 Apr 2018 14:59:47 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> LGTM!

Same here!  :-)

Ludo'.

Message #14 received at 30362 <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 30362 <at> debbugs.gnu.org
Subject: Re: [bug#30362] [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.
Date: Fri, 08 Jun 2018 22:18:37 -0700

[Message part 1 (text/plain, inline)]

Hi Leo,

Is this patch still relevant, now that webkitgtk <at> 2.4 has been removed,
and we upgraded to GnuCash 3.0 on core-updates?

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 30362-done <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: 30362-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#30362] [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.
Date: Sun, 10 Jun 2018 13:04:26 +0800

Chris Marusich <cmmarusich <at> gmail.com> writes:

> Hi Leo,
>
> Is this patch still relevant, now that webkitgtk <at> 2.4 has been removed,
> and we upgraded to GnuCash 3.0 on core-updates?

Yeah, we don’t need it, GnuCash 3.0 is on ‘master’ now, closing :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.