GNU bug report logs - #30379
[PATCH] gnu: bash: Don't specify default configuration filenames.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30379 in the body.
You can then email your comments to 30379 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: bash: Don't specify default configuration filenames.
Date: Wed, 07 Feb 2018 12:39:09 +0100

[0001-gnu-bash-Don-t-specify-default-configuration-filenam.patch (text/x-patch, attachment)]

[Message part 2 (text/plain, inline)]

Dear guix,

In bug #29337 I reported a “problem” with our Bash package:  It reads
/etc/bashrc even when it shouldn't, according to its own documentation.
I also compared the behavior of Bash on CentOS to that of Bash on Guix
with the following test:

> On CentOS 7, the following happens (yes, I added the echo-statement to
> /etc/bashrc on CentOS as well):
> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
> Goodbye, world
>
> On GuixSD:
> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
> Hello, world
> Goodbye, world

I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
to core-updates now, or should I wait for the next core-updates cycle?

Thanks!

Kind regards,
Roel Janssen

Message #8 received at 30379 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 30379 <at> debbugs.gnu.org
Subject: Re: [bug#30379] [PATCH] gnu: bash: Don't specify default
 configuration filenames.
Date: Fri, 09 Feb 2018 15:06:47 +0100

Hi,

Roel Janssen <roel <at> gnu.org> skribis:

> In bug #29337 I reported a “problem” with our Bash package:  It reads
> /etc/bashrc even when it shouldn't, according to its own documentation.
> I also compared the behavior of Bash on CentOS to that of Bash on Guix
> with the following test:
>
>> On CentOS 7, the following happens (yes, I added the echo-statement to
>> /etc/bashrc on CentOS as well):
>> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
>> Goodbye, world
>>
>> On GuixSD:
>> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
>> Hello, world
>> Goodbye, world
>
> I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
> to core-updates now, or should I wait for the next core-updates cycle?

Not now, because it’s still not merged (but you can help! :-)), but
definitely soonish, hopefully within a few days.

(I think that’s what we agreed on
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29337#28>.)

Thank you!

Ludo’.

Message #11 received at 30379 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 30379 <at> debbugs.gnu.org
Subject: Re: [bug#30379] [PATCH] gnu: bash: Don't specify default
 configuration filenames.
Date: Sat, 03 Mar 2018 22:55:44 +0100

Roel Janssen <roel <at> gnu.org> skribis:

> I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
> to core-updates now, or should I wait for the next core-updates cycle?

Now’s a good time to push to ‘core-updates’!

TIA,
Ludo’.

Message #14 received at 30379 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30379 <at> debbugs.gnu.org
Subject: Re: [bug#30379] [PATCH] gnu: bash: Don't specify default
 configuration filenames.
Date: Sun, 04 Mar 2018 15:22:59 +0100

Ludovic Courtès <ludo <at> gnu.org> writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
>> to core-updates now, or should I wait for the next core-updates cycle?
>
> Now’s a good time to push to ‘core-updates’!
>
> TIA,
> Ludo’.

Thanks!  I applied it in 1382bde93.

Kind regards,
Roel Janssen

Message #19 received at 30379-done <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: bug#30379 <30379-done <at> debbugs.gnu.org>
Subject: Re: Status: [PATCH] gnu: bash: Don't specify default configuration
 filenames.
Date: Sun, 10 Jun 2018 13:01:21 +0800

Already landed in master, closing :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.