GNU bug report logs - #30494
25.2; (setting-constant nil) error in sql.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30494 in the body.
You can then email your comments to 30494 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sciamano <at> yandex.ru
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; (setting-constant nil) error in sql.el
Date: Fri, 16 Feb 2018 22:52:28 +0100

Hi,

i'm trying to add SQL product by following steps from the introduction
section in the sql.el, but for the settings
:sqli-program
:sqli-login
:sqli-options
it fails with "attemt to set a constant symbol: nil"

In 'emacs -Q' executing it step-by-step:

(require 'sql)

(sql-add-product 'xyz "XyzDB"
                 '(:free-software t))

(defcustom my-sql-xyz-program "ixyz"
  "Command to start ixyz by XyzDB."
  :type 'file
  :group 'SQL)

;; NEXT STEP FAILS WITH:
;; Debugger entered--Lisp error: (setting-constant nil)
;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
(sql-set-product-feature 'xyz
                         :sqli-program 'my-sql-xyz-program)

;; BUT THIS TWO ARE OK
(sql-set-product-feature 'xyz
			 :prompt-regexp "^xyzdb> ")
(sql-set-product-feature 'xyz
			 :prompt-length 7)


-- 
Denis

Message #8 received at 30494 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: sciamano <at> yandex.ru
Cc: 30494 <at> debbugs.gnu.org
Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el
Date: Thu, 08 Mar 2018 20:18:48 -0500

tags 30494 + confirmed easy
quit

sciamano <at> yandex.ru writes:

> In 'emacs -Q' executing it step-by-step:
>
> (require 'sql)
>
> (sql-add-product 'xyz "XyzDB"
>                  '(:free-software t))
>
> (defcustom my-sql-xyz-program "ixyz"
>   "Command to start ixyz by XyzDB."
>   :type 'file
>   :group 'SQL)
>
> ;; NEXT STEP FAILS WITH:
> ;; Debugger entered--Lisp error: (setting-constant nil)
> ;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
> ;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
> (sql-set-product-feature 'xyz
>                          :sqli-program 'my-sql-xyz-program)

Looks like it's probably just a missing nil check in
sql-set-product-feature.

Message #13 received at 30494 <at> debbugs.gnu.org (full text, mbox):

From: pierre.techoueyres <at> free.fr (Pierre Téchoueyres)
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: sciamano <at> yandex.ru, 30494 <at> debbugs.gnu.org
Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el
Date: Sat, 01 Dec 2018 01:30:29 +0100

[Message part 1 (text/plain, inline)]

Noam Postavsky <npostavs <at> gmail.com> writes:

> tags 30494 + confirmed easy
> quit
>
> sciamano <at> yandex.ru writes:
>
>> In 'emacs -Q' executing it step-by-step:
>>
>> (require 'sql)
>>
>> (sql-add-product 'xyz "XyzDB"
>>                  '(:free-software t))
>>
>> (defcustom my-sql-xyz-program "ixyz"
>>   "Command to start ixyz by XyzDB."
>>   :type 'file
>>   :group 'SQL)
>>
>> ;; NEXT STEP FAILS WITH:
>> ;; Debugger entered--Lisp error: (setting-constant nil)
>> ;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
>> ;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
>> (sql-set-product-feature 'xyz
>>                          :sqli-program 'my-sql-xyz-program)
>
> Looks like it's probably just a missing nil check in
> sql-set-product-feature.
>

Does the attached patch do the trick ?

[0001-Check-that-feature-exist-in-sql-set-product-feature-.patch (text/x-patch, attachment)]

Message #16 received at 30494 <at> debbugs.gnu.org (full text, mbox):

From: pierre.techoueyres <at> free.fr (Pierre Téchoueyres)
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: sciamano <at> yandex.ru, 30494 <at> debbugs.gnu.org
Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el
Date: Thu, 13 Dec 2018 20:40:40 +0100

pierre.techoueyres <at> free.fr (Pierre Téchoueyres) writes:

> Noam Postavsky <npostavs <at> gmail.com> writes:
>
>> tags 30494 + confirmed easy
>> quit
>>
>> sciamano <at> yandex.ru writes:
>>
>>> In 'emacs -Q' executing it step-by-step:
>>>
>>> (require 'sql)
>>>
>>> (sql-add-product 'xyz "XyzDB"
>>>                  '(:free-software t))
>>>
>>> (defcustom my-sql-xyz-program "ixyz"
>>>   "Command to start ixyz by XyzDB."
>>>   :type 'file
>>>   :group 'SQL)
>>>
>>> ;; NEXT STEP FAILS WITH:
>>> ;; Debugger entered--Lisp error: (setting-constant nil)
>>> ;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
>>> ;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
>>> (sql-set-product-feature 'xyz
>>>                          :sqli-program 'my-sql-xyz-program)
>>
>> Looks like it's probably just a missing nil check in
>> sql-set-product-feature.
>>
>
> Does the attached patch do the trick ?
>
Any interrest on this ?

Message #19 received at 30494 <at> debbugs.gnu.org (full text, mbox):

From: pierre.techoueyres <at> free.fr (Pierre Téchoueyres)
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: sciamano <at> yandex.ru, eliz <at> gnu.org, 30494 <at> debbugs.gnu.org
Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el
Date: Sun, 23 Dec 2018 20:51:44 +0100

pierre.techoueyres <at> free.fr (Pierre Téchoueyres) writes:

> pierre.techoueyres <at> free.fr (Pierre Téchoueyres) writes:
>
>> Noam Postavsky <npostavs <at> gmail.com> writes:
>>
>>> tags 30494 + confirmed easy
>>> quit
>>>
>>> sciamano <at> yandex.ru writes:
>>>
>>>> In 'emacs -Q' executing it step-by-step:
>>>>
>>>> (require 'sql)
>>>>
>>>> (sql-add-product 'xyz "XyzDB"
>>>>                  '(:free-software t))
>>>>
>>>> (defcustom my-sql-xyz-program "ixyz"
>>>>   "Command to start ixyz by XyzDB."
>>>>   :type 'file
>>>>   :group 'SQL)
>>>>
>>>> ;; NEXT STEP FAILS WITH:
>>>> ;; Debugger entered--Lisp error: (setting-constant nil)
>>>> ;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
>>>> ;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
>>>> (sql-set-product-feature 'xyz
>>>>                          :sqli-program 'my-sql-xyz-program)
>>>
>>> Looks like it's probably just a missing nil check in
>>> sql-set-product-feature.
>>>
>>
>> Does the attached patch do the trick ?
>>
> Any interrest on this ?

Ping ! Or if this isn't desired, maybe it's time to close the bug ?

Message #22 received at 30494 <at> debbugs.gnu.org (full text, mbox):

From: pierre.techoueyres <at> free.fr (Pierre Téchoueyres)
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: sciamano <at> yandex.ru, 30494 <at> debbugs.gnu.org
Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el
Date: Tue, 08 Jan 2019 23:00:06 +0100

pierre.techoueyres <at> free.fr (Pierre Téchoueyres) writes:

> pierre.techoueyres <at> free.fr (Pierre Téchoueyres) writes:
>
>> pierre.techoueyres <at> free.fr (Pierre Téchoueyres) writes:
>>
>>> Noam Postavsky <npostavs <at> gmail.com> writes:
>>>
>>>> tags 30494 + confirmed easy
>>>> quit
>>>>
>>>> sciamano <at> yandex.ru writes:
>>>>
>>>>> In 'emacs -Q' executing it step-by-step:
>>>>>
>>>>> (require 'sql)
>>>>>
>>>>> (sql-add-product 'xyz "XyzDB"
>>>>>                  '(:free-software t))
>>>>>
>>>>> (defcustom my-sql-xyz-program "ixyz"
>>>>>   "Command to start ixyz by XyzDB."
>>>>>   :type 'file
>>>>>   :group 'SQL)
>>>>>
>>>>> ;; NEXT STEP FAILS WITH:
>>>>> ;; Debugger entered--Lisp error: (setting-constant nil)
>>>>> ;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
>>>>> ;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
>>>>> (sql-set-product-feature 'xyz
>>>>>                          :sqli-program 'my-sql-xyz-program)
>>>>
>>>> Looks like it's probably just a missing nil check in
>>>> sql-set-product-feature.
>>>>
>>>
>>> Does the attached patch do the trick ?
>>>
>> Any interrest on this ?
>
> Ping ! Or if this isn't desired, maybe it's time to close the bug ?

Ping ! Ping !

Message #27 received at 30494-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: pierre.techoueyres <at> free.fr (Pierre Téchoueyres)
Cc: sciamano <at> yandex.ru, npostavs <at> gmail.com, 30494-done <at> debbugs.gnu.org
Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el
Date: Sat, 12 Jan 2019 13:35:14 +0200

> From: pierre.techoueyres <at> free.fr (Pierre Téchoueyres)
> Date: Tue, 08 Jan 2019 23:00:06 +0100
> Cc: sciamano <at> yandex.ru, 30494 <at> debbugs.gnu.org
> 
> >>>> Looks like it's probably just a missing nil check in
> >>>> sql-set-product-feature.
> >>>>
> >>>
> >>> Does the attached patch do the trick ?
> >>>
> >> Any interrest on this ?
> >
> > Ping ! Or if this isn't desired, maybe it's time to close the bug ?
> 
> Ping ! Ping !

Sorry for lack of replies so far.

I've now pushed these changes to the master branch, and I'm closing
the bug report.  In the future, please be sure to state in the log
message the function(s) where you make changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.