GNU bug report logs - #30515
26.0; `mouse-1' in Profiler report

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30515 in the body.
You can then email your comments to 30515 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0; `mouse-1' in Profiler report
Date: Sun, 18 Feb 2018 09:01:55 -0800 (PST)

In the output of `profiler-report', `mouse-1' does not respect option
`mouse-1-click-follows-link'.

For a quick `mouse-1' click, `mouse-1' invokes
`profiler-report-toggle-entry'.  For a slow click (holding the button
depressed > 0.5 sec) it invokes `mouse-drag-region', but the subsequent
up event then still invokes `profiler-report-toggle-entry'.  The net
effect of a click (i.e., not dragging the mouse) is just that of
`profiler-report-toggle-entry'.

This gives users no easy way to use `mouse-1' to just set point.  They
can press `mouse-1', hold it pressed, and drag it, say, one char before
releasing it, but that also activates the region and sets mark.

`mouse-1' should respect option `mouse-1-click-follows-link', in
particular when its value is nil.

In GNU Emacs 26.0.91 (build 1, x86_64-w64-mingw32)
 of 2018-01-22
Repository revision: 752fba992b793a74d202c9cfc3e1a92fd458e748
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Message #8 received at 30515 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 30515 <at> debbugs.gnu.org
Subject: Re: bug#30515: 26.0; `mouse-1' in Profiler report
Date: Sun, 14 Jul 2019 18:21:59 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> In the output of `profiler-report', `mouse-1' does not respect option
> `mouse-1-click-follows-link'.

The patch below seems to fix this (and works with
mouse-1-click-follows-link both nil or not.

But is this really the way to do this stuff these days?  It seems so...
odd...

diff --git a/lisp/profiler.el b/lisp/profiler.el
index 775096276d..ee11ff68c5 100644
--- a/lisp/profiler.el
+++ b/lisp/profiler.el
@@ -473,6 +473,7 @@ profiler-report-make-entry-part
 		       (fboundp entry))
 		  (propertize (symbol-name entry)
 			      'face 'link
+                              'follow-link "\r"
 			      'mouse-face 'highlight
 			      'help-echo "\
 mouse-2: jump to definition\n\
@@ -534,9 +535,9 @@ profiler-report-mode-map
     (define-key map "\r"    'profiler-report-toggle-entry)
     (define-key map "\t"    'profiler-report-toggle-entry)
     (define-key map "i"     'profiler-report-toggle-entry)
-    (define-key map [mouse-1] 'profiler-report-toggle-entry)
     (define-key map "f"     'profiler-report-find-entry)
     (define-key map "j"     'profiler-report-find-entry)
+    (define-key map [follow-link] 'mouse-face)
     (define-key map [mouse-2] 'profiler-report-find-entry)
     (define-key map "d"	    'profiler-report-describe-entry)
     (define-key map "C"	    'profiler-report-render-calltree)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 30515 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 30515 <at> debbugs.gnu.org
Subject: Re: bug#30515: 26.0; `mouse-1' in Profiler report
Date: Thu, 25 Jul 2019 22:01:24 +0200

I've now applied the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.