GNU bug report logs - #30547
Hurd patch for `patch` does not apply to latest release

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30547 in the body.
You can then email your comments to 30547 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Hurd patch for `patch` does not apply to latest release
Date: Tue, 20 Feb 2018 07:20:34 -0500

[Message part 1 (text/plain, inline)]

There is a new version of GNU Patch, 2.7.6:

https://ftp.gnu.org/gnu/patch/

I noticed that our patch, 'patch-hurd-path-max.patch', doesn't apply. I
have an idea of how to adapt the patch, but I don't really have a way to
test it.

Manolis, are you able to adapt the patch to Patch 2.7.6?

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>, bug-guix <at> gnu.org
Subject: Re: Hurd patch for `patch` does not apply to latest release
Date: Tue, 20 Feb 2018 17:31:50 +0200

[Message part 1 (text/plain, inline)]

Hello Leo,

On 02/20/18 14:20, Leo Famulari wrote:
> There is a new version of GNU Patch, 2.7.6:
> 
> https://ftp.gnu.org/gnu/patch/
> 
> I noticed that our patch, 'patch-hurd-path-max.patch', doesn't apply. I
> have an idea of how to adapt the patch, but I don't really have a way to
> test it.
> 
> Manolis, are you able to adapt the patch to Patch 2.7.6?
> 

I rebased the patch on the latest patch master. The only thing I am not
sure is why the old patch was changing PATH_MAX with tost->st_size + 1.
I can't remember for the life of me. Also I can't remember why this
patch isn't part of patch upstream yet.

The old diff

-      char *buffer = xmalloc (PATH_MAX);
+      char *buffer = xmalloc (tost->st_size + 1);

while now I made it:
-      char *buffer = xmalloc (PATH_MAX + 1);
+      char *buffer = xmalloc (tost->st_size + 2);

Anyhow it should work now, can you try it?

Thank you!
Manolis

[patch-hurd-path-max.patch (text/x-patch, attachment)]

Message #13 received at 30547-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 30547-done <at> debbugs.gnu.org
Subject: Re: Hurd patch for `patch` does not apply to latest release
Date: Mon, 25 Feb 2019 20:40:40 -0500

[Message part 1 (text/plain, inline)]

The Hurd `patch` patch was adjusted in commit
ec07ba1ff73d6317470517ccf530a4a89b216f23

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.