GNU bug report logs - #30663
27.0.50; DirectoryVariables not refreshing on revert-buffer in dired-mode

Previous Next

Package: emacs;

Reported by: Christian Johansson <christian <at> mediastrategi.se>

Date: Thu, 1 Mar 2018 07:17:01 UTC

Severity: normal

Found in version 27.0.50

Fixed in version 27.1

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30663 in the body.
You can then email your comments to 30663 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#30663; Package emacs. (Thu, 01 Mar 2018 07:17:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christian Johansson <christian <at> mediastrategi.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 01 Mar 2018 07:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christian Johansson <christian <at> mediastrategi.se>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; DirectoryVariables not refreshing on revert-buffer in
 dired-mode
Date: Thu, 1 Mar 2018 08:09:32 +0100
If you create this file .dir-locals.el in a directory A:
((nil . (
         (test-variable . "My-Value 2")
         )))

And then open the directory A containing this file, when the 
confirmation of unsafe variables comes up, approve of using the variable 
value.

Now check the value of variable "test-variable" with (decribe-variable) 
inside the (dired-mode) buffer, it's value should be the expected one.

Now change the value to "My-Value 3" in the .dir-locals.el file and save 
it.

Switch to the (dired-mode) buffer again and glick g to do a 
(revert-buffer). Now inspect the same variable again, it should be 
"My-Value 3" but it is "My-Value 2"

(revert-buffer) refreshes DirectoryVariables in most modes but not in 
(dired-mode)


In GNU Emacs 27.0.50 (build 5, x86_64-apple-darwin17.4.0, NS 
appkit-1561.20 Version 10.13.3 (Build 17D102))
 of 2018-02-28 built on Christians-iMac
Repository revision: 108ce84432d597f92637ea74bd0a094224d157de
Windowing system distributor 'Apple', version 10.3.1561
System Description:  Mac OS X 10.13.3

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
user-error: The mark is not set now, so there is no region
Making completion list...
delete-backward-char: Text is read-only
Making completion list... [2 times]

Configured features:
RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS
THREADS LCMS2

Important settings:
  value of $LANG: sv_SE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote kqueue cocoa ns lcms2
multi-tty make-network-process emacs)

Memory information:
((conses 16 204092 10722)
 (symbols 48 19937 1)
 (miscs 40 43 158)
 (strings 32 28820 2211)
 (string-bytes 1 760839)
 (vectors 16 35104)
 (vector-slots 8 714916 18226)
 (floats 8 48 68)
 (intervals 56 217 0)
 (buffers 992 12))





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30663; Package emacs. (Thu, 01 Mar 2018 15:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 30663 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Christian Johansson <christian <at> mediastrategi.se>
Cc: 30663 <at> debbugs.gnu.org
Subject: Re: bug#30663: 27.0.50;
 DirectoryVariables not refreshing on revert-buffer in dired-mode
Date: Thu, 01 Mar 2018 17:07:37 +0200
> From: Christian Johansson <christian <at> mediastrategi.se>
> Date: Thu, 1 Mar 2018 08:09:32 +0100
> 
> (revert-buffer) refreshes DirectoryVariables in most modes but not in 
> (dired-mode)

My guess is that this happens because Dired has its own
revert-buffer-function, and something is missing in that function to
re-read the local variables.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30663; Package emacs. (Mon, 14 May 2018 15:18:01 GMT) Full text and rfc822 format available.

Message #11 received at 30663 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Christian Johansson <christian <at> mediastrategi.se>, 30663 <at> debbugs.gnu.org
Subject: Re: bug#30663: 27.0.50;
 DirectoryVariables not refreshing on revert-buffer in dired-mode
Date: Mon, 14 May 2018 17:17:01 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

Hi,

>> (revert-buffer) refreshes DirectoryVariables in most modes but not in 
>> (dired-mode)
>
> My guess is that this happens because Dired has its own
> revert-buffer-function, and something is missing in that function to
> re-read the local variables.

Indeed, I've pushed a fix to the master branch.

Christian, could you pls retest?

> Thanks.

Best regards, Michael.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30663; Package emacs. (Tue, 15 May 2018 06:12:02 GMT) Full text and rfc822 format available.

Message #14 received at 30663 <at> debbugs.gnu.org (full text, mbox):

From: Christian Johansson <christian <at> mediastrategi.se>
To: Michael Albinus <michael.albinus <at> gmx.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 30663 <at> debbugs.gnu.org
Subject: Re: bug#30663: 27.0.50; DirectoryVariables not refreshing on
 revert-buffer in dired-mode
Date: Tue, 15 May 2018 08:11:47 +0200
Thanks Michael, I can confirm it's now working as expected

Regards, Christian

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> Hi,
>
>>> (revert-buffer) refreshes DirectoryVariables in most modes but not in
>>> (dired-mode)
>> My guess is that this happens because Dired has its own
>> revert-buffer-function, and something is missing in that function to
>> re-read the local variables.
> Indeed, I've pushed a fix to the master branch.
>
> Christian, could you pls retest?
>
>> Thanks.
> Best regards, Michael.





Reply sent to Michael Albinus <michael.albinus <at> gmx.de>:
You have taken responsibility. (Tue, 15 May 2018 06:49:01 GMT) Full text and rfc822 format available.

Notification sent to Christian Johansson <christian <at> mediastrategi.se>:
bug acknowledged by developer. (Tue, 15 May 2018 06:49:01 GMT) Full text and rfc822 format available.

Message #19 received at 30663-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Christian Johansson <christian <at> mediastrategi.se>
Cc: 30663-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#30663: 27.0.50;
 DirectoryVariables not refreshing on revert-buffer in dired-mode
Date: Tue, 15 May 2018 08:48:33 +0200
Version: 27.1

Christian Johansson <christian <at> mediastrategi.se> writes:

Hi Christian,

> Thanks Michael, I can confirm it's now working as expected

Thanks for the cross-check. I'm closing the bug.

> Regards, Christian

Best regards, Michael.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 12 Jun 2018 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 291 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.