GNU bug report logs -
#30679
[PATCH] Update VLC to 3.0.1 (Fixed submission - second try)
Previous Next
Reported by: <pkill9 <at> runbox.com>
Date: Fri, 2 Mar 2018 16:29:02 UTC
Severity: normal
Tags: patch
Merged with 30678
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30679 in the body.
You can then email your comments to 30679 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#30679
; Package
guix-patches
.
(Fri, 02 Mar 2018 16:29:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
<pkill9 <at> runbox.com>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Fri, 02 Mar 2018 16:29:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
The uploaded attachment was empty >.< Now I've uploaded it properly.
----- Start Forwarded Message -----
Sent: Fri, 02 Mar 2018 10:32:56 +0000 (GMT)
From: <pkill9 <at> runbox.com>
To: "guix-patches" <guix-patches <at> gnu.org>
Subject: [PATCH] Update VLC to 3.0.1 (Fixed submission)
My original patch submission (from email address miles.harvey <at> runbox.com) got butchered by my email client, so I have instead uploaded it as an attachment.
----- End Forwarded Message -----
[vlc-update.patch (text/x-patch, attachment)]
Merged 30678 30679.
Request was from
ludo <at> gnu.org (Ludovic Courtès)
to
control <at> debbugs.gnu.org
.
(Sat, 03 Mar 2018 21:24:01 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#30679
; Package
guix-patches
.
(Sat, 03 Mar 2018 21:32:01 GMT)
Full text and
rfc822 format available.
Message #10 received at 30679 <at> debbugs.gnu.org (full text, mbox):
Hello pkill9,
Thanks for the patch!
In the future, can you please send a patch containing a commit log that
follows the project’s conventions, and produced by ‘git format-patch’?
See
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.
Don’t worry if you’re unsure about the details, we can help.
<pkill9 <at> runbox.com> skribis:
> (native-inputs
> `(("git" ,git) ; needed for a test
> + ("gcc" ,gcc)
This is normally not needed. Can you remove it?
> + ;Optional inputs
> + ;("lua" ,lua) ;Configure phase doesn't find this
> + ("libarchive" ,libarchive)
> + ("livemedia-utils" ,livemedia-utils)
> + ("libbluray" ,libbluray)
> + ("samba" ,samba)
> + ;("nfs-utils" ,(@ (gnu packages nfs) nfs-utils)) ;configure phase doesn't find this
> + ;("freerdp" ,(@ (gnu packages rdesktop) freerdp)) ;causes compilation failure
> + ("libshout" ,libshout)
> + ("libebml" ,libebml)
> + ("libmatroska" ,libmatroska)
> + ("libmodplug" ,libmodplug)
> + ("mpg123" ,mpg123)
> + ;("gstreamer"
> + ; ,(@ (gnu packages gstreamer) gstreamer)) ;configure phase doesn't find this.
Nitpick: please use two semicolons for comments like this (one semicolon
is for margin comments.)
> + ("libva" ,libva)
> + ("twolame" ,twolame)
> + ("libdca" ,libdca)
> + ("libmpeg2" ,libmpeg2)
> + ("speexdsp" ,speexdsp)
> + ("fluidsynth" ,fluidsynth)
> + ("libass" ,libass)
> + ("fribidi" ,fribidi)
> + ("librsvg" ,librsvg)
> + ("libcaca" ,libcaca)
> + ("jack" ,jack-1)
> + ("soxr" ,soxr)
> + ("chromaprint" ,chromaprint)
> + ("protobuf" ,protobuf)
> + ("eudev" ,eudev)
> + ("libmtp" ,libmtp)
> + ("libupnp" ,libupnp)
> + ("taglib" ,taglib)
> + ("libsecret" ,libsecret)
> + ("libnotify" ,libnotify)))
That’s a lot of new dependencies! :-)
Could you check the impact this has on the size of vlc plus its
dependencies, as shown by “guix size vlc”?
In many cases we add all the optional dependencies of the package, for
convenience. However there are cases where doing it may be impractical,
because that would make the whole thing just too big. If that is the
case, we should keep a reduced set of dependencies of the ‘vlc’ package
and, if needed, add specific package variants with additional
dependencies.
> + (add-after 'build 'fix-misnamed-appdata
> + ;; vlc.appdata.xml.in gets created instead of vlc.appdata.xml, so
> + ;; we copy it to the correct name - This solution is hacky, if the
> + ;; root cause is found then please supply a patch.
> + (lambda _ (copy-file "share/vlc.appdata.xml.in" "share/vlc.appdata.xml")))
That looks fishy. Could you check if there’s a Makefile(.am) that
mentions “vlc.appdata.xml” so we can see how it’s supposed to be built?
Thanks,
Ludo’.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 27 Sep 2018 11:24:07 GMT)
Full text and
rfc822 format available.
This bug report was last modified 5 years and 210 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.