GNU bug report logs - #30812
Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Clément Pit-Claudel <clement.pitclaudel@HIDDEN>; dated Tue, 13 Mar 2018 23:16:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 30812 <at> debbugs.gnu.org:


Received: (at 30812) by debbugs.gnu.org; 21 Mar 2018 00:26:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 20 20:26:51 2018
Received: from localhost ([127.0.0.1]:44440 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eyRac-0008Sf-RA
	for submit <at> debbugs.gnu.org; Tue, 20 Mar 2018 20:26:51 -0400
Received: from mail-io0-f180.google.com ([209.85.223.180]:36528)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>)
 id 1eyRaZ-0008SM-Im; Tue, 20 Mar 2018 20:26:48 -0400
Received: by mail-io0-f180.google.com with SMTP id o4so4562111iod.3;
 Tue, 20 Mar 2018 17:26:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=PEE25MI5hvGepB3nJh5YuxfW6fZF3QAyXU+5akxjk3A=;
 b=udTOfD4aO8fPgY6pjk6Q9zDOHKJNdS3aQKr05ViqpJUsrrLKJSqZNsT7GoCLf4DYQR
 kw4ZMy8XgFcAm1JbVl3GkzDtIwQEmbridWKBGNd/qsk4D0NMezIktcXzWaOFKvRPdFgi
 u+H8F25Iqy6/vSeG3DcuYkmcYHICL5bAmTxzf/NkVH5Ujo69ItVGyawq4AR0mt7P2eYe
 3Gwk/848yjZGXPvgl74gEj3ozfjlhixwrWLnZMXNuOQDFew3AWgDi8OL4KQBLqMXJcwc
 F7VoJOfvRqU4fXOUMe29GJqtDCpt+IU1E/MqyfK1RCZ3yAzhyeKWrxgJUz6f2IoNdiKB
 V4DA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=PEE25MI5hvGepB3nJh5YuxfW6fZF3QAyXU+5akxjk3A=;
 b=U9fw8FEkG73L721RiFae9pKyBfcH/CzMKKbs85fYybYf+/7ggMupggc9HG3jYflNlF
 9UmlQkRuXIDnJfcmlVX+20sZfvDZKm80EL1ceuKZ7Q9HEKTWzm4YrzcAwok9UpvyoAlk
 BmOMXWWify/ac145ZXybQgDEiUcFB3FQhUGyiR+js44YwdJot1k4j16ILG2qC4zXxZIn
 WC2XlL54Gtm5L9eaYSdHhHt9W6bnx+bSZ4SX4sS5UoAfteg5J7CCSiWkfCL8w36jnuqk
 lDQgcu/RoHtTpnsfA/QnJo1+A1DY8ENNuqUNp5OouJ0fKNCwGT3PeNFQStpM3/ivVTmh
 W56w==
X-Gm-Message-State: AElRT7F/x/G31b5SwL5tbVhjCbmLN0wf5KD8VI3aT/u5XkKPEVYN8hxQ
 5hxsC7X0VEYViiVREgcYFnvbcw==
X-Google-Smtp-Source: AG47ELsEcfiG83RsxNEIID3sglAwfUNKGSsijjsE4Q+iBbxJyhIenk4y0E0mOvmU6b417OTCIqiJbA==
X-Received: by 10.107.144.197 with SMTP id s188mr19661606iod.147.1521592001943; 
 Tue, 20 Mar 2018 17:26:41 -0700 (PDT)
Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34])
 by smtp.googlemail.com with ESMTPSA id
 12-v6sm2252618itm.0.2018.03.20.17.26.40
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 20 Mar 2018 17:26:41 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel <clement.pitclaudel@HIDDEN>
Subject: Re: bug#30812: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
References: <c2760cec-0a04-2cb0-a5b4-bb7d1df212e5@HIDDEN>
Date: Tue, 20 Mar 2018 20:26:39 -0400
In-Reply-To: <c2760cec-0a04-2cb0-a5b4-bb7d1df212e5@HIDDEN>
 (=?utf-8?Q?=22Cl=C3=A9ment?=
 Pit-Claudel"'s message of "Tue, 13 Mar 2018 19:14:56 -0400")
Message-ID: <874llatgsg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 30812
Cc: 30812 <at> debbugs.gnu.org, jeffersoncarpenter2@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

unarchive 27613
notfixed 27613 26.1
quit

Cl=C3=A9ment Pit-Claudel <clement.pitclaudel@HIDDEN> writes:

> I think the following commit was a bit too enthusiastic, as variables
> like @temp are now highlighted in font-lock-type-face.

I've reverted this from emacs-26 [1: f8cad16bb3].

> -     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
> +     ;; Fontify declarators and prefixes as types.
> +     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersed=
e\\)\\>" . font-lock-type-face) ; declarators
> +     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes

> Am I missing something? (I don't speak Perl, so I noticed this in a regre=
ssion test)

I missed this in the originating thread, but according to what I'm
getting from web searches, most of those keywords are perl 6 specific.
I think perl-mode shouldn't support them.

[1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
  Revert "Support all perl variable declarators and prefixes"
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Df8cad16bb3272a80=
69b3008019f9d18516aef1a5>




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#30812; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Mar 2018 23:15:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 13 19:15:14 2018
Received: from localhost ([127.0.0.1]:60129 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1evt8T-0004Di-W8
	for submit <at> debbugs.gnu.org; Tue, 13 Mar 2018 19:15:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45297)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <clement.pitclaudel@HIDDEN>) id 1evt8R-0004DQ-QY
 for submit <at> debbugs.gnu.org; Tue, 13 Mar 2018 19:15:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <clement.pitclaudel@HIDDEN>) id 1evt8L-0000NQ-Or
 for submit <at> debbugs.gnu.org; Tue, 13 Mar 2018 19:15:06 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM,
 FREEMAIL_REPLY autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:48775)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <clement.pitclaudel@HIDDEN>)
 id 1evt8L-0000NJ-LM
 for submit <at> debbugs.gnu.org; Tue, 13 Mar 2018 19:15:05 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36252)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <clement.pitclaudel@HIDDEN>) id 1evt8K-0002ww-Eq
 for bug-gnu-emacs@HIDDEN; Tue, 13 Mar 2018 19:15:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <clement.pitclaudel@HIDDEN>) id 1evt8H-0000Km-Ap
 for bug-gnu-emacs@HIDDEN; Tue, 13 Mar 2018 19:15:04 -0400
Received: from mout.kundenserver.de ([212.227.126.133]:52369)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <clement.pitclaudel@HIDDEN>)
 id 1evt8G-0000Jn-FM
 for bug-gnu-emacs@HIDDEN; Tue, 13 Mar 2018 19:15:00 -0400
Received: from [192.168.1.109] ([73.126.99.55]) by mrelayeu.kundenserver.de
 (mreue001 [212.227.15.168]) with ESMTPSA (Nemesis) id
 0M78fW-1ekOQ81nXS-00x5CR for <bug-gnu-emacs@HIDDEN>; Wed, 14 Mar 2018
 00:14:58 +0100
To: bug-gnu-emacs@HIDDEN
From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= <clement.pitclaudel@HIDDEN>
Subject: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Message-ID: <c2760cec-0a04-2cb0-a5b4-bb7d1df212e5@HIDDEN>
Date: Tue, 13 Mar 2018 19:14:56 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="2dUgDlXT1nLTFGnr6Zrfm5KNbAm10cc3w"
X-Provags-ID: V03:K0:T8vDuQ6cy4RAowwa/B98yGbDsXEc57ynmg5+E1TAjw8DPO93B+I
 pQjv7MhYtAvjtvdi2Y41OfVzp0tKSdtc5TaCZ/xfoBm9K7yn6zJO+X5DvBfLHnfwaD/LqXm
 G7mi6JS4cmSTmig8fnaSXLgTG/CuMg6XCqB07/BzYeWOcdcbZLJuMqSg8V1pmXJgKoGqHlf
 VAHgH0jMd2DvWdP2dnmAw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:CWe0JNnlz98=:1UT0a5umRMKUxnVyhMOHoS
 dBv7aNZwNXSZI32Yh154IhnfNCdePALqNqS+bKyzo2XvDnDtgi1rSBurXuJoGmDy9/X1waxuu
 Qh/kkXeuYhkdlVdYCc9vCvKw+vrN6/lZSAxAH3xOQoXtX/McyD4KrrrZDpWxwJrJagw5vSj+W
 A9GHTK6ghypJWyQytCbcC9IUj2fkeUlt18MZ1kToi2owd56GWUIMd/ueMMJgr0DFvptc42+6a
 nA+YR6dJ2CIYirExI+lTA/Df3tzkLM2GnZDRxkLT7l/5SzwB4Vr2Eaq97uYNG1ANgfarFj6Va
 1Ra94QQG5mtDpx4wEIPMpP863KvEBl+0YywseZwNNI9kmwl1PW7zSiAlLLMGIWk/djfhswyVl
 9EVaPp/Rqx6ZJtK5VoAwb3iHpfxU1nw9tF4Yq+YEnm/tot8o8bXSxY0X5rSYLWzEzd3xhSiuv
 DO3EvSkcVIL2kVTe103W3YD2+tshrNFOfgzHfb6FqLukZtmaE6ltorywkgUGMboKiqzIx7FSF
 PZSrZO9gv2WyoozFULzTxq9inJkNH1pE9OPL6Twk0UMEoZ9CPEeNCtsrR+uHEDauLg6iRRyJK
 zT+Gc4E7RlNols83mOLe53zk3XeMwd3rZNIxyk9uXU1gmkRiOZtns/SvNlITL3IzoEI+pPspV
 LzsH5+BALf7AlqlwyjYOHRlNOscQiOFGFAnmWL4vQMiWru6X+otvTNsuMLksu8xTFiJ1019dQ
 3vD5QGBvFxnoX8D6VvTzRdqFHrsai84uJ7WlWA==
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -3.0 (---)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2dUgDlXT1nLTFGnr6Zrfm5KNbAm10cc3w
Content-Type: multipart/mixed; boundary="jrJr0Ugg7denLsJ6FydG4xoUMBTbEhk7G";
 protected-headers="v1"
From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= <clement.pitclaudel@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Message-ID: <c2760cec-0a04-2cb0-a5b4-bb7d1df212e5@HIDDEN>
Subject: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

--jrJr0Ugg7denLsJ6FydG4xoUMBTbEhk7G
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: quoted-printable

X-Debbugs-CC: jeffersoncarpenter2@HIDDEN

Hi all,

I think the following commit was a bit too enthusiastic, as variables lik=
e @temp are now highlighted in font-lock-type-face.

diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -181,4 +181,5 @@
      ;;
-     ;; Fontify local and my keywords as types.
-     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
+     ;; Fontify declarators and prefixes as types.
+     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersed=
e\\)\\>" . font-lock-type-face) ; declarators
+     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
      ;;

Am I missing something? (I don't speak Perl, so I noticed this in a regre=
ssion test)

Cl=C3=A9ment.



--jrJr0Ugg7denLsJ6FydG4xoUMBTbEhk7G--

--2dUgDlXT1nLTFGnr6Zrfm5KNbAm10cc3w
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJaqFtwAAoJEPqg+cTm90wjjK8P/3TBJ7B/qJ9UnxlUafSHf78K
5BZfs/JCfAkHJ/ihvvJXRgd+vk0iFU1+EgYsKdwezByvOXNcx3hj5G8cwoINtzmX
eKiGKkMGcGCnb6dJ2fjfjzwGFmXXjGCeEK56nyZGCHKCHDvNHU1R0CHungjggNs6
fYheWco1a5ydS9txMdZ6rfsNkRd8Xz8DJpaKdTC0V669lV+3Enus/22BoBrWbs5g
rRhWewK5xsIBUjbQCi3gpBUcNE/bcMAThQjbWhuUSJ0r3X78SdEiSBJ5DKVB5Dfd
PCRGuMVDIB/aXAQkwN8lzlxXAWqC1fHS/RVuFYAynUmXT0GnBw7nkfNDRu9CvJli
s/VE+FsyNfhl7YF8CBsrEN+f7/BLoRyqnnXbWjuM2RHZ9tcTznC2hoRq+1Xj6dWQ
CXgIjJYWqUjTF6BqOomuXEQLgCL+661K/T5zbHmxw/M7D8OIB2uqqWdDdC2Y59gb
3R2uRBz3b9l4JPAAQXG/5gF+elH9Kv2j7P6c0rO1XKSVtbR8b4WcGY9F1UzadpU/
6AspZZzjq3CxYaYgQvR6euLhLuy6tlrytHux0F/Xwkxs7nWBOoZ2THXZ0agvNngf
reFvb1X8/L6z2jhvevF7hZ7cUiEwNGWN7l3wJQAvRdYLJXBfkRgiHZLtAAdKpWX/
sGxzYRdZ6TTr6TlMXvLf
=1C2t
-----END PGP SIGNATURE-----

--2dUgDlXT1nLTFGnr6Zrfm5KNbAm10cc3w--




Acknowledgement sent to Clément Pit-Claudel <clement.pitclaudel@HIDDEN>:
New bug report received and forwarded. Copy sent to jeffersoncarpenter2@HIDDEN, bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to jeffersoncarpenter2@HIDDEN, bug-gnu-emacs@HIDDEN:
bug#30812; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 21 Mar 2018 00:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.