GNU bug report logs - #30812
Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30812 in the body.
You can then email your comments to 30812 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Date: Tue, 13 Mar 2018 19:14:56 -0400

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: jeffersoncarpenter2 <at> gmail.com

Hi all,

I think the following commit was a bit too enthusiastic, as variables like @temp are now highlighted in font-lock-type-face.

diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -181,4 +181,5 @@
      ;;
-     ;; Fontify local and my keywords as types.
-     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
+     ;; Fontify declarators and prefixes as types.
+     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
+     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
      ;;

Am I missing something? (I don't speak Perl, so I noticed this in a regression test)

Clément.

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 30812 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
Cc: 30812 <at> debbugs.gnu.org, jeffersoncarpenter2 <at> gmail.com
Subject: Re: bug#30812: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Date: Tue, 20 Mar 2018 20:26:39 -0400

unarchive 27613
notfixed 27613 26.1
quit

Clément Pit-Claudel <clement.pitclaudel <at> live.com> writes:

> I think the following commit was a bit too enthusiastic, as variables
> like @temp are now highlighted in font-lock-type-face.

I've reverted this from emacs-26 [1: f8cad16bb3].

> -     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
> +     ;; Fontify declarators and prefixes as types.
> +     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
> +     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes

> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)

I missed this in the originating thread, but according to what I'm
getting from web searches, most of those keywords are perl 6 specific.
I think perl-mode shouldn't support them.

[1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
  Revert "Support all perl variable declarators and prefixes"
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>

Message #11 received at 30812 <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 30812 <at> debbugs.gnu.org, jeffersoncarpenter2 <at> gmail.com
Subject: Re: bug#30812: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Date: Wed, 21 Mar 2018 00:21:56 -0400

[Message part 1 (text/plain, inline)]

>> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)
> 
> I missed this in the originating thread, but according to what I'm
> getting from web searches, most of those keywords are perl 6 specific.
> I think perl-mode shouldn't support them.

Thanks.  My understanding was that these keywords could safely be highlighted, as long as care was taken to not highlight variable names (distinguishable due to the sigils).

> 
> [1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
>   Revert "Support all perl variable declarators and prefixes"
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>
> .
> 

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 30812 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Clément Pit-Claudel <clement.pitclaudel <at> live.com>,
 30812 <at> debbugs.gnu.org, jeffersoncarpenter2 <at> gmail.com
Subject: Re: bug#30812: Perl syntax highlighting regression in fix for
 #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Date: Sat, 22 Aug 2020 18:03:30 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:

> Clément Pit-Claudel <clement.pitclaudel <at> live.com> writes:
>
>> I think the following commit was a bit too enthusiastic, as variables
>> like @temp are now highlighted in font-lock-type-face.
>
> I've reverted this from emacs-26 [1: f8cad16bb3].

If I understand this correctly, that means that this bug report was
fixed, so I'm closing it.  If I'm misinterpreting this, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.