Received: (at 30847) by debbugs.gnu.org; 27 Mar 2018 13:19:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 27 09:19:53 2018
Received: from localhost ([127.0.0.1]:55325 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1f0oW0-000695-Qs
for submit <at> debbugs.gnu.org; Tue, 27 Mar 2018 09:19:53 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:51092)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1f0oVy-00068w-Hm
for 30847 <at> debbugs.gnu.org; Tue, 27 Mar 2018 09:19:52 -0400
Received: from localhost (localhost [127.0.0.1])
by hera.aquilenet.fr (Postfix) with ESMTP id 7D65E12627;
Tue, 27 Mar 2018 15:19:49 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id uBLMNBCuWiY3; Tue, 27 Mar 2018 15:19:48 +0200 (CEST)
Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::])
by hera.aquilenet.fr (Postfix) with ESMTPSA id 31B7912621;
Tue, 27 Mar 2018 15:19:48 +0200 (CEST)
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: Adam Van Ymeren <adam@HIDDEN>
Subject: Re: bug#30847: Cannot upgrade GuixSD due to
check-device-initrd-modules
References: <87zi351h0t.fsf@HIDDEN> <87fu4wuhyz.fsf@HIDDEN>
Date: Tue, 27 Mar 2018 15:19:46 +0200
In-Reply-To: <87fu4wuhyz.fsf@HIDDEN> ("Ludovic
\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
\=\?utf-8\?Q\?s\?\= message of "Mon, 19 Mar 2018 17:51:16 +0100")
Message-ID: <87605hwt8t.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 30847
Cc: 30847 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)
Ping! :-)
ludo@HIDDEN (Ludovic Court=C3=A8s) skribis:
> Hello Adam,
>
> Adam Van Ymeren <adam@HIDDEN> skribis:
>
>> My root device is on NVMe.
>>
>> In my current kernel config CONFIG_NVME_CORE is set to a module, which is
>> included in my initrd.
>>
>> However upstream defconfig has been changed to CONFIG_NVME_CORE=3Dy
>
> Out of curiosity, what=E2=80=99s the current and target kernel versions?
>
> Like Danny wrote, =E2=80=98check-device-initrd-modules=E2=80=99 can have =
false positives
> as it is, in which case you have to use =E2=80=98--skip-checks=E2=80=99.
>
> We could arrange to not have false positives, but the UX would be a
> little less good because we=E2=80=99d first need to build the target kern=
el. So
> I wonder how frequent the situation you experienced is.
>
> Thanks for your report!
>
> Ludo=E2=80=99.
bug-guix@HIDDEN:bug#30847; Package guix.
Full text available.Received: (at 30847) by debbugs.gnu.org; 19 Mar 2018 16:51:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 19 12:51:20 2018 Received: from localhost ([127.0.0.1]:42080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1exy0G-0005mG-LL for submit <at> debbugs.gnu.org; Mon, 19 Mar 2018 12:51:20 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:35604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1exy0E-0005m8-R2 for 30847 <at> debbugs.gnu.org; Mon, 19 Mar 2018 12:51:19 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 18B5912412; Mon, 19 Mar 2018 17:51:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xFUu5l910tSg; Mon, 19 Mar 2018 17:51:16 +0100 (CET) Received: from ribbon (unknown [193.50.110.92]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 75AFB123F9; Mon, 19 Mar 2018 17:51:16 +0100 (CET) From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Adam Van Ymeren <adam@HIDDEN> Subject: Re: bug#30847: Cannot upgrade GuixSD due to check-device-initrd-modules References: <87zi351h0t.fsf@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Vent=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 19 Mar 2018 17:51:16 +0100 In-Reply-To: <87zi351h0t.fsf@HIDDEN> (Adam Van Ymeren's message of "Sun, 18 Mar 2018 12:32:18 -0400") Message-ID: <87fu4wuhyz.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30847 Cc: 30847 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.0 (+) Hello Adam, Adam Van Ymeren <adam@HIDDEN> skribis: > My root device is on NVMe. > > In my current kernel config CONFIG_NVME_CORE is set to a module, which is > included in my initrd. > > However upstream defconfig has been changed to CONFIG_NVME_CORE=3Dy Out of curiosity, what=E2=80=99s the current and target kernel versions? Like Danny wrote, =E2=80=98check-device-initrd-modules=E2=80=99 can have fa= lse positives as it is, in which case you have to use =E2=80=98--skip-checks=E2=80=99. We could arrange to not have false positives, but the UX would be a little less good because we=E2=80=99d first need to build the target kernel= . So I wonder how frequent the situation you experienced is. Thanks for your report! Ludo=E2=80=99.
bug-guix@HIDDEN:bug#30847; Package guix.
Full text available.Received: (at 30847) by debbugs.gnu.org; 18 Mar 2018 22:33:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 18 18:33:43 2018 Received: from localhost ([127.0.0.1]:40456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1exgs2-00010J-WB for submit <at> debbugs.gnu.org; Sun, 18 Mar 2018 18:33:43 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:53944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dannym@HIDDEN>) id 1exgs0-000109-Po for 30847 <at> debbugs.gnu.org; Sun, 18 Mar 2018 18:33:41 -0400 Received: from localhost (77.118.190.99.wireless.dyn.drei.com [77.118.190.99]) by dd26836.kasserver.com (Postfix) with ESMTPSA id D32E733600D8; Sun, 18 Mar 2018 23:33:38 +0100 (CET) Date: Sun, 18 Mar 2018 23:33:31 +0100 From: Danny Milosavljevic <dannym@HIDDEN> To: Adam Van Ymeren <adam@HIDDEN> Subject: Re: bug#30847: Cannot upgrade GuixSD due to check-device-initrd-modules Message-ID: <20180318233331.59bc54e1@HIDDEN> In-Reply-To: <87zi351h0t.fsf@HIDDEN> References: <87zi351h0t.fsf@HIDDEN> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/7XU_3qSGwxLb7OPvhDJ78W8"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30847 Cc: 30847 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --Sig_/7XU_3qSGwxLb7OPvhDJ78W8 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adam, On Sun, 18 Mar 2018 12:32:18 -0400 Adam Van Ymeren <adam@HIDDEN> wrote: > Fundamentally I think the problem is that check-device-initrd-modules is > checking modules for the currently running kernel which is not > necessarily the kernel that I will be installing. Yeah, otherwise it would have to build everything first. > At the very least however it would be nice if I could override this > check with a --i-know-what-im-doing flag of some sort. It exists: --skip-checks > It seems odd that check-device-initrd-modules will not prevent your > installation from continuing if it can't find modules.alias, but if it > can find it and you didn't specify the initrd-modules it thinks you need > then it becomes a hard error that you can't override.=20 > Perhaps it should > always be a warning or prompt the user if they want to continue. Yeah, I'd prefer a warning and sleep 5 since the result is not guaranteed t= o be correct. Also it would be possible to build a Frankenstein's monster version where it checks the new kernel config and finds out which modules would be builtin (that would involve a lot of Makefile and Kconfig parsing... ugh). An additional more complete check (with the new kernel etc) at the end would make sense. --Sig_/7XU_3qSGwxLb7OPvhDJ78W8 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqu6TsACgkQ5xo1VCww uqVsoAf+KBvrfuaJ9EMMEz9c5jCaD+4ZQxFo/dT7AbQPewIzVAcZyIs4FCrrA/3h I1Vc8/XkrQUaqC9MrDsS7ExsnFZ10xJFg+szqcr0gxV9q/BHfP6XcVa1mLVui2e7 qWoh/ZDRWIu9W9wjypmofeKoVho2yLMMwZwEuaVFrlrXtpKTEVUpniHYpfiEHXpA JeagG/xqTpJnwQjXswQ4ZdTjXOl6QQWsW3908CQMJx4aMD/kJWohA6ERoAdqKsKH EvYVbt0wu+xkQiyy4aE8y8kJfQOAb/HUsbboBEx4dRf6mKtQ7Gx1tRiXFxlySzcu hz6Tp4zOZittloVea+MaUm6gDxxLEw== =PCYY -----END PGP SIGNATURE----- --Sig_/7XU_3qSGwxLb7OPvhDJ78W8--
bug-guix@HIDDEN:bug#30847; Package guix.
Full text available.
Received: (at submit) by debbugs.gnu.org; 18 Mar 2018 16:32:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 18 12:32:36 2018
Received: from localhost ([127.0.0.1]:40291 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1exbEZ-00019W-Ue
for submit <at> debbugs.gnu.org; Sun, 18 Mar 2018 12:32:36 -0400
Received: from eggs.gnu.org ([208.118.235.92]:46994)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <adam@HIDDEN>) id 1exbEY-00019I-Fo
for submit <at> debbugs.gnu.org; Sun, 18 Mar 2018 12:32:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <adam@HIDDEN>) id 1exbES-0001Ju-BZ
for submit <at> debbugs.gnu.org; Sun, 18 Mar 2018 12:32:29 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:50252)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <adam@HIDDEN>) id 1exbES-0001Jo-8F
for submit <at> debbugs.gnu.org; Sun, 18 Mar 2018 12:32:28 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37957)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <adam@HIDDEN>) id 1exbER-0003aW-2P
for bug-guix@HIDDEN; Sun, 18 Mar 2018 12:32:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <adam@HIDDEN>) id 1exbEN-0001Ik-UI
for bug-guix@HIDDEN; Sun, 18 Mar 2018 12:32:27 -0400
Received: from mail2.vany.ca ([142.54.190.254]:33768)
by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <adam@HIDDEN>) id 1exbEN-0001I5-Op
for bug-guix@HIDDEN; Sun, 18 Mar 2018 12:32:23 -0400
Received: from adamvy-laptop
(CPEac202e0a8da3-CMac202e0a8da0.cpe.net.cable.rogers.com [174.115.45.4])
by mail2.vany.ca (Postfix) with ESMTPSA id EBA5DAC0144
for <bug-guix@HIDDEN>; Sun, 18 Mar 2018 11:32:19 -0500 (CDT)
From: Adam Van Ymeren <adam@HIDDEN>
To: bug-guix@HIDDEN
Subject: Cannot upgrade GuixSD due to check-device-initrd-modules
Date: Sun, 18 Mar 2018 12:32:18 -0400
Message-ID: <87zi351h0t.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
[fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.4 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.4 (----)
My root device is on NVMe.
In my current kernel config CONFIG_NVME_CORE is set to a module, which is
included in my initrd.
However upstream defconfig has been changed to CONFIG_NVME_CORE=y
When trying to guix reconfigure my system, building the operating system
fails in check-device-initrd-modules with the following message
vany/systems.scm:111:10: error: you may need these modules in the initrd for /dev/nvme0n1p2: nvme shpchp
hint: Try adding them to the `initrd-modules' field of your `operating-system' declaration, along these lines:
(operating-system
;; ...
(initrd-modules (append (list "nvme" "shpchp")
%base-initrd-modules)))
If I add initrd-modules to my operating-system, then building the initrd
fails because nvme module cannot be found (as it is not being build as a
module).
Fundamentally I think the problem is that check-device-initrd-modules is
checking modules for the currently running kernel which is not
necessarily the kernel that I will be installing.
At the very least however it would be nice if I could override this
check with a --i-know-what-im-doing flag of some sort.
It seems odd that check-device-initrd-modules will not prevent your
installation from continuing if it can't find modules.alias, but if it
can find it and you didn't specify the initrd-modules it thinks you need
then it becomes a hard error that you can't override. Perhaps it should
always be a warning or prompt the user if they want to continue.
Adam Van Ymeren <adam@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#30847; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.