GNU bug report logs - #30889
[PATCH] gnu: Add pipewalker.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30889 in the body.
You can then email your comments to 30889 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add pipewalker.
Date: Wed, 21 Mar 2018 00:39:30 +0100

* gnu/packages/games.scm (pipewalker): New public variable.
---

Guix,

Here's a little game to waste your time while you should be writing
patches.

Kind regards,

T G-R

 gnu/packages/games.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 9d63930e3..b0a6b2613 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -669,6 +669,46 @@ removed lines to all opponents.  There is also a Demo mode in which you can
 watch your CPU playing while enjoying a cup of tea!")
     (license license:gpl2+)))
 
+(define-public pipewalker
+  (package
+    (name "pipewalker")
+    (version "0.9.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://downloads.sourceforge.net/pipewalker/"
+                           name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1x46wgk0s55562pd96cxagxkn6wpgglq779f9b64ff1k3xzp3myn"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("libpng" ,libpng)
+       ("mesa" ,mesa)
+       ("sdl" ,sdl)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--docdir=" (assoc-ref %outputs "out")
+                            "/share/doc/" ,name "-" ,version))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'configure 'patch-docdir
+           ;; Makefile.in ignores configure's ‘--docdir=...’ option.  Fix that.
+           (lambda _
+             (substitute* "Makefile"
+               (("(pkgdocdatadir = ).*" _ key)
+                (string-append key "$(docdir)\n")))
+             #t)))))
+    (home-page "http://pipewalker.sourceforge.net/")
+    (synopsis "Logical tile puzzle")
+    (description
+     "PipeWalker is a simple puzzle game with many diffent themes: connect all
+computers to one network server, bring water from a source to the taps, etc.
+The underlying mechanism is always the same: you must turn each tile in the
+grid in the right direction to combine all components into a single circuit.
+Every puzzle has a complete solution, although there may be more than one.")
+    (license license:gpl3+)))
+
 (define-public prboom-plus
   (package
    (name "prboom-plus")
-- 
2.15.1

Message #8 received at 30889 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 30889 <at> debbugs.gnu.org
Subject: Re: [bug#30889] [PATCH] gnu: Add pipewalker.
Date: Thu, 22 Mar 2018 00:22:11 +0100

Hi Tobias,

> * gnu/packages/games.scm (pipewalker): New public variable.
> ---
>
> Guix,
>
> Here's a little game to waste your time while you should be writing
> patches.

Yay!

> +(define-public pipewalker
> +  (package
> +    (name "pipewalker")
> +    (version "0.9.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://downloads.sourceforge.net/pipewalker/"
> +                           name "-" version ".tar.gz"))

Could you use the sourceforge mirror here?

> +    (inputs
> +     `(("libpng" ,libpng)
> +       ("mesa" ,mesa)
> +       ("sdl" ,sdl)))
> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "--docdir=" (assoc-ref %outputs "out")
> +                            "/share/doc/" ,name "-" ,version))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'configure 'patch-docdir
> +           ;; Makefile.in ignores configure's ‘--docdir=...’ option.  Fix that.
> +           (lambda _
> +             (substitute* "Makefile"
> +               (("(pkgdocdatadir = ).*" _ key)
> +                (string-append key "$(docdir)\n")))
> +             #t)))))

It’s just a minor irritation for me, but I always expect to see the
“arguments” field right below the build system field, because it defines
arguments for the build system.

> +    (home-page "http://pipewalker.sourceforge.net/")
> +    (synopsis "Logical tile puzzle")
> +    (description
> +     "PipeWalker is a simple puzzle game with many diffent themes: connect all
> +computers to one network server, bring water from a source to the taps, etc.
> +The underlying mechanism is always the same: you must turn each tile in the
> +grid in the right direction to combine all components into a single circuit.
> +Every puzzle has a complete solution, although there may be more than
> one.")

Sounds like fun!

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #11 received at 30889 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 30889 <at> debbugs.gnu.org
Subject: Re: [bug#30889] [PATCH] gnu: Add pipewalker.
Date: Thu, 22 Mar 2018 00:47:07 +0100

Ricardo,

Thanks for the review!

On 2018-03-22 0:22, Ricardo Wurmus wrote:
>> +       (uri (string-append 
>> "http://downloads.sourceforge.net/pipewalker/"
>> +                           name "-" version ".tar.gz"))
> 
> Could you use the sourceforge mirror here?

I had some trouble with a dodgy mirror(?) when I wrote this, hence this 
‘temporary’ workaround[0]. You're right that this should use a mirror.

>> +    (inputs
>> +     `(("libpng" ,libpng)
>> +       ("mesa" ,mesa)
>> +       ("sdl" ,sdl)))
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list (string-append "--docdir=" (assoc-ref %outputs "out")
>> +                            "/share/doc/" ,name "-" ,version))
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'configure 'patch-docdir
>> +           ;; Makefile.in ignores configure's ‘--docdir=...’ option.  
>> Fix that.
>> +           (lambda _
>> +             (substitute* "Makefile"
>> +               (("(pkgdocdatadir = ).*" _ key)
>> +                (string-append key "$(docdir)\n")))
>> +             #t)))))
> 
> It’s just a minor irritation for me, but I always expect to see the
> “arguments” field right below the build system field, because it 
> defines
> arguments for the build system.

Hehe. We seem to have opposite irritations.

I always expect the inputs to follow first, since they're, er, inputs, I 
guess, and often referenced later (;-) in arguments, together with 
things like source and outputs (doesn't the latter also belong at the 
end, then?). At least the inverse is never true.

Of course this is hardly a solid technical argument, if there is one. 
And the single example in the manual does list arguments before inputs.

Damn it.

>> +    (home-page "http://pipewalker.sourceforge.net/")
>> +    (synopsis "Logical tile puzzle")
>> +    (description
>> +     "PipeWalker is a simple puzzle game with many diffent themes: 
>> connect all
>> +computers to one network server, bring water from a source to the 
>> taps, etc.
>> +The underlying mechanism is always the same: you must turn each tile 
>> in the
>> +grid in the right direction to combine all components into a single 
>> circuit.
>> +Every puzzle has a complete solution, although there may be more than
>> one.")
> 
> Sounds like fun!

It beats working.

Kind regards,

T G-R

[0]: I'm aware that it still HTTP-redirects to a mirror. However, this 
worked.

Sent from a Web browser. Excuse or enjoy my brevity.

Message #16 received at 30889-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 30889-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add pipewalker.
Date: Thu, 30 Aug 2018 20:10:35 +0200

Ricardo, Guix,

On 2018-03-22 0:22, Ricardo Wurmus wrote:
> It’s just a minor irritation for me, but I always expect to see 
> the
> “arguments” field right below the build system field, because it 
> defines arguments for the build system.

I have seen the light. Done in 
8294362688096145547464ceaa25edd5cc65d024.

Thanks!

T G-R

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.