GNU bug report logs - #30900
26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30900 in the body.
You can then email your comments to 30900 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Wed, 21 Mar 2018 17:32:53 -0500

Using the new (26.0.91) auth-source-pass-enable function modifies the
auth-sources variable to something isn't specified in :type, resulting
in a type mismatch when looking at the customize-variable buffer for
auth-sources.

Alex

Message #8 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Wed, 21 Mar 2018 19:52:26 -0400

Alex Branham wrote:

> Using the new (26.0.91) auth-source-pass-enable function modifies the
> auth-sources variable to something isn't specified in :type, resulting
> in a type mismatch when looking at the customize-variable buffer for
> auth-sources.

Presumably this auth-sources setting also doesn't work in the next Emacs
instance, unless one manually loads the auth-source-pass library?

Also, there doesn't seem to be any NEWS entry about auth-source-pass.el.

Message #11 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>, Nicolas Petton <nicolas <at> petton.fr>
Cc: Glenn Morris <rgm <at> gnu.org>, alex.branham <at> gmail.com, 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Thu, 22 Mar 2018 09:36:44 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Wed, 21 Mar 2018 19:52:26 -0400
> Cc: 30900 <at> debbugs.gnu.org
> 
> Alex Branham wrote:
> 
> > Using the new (26.0.91) auth-source-pass-enable function modifies the
> > auth-sources variable to something isn't specified in :type, resulting
> > in a type mismatch when looking at the customize-variable buffer for
> > auth-sources.
> 
> Presumably this auth-sources setting also doesn't work in the next Emacs
> instance, unless one manually loads the auth-source-pass library?
> 
> Also, there doesn't seem to be any NEWS entry about auth-source-pass.el.

Damien, Nicolas: could you please look into fixing these issues ASAP?
We are about to make RC1 of Emacs 26.1 very soon.

Thanks.

Message #14 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Eli Zaretskii <eliz <at> gnu.org>, Damien Cassou <damien <at> cassou.me>
Cc: Glenn Morris <rgm <at> gnu.org>, alex.branham <at> gmail.com, 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Thu, 22 Mar 2018 11:12:15 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Damien, Nicolas: could you please look into fixing these issues ASAP?
> We are about to make RC1 of Emacs 26.1 very soon.

Yes, we will.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Eli Zaretskii <eliz <at> gnu.org>, Nicolas Petton <nicolas <at> petton.fr>
Cc: Ted Zlatanov <tzz <at> lifelogs.com>, Glenn Morris <rgm <at> gnu.org>,
 alex.branham <at> gmail.com, 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Fri, 23 Mar 2018 09:39:25 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:
>> > Using the new (26.0.91) auth-source-pass-enable function modifies the
>> > auth-sources variable to something isn't specified in :type, resulting
>> > in a type mismatch when looking at the customize-variable buffer for
>> > auth-sources.
>> 
>> Presumably this auth-sources setting also doesn't work in the next Emacs
>> instance, unless one manually loads the auth-source-pass library?

I think we should sync with Ted, in CC, so that auth-sources
customization type allows external providers. What do you think Ted?

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #20 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: tzz <at> lifelogs.com, rgm <at> gnu.org, nicolas <at> petton.fr, alex.branham <at> gmail.com,
 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Sun, 01 Apr 2018 12:11:52 +0300

Ping!

> From: Damien Cassou <damien <at> cassou.me>
> Cc: Glenn Morris <rgm <at> gnu.org>, alex.branham <at> gmail.com, 30900 <at> debbugs.gnu.org, Ted Zlatanov <tzz <at> lifelogs.com>
> Date: Fri, 23 Mar 2018 09:39:25 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> > Using the new (26.0.91) auth-source-pass-enable function modifies the
> >> > auth-sources variable to something isn't specified in :type, resulting
> >> > in a type mismatch when looking at the customize-variable buffer for
> >> > auth-sources.
> >> 
> >> Presumably this auth-sources setting also doesn't work in the next Emacs
> >> instance, unless one manually loads the auth-source-pass library?
> 
> I think we should sync with Ted, in CC, so that auth-sources
> customization type allows external providers. What do you think Ted?

Message #23 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Damien Cassou <damien <at> cassou.me>
Cc: alex.branham <at> gmail.com, Glenn Morris <rgm <at> gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, Nicolas Petton <nicolas <at> petton.fr>,
 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Mon, 02 Apr 2018 08:56:39 -0400

On Fri, 23 Mar 2018 09:39:25 +0100 Damien Cassou <damien <at> cassou.me> wrote: 

DC> Eli Zaretskii <eliz <at> gnu.org> writes:
>>> > Using the new (26.0.91) auth-source-pass-enable function modifies the
>>> > auth-sources variable to something isn't specified in :type, resulting
>>> > in a type mismatch when looking at the customize-variable buffer for
>>> > auth-sources.
>>> 
>>> Presumably this auth-sources setting also doesn't work in the next Emacs
>>> instance, unless one manually loads the auth-source-pass library?

DC> I think we should sync with Ted, in CC, so that auth-sources
DC> customization type allows external providers. What do you think Ted?

IIUC, we have external providers for the auth-source backends but the
customization types of `auth-sources' are not extensible by the
providers.

I can think of two approaches. We can either allow a typeless
configuration (in addition to the built-ins) to make it easier to
customize any way the user wants, or we can make the :type extensible.
I'm not sure if there's a standard way of doing this in Emacs but if
there is, I'd use it. If not, the typeless approach is probably easier
to support and less surprising.

Ted

Message #26 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: alex.branham <at> gmail.com, Glenn Morris <rgm <at> gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, Nicolas Petton <nicolas <at> petton.fr>,
 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Tue, 03 Apr 2018 15:34:15 +0200

Ted Zlatanov <tzz <at> lifelogs.com> writes:
> IIUC, we have external providers for the auth-source backends but the
> customization types of `auth-sources' are not extensible by the
> providers.


yes


> I can think of two approaches. We can either allow a typeless
> configuration (in addition to the built-ins) to make it easier to
> customize any way the user wants


this should work and is probably the simplest.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #29 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Damien Cassou <damien <at> cassou.me>
Cc: alex.branham <at> gmail.com, Glenn Morris <rgm <at> gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, Nicolas Petton <nicolas <at> petton.fr>,
 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Wed, 04 Apr 2018 14:16:19 -0400

On Tue, 03 Apr 2018 15:34:15 +0200 Damien Cassou <damien <at> cassou.me> wrote: 

DC> Ted Zlatanov <tzz <at> lifelogs.com> writes:
>> IIUC, we have external providers for the auth-source backends but the
>> customization types of `auth-sources' are not extensible by the
>> providers.

DC> yes

>> I can think of two approaches. We can either allow a typeless
>> configuration (in addition to the built-ins) to make it easier to
>> customize any way the user wants

DC> this should work and is probably the simplest.

OK. Since there were no objections:

commit 447da5b0d49b7aa14fa5d6969015770fdf9b9f92
Author: Ted Zlatanov <tzz <at> lifelogs.com>

    * lisp/auth-source.el (auth-sources): Allow sexp customization type

HTH
Ted

Message #34 received at 30900-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: damien <at> cassou.me, rgm <at> gnu.org, nicolas <at> petton.fr, alex.branham <at> gmail.com,
 30900-done <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Wed, 04 Apr 2018 22:17:31 +0300

> From: Ted Zlatanov <tzz <at> lifelogs.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Nicolas Petton <nicolas <at> petton.fr>,  Glenn Morris <rgm <at> gnu.org>,  alex.branham <at> gmail.com,  30900 <at> debbugs.gnu.org
> Date: Wed, 04 Apr 2018 14:16:19 -0400
> 
> OK. Since there were no objections:
> 
> commit 447da5b0d49b7aa14fa5d6969015770fdf9b9f92
> Author: Ted Zlatanov <tzz <at> lifelogs.com>
> 
>     * lisp/auth-source.el (auth-sources): Allow sexp customization type

Thanks, but that should have been done on the release branch, and the
:version tag should have been updated.  I fixed that.

Message #37 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: 30900 <at> debbugs.gnu.org
Cc: eliz <at> gnu.org, alex.branham <at> gmail.com
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Wed, 04 Apr 2018 17:32:21 -0400

On Wed, 04 Apr 2018 22:17:31 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote: 

>> From: Ted Zlatanov <tzz <at> lifelogs.com>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Nicolas Petton <nicolas <at> petton.fr>,  Glenn Morris <rgm <at> gnu.org>,  alex.branham <at> gmail.com,  30900 <at> debbugs.gnu.org
>> Date: Wed, 04 Apr 2018 14:16:19 -0400
>> 
>> OK. Since there were no objections:
>> 
>> commit 447da5b0d49b7aa14fa5d6969015770fdf9b9f92
>> Author: Ted Zlatanov <tzz <at> lifelogs.com>
>> 
>> * lisp/auth-source.el (auth-sources): Allow sexp customization type

EZ> Thanks, but that should have been done on the release branch, and the
EZ> :version tag should have been updated.  I fixed that.

Thank you for your kind help. Does that close the issue?

Ted

Message #40 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 30900 <at> debbugs.gnu.org
Cc: alex.branham <at> gmail.com
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Wed, 04 Apr 2018 18:00:05 -0400

Ted Zlatanov wrote:

> Thank you for your kind help. Does that close the issue?

Changing the :type doesn't help with this:

  Presumably this auth-sources setting also doesn't work in the next Emacs
  instance, unless one manually loads the auth-source-pass library?

Ie the procedure documented in the manual doesn't suffice:

  (setq auth-sources '(password-store))

because auth-source won't know how to handle that mechanism, or any
other external one.

Message #43 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: alex.branham <at> gmail.com, 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Thu, 05 Apr 2018 09:06:24 +0300

> From: Ted Zlatanov <tzz <at> lifelogs.com>
> Cc: eliz <at> gnu.org,  alex.branham <at> gmail.com
> Date: Wed, 04 Apr 2018 17:32:21 -0400
> 
> EZ> Thanks, but that should have been done on the release branch, and the
> EZ> :version tag should have been updated.  I fixed that.
> 
> Thank you for your kind help. Does that close the issue?

Sounds like it doesn't, see Glenn's followup.

Message #46 received at 30900-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: damien <at> cassou.me, Ted Zlatanov <tzz <at> lifelogs.com>,
 30900-done <at> debbugs.gnu.org, nicolas <at> petton.fr, alex.branham <at> gmail.com
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Thu, 05 Apr 2018 06:03:24 -0400

Eli Zaretskii wrote:

> :version tag should have been updated.  I fixed that.

It's not new, nor has the default value changed, so I don't see why
:version should be changed. Anyway, the "No Gnus" comment is now incorrect.

Message #49 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: damien <at> cassou.me, tzz <at> lifelogs.com, 30900 <at> debbugs.gnu.org,
 nicolas <at> petton.fr, alex.branham <at> gmail.com
Subject: Re: bug#30900: 26.0.91;
 auth-source-pass-enable results in customization type mismatch for
 auth-sources
Date: Thu, 05 Apr 2018 13:21:13 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Ted Zlatanov <tzz <at> lifelogs.com>,  damien <at> cassou.me,  nicolas <at> petton.fr,  alex.branham <at> gmail.com,  30900-done <at> debbugs.gnu.org
> Date: Thu, 05 Apr 2018 06:03:24 -0400
> 
> Eli Zaretskii wrote:
> 
> > :version tag should have been updated.  I fixed that.
> 
> It's not new, nor has the default value changed, so I don't see why
> :version should be changed.

It depends on the POV, I guess.  I thought it should change.

> Anyway, the "No Gnus" comment is now incorrect.

Feel free to fix that, and thanks.

Message #54 received at 30900 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: alex.branham <at> gmail.com, 30900 <at> debbugs.gnu.org
Subject: Re: bug#30900: 26.0.91; auth-source-pass-enable results in
 customization type mismatch for auth-sources
Date: Sun, 17 Apr 2022 12:39:59 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> Changing the :type doesn't help with this:
>
>   Presumably this auth-sources setting also doesn't work in the next Emacs
>   instance, unless one manually loads the auth-source-pass library?
>
> Ie the procedure documented in the manual doesn't suffice:
>
>   (setq auth-sources '(password-store))
>
> because auth-source won't know how to handle that mechanism, or any
> other external one.

I've now updated the manual to refer to the correct function.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.