GNU bug report logs - #30925
[PATCH] gnu: Add emacs-puppet-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30925 in the body.
You can then email your comments to 30925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-puppet-mode.
Date: Sat, 24 Mar 2018 15:59:20 +0000

* gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index de0ee358d..a6dc5d866 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2772,6 +2772,30 @@ This provides a basic API and common UI widgets such as popup tooltips
 and popup menus.")
     (license license:gpl3+)))
 
+(define-public emacs-puppet-mode
+  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
+        (revision "1"))
+    (package
+      (name "emacs-puppet-mode")
+      (version (git-version "0.3" revision commit))
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append
+               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
+               commit "/puppet-mode.el"))
+         (sha256
+          (base32
+           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/voxpupuli/puppet-mode")
+      (synopsis "Emacs major mode for the Puppet configuration language")
+      (description
+       "This package provides support for the Puppet configuration language,
+including syntax highlighting, indentation of expressions and statements,
+linting of manifests and integration with Puppet Debugger.")
+      (license license:gpl3+))))
+
 (define-public emacs-god-mode
   (let ((commit "6cf0807b6555eb6fcf8387a4e3b667071ef38964")
         (revision "1"))
-- 
2.16.2

Message #8 received at 30925 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 30925 <at> debbugs.gnu.org
Subject: Re: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Mon, 26 Mar 2018 19:54:05 +0200

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.

[...]
  
> +(define-public emacs-puppet-mode
> +  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
> +        (revision "1"))
> +    (package
> +      (name "emacs-puppet-mode")
> +      (version (git-version "0.3" revision commit))

Maybe mention why we can't take the 0.3 tag?

> +      (source
> +       (origin
> +         (method url-fetch)
> +         (uri (string-append
> +               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
> +               commit "/puppet-mode.el"))

It would be nice to install the README too, but no strong opinion.

> +         (sha256
> +          (base32
> +           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/voxpupuli/puppet-mode")
> +      (synopsis "Emacs major mode for the Puppet configuration language")
> +      (description
> +       "This package provides support for the Puppet configuration language,
> +including syntax highlighting, indentation of expressions and statements,
> +linting of manifests and integration with Puppet Debugger.")
> +      (license license:gpl3+))))

Perhaps mention in a comment that it includes ASL code, as mentioned in
puppet-mode.el.

LGTM otherwise.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30925 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30925 <at> debbugs.gnu.org
Subject: Re: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Thu, 17 May 2018 15:32:10 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
>
> [...]
>   
>> +(define-public emacs-puppet-mode
>> +  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-puppet-mode")
>> +      (version (git-version "0.3" revision commit))
>
> Maybe mention why we can't take the 0.3 tag?
>
>> +      (source
>> +       (origin
>> +         (method url-fetch)
>> +         (uri (string-append
>> +               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
>> +               commit "/puppet-mode.el"))
>
> It would be nice to install the README too, but no strong opinion.
>
>> +         (sha256
>> +          (base32
>> +           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
>> +      (build-system emacs-build-system)
>> +      (home-page "https://github.com/voxpupuli/puppet-mode")
>> +      (synopsis "Emacs major mode for the Puppet configuration language")
>> +      (description
>> +       "This package provides support for the Puppet configuration language,
>> +including syntax highlighting, indentation of expressions and statements,
>> +linting of manifests and integration with Puppet Debugger.")
>> +      (license license:gpl3+))))
>
> Perhaps mention in a comment that it includes ASL code, as mentioned in
> puppet-mode.el.

Hey Marius,

Thanks for taking a look at this. I don't follow about the ASL code
through, what's that?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 30925 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 30925 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-puppet-mode.
Date: Mon, 11 Jun 2018 19:46:21 +0100

* gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9caa01a0f..039f52a56 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3014,6 +3014,33 @@ This provides a basic API and common UI widgets such as popup tooltips
 and popup menus.")
     (license license:gpl3+)))
 
+(define-public emacs-puppet-mode
+  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
+        (revision "1"))
+    (package
+      (name "emacs-puppet-mode")
+      ;; The last release, 0.3 was several years ago, and there have been many
+      ;; commits since
+      (version (git-version "0.3" revision commit))
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append
+               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
+               commit "/puppet-mode.el"))
+         (sha256
+          (base32
+           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/voxpupuli/puppet-mode")
+      (synopsis "Emacs major mode for the Puppet configuration language")
+      (description
+       "This package provides support for the Puppet configuration language,
+including syntax highlighting, indentation of expressions and statements,
+linting of manifests and integration with Puppet Debugger.")
+      ;; Also incorporates work covered by the Apache License, Version 2.0
+      (license license:gpl3+))))
+
 (define-public emacs-god-mode
   (let ((commit "6cf0807b6555eb6fcf8387a4e3b667071ef38964")
         (revision "1"))
-- 
2.17.1

Message #17 received at 30925 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30925 <at> debbugs.gnu.org
Subject: Re: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Mon, 11 Jun 2018 19:54:47 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
>
> [...]
>
>> +(define-public emacs-puppet-mode
>> +  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-puppet-mode")
>> +      (version (git-version "0.3" revision commit))
>
> Maybe mention why we can't take the 0.3 tag?

I've sent a new patch with a comment.

>> +      (source
>> +       (origin
>> +         (method url-fetch)
>> +         (uri (string-append
>> +               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
>> +               commit "/puppet-mode.el"))
>
> It would be nice to install the README too, but no strong opinion.

I've gone for leaving it out for now, just to keep the package simple.

>> +         (sha256
>> +          (base32
>> +           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
>> +      (build-system emacs-build-system)
>> +      (home-page "https://github.com/voxpupuli/puppet-mode")
>> +      (synopsis "Emacs major mode for the Puppet configuration language")
>> +      (description
>> +       "This package provides support for the Puppet configuration language,
>> +including syntax highlighting, indentation of expressions and statements,
>> +linting of manifests and integration with Puppet Debugger.")
>> +      (license license:gpl3+))))
>
> Perhaps mention in a comment that it includes ASL code, as mentioned in
> puppet-mode.el.

I've added this now :)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 30925 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 30925 <at> debbugs.gnu.org
Subject: Re: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Mon, 11 Jun 2018 21:03:40 +0200

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.

LGTM, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 30925-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30925-done <at> debbugs.gnu.org
Subject: Re: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Tue, 12 Jun 2018 07:58:38 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
>
> LGTM, thanks!

Great, I've pushed this now :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.