GNU bug report logs - #31137
27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls?

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Thu, 12 Apr 2018 18:15:02 UTC

Severity: minor

Tags: fixed

Found in version 27.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31137 in the body.
You can then email your comments to 31137 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#31137; Package emacs. (Thu, 12 Apr 2018 18:15:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 12 Apr 2018 18:15:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2
 `Info-find-node' calls?
Date: Thu, 12 Apr 2018 11:14:37 -0700 (PDT)
At the end of `Info-find-node-2' we see this in the second
part of `unwind-protect':

;; If we did not finish finding the specified node,
;; go back to the previous one or to the Top node.
(unless (or Info-current-node no-going-back)
  (if Info-history
     (let ((hist (car Info-history)))
        (setq Info-history (cdr Info-history))
        (Info-find-node (nth 0 hist) (nth 1 hist) t)
        (goto-char (nth 2 hist)))
    (Info-find-node Info-current-file "Top" t)))))

Shouldn't those calls to `Info-find-node' pass along the
received value of arg STRICT-CASE?



In GNU Emacs 27.0.50 (build 3, x86_64-w64-mingw32)
 of 2018-03-21 built on CIRROCUMULUS
Repository revision: e70d0c9e66d7a8609450b2889869d16aeb0363b5
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Read-Only mode enabled in current buffer
Mark saved where search started
Mark set
Quit
Quit
Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install -C 'CFLAGS=-O2 -static -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS THREADS LCMS2




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31137; Package emacs. (Thu, 12 Apr 2018 18:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 31137 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 31137 <at> debbugs.gnu.org
Subject: Re: bug#31137: 27.0.50;
 `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls?
Date: Thu, 12 Apr 2018 21:46:29 +0300
> Date: Thu, 12 Apr 2018 11:14:37 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> ;; If we did not finish finding the specified node,
> ;; go back to the previous one or to the Top node.
> (unless (or Info-current-node no-going-back)
>   (if Info-history
>      (let ((hist (car Info-history)))
>         (setq Info-history (cdr Info-history))
>         (Info-find-node (nth 0 hist) (nth 1 hist) t)
>         (goto-char (nth 2 hist)))
>     (Info-find-node Info-current-file "Top" t)))))
> 
> Shouldn't those calls to `Info-find-node' pass along the
> received value of arg STRICT-CASE?

I don't think it matters, because in both calls the node names are
exact.  We actually might as well force the 4th arg to Info-find-node
be t.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31137; Package emacs. (Thu, 04 Feb 2021 10:24:02 GMT) Full text and rfc822 format available.

Message #11 received at 31137 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31137 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#31137: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in
 last 2 `Info-find-node' calls?
Date: Thu, 04 Feb 2021 11:23:41 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> I don't think it matters, because in both calls the node names are
> exact.  We actually might as well force the 4th arg to Info-find-node
> be t.

Makes sense.  I've now made this change in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 04 Feb 2021 10:24:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 31137 <at> debbugs.gnu.org and Drew Adams <drew.adams <at> oracle.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 04 Feb 2021 10:24:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 04 Mar 2021 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 24 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.