GNU bug report logs - #31141
[PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31141 in the body.
You can then email your comments to 31141 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
Date: Fri, 13 Apr 2018 00:40:06 +0200

* gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
[arguments]: Help configure with locating mit-krb5.
---
 gnu/packages/curl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
index fbf177d9d..38f7195ca 100644
--- a/gnu/packages/curl.scm
+++ b/gnu/packages/curl.scm
@@ -36,6 +36,7 @@
   #:use-module (gnu packages golang)
   #:use-module (gnu packages groff)
   #:use-module (gnu packages gsasl)
+  #:use-module (gnu packages kerberos)
   #:use-module (gnu packages libidn)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages perl)
@@ -60,9 +61,9 @@
    (outputs '("out"
               "doc"))                             ;1.2 MiB of man3 pages
    (inputs `(("gnutls" ,gnutls)
-             ("gss" ,gss)
              ("libidn" ,libidn)
              ("libssh2" ,libssh2)
+             ("mit-krb5" ,mit-krb5)
              ("openldap" ,openldap)
              ("zlib" ,zlib)))
    (native-inputs
@@ -81,7 +82,10 @@
            (separator #f)                         ;single entry
            (files '("etc/ssl/certs/ca-certificates.crt")))))
    (arguments
-    `(#:configure-flags '("--with-gnutls" "--with-gssapi")
+    `(#:configure-flags (list
+                         "--with-gnutls"
+                         (string-append "--with-gssapi="
+                                        (assoc-ref %build-inputs "mit-krb5")))
       ;; Add a phase to patch '/bin/sh' occurances in tests/runtests.pl
       #:phases
       (modify-phases %standard-phases
-- 
2.16.3

Message #8 received at 31141 <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: 31141 <at> debbugs.gnu.org
Subject: Re: bug#31141: Acknowledgement ([PATCH] gnu: curl: Use mit-krb5 as
 GSSAPI implementation.)
Date: Sat, 21 Apr 2018 17:52:28 +0200

[Message part 1 (text/plain, inline)]

Hi,

did anyone have time to have a look on this change?

Is that problematic for you?


Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31141 <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: 31141 <at> debbugs.gnu.org
Cc: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
Date: Sat, 21 Apr 2018 18:10:17 +0200

* gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
[arguments]: Help configure with locating mit-krb5.
---
 gnu/packages/curl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
index ae8b9600d..b5e1f52da 100644
--- a/gnu/packages/curl.scm
+++ b/gnu/packages/curl.scm
@@ -38,6 +38,7 @@
   #:use-module (gnu packages groff)
   #:use-module (gnu packages gsasl)
   #:use-module (gnu packages guile)
+  #:use-module (gnu packages kerberos)
   #:use-module (gnu packages libidn)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages perl)
@@ -62,9 +63,9 @@
    (outputs '("out"
               "doc"))                             ;1.2 MiB of man3 pages
    (inputs `(("gnutls" ,gnutls)
-             ("gss" ,gss)
              ("libidn" ,libidn)
              ("libssh2" ,libssh2)
+             ("mit-krb5" ,mit-krb5)
              ("openldap" ,openldap)
              ("zlib" ,zlib)))
    (native-inputs
@@ -83,7 +84,10 @@
            (separator #f)                         ;single entry
            (files '("etc/ssl/certs/ca-certificates.crt")))))
    (arguments
-    `(#:configure-flags '("--with-gnutls" "--with-gssapi")
+    `(#:configure-flags (list
+                         "--with-gnutls"
+                         (string-append "--with-gssapi="
+                                        (assoc-ref %build-inputs "mit-krb5")))
       ;; Add a phase to patch '/bin/sh' occurances in tests/runtests.pl
       #:phases
       (modify-phases %standard-phases
-- 
2.17.0

Message #14 received at 31141 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Tomáš Čech <sleep_walker <at> gnu.org>
Cc: 31141 <at> debbugs.gnu.org
Subject: Re: [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI
 implementation.
Date: Mon, 23 Apr 2018 14:57:34 +0200

Hello,

Tomáš Čech <sleep_walker <at> gnu.org> skribis:

> * gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
> [arguments]: Help configure with locating mit-krb5.
> ---
>  gnu/packages/curl.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
> index ae8b9600d..b5e1f52da 100644
> --- a/gnu/packages/curl.scm
> +++ b/gnu/packages/curl.scm
> @@ -38,6 +38,7 @@
>    #:use-module (gnu packages groff)
>    #:use-module (gnu packages gsasl)
>    #:use-module (gnu packages guile)
> +  #:use-module (gnu packages kerberos)
>    #:use-module (gnu packages libidn)
>    #:use-module (gnu packages openldap)
>    #:use-module (gnu packages perl)
> @@ -62,9 +63,9 @@
>     (outputs '("out"
>                "doc"))                             ;1.2 MiB of man3 pages
>     (inputs `(("gnutls" ,gnutls)
> -             ("gss" ,gss)
>               ("libidn" ,libidn)
>               ("libssh2" ,libssh2)
> +             ("mit-krb5" ,mit-krb5)

Could you explain the rationale?  In general, if there’s a choice and no
compelling reason to do otherwise, we try to favor the GNU
implementation (in this case, GNU GSS) by default.

Thanks,
Ludo’.

Message #17 received at 31141 <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31141 <at> debbugs.gnu.org
Subject: Re: [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI
 implementation.
Date: Mon, 23 Apr 2018 16:53:45 +0200

[Message part 1 (text/plain, inline)]

Hello,

On Mon, Apr 23, 2018 at 02:57:34PM +0200, Ludovic Courtès wrote:
>Hello,
>
>Tomáš Čech <sleep_walker <at> gnu.org> skribis:
>
>> * gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
>> [arguments]: Help configure with locating mit-krb5.
>> ---
>>  gnu/packages/curl.scm | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
>> index ae8b9600d..b5e1f52da 100644
>> --- a/gnu/packages/curl.scm
>> +++ b/gnu/packages/curl.scm
>> @@ -38,6 +38,7 @@
>>    #:use-module (gnu packages groff)
>>    #:use-module (gnu packages gsasl)
>>    #:use-module (gnu packages guile)
>> +  #:use-module (gnu packages kerberos)
>>    #:use-module (gnu packages libidn)
>>    #:use-module (gnu packages openldap)
>>    #:use-module (gnu packages perl)
>> @@ -62,9 +63,9 @@
>>     (outputs '("out"
>>                "doc"))                             ;1.2 MiB of man3 pages
>>     (inputs `(("gnutls" ,gnutls)
>> -             ("gss" ,gss)
>>               ("libidn" ,libidn)
>>               ("libssh2" ,libssh2)
>> +             ("mit-krb5" ,mit-krb5)
>
>Could you explain the rationale?  In general, if there’s a choice and no
>compelling reason to do otherwise, we try to favor the GNU
>implementation (in this case, GNU GSS) by default.

I am using curl against services with Kerberos authentication. Login
against authority server and obtain ticket proving that I am who I
am. I can use that ticket against services.

I'm not able to do the same with GNU GSS implementation. I might be
wrong but it didn't seem to allow me to do the same at least in the
shape we have it.

After this change it works for me as expected.

Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 31141 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Tomáš Čech <sleep_walker <at> gnu.org>
Cc: 31141 <at> debbugs.gnu.org
Subject: Re: [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI
 implementation.
Date: Mon, 23 Apr 2018 17:24:28 +0200

Hello,

Tomáš Čech <sleep_walker <at> gnu.org> skribis:

> I am using curl against services with Kerberos authentication. Login
> against authority server and obtain ticket proving that I am who I
> am. I can use that ticket against services.
>
> I'm not able to do the same with GNU GSS implementation. I might be
> wrong but it didn't seem to allow me to do the same at least in the
> shape we have it.

I just realized that the equivalent of mit-krb5 would be GNU Shishi, not
GNU GSS.  Does that one work for you?  (Perhaps GSS is still needed in
addition to Shishi though, dunno.)

If not, I have nothing against switching to mit-krb5 if that doesn’t
work either, with a comment explaining it.

Thanks,
Ludo’.

Message #25 received at 31141-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 31141-done <at> debbugs.gnu.org
Subject: Re: [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI
Date: Fri, 10 Apr 2020 01:50:49 +0300

[Message part 1 (text/plain, inline)]

This seems to have been applied with commit
828d3765a71ce1b74d1ab122c84d5c16eabf98b9 in May 2019.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.