GNU bug report logs - #31160
[PATCH] gnu: lvm2: Enable pkg-config files generation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31160 in the body.
You can then email your comments to 31160 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: [PATCH] gnu: lvm2: Enable pkg-config files generation.
Date: Sun, 15 Apr 2018 10:49:28 +0200

* gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
via configure flag.
---
 gnu/packages/linux.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index c09e0474a..c80cadb6c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2121,6 +2121,7 @@ time.")
                                               "/etc/lvm")
                                "--enable-udev_sync"
                                "--enable-udev_rules"
+                               "--enable-pkgconfig"
 
                                ;; Make sure programs such as 'dmsetup' can
                                ;; find libdevmapper.so.
-- 
2.16.3

Message #8 received at 31160 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tomáš Čech <sleep_walker <at> gnu.org>,
 31160 <at> debbugs.gnu.org
Subject: Re: [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
Date: Tue, 17 Apr 2018 00:24:07 +0200

[Message part 1 (text/plain, inline)]

Tomáš Čech <sleep_walker <at> gnu.org> writes:

> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
> via configure flag.

LGTM, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31160 <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31160 <at> debbugs.gnu.org
Subject: Re: [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
Date: Tue, 17 Apr 2018 09:07:42 +0200

[Message part 1 (text/plain, inline)]

On Tue, Apr 17, 2018 at 12:24:07AM +0200, Marius Bakke wrote:
>Tomáš Čech <sleep_walker <at> gnu.org> writes:
>
>> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
>> via configure flag.
>
>LGTM, thanks!

Is it OK for me to push it into master directly? I'm not sure how big
is dependency subtree for such lowlevel package... Is there easy way,
how to print dependency subtree?

Thanks in advance.

Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 31160 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tomáš Čech <sleep_walker <at> gnu.org>
Cc: 31160 <at> debbugs.gnu.org
Subject: Re: [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
Date: Tue, 17 Apr 2018 22:52:26 +0200

[Message part 1 (text/plain, inline)]

Tomáš Čech <sleep_walker <at> gnu.org> writes:

> On Tue, Apr 17, 2018 at 12:24:07AM +0200, Marius Bakke wrote:
>>Tomáš Čech <sleep_walker <at> gnu.org> writes:
>>
>>> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
>>> via configure flag.
>>
>>LGTM, thanks!
>
> Is it OK for me to push it into master directly? I'm not sure how big
> is dependency subtree for such lowlevel package... Is there easy way,
> how to print dependency subtree?

There is!  `guix refresh -l lvm2{,-static}` will tell you exactly how
many packages are affected.  On current 'master', only 37 packages will
be rebuilt.

So it should be fine for the master branch.  It's good if you try to
build some of the dependent packages before pushing however, to make
sure it does not cause any regressions.

Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 31160-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tomáš Čech <sleep_walker <at> gnu.org>
Cc: 31160-done <at> debbugs.gnu.org
Subject: Re: [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
Date: Wed, 29 Aug 2018 17:30:59 -0400

[Message part 1 (text/plain, inline)]

On Sun, Apr 15, 2018 at 10:49:28AM +0200, Tomáš Čech wrote:
> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
> via configure flag.

Pushed as 9324d92e6a3ef030193f43d21a75ca3e88fa90b4

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.