GNU bug report logs - #31222
automake 1.16.1 am__pep3147_tweak bug

Previous Next

Package: automake;

Reported by: Mark Thomas <mthomas <at> cmu.edu>

Date: Fri, 20 Apr 2018 14:56:02 UTC

Severity: normal

Tags: fixed

Done: Mathieu Lirzin <mthl <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31222 in the body.
You can then email your comments to 31222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-automake <at> gnu.org:
bug#31222; Package automake. (Fri, 20 Apr 2018 14:56:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mark Thomas <mthomas <at> cmu.edu>:
New bug report received and forwarded. Copy sent to bug-automake <at> gnu.org. (Fri, 20 Apr 2018 14:56:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Thomas <mthomas <at> cmu.edu>
To: "bug-automake <at> gnu.org" <bug-automake <at> gnu.org>
Subject: automake 1.16.1 am__pep3147_tweak bug
Date: Fri, 20 Apr 2018 13:46:14 +0000
[Message part 1 (text/plain, inline)]
The change to the "am__pep3147_tweak" variable included in <http://git.savannah.gnu.org/cgit/automake.git/commit/?id=006c4dfede96091f5bed622c17946cbec067347f> causes the generated Makefile files not to work on systems (such as macOS) where "sed" interprets "\n" in the substitution text as the letter "n" instead of as a newline.

For example, if I run "make distcheck" in the package created with the attached files, I see that in the uninstall phase it attempts to remove

  rm -f foo.*.pycnfoo.*.pyo

which results in the following error:

ERROR: files left after uninstall:
./lib/python3.6/site-packages/automake_python_test/__pycache__/foo.cpython-36.opt-1.pyc
./lib/python3.6/site-packages/automake_python_test/__pycache__/foo.cpython-36.pyc

A log file containing the output of running configure and make distcheck is attached.

Versions of OS and software:

macOS High Sierra 10.13.4
autoconf (GNU Autoconf) 2.69
automake (GNU automake) 1.16.1

Thanks,

-Mark
[pep3147-bug.log (application/octet-stream, attachment)]
[configure.ac (application/octet-stream, attachment)]
[Makefile.am (application/octet-stream, attachment)]
[foo.py (text/x-python-script, attachment)]

Information forwarded to bug-automake <at> gnu.org:
bug#31222; Package automake. (Sat, 21 Apr 2018 21:09:02 GMT) Full text and rfc822 format available.

Message #8 received at 31222 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: Mark Thomas <mthomas <at> cmu.edu>
Cc: 31222 <at> debbugs.gnu.org
Subject: Re: bug#31222: automake 1.16.1 am__pep3147_tweak bug
Date: Sat, 21 Apr 2018 23:08:41 +0200
[Message part 1 (text/plain, inline)]
Hello Mark,

Mark Thomas <mthomas <at> cmu.edu> writes:

> The change to the "am__pep3147_tweak" variable included in
> <http://git.savannah.gnu.org/cgit/automake.git/commit/?id=006c4dfede96091f5bed622c17946cbec067347f>
> causes the generated Makefile files not to work on systems (such as
> macOS) where "sed" interprets "\n" in the substitution text as the
> letter "n" instead of as a newline.

Interesting. :-)

It seems that using a space instead of a newline work as well.

[sed-no-newline.patch (text/x-patch, inline)]
1 file changed, 1 insertion(+), 1 deletion(-)
lib/am/python.am | 2 +-

modified   lib/am/python.am
@@ -97,7 +97,7 @@ endif %?INSTALL%
 if %?INSTALL%
 
 ?FIRST?am__pep3147_tweak = \
-?FIRST?  sed -e 's|\.py$$||' -e 's|[^/]*$$|&.*.pyc\n&.*.pyo|'
+?FIRST?  sed -e 's|\.py$$||' -e 's|[^/]*$$|&.*.pyc &.*.pyo|'
 
 .PHONY uninstall-am: uninstall-%DIR%PYTHON
 uninstall-%DIR%PYTHON:

[Message part 3 (text/plain, inline)]
Can you confirm it works on your system?

Thanks for the report.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Information forwarded to bug-automake <at> gnu.org:
bug#31222; Package automake. (Mon, 23 Apr 2018 20:30:02 GMT) Full text and rfc822 format available.

Message #11 received at 31222 <at> debbugs.gnu.org (full text, mbox):

From: Mark Thomas <mthomas <at> cmu.edu>
To: Mathieu Lirzin <mthl <at> gnu.org>
Cc: "31222 <at> debbugs.gnu.org" <31222 <at> debbugs.gnu.org>
Subject: Re: bug#31222: automake 1.16.1 am__pep3147_tweak bug
Date: Mon, 23 Apr 2018 20:29:31 +0000
Thank you for the quick reply.

Yes, using a space in place of "\n" works on my system.

Thanks again.

-Mark

________________________________________
From: Mathieu Lirzin <mthl <at> gnu.org>
Sent: Saturday, April 21, 2018 5:08 PM
To: Mark Thomas
Cc: 31222 <at> debbugs.gnu.org
Subject: Re: bug#31222: automake 1.16.1 am__pep3147_tweak bug

Hello Mark,

Mark Thomas <mthomas <at> cmu.edu> writes:

> The change to the "am__pep3147_tweak" variable included in
> <http://git.savannah.gnu.org/cgit/automake.git/commit/?id=006c4dfede96091f5bed622c17946cbec067347f>
> causes the generated Makefile files not to work on systems (such as
> macOS) where "sed" interprets "\n" in the substitution text as the
> letter "n" instead of as a newline.

Interesting. :-)

It seems that using a space instead of a newline work as well.





Information forwarded to bug-automake <at> gnu.org:
bug#31222; Package automake. (Sun, 08 Jul 2018 21:59:01 GMT) Full text and rfc822 format available.

Message #14 received at 31222 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: Mark Thomas <mthomas <at> cmu.edu>
Cc: "31222 <at> debbugs.gnu.org" <31222 <at> debbugs.gnu.org>
Subject: Re: bug#31222: automake 1.16.1 am__pep3147_tweak bug
Date: Sun, 08 Jul 2018 23:58:41 +0200
Mark Thomas <mthomas <at> cmu.edu> writes:

> Yes, using a space in place of "\n" works on my system.

Pushed as commit a348d830659fffd2cfc42994524783b07e69b4b5.

Thanks for the report.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37




Added tag(s) fixed. Request was from Mathieu Lirzin <mthl <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 08 Jul 2018 22:00:02 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 31222 <at> debbugs.gnu.org and Mark Thomas <mthomas <at> cmu.edu> Request was from Mathieu Lirzin <mthl <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 08 Jul 2018 22:00:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 06 Aug 2018 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 236 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.