GNU bug report logs - #31239
Make alsa find its plugins

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31239 in the body.
You can then email your comments to 31239 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Make alsa find its plugins
Date: Sun, 22 Apr 2018 19:13:45 +0200

[Message part 1 (text/plain, inline)]

Hi, this patch adds an environment variable, ALSA_PLUGIN_DIR to allow
it to find its plugins. This is especially useful in GuixSD where
pulseaudio is used by most applications. When running an application
that only knows about alsa, no sound can be output because the card is
taken by pulse. One solution is to use the pulseaudio plugin from
alsa-plugins:pulseaudio and setting ~/.asoundrc:

# Default to PulseAudio
pcm.!default {
    type pulse
    hint {
        show on
        description "Default ALSA Output (currently PulseAudio Sound
Server)" }
}
ctl.!default {
    type pulse
}


But this results in an error because alsa will look for plugins in its
own output directory in the store. With this patch, alsa is able to
find its plugins in ALSA_PLUGIN_DIR after exporting it (export
ALSA_PLUGIN_DIR=$HOME/.guix-profile/lib/alsa-lib).

[0001-gnu-Make-alsa-find-its-plugins-by-setting-ALSA_PLUGI.patch (text/x-patch, attachment)]

Message #8 received at 31239 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 31239 <at> debbugs.gnu.org
Subject: Re: [bug#31239] Make alsa find its plugins
Date: Thu, 17 May 2018 08:01:43 +0200

[Message part 1 (text/plain, inline)]

Hi Julien,

good idea!

The indentation in the patch files is off (alsa-lib uses tabs in its source code).

Also, what is 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch
embedded in this patch for?  Maybe for upstream?  Nice :)

You already patch the individual files in alsa-lib.

Note: It would be possible to use

++      char* plugdir = getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR;

instead of

++      char* plugdir = ALSA_PLUGIN_DIR;
++        char* envplugdir = getenv("ALSA_PLUGIN_DIR");
++        if(envplugdir != NULL)
++            plugdir = envplugdir;

(especially since it's repeated multiple times) but maybe that's too obscure.

So LGTM except for the indentation and extra patch file!

[Message part 2 (application/pgp-signature, inline)]

Message #13 received at 31239-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31239-done <at> debbugs.gnu.org
Subject: Re: [bug#31239] Make alsa find its plugins
Date: Sun, 27 May 2018 19:07:26 +0200

[Message part 1 (text/plain, inline)]

Le Thu, 17 May 2018 08:01:43 +0200,
Danny Milosavljevic <dannym <at> scratchpost.org> a écrit :

> Hi Julien,
> 
> good idea!
> 
> The indentation in the patch files is off (alsa-lib uses tabs in its
> source code).
> 
> Also, what is
> 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch
> embedded in this patch for?  Maybe for upstream?  Nice :)
> 
> You already patch the individual files in alsa-lib.
> 
> Note: It would be possible to use
> 
> ++      char* plugdir = getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR;
> 
> instead of
> 
> ++      char* plugdir = ALSA_PLUGIN_DIR;
> ++        char* envplugdir = getenv("ALSA_PLUGIN_DIR");
> ++        if(envplugdir != NULL)
> ++            plugdir = envplugdir;
> 
> (especially since it's repeated multiple times) but maybe that's too
> obscure.
> 
> So LGTM except for the indentation and extra patch file!

Pushed as 2101cc3fb691f443b830fdf5f846ded5fa018739 on core-updates.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.