GNU bug report logs - #31366
Missing icons in virt-manager user-interface

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31366 in the body.
You can then email your comments to 31366 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: bug-guix <at> gnu.org
Subject: Missing icons in virt-manager user-interface
Date: Fri, 04 May 2018 17:10:56 -0700

[Message part 1 (text/plain, inline)]

Many of the icons appear to be missing from the user interface, such as
the button for "Power on", "Pause the virtual machine", "Shut down the
virtual machine" and "Show virtual hardware details".

Also, selecting the "Show virtual hardware details" nearly all the icons
are missing (e.g. "Overview", "Performance",
"CPUs", "Memory", etc.).


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 31366 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: 31366 <at> debbugs.gnu.org
Subject: Re: Missing icons in virt-manager user-interface
Date: Mon, 27 Aug 2018 16:09:09 -0700

[Message part 1 (text/plain, inline)]

On 2018-05-04, Vagrant Cascadian wrote:
> Many of the icons appear to be missing from the user interface, such as
> the button for "Power on", "Pause the virtual machine", "Shut down the
> virtual machine" and "Show virtual hardware details".
>
> Also, selecting the "Show virtual hardware details" nearly all the icons
> are missing (e.g. "Overview", "Performance",
> "CPUs", "Memory", etc.).

Attached patch that fixes the issue by adding adwaita-icon-theme and
hicolor-icon-theme to propagated-inputs.

live well,
  vagrant

[virt-manager-icons.patch (text/x-diff, inline)]

From 82f11703d0c1c45428fd4667b02e23eb714492de Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Mon, 27 Aug 2018 22:49:30 +0000
Subject: [PATCH] gnu: virt-manager: Add missing icon-theme dependencies.

Fixes <https://bugs.gnu.org/31366>.

* gnu/packages/virtualization.scm (virt-manager) [propagated-inputs]: Add
  adwaita-icon-theme and hicolor-icon-theme.
---
 gnu/packages/virtualization.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 7427465f5..e6948b872 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -634,7 +634,9 @@ virtualization library.")
        ("spice-gtk" ,spice-gtk)))
     ;; virt-manager searches for qemu-img or kvm-img in the PATH.
     (propagated-inputs
-     `(("qemu" ,qemu)))
+     `(("adwaita-icon-theme" ,adwaita-icon-theme)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("qemu" ,qemu)))
     (native-inputs
      `(("glib" ,glib "bin")             ; glib-compile-schemas.
        ("gtk+" ,gtk+ "bin")             ; gtk-update-icon-cache
-- 
2.18.0

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 31366 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: 31366 <at> debbugs.gnu.org
Subject: Re: Missing icons in virt-manager user-interface
Date: Wed, 29 Aug 2018 14:05:45 -0700

[Message part 1 (text/plain, inline)]

On 2018-08-27, Vagrant Cascadian wrote:
> On 2018-05-04, Vagrant Cascadian wrote:
>> Many of the icons appear to be missing from the user interface, such as
>> the button for "Power on", "Pause the virtual machine", "Shut down the
>> virtual machine" and "Show virtual hardware details".
>>
>> Also, selecting the "Show virtual hardware details" nearly all the icons
>> are missing (e.g. "Overview", "Performance",
>> "CPUs", "Memory", etc.).
>
> Attached patch that fixes the issue by adding adwaita-icon-theme and
> hicolor-icon-theme to propagated-inputs.

Apparently, merely installing adwaita-icon-theme and hicolor-icon-theme
into the user's profile also works... not sure if this means it should
be added to propagated-inputs or users are just expected to install
relevent icon-theme packages themselves... ?


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 31366 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 31366 <at> debbugs.gnu.org
Subject: Re: bug#31366: Missing icons in virt-manager user-interface
Date: Wed, 29 Aug 2018 18:24:37 -0400

[Message part 1 (text/plain, inline)]

On Wed, Aug 29, 2018 at 02:05:45PM -0700, Vagrant Cascadian wrote:
> Apparently, merely installing adwaita-icon-theme and hicolor-icon-theme
> into the user's profile also works... not sure if this means it should
> be added to propagated-inputs or users are just expected to install
> relevent icon-theme packages themselves... ?

Yeah, so far it's preferred that users install the icons themselves. I
*thought* this was in the manual but it's not :)

One advantage of asking users to install the icon themes is that it
makes it easier to update the icon themes without having to rebuild many
packages.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 31366 <at> debbugs.gnu.org (full text, mbox):

From: Mike Gerwitz <mtg <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 31366 <at> debbugs.gnu.org
Subject: Re: bug#31366: Missing icons in virt-manager user-interface
Date: Wed, 29 Aug 2018 21:01:15 -0400

[Message part 1 (text/plain, inline)]

On Wed, Aug 29, 2018 at 18:24:37 -0400, Leo Famulari wrote:
> On Wed, Aug 29, 2018 at 02:05:45PM -0700, Vagrant Cascadian wrote:
>> Apparently, merely installing adwaita-icon-theme and hicolor-icon-theme
>> into the user's profile also works... not sure if this means it should
>> be added to propagated-inputs or users are just expected to install
>> relevent icon-theme packages themselves... ?
>
> Yeah, so far it's preferred that users install the icons themselves. I
> *thought* this was in the manual but it's not :)
>
> One advantage of asking users to install the icon themes is that it
> makes it easier to update the icon themes without having to rebuild many
> packages.

That explains why I had this issue in the past and it has since resolved
itself.

I'm sorry if this type of thing has been discussed before (I don't read
every message on the Guix lists), but what about some way of indicating
recommended packages as part of the package definition (a sort of soft
dependency).  Guix could then output to the user after installation that
certain package(s) ought to be installed for things to work optimally.

Guix could then be helpful to the user without expecting the user to
have read all relevant sections of the manual (I have only read portions
so far).  `guix package` maybe could also have a flag to automatically
install recommended packages into the user's profile.

There are strong design considerations here; this is an
oversimplification of the problem.

-- 
Mike Gerwitz

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 31366 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mike Gerwitz <mtg <at> gnu.org>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 31366 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#31366: Missing icons in virt-manager user-interface
Date: Fri, 31 Aug 2018 15:11:49 +0200

Mike Gerwitz <mtg <at> gnu.org> writes:

> I'm sorry if this type of thing has been discussed before (I don't read
> every message on the Guix lists), but what about some way of indicating
> recommended packages as part of the package definition (a sort of soft
> dependency).  Guix could then output to the user after installation that
> certain package(s) ought to be installed for things to work optimally.
>
> Guix could then be helpful to the user without expecting the user to
> have read all relevant sections of the manual (I have only read portions
> so far).  `guix package` maybe could also have a flag to automatically
> install recommended packages into the user's profile.

One way of achieving this is to record recommended packages in the
package’s properties list.  (We use the properties list very rarely
because it easily becomes a grab bag of miscellaneous things that don’t
fit anywhere else.)

Much like we pin search path recommendations to certain “root” packages
we could do something similar for recommended packages.  “glibc”, for
example, could recommend “glibc-locales”; having a package installed
that links with glibc (i.e. all of them) would result in a
recommendation to also install the “glibc-locales” package.  For “gtk+”
the recommendation could be to also install one of the icon themes.
Installing any package depending on “gtk+” would then lead to a
recommendation to install one of these packages.

Unfortunately, some of these recommendations will only be correct when
using Guix on top of a foreign distribution, because we handle common
scenarios on the Guix-based GNU system directly.

--
Ricardo

Message #25 received at 31366 <at> debbugs.gnu.org (full text, mbox):

From: Mike Gerwitz <mtg <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 31366 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#31366: Missing icons in virt-manager user-interface
Date: Fri, 31 Aug 2018 21:12:11 -0400

[Message part 1 (text/plain, inline)]

On Fri, Aug 31, 2018 at 15:11:49 +0200, Ricardo Wurmus wrote:
> Much like we pin search path recommendations to certain “root” packages
> we could do something similar for recommended packages.  “glibc”, for
> example, could recommend “glibc-locales”; having a package installed
> that links with glibc (i.e. all of them) would result in a
> recommendation to also install the “glibc-locales” package.  For “gtk+”
> the recommendation could be to also install one of the icon themes.
> Installing any package depending on “gtk+” would then lead to a
> recommendation to install one of these packages.

That seems like desirable behavior to me.

> Unfortunately, some of these recommendations will only be correct when
> using Guix on top of a foreign distribution, because we handle common
> scenarios on the Guix-based GNU system directly.

I can't comment on that, but in this virt-manager case, I did experience
the issue on GuixSD.

-- 
Mike Gerwitz

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.