GNU bug report logs - #31548
[PATCH] gnu: Add sbcl-stumpwm-checkout.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31548 in the body.
You can then email your comments to 31548 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Tue, 22 May 2018 11:43:32 +0300

* gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
---
 gnu/packages/lisp.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 1f8e6ab42..4c10ec39a 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -987,6 +987,25 @@ productive, customizable lisp based systems.")
     (license license:gpl2+)
     (properties `((ecl-variant . ,(delay ecl-stumpwm))))))
 
+(define-public sbcl-stumpwm-checkout
+  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
+    (package
+      (inherit sbcl-stumpwm)
+      (version (git-version (package-version sbcl-stumpwm) "1" commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/stumpwm/stumpwm.git")
+               (commit commit)))
+         (file-name (git-file-name (package-name sbcl-stumpwm) version))
+         (sha256
+          (base32
+           "1qyvhw73dghs167hcds1k2021w2hakh99zfv0039w7lx259gazl9"))))
+      (inputs
+       `(("sbcl-alexandria" ,sbcl-alexandria)
+         ,@(package-inputs sbcl-stumpwm))))))
+
 (define-public cl-stumpwm
   (sbcl-package->cl-source-package sbcl-stumpwm))
 
-- 
2.17.0

Message #8 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Wed, 23 May 2018 15:03:12 +0200

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.

[...]

> +(define-public sbcl-stumpwm-checkout
> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
> +    (package
> +      (inherit sbcl-stumpwm)
> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))

Could you explain the rationale and write that as a comment?  :-)

As you know we currently avoid packaging unreleased versions unless we
have a good reason to do so (info "(guix) Version Numbers").

TIA!

Ludo’.

Message #11 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Fri, 25 May 2018 13:46:43 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

ludo <at> gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
>
> [...]
>
>> +(define-public sbcl-stumpwm-checkout
>> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
>> +    (package
>> +      (inherit sbcl-stumpwm)
>> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))
>
> Could you explain the rationale and write that as a comment?  :-)
>
> As you know we currently avoid packaging unreleased versions unless we
> have a good reason to do so (info "(guix) Version Numbers").

The reason I want to be it in a Guix package collection is StumpWM
release version (not a release candidate) was published 1 year ago and
since this date there are 250 commits in master branch.

I was using StumpWM builded manually with Quicklisp, but then I switched
to Guix package, because I don't want to build StumpWM manually, but I
found that StumpWM command ‘toggle-always-on-top’ is missing and StumpWM
contrib modules failed to build.

It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib
modules with some dependencies builded with Quicklisp.  :-)  E.g.:

~/.stumpwm.d/init.lisp
--8<---------------cut here---------------start------------->8---
(load "~/quicklisp/setup.lisp")

(set-module-dir "~/.stumpwm.d/modules/")

(ql:quickload "clx-truetype")
(load-module "ttf-fonts")
(xft:cache-fonts)
(set-font (make-instance 'xft:font
                         :family "DejaVu Sans Mono"
                         :subfamily "Book"
                         :size 14))
--8<---------------cut here---------------end--------------->8---

The best solution is to package all StumpWM contrib modules as separate
recipes, but I'm not sure how do it right now because for example
‘sbcl-winner-mode’ package recipe complains about STUMPWM not found.

[Message part 2 (text/x-scheme, attachment)]

[Message part 3 (text/plain, inline)]

--8<---------------cut here---------------start------------->8---
Component :STUMPWM not found, required by #<SYSTEM "winner-mode">
--8<---------------cut here---------------end--------------->8---

[Message part 4 (text/plain, attachment)]

[Message part 5 (text/plain, inline)]

Regards,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Fri, 25 May 2018 18:08:35 +0200

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> Hello Ludovic,
>
> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>>
>>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
>>
>> [...]
>>
>>> +(define-public sbcl-stumpwm-checkout
>>> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
>>> +    (package
>>> +      (inherit sbcl-stumpwm)
>>> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))
>>
>> Could you explain the rationale and write that as a comment?  :-)
>>
>> As you know we currently avoid packaging unreleased versions unless we
>> have a good reason to do so (info "(guix) Version Numbers").
>
> The reason I want to be it in a Guix package collection is StumpWM
> release version (not a release candidate) was published 1 year ago and
> since this date there are 250 commits in master branch.
>
> I was using StumpWM builded manually with Quicklisp, but then I switched
> to Guix package, because I don't want to build StumpWM manually, but I
> found that StumpWM command ‘toggle-always-on-top’ is missing and StumpWM
> contrib modules failed to build.
>
> It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib
> modules with some dependencies builded with Quicklisp.  :-)  E.g.:

OK, that sounds reasonable.

In that case, I’d suggest changing the “name” field to “stumpwm-next” as
we did a few times in the past, so that by default, people still get the
official release.  That and a comment summarizing what you wrote above
and you can go ahead!

Thanks,
Ludo’.

Message #17 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Sun, 17 Jun 2018 00:08:35 +0200

Ping!  :-)

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> Hello Ludovic,
>>
>> ludo <at> gnu.org (Ludovic Courtès) writes:
>>
>>> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>>>
>>>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
>>>
>>> [...]
>>>
>>>> +(define-public sbcl-stumpwm-checkout
>>>> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
>>>> +    (package
>>>> +      (inherit sbcl-stumpwm)
>>>> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))
>>>
>>> Could you explain the rationale and write that as a comment?  :-)
>>>
>>> As you know we currently avoid packaging unreleased versions unless we
>>> have a good reason to do so (info "(guix) Version Numbers").
>>
>> The reason I want to be it in a Guix package collection is StumpWM
>> release version (not a release candidate) was published 1 year ago and
>> since this date there are 250 commits in master branch.
>>
>> I was using StumpWM builded manually with Quicklisp, but then I switched
>> to Guix package, because I don't want to build StumpWM manually, but I
>> found that StumpWM command ‘toggle-always-on-top’ is missing and StumpWM
>> contrib modules failed to build.
>>
>> It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib
>> modules with some dependencies builded with Quicklisp.  :-)  E.g.:
>
> OK, that sounds reasonable.
>
> In that case, I’d suggest changing the “name” field to “stumpwm-next” as
> we did a few times in the past, so that by default, people still get the
> official release.  That and a comment summarizing what you wrote above
> and you can go ahead!
>
> Thanks,
> Ludo’.

Message #20 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Sun, 17 Jun 2018 18:55:41 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Apologies for a long reply.

ludo <at> gnu.org (Ludovic Courtès) writes:

[…]

>> In that case, I’d suggest changing the “name” field to “stumpwm-next” as
>> we did a few times in the past, so that by default, people still get the
>> official release.

Changing “name” field unfortunatelly breaks the build.  I didn't
investigate a reason yet and I don't want to push without changing
“name” field because users will install the “stumpwm-next” by default.

> That and a comment summarizing what you wrote above and you can go ahead!

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: Andy Patterson <ajpatter <at> uwaterloo.ca>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.
Date: Sun, 17 Jun 2018 17:59:16 -0400

Hi Oleg,

On Sun, 17 Jun 2018 18:55:41 +0300
Oleg Pykhalov <go.wigust <at> gmail.com> wrote:

> Hello Ludovic,
> 
> Apologies for a long reply.
> 
> ludo <at> gnu.org (Ludovic Courtès) writes:
> 
> […]
> 
> >> In that case, I’d suggest changing the “name” field to
> >> “stumpwm-next” as we did a few times in the past, so that by
> >> default, people still get the official release.  
> 
> Changing “name” field unfortunatelly breaks the build.  I didn't
> investigate a reason yet and I don't want to push without changing
> “name” field because users will install the “stumpwm-next” by default.

I haven't looked much into your patch, but this might be because the
asdf build system uses the package name to guess where the system will
be defined. If the package name differs from the system name, this
behaviour can be overridden using the #:asd-system-name argument.

Hope that helps,

--
Andy

Message #26 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Andy Patterson <ajpatter <at> uwaterloo.ca>
Cc: 31548 <at> debbugs.gnu.org
Subject: [bug#31548] [PATCH] gnu: sbcl-stumpwm: Update to 18.05.
Date: Tue, 19 Jun 2018 00:39:26 +0300

[Message part 1 (text/plain, inline)]

Hello Andy,

Andy Patterson <ajpatter <at> uwaterloo.ca> writes:

[…]

>> Changing “name” field unfortunatelly breaks the build.  I didn't
>> investigate a reason yet and I don't want to push without changing
>> “name” field because users will install the “stumpwm-next” by default.
>
> I haven't looked much into your patch, but this might be because the
> asdf build system uses the package name to guess where the system will
> be defined. If the package name differs from the system name, this
> behaviour can be overridden using the #:asd-system-name argument.
>
> Hope that helps

It does, thank you.  For the record ‘#:asd-system-name "stumpwm"’.

Upstream pushed a new release.  I'll test it during current week and
push the following patch probably.

[0001-gnu-sbcl-stumpwm-Update-to-18.05.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

I don't know what to do with ‘sbcl-stumpwm-next’ package.  I think we
shouldn't push it because of our policy to stick with stable versions
for recipes.  But anybody fill free to ping me if you need next version.

Regards,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 31548 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 31548-done <at> debbugs.gnu.org
Cc: 31548 <at> debbugs.gnu.org
Subject: Re: [bug#31548] [PATCH] gnu: sbcl-stumpwm: Update to 18.05.
Date: Sun, 24 Jun 2018 01:20:31 +0300

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

[…]

> Upstream pushed a new release.  I'll test it during current week and
> push the following patch probably.

Pushed as abf818bcf59998ba62ae7bfb2d03c28d7cffaa42

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.