GNU bug report logs - #31570
[PATCH 0/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.

Previous Next

Package: guix-patches;

Reported by: Alex Vong <alexvong1995 <at> gmail.com>

Date: Wed, 23 May 2018 17:13:02 UTC

Severity: normal

Tags: patch

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31570 in the body.
You can then email your comments to 31570 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Wed, 23 May 2018 17:13:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alex Vong <alexvong1995 <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 23 May 2018 17:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap
 binary.
Date: Thu, 24 May 2018 01:12:29 +0800
[Message part 1 (text/plain, inline)]
Tags: patch

Hello,

This patch set will cause javacc to bootstrap from javacc-4 instead of
the bundled bootstrap jar. The next step would be to figure out how to
bootstrap javacc-4 by hand, which would be challenging I think...

Cheers,
Alex
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Wed, 23 May 2018 17:17:01 GMT) Full text and rfc822 format available.

Message #8 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: 31570 <at> debbugs.gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH 1/2] gnu: javacc: 'javacc' now inherits from 'javacc-4'.
Date: Thu, 24 May 2018 01:16:33 +0800
[0001-gnu-javacc-javacc-now-inherits-from-javacc-4.patch (text/x-diff, inline)]
From f9a32516aab9aca1b8797e685623ac8cfb188535 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Thu, 24 May 2018 00:21:49 +0800
Subject: [PATCH 1/2] gnu: javacc: 'javacc' now inherits from 'javacc-4'.

* gnu/packages/java.scm (javacc, javacc-4): 'javacc' now inherits from
'javacc-4' instead of the opposite around.
---
 gnu/packages/java.scm | 47 ++++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 90fd07c59..c64313046 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1861,27 +1861,31 @@ designs.")
                      license:asl2.0
                      license:cpl1.0)))))
 
-(define-public javacc
+(define-public javacc-4
   (package
     (name "javacc")
-    (version "7.0.3")
+    (version "4.1")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/javacc/javacc/"
-                                  "archive/" version ".tar.gz"))
-              (file-name (string-append "javacc-" version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/javacc/javacc.git")
+                    (commit "release_41")))
+              (file-name (string-append "javacc-" version "-checkout"))
               (sha256
                (base32
-                "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))))
+                "07ysav7j8r1c6h8qxrgqk6lwdp74ly0ad1935lragxml0qqc3ka0"))))
     (build-system ant-build-system)
+    ;; Tests fail with
+    ;; /tmp/guix-build-javacc-4.1.drv-0/source/test/javacodeLA/build.xml:60:
+    ;; JAVACODE failed
     (arguments
-     `(#:test-target "test"
+     `(#:tests? #f
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'delete-bundled-libs
            (lambda _
              (delete-file-recursively "lib") #t))
-         (replace 'install (install-jars "target")))))
+         (replace 'install (install-jars "bin/lib")))))
     (home-page "https://javacc.org/")
     (synopsis "Java parser generator")
     (description "Java Compiler Compiler (JavaCC) is the most popular parser
@@ -1893,29 +1897,26 @@ as tree building (via a tool called JJTree included with JavaCC), actions,
 debugging, etc.")
     (license license:bsd-3)))
 
-(define-public javacc-4
-  (package (inherit javacc)
-    (version "4.1")
+(define-public javacc
+  (package
+    (inherit javacc-4)
+    (version "7.0.3")
     (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/javacc/javacc.git")
-                    (commit "release_41")))
-              (file-name (string-append "javacc-" version "-checkout"))
+              (method url-fetch)
+              (uri (string-append "https://github.com/javacc/javacc/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append "javacc-" version ".tar.gz"))
               (sha256
                (base32
-                "07ysav7j8r1c6h8qxrgqk6lwdp74ly0ad1935lragxml0qqc3ka0"))))
-    ;; Tests fail with
-    ;; /tmp/guix-build-javacc-4.1.drv-0/source/test/javacodeLA/build.xml:60:
-    ;; JAVACODE failed
+                "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))))
     (arguments
-     `(#:tests? #f
+     `(#:test-target "test"
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'delete-bundled-libs
            (lambda _
              (delete-file-recursively "lib") #t))
-         (replace 'install (install-jars "bin/lib")))))))
+         (replace 'install (install-jars "target")))))))
 
 ;; This is the last 3.x release of ECJ
 (define-public java-ecj-3
-- 
2.17.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Wed, 23 May 2018 17:18:01 GMT) Full text and rfc822 format available.

Message #11 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: 31570 <at> debbugs.gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH 2/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap
 binary.
Date: Thu, 24 May 2018 01:17:46 +0800
[0002-gnu-javacc-Bootstrap-from-javacc-4-instead-of-bootst.patch (text/x-diff, inline)]
From 567852350ba03246253218e56d87e5ab13e4bfaf Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Thu, 24 May 2018 00:32:51 +0800
Subject: [PATCH 2/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap
 binary.

* gnu/packages/java.scm (javacc)[arguments]: Use javacc-4, remove bootstrap
binary.
[native-inputs]: Add 'javacc-4'.
---
 gnu/packages/java.scm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index c64313046..9ee795aba 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1910,13 +1910,21 @@ debugging, etc.")
                (base32
                 "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))))
     (arguments
-     `(#:test-target "test"
+     `(#:make-flags ; bootstrap from javacc-4
+       (list (string-append "-Dbootstrap-jar="
+                            (assoc-ref %build-inputs "javacc")
+                            "/share/java/javacc.jar"))
+       #:test-target "test"
        #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'delete-bundled-libs
+         (add-after 'unpack 'delete-bundled-jars
            (lambda _
-             (delete-file-recursively "lib") #t))
-         (replace 'install (install-jars "target")))))))
+             (delete-file-recursively "bootstrap")
+             (delete-file-recursively "lib")
+             #t))
+         (replace 'install (install-jars "target")))))
+    (native-inputs
+     `(("javacc" ,javacc-4)))))
 
 ;; This is the last 3.x release of ECJ
 (define-public java-ecj-3
-- 
2.17.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Thu, 24 May 2018 09:23:02 GMT) Full text and rfc822 format available.

Message #14 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 31570 <at> debbugs.gnu.org
Subject: Re: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4
 instead of bootstrap binary.
Date: Thu, 24 May 2018 11:22:22 +0200
Hi Alex,

> This patch set will cause javacc to bootstrap from javacc-4 instead of
> the bundled bootstrap jar. The next step would be to figure out how to
> bootstrap javacc-4 by hand, which would be challenging I think...

Thanks for this.

The patches look fine to me.

>         (modify-phases %standard-phases
> -         (add-after 'unpack 'delete-bundled-libs
> +         (add-after 'unpack 'delete-bundled-jars
>             (lambda _
> -             (delete-file-recursively "lib") #t))
> -         (replace 'install (install-jars "target")))))))
> +             (delete-file-recursively "bootstrap")
> +             (delete-file-recursively "lib")
> +             #t))

Can we delete these things in a snippet instead?

(I vaguely remember that we didn’t use snippets for jars because
patch-and-repack wouldn’t support the jar format, but I don’t know if
that’s still the case.)

-- 
Ricardo




Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Thu, 24 May 2018 19:56:01 GMT) Full text and rfc822 format available.

Message #17 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: alexvong1995 <at> gmail.com, 31570 <at> debbugs.gnu.org
Subject: Re: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4
 instead of bootstrap binary.
Date: Fri, 25 May 2018 03:55:36 +0800
[Message part 1 (text/plain, inline)]
Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de> writes:

[...]
> Can we delete these things in a snippet instead?
>
> (I vaguely remember that we didn’t use snippets for jars because
> patch-and-repack wouldn’t support the jar format, but I don’t know if
> that’s still the case.)

Indeed, it fails to build if I switch to use snippet. But I manage to
fix it by adding java-junit to native-inputs :) (since the error message
seems to be related to some missing junit symbols). Will send a revised
patch series later.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Fri, 25 May 2018 00:20:02 GMT) Full text and rfc822 format available.

Message #20 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: alexvong1995 <at> gmail.com, 31570 <at> debbugs.gnu.org
Subject: Re: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4
 instead of bootstrap binary.
Date: Fri, 25 May 2018 08:19:34 +0800
[Message part 1 (text/plain, inline)]
Alex Vong <alexvong1995 <at> gmail.com> writes:

> Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de> writes:
>
> [...]
>> Can we delete these things in a snippet instead?
>>
>> (I vaguely remember that we didn’t use snippets for jars because
>> patch-and-repack wouldn’t support the jar format, but I don’t know if
>> that’s still the case.)
>
> Indeed, it fails to build if I switch to use snippet. But I manage to
> fix it by adding java-junit to native-inputs :) (since the error message
> seems to be related to some missing junit symbols). Will send a revised
> patch series later.

I decide to remove the tests instead of adding junit to native-inputs
since we are not running the tests for javacc-4 anyway. Here come the
patch series:
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Fri, 25 May 2018 00:22:02 GMT) Full text and rfc822 format available.

Message #23 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: 31570 <at> debbugs.gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH 1/3] gnu: javacc: 'javacc' now inherits from 'javacc-4'.
Date: Fri, 25 May 2018 08:21:27 +0800
[0001-gnu-javacc-javacc-now-inherits-from-javacc-4.patch (text/x-diff, inline)]
From b46255b724c72d46c9c5f5418eaf7117de22ba92 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Thu, 24 May 2018 00:21:49 +0800
Subject: [PATCH 1/3] gnu: javacc: 'javacc' now inherits from 'javacc-4'.

* gnu/packages/java.scm (javacc, javacc-4): 'javacc' now inherits from
'javacc-4' instead of the opposite around.
---
 gnu/packages/java.scm | 47 ++++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 90fd07c59..c64313046 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1861,27 +1861,31 @@ designs.")
                      license:asl2.0
                      license:cpl1.0)))))
 
-(define-public javacc
+(define-public javacc-4
   (package
     (name "javacc")
-    (version "7.0.3")
+    (version "4.1")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/javacc/javacc/"
-                                  "archive/" version ".tar.gz"))
-              (file-name (string-append "javacc-" version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/javacc/javacc.git")
+                    (commit "release_41")))
+              (file-name (string-append "javacc-" version "-checkout"))
               (sha256
                (base32
-                "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))))
+                "07ysav7j8r1c6h8qxrgqk6lwdp74ly0ad1935lragxml0qqc3ka0"))))
     (build-system ant-build-system)
+    ;; Tests fail with
+    ;; /tmp/guix-build-javacc-4.1.drv-0/source/test/javacodeLA/build.xml:60:
+    ;; JAVACODE failed
     (arguments
-     `(#:test-target "test"
+     `(#:tests? #f
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'delete-bundled-libs
            (lambda _
              (delete-file-recursively "lib") #t))
-         (replace 'install (install-jars "target")))))
+         (replace 'install (install-jars "bin/lib")))))
     (home-page "https://javacc.org/")
     (synopsis "Java parser generator")
     (description "Java Compiler Compiler (JavaCC) is the most popular parser
@@ -1893,29 +1897,26 @@ as tree building (via a tool called JJTree included with JavaCC), actions,
 debugging, etc.")
     (license license:bsd-3)))
 
-(define-public javacc-4
-  (package (inherit javacc)
-    (version "4.1")
+(define-public javacc
+  (package
+    (inherit javacc-4)
+    (version "7.0.3")
     (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/javacc/javacc.git")
-                    (commit "release_41")))
-              (file-name (string-append "javacc-" version "-checkout"))
+              (method url-fetch)
+              (uri (string-append "https://github.com/javacc/javacc/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append "javacc-" version ".tar.gz"))
               (sha256
                (base32
-                "07ysav7j8r1c6h8qxrgqk6lwdp74ly0ad1935lragxml0qqc3ka0"))))
-    ;; Tests fail with
-    ;; /tmp/guix-build-javacc-4.1.drv-0/source/test/javacodeLA/build.xml:60:
-    ;; JAVACODE failed
+                "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))))
     (arguments
-     `(#:tests? #f
+     `(#:test-target "test"
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'delete-bundled-libs
            (lambda _
              (delete-file-recursively "lib") #t))
-         (replace 'install (install-jars "bin/lib")))))))
+         (replace 'install (install-jars "target")))))))
 
 ;; This is the last 3.x release of ECJ
 (define-public java-ecj-3
-- 
2.17.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Fri, 25 May 2018 00:23:02 GMT) Full text and rfc822 format available.

Message #26 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: 31570 <at> debbugs.gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH 2/3] gnu: javacc: Use snippet to delete bundled jars.
Date: Fri, 25 May 2018 08:22:29 +0800
[0002-gnu-javacc-Use-snippet-to-delete-bundled-jars.patch (text/x-diff, inline)]
From 16079becafbd7d9272f68a9d91412846697e3626 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Fri, 25 May 2018 07:43:42 +0800
Subject: [PATCH 2/3] gnu: javacc: Use snippet to delete bundled jars.

* gnu/packages/java.scm (javacc-4)[source](snippet, modules): New fields.
[arguments]: Remove 'delete-bundled-libs' phase and add 'delete-tests'
phase.
* gnu/packages/java.scm (javacc)[source](snippet, modules): New fields.
[arguments]: Remove 'delete-bundled-libs' phase.
---
 gnu/packages/java.scm | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index c64313046..ce4a6b8ac 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1873,7 +1873,10 @@ designs.")
               (file-name (string-append "javacc-" version "-checkout"))
               (sha256
                (base32
-                "07ysav7j8r1c6h8qxrgqk6lwdp74ly0ad1935lragxml0qqc3ka0"))))
+                "07ysav7j8r1c6h8qxrgqk6lwdp74ly0ad1935lragxml0qqc3ka0"))
+              (modules '((guix build utils)))
+              ;; delete bundled jars
+              (snippet '(begin (delete-file-recursively "lib") #t))))
     (build-system ant-build-system)
     ;; Tests fail with
     ;; /tmp/guix-build-javacc-4.1.drv-0/source/test/javacodeLA/build.xml:60:
@@ -1882,9 +1885,18 @@ designs.")
      `(#:tests? #f
        #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'delete-bundled-libs
+         ;; Delete tests to avoid build failure (we don't run them anyway).
+         (add-after 'unpack 'delete-tests
            (lambda _
-             (delete-file-recursively "lib") #t))
+             (for-each delete-file
+                       '("src/org/javacc/JavaCCTestCase.java"
+                         "src/org/javacc/parser/ExpansionTest.java"
+                         "src/org/javacc/parser/OptionsTest.java"
+                         "src/org/javacc/jjtree/JJTreeOptionsTest.java"))
+             (for-each delete-file-recursively
+                       '("src/org/javacc/parser/test"
+                         "src/org/javacc/jjdoc/test"))
+             #t))
          (replace 'install (install-jars "bin/lib")))))
     (home-page "https://javacc.org/")
     (synopsis "Java parser generator")
@@ -1908,14 +1920,14 @@ debugging, etc.")
               (file-name (string-append "javacc-" version ".tar.gz"))
               (sha256
                (base32
-                "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))))
+                "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))
+              (modules '((guix build utils)))
+              ;; delete bundled jars
+              (snippet '(begin (delete-file-recursively "lib") #t))))
     (arguments
      `(#:test-target "test"
        #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'delete-bundled-libs
-           (lambda _
-             (delete-file-recursively "lib") #t))
          (replace 'install (install-jars "target")))))))
 
 ;; This is the last 3.x release of ECJ
-- 
2.17.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Fri, 25 May 2018 00:24:01 GMT) Full text and rfc822 format available.

Message #29 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: 31570 <at> debbugs.gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH 3/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap
 binary.
Date: Fri, 25 May 2018 08:23:20 +0800
[0003-gnu-javacc-Bootstrap-from-javacc-4-instead-of-bootst.patch (text/x-diff, inline)]
From 5e84c4dc3a36fa304277801f4e259aa795cf92e3 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Thu, 24 May 2018 00:32:51 +0800
Subject: [PATCH 3/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap
 binary.

* gnu/packages/java.scm (javacc)[source](snippet): Delete bootstrap binary.
[arguments]: Set 'bootstrap-jar' path.
[native-inputs]: Add 'javacc-4'.
---
 gnu/packages/java.scm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index ce4a6b8ac..5bcd94022 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1923,12 +1923,20 @@ debugging, etc.")
                 "111xc9mnmc5a6qz6x3xbhqc07y1lg2b996ggzw0hrblg42zya9xf"))
               (modules '((guix build utils)))
               ;; delete bundled jars
-              (snippet '(begin (delete-file-recursively "lib") #t))))
-    (arguments
-     `(#:test-target "test"
+              (snippet '(begin (for-each delete-file-recursively
+                                         '("bootstrap" "lib"))
+                               #t))))
+    (arguments
+     `(#:make-flags ; bootstrap from javacc-4
+       (list (string-append "-Dbootstrap-jar="
+                            (assoc-ref %build-inputs "javacc")
+                            "/share/java/javacc.jar"))
+       #:test-target "test"
        #:phases
        (modify-phases %standard-phases
-         (replace 'install (install-jars "target")))))))
+         (replace 'install (install-jars "target")))))
+    (native-inputs
+     `(("javacc" ,javacc-4)))))
 
 ;; This is the last 3.x release of ECJ
 (define-public java-ecj-3
-- 
2.17.0

[signature.asc (application/pgp-signature, inline)]

Changed bug title to '[PATCH 3/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.' from '[PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.' Request was from Alex Vong <alexvong1995 <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 25 May 2018 00:27:02 GMT) Full text and rfc822 format available.

Changed bug title to '[PATCH 0/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.' from '[PATCH 3/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.' Request was from Alex Vong <alexvong1995 <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 25 May 2018 00:31:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Tue, 03 Jul 2018 12:46:02 GMT) Full text and rfc822 format available.

Message #36 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Re: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4
 instead of bootstrap binary.
Date: Tue, 03 Jul 2018 14:44:49 +0200
Le 2018-05-23 19:12, Alex Vong a écrit :
> Tags: patch
> 
> Hello,
> 
> This patch set will cause javacc to bootstrap from javacc-4 instead of
> the bundled bootstrap jar. The next step would be to figure out how to
> bootstrap javacc-4 by hand, which would be challenging I think...
> 
> Cheers,
> Alex

Hi Alex,

What's the status of this patch series? Do you think you can push them?




Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Wed, 17 Oct 2018 21:48:01 GMT) Full text and rfc822 format available.

Message #39 received at 31570 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: 31570 <at> debbugs.gnu.org
Cc: Julien Lepiller <julien <at> lepiller.eu>,
 Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>, alexvong1995 <at> gmail.com
Subject: Re: [PATCH 0/3] gnu: javacc: Bootstrap from javacc-4 instead of
 bootstrap binary.
Date: Thu, 18 Oct 2018 05:47:33 +0800
[Message part 1 (text/plain, inline)]
(Re-sending to the right place.)

Hello Julien,

I have tested the patches just now. All of them still apply. But I don't
have push right. Can someone please push it for me?

Thanks,
Alex
[signature.asc (application/pgp-signature, inline)]

Reply sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
You have taken responsibility. (Thu, 18 Oct 2018 15:05:01 GMT) Full text and rfc822 format available.

Notification sent to Alex Vong <alexvong1995 <at> gmail.com>:
bug acknowledged by developer. (Thu, 18 Oct 2018 15:05:02 GMT) Full text and rfc822 format available.

Message #44 received at 31570-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 31570-done <at> debbugs.gnu.org, Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Subject: Re: [bug#31570] [PATCH 0/3] gnu: javacc: Bootstrap from javacc-4
 instead of bootstrap binary.
Date: Thu, 18 Oct 2018 17:03:55 +0200
[Message part 1 (text/plain, inline)]
Hi Alex,

On Thu, 18 Oct 2018 05:47:33 +0800
Alex Vong <alexvong1995 <at> gmail.com> wrote:

> I have tested the patches just now. All of them still apply. But I don't
> have push right. Can someone please push it for me?

Pushed as 33428d12672fefde745b313ce1f0c02ae9870e39, 6662d65f96b948271eeaa0ba5c93d0e61663e7d3, 53fb0476ec4e5df9511490aaf8c3c70ba68aa83b.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31570; Package guix-patches. (Thu, 18 Oct 2018 15:19:01 GMT) Full text and rfc822 format available.

Message #47 received at 31570-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 31570-done <at> debbugs.gnu.org, Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>,
 alexvong1995 <at> gmail.com
Subject: Re: [bug#31570] [PATCH 0/3] gnu: javacc: Bootstrap from javacc-4
 instead of bootstrap binary.
Date: Thu, 18 Oct 2018 23:17:47 +0800
[Message part 1 (text/plain, inline)]
Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> Hi Alex,
>
> On Thu, 18 Oct 2018 05:47:33 +0800
> Alex Vong <alexvong1995 <at> gmail.com> wrote:
>
>> I have tested the patches just now. All of them still apply. But I don't
>> have push right. Can someone please push it for me?
>
> Pushed as 33428d12672fefde745b313ce1f0c02ae9870e39,
> 6662d65f96b948271eeaa0ba5c93d0e61663e7d3,
> 53fb0476ec4e5df9511490aaf8c3c70ba68aa83b.

Thanks for taking care of it!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 16 Nov 2018 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 134 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.