GNU bug report logs - #31794
26.1; dired-do-shell-command broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31794 in the body.
You can then email your comments to 31794 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; dired-do-shell-command broken
Date: Tue, 12 Jun 2018 12:24:09 +0800

1. emacs -q
2. in dired mode press !
3. C-h v

Step 3 should give you no completion. Another issue is when
icomplete-mode is on one constantly gets "No matches" for every input.

This is due to the following change.

commit c2a8cffe8044cc38c4cf1b5c3d1c9571ddeec623
Date:   Sun Aug 6 10:15:17 2017 -0400

    ; Fix previous commit
    
    The mailcap minibuffer completion used dynamic binding.  Locally set
    a dynamic variable.
    * lisp/dired-aux.el: Store list of files in
    `minibuffer-completion-table'.

I intend to fix the issue on emacs-26 with the following patch. Comments?

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index c336103f..516cd2c5 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -614,14 +614,16 @@ with a prefix argument."
 
 (declare-function mailcap-file-default-commands "mailcap" (files))
 
+(defvar dired-aux-files)
+
 (defun minibuffer-default-add-dired-shell-commands ()
   "Return a list of all commands associated with current dired files.
 This function is used to add all related commands retrieved by `mailcap'
 to the end of the list of defaults just after the default value."
   (interactive)
-  (let* ((files minibuffer-completion-table)
-         (commands (and (require 'mailcap nil t)
-                        (mailcap-file-default-commands files))))
+  (let ((commands (and (boundp 'dired-aux-files)
+		       (require 'mailcap nil t)
+		       (mailcap-file-default-commands dired-aux-files))))
     (if (listp minibuffer-default)
 	(append minibuffer-default commands)
       (cons minibuffer-default commands))))
@@ -639,9 +641,9 @@ This normally reads using `read-shell-command', but if the
 offer a smarter default choice of shell command."
   (minibuffer-with-setup-hook
       (lambda ()
-        (set (make-local-variable 'minibuffer-completion-table) files)
-	(set (make-local-variable 'minibuffer-default-add-function)
-	     'minibuffer-default-add-dired-shell-commands))
+	(setq-local dired-aux-files files)
+	(setq-local minibuffer-default-add-function
+		    #'minibuffer-default-add-dired-shell-commands))
     (setq prompt (format prompt (dired-mark-prompt arg files)))
     (if (functionp 'dired-guess-shell-command)
 	(dired-mark-pop-up nil 'shell files

Message #8 received at 31794 <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 31794 <at> debbugs.gnu.org
Subject: Re: bug#31794: 26.1; dired-do-shell-command broken
Date: Tue, 19 Jun 2018 07:40:51 -0400

On Tue, Jun 12, 2018 at 12:24 AM, Leo Liu <sdl.web <at> gmail.com> wrote:
>
> 1. emacs -q
> 2. in dired mode press !
> 3. C-h v
>
> Step 3 should give you no completion. Another issue is when
> icomplete-mode is on one constantly gets "No matches" for every input.
>
> This is due to the following change.
>
> commit c2a8cffe8044cc38c4cf1b5c3d1c9571ddeec623
> Date:   Sun Aug 6 10:15:17 2017 -0400
>
>     ; Fix previous commit
>
>     The mailcap minibuffer completion used dynamic binding.  Locally set
>     a dynamic variable.
>     * lisp/dired-aux.el: Store list of files in
>     `minibuffer-completion-table'.
>
> I intend to fix the issue on emacs-26 with the following patch. Comments?

Nope, looks fine to me.

Message #11 received at 31794 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: sdl.web <at> gmail.com, 31794 <at> debbugs.gnu.org
Subject: Re: bug#31794: 26.1; dired-do-shell-command broken
Date: Sat, 23 Jun 2018 16:18:21 +0300

> From: Mark Oteiza <mvoteiza <at> udel.edu>
> Date: Tue, 19 Jun 2018 07:40:51 -0400
> Cc: 31794 <at> debbugs.gnu.org
> 
> On Tue, Jun 12, 2018 at 12:24 AM, Leo Liu <sdl.web <at> gmail.com> wrote:
> >
> > 1. emacs -q
> > 2. in dired mode press !
> > 3. C-h v
> >
> > Step 3 should give you no completion. Another issue is when
> > icomplete-mode is on one constantly gets "No matches" for every input.
> >
> > This is due to the following change.
> >
> > commit c2a8cffe8044cc38c4cf1b5c3d1c9571ddeec623
> > Date:   Sun Aug 6 10:15:17 2017 -0400
> >
> >     ; Fix previous commit
> >
> >     The mailcap minibuffer completion used dynamic binding.  Locally set
> >     a dynamic variable.
> >     * lisp/dired-aux.el: Store list of files in
> >     `minibuffer-completion-table'.
> >
> > I intend to fix the issue on emacs-26 with the following patch. Comments?
> 
> Nope, looks fine to me.

Leo, do you need help in installing this?

Thanks.

Message #14 received at 31794 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Mark Oteiza <mvoteiza <at> udel.edu>, 31794 <at> debbugs.gnu.org
Subject: Re: bug#31794: 26.1; dired-do-shell-command broken
Date: Sat, 23 Jun 2018 21:32:09 +0800

On 2018-06-23 16:18 +0300, Eli Zaretskii wrote:
> Leo, do you need help in installing this?
>
> Thanks.

Sorry for the lack of activity. I was moving last week and things are
bit messy at the moment. The worst is no good internet connection. So
yes I'd appreciate it if someone can help me install the fix. Otherwise
I'll get to it ASAP (might be one or two weeks).

Leo

Message #19 received at 31794-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: mvoteiza <at> udel.edu, 31794-done <at> debbugs.gnu.org
Subject: Re: bug#31794: 26.1; dired-do-shell-command broken
Date: Sat, 23 Jun 2018 16:49:03 +0300

> From:  Leo Liu <sdl.web <at> gmail.com>
> Cc: Mark Oteiza <mvoteiza <at> udel.edu>,  31794 <at> debbugs.gnu.org
> Date: Sat, 23 Jun 2018 21:32:09 +0800
> 
> Sorry for the lack of activity. I was moving last week and things are
> bit messy at the moment. The worst is no good internet connection. So
> yes I'd appreciate it if someone can help me install the fix. Otherwise
> I'll get to it ASAP (might be one or two weeks).

Thanks, I pushed it to the emacs-26 branch, and I'm marking this bug
done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.