GNU bug report logs - #31828
[PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31828 in the body.
You can then email your comments to 31828 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome
Date: Thu, 14 Jun 2018 11:43:34 -0400

[Message part 1 (text/plain, inline)]

From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi <at> gmail.com>
Date: Thu, 14 Jun 2018 11:41:35 -0400
Subject: [PATCH] Add missing autoload for browse-url-chrome

* lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.
---
 lisp/net/browse-url.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index a84a7b1c71..85cf898438 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -1145,6 +1145,7 @@ browse-url-chromium
         browse-url-chromium-arguments
         (list url)))))

+;;;###autoload
 (defun browse-url-chrome (url &optional _new-window)
   "Ask the Google Chrome WWW browser to load URL.
 Default to the URL around or before point.  The strings in
-- 
2.17.0.rc0


-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #8 received at 31828 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 31828 <at> debbugs.gnu.org
Subject: Re: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for
 browse-url-chrome
Date: Thu, 14 Jun 2018 18:56:29 +0300

> From: Kaushal Modi <kaushal.modi <at> gmail.com>
> Date: Thu, 14 Jun 2018 11:43:34 -0400
> 
> From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
> From: Kaushal Modi <kaushal.modi <at> gmail.com>
> Date: Thu, 14 Jun 2018 11:41:35 -0400
> Subject: [PATCH] Add missing autoload for browse-url-chrome
> 
> * lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.

No rationale?

Message #11 received at 31828 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31828 <at> debbugs.gnu.org
Subject: Re: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for
 browse-url-chrome
Date: Thu, 14 Jun 2018 11:59:27 -0400

[Message part 1 (text/plain, inline)]

The rationale is because I ended up with this error:

> Symbol’s function definition is void: browse-url-chrome

:)

Then looking up in lisp/net/browse-url.el, I saw that all browse-url-*
functions had an autoload except for browse-url-chrome.

So it looked like a clear oversight. Is that correct?




On Thu, Jun 14, 2018 at 11:56 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Kaushal Modi <kaushal.modi <at> gmail.com>
> > Date: Thu, 14 Jun 2018 11:43:34 -0400
> >
> > From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
> > From: Kaushal Modi <kaushal.modi <at> gmail.com>
> > Date: Thu, 14 Jun 2018 11:41:35 -0400
> > Subject: [PATCH] Add missing autoload for browse-url-chrome
> >
> > * lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.
>
> No rationale?
>
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #14 received at 31828 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 31828 <at> debbugs.gnu.org
Subject: Re: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for
 browse-url-chrome
Date: Thu, 14 Jun 2018 20:54:15 +0300

> From: Kaushal Modi <kaushal.modi <at> gmail.com>
> Date: Thu, 14 Jun 2018 11:59:27 -0400
> Cc: 31828 <at> debbugs.gnu.org
> 
> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* functions had an autoload except for
> browse-url-chrome. 

No, not all of them.

> So it looked like a clear oversight. Is that correct?

I don't think it's an oversight.  Chrome is proprietary software.

Message #17 received at 31828 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31828 <at> debbugs.gnu.org
Subject: Re: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for
 browse-url-chrome
Date: Thu, 14 Jun 2018 13:59:11 -0400

[Message part 1 (text/plain, inline)]

If this was intentional, it's not a big deal. You can reject this patch.

My use-package based workaround is quite simple (in case any one else ends
up here while searching):

(use-package browse-url
  :commands (browse-url-chrome)) ;
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31828


On Thu, Jun 14, 2018 at 1:54 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Kaushal Modi <kaushal.modi <at> gmail.com>
> > Date: Thu, 14 Jun 2018 11:59:27 -0400
> > Cc: 31828 <at> debbugs.gnu.org
> >
> > Then looking up in lisp/net/browse-url.el, I saw that all browse-url-*
> functions had an autoload except for
> > browse-url-chrome.
>
> No, not all of them.
>
> > So it looked like a clear oversight. Is that correct?
>
> I don't think it's an oversight.  Chrome is proprietary software.
>
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #20 received at 31828 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31828 <at> debbugs.gnu.org, Kelvin White <kwhite <at> gnu.org>,
 Kaushal Modi <kaushal.modi <at> gmail.com>
Subject: Re: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for
 browse-url-chrome
Date: Fri, 15 Jun 2018 06:41:27 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Kaushal Modi <kaushal.modi <at> gmail.com>
>> Date: Thu, 14 Jun 2018 11:59:27 -0400
>> Cc: 31828 <at> debbugs.gnu.org
>> 
>> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* functions had an autoload except for
>> browse-url-chrome. 
>
> No, not all of them.

Looks like the only other one missing an autoload is
browse-url-epiphany.

>> So it looked like a clear oversight. Is that correct?
>
> I don't think it's an oversight.  Chrome is proprietary software.

If that's the reason, shouldn't it be removed completely (and people who
want to use Chrome could just set browse-url-chromium-program to
"chrome" instead)?  I've cc'd the author of the commit which added it.

[1: 05a630484f]: 2016-01-24 14:47:28 -0500
  browse-url.el: Add 'google-chrome' to supported browsers.
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05a630484fd652f67ce06679fb3f890f5fdd65ea

Message #25 received at 31828 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 31828 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Kelvin White <kwhite <at> gnu.org>, Kaushal Modi <kaushal.modi <at> gmail.com>
Subject: Re: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for
 browse-url-chrome
Date: Wed, 15 May 2019 06:27:55 +0200

Noam Postavsky <npostavs <at> gmail.com> writes:

> If that's the reason, shouldn't it be removed completely (and people who
> want to use Chrome could just set browse-url-chromium-program to
> "chrome" instead)?  I've cc'd the author of the commit which added it.

My guess would be that some people may want to use both Chrome and
Chromium, so I think it might make sense to have separate functions.

And leaving the autoload off of the -chrome version seems OK to me, so
I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.