GNU bug report logs - #31844
[cuirass] Invalid specs are ignored, should be reported instead

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31844 in the body.
You can then email your comments to 31844 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: <bug-guix <at> gnu.org>
Subject: [cuirass] Invalid specs are ignored, should be reported instead
Date: Fri, 15 Jun 2018 14:37:19 +0200

When Cuirass processes a list of specifications it silently ignores
those that would result in erroneous SQL statements.

Take for example a specification that does not include an #:arguments
field.  The database schema says that “arguments” may not be NULL, but
db-add-specification will produce an INSERT statement that sets
“arguments” to NULL when it is not part of the specification alist.

Cuirass should either validate the specifications before passing them to
“db-add-specification” or report an error when “db-add-specification”
fails to add a table record.

--
Ricardo

Message #10 received at 31844-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: 31844-done <at> debbugs.gnu.org
Subject: Re: bug#31844: [cuirass] Invalid specs are ignored, should be
 reported instead
Date: Thu, 25 Mar 2021 14:56:08 +0100

Hello,

Invalid specifications are now reported, see for example:

--8<---------------cut here---------------start------------->8---
(list (specification
       (namee "guix-master")
       (build 'hello)))
--8<---------------cut here---------------end--------------->8---

gives,

--8<---------------cut here---------------start------------->8---
2021-03-25T14:52:46 running Fibers on 4 kernel threads
/home/mathieu/cuirass/examples/hello.scm:1:6: error: (specification (namee "guix-master") (build (quote hello))): extraneous field initializers (namee)
--8<---------------cut here---------------end--------------->8---

Closing this one,

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.