GNU bug report logs - #31914
[PATCH] gnu: Add emacs-atom-one-dark-theme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31914 in the body.
You can then email your comments to 31914 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Mikkelsen <peter <at> alaok.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-atom-one-dark-theme.
Date: Wed, 20 Jun 2018 16:49:19 +0200

Date: Tue, 19 Jun 2018 21:19:44 +0200
User-agent: mu4e 1.0; emacs 26.1
From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
* gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
---
 gnu/packages/emacs.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 219358bbd..86fa34cf9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3213,6 +3213,25 @@ started with 20 minutes.  All values are customizable.")
 organizer.")
     (license license:gpl3+)))
 
+(define-public emacs-atom-one-dark-theme
+  (package
+   (name "emacs-atom-one-dark-theme")
+   (version "20180607.1638")
+   (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://melpa.org/packages/atom-one-dark-theme-"
+                   version ".el"))
+             (sha256
+              (base32
+               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
+   (build-system emacs-build-system)
+   (home-page
+    "https://github.com/jonathanchu/atom-one-dark-theme")
+   (synopsis "Atom One Dark color theme for Emacs")
+   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
+   (license license:gpl3)))
+
 (define-public emacs-zenburn-theme
   (package
     (name "emacs-zenburn-theme")
-- 
2.17.1

Message #8 received at 31914 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Peter Mikkelsen <peter <at> alaok.org>, 31914 <at> debbugs.gnu.org
Subject: Re: [bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.
Date: Mon, 25 Jun 2018 21:10:05 +0200

[Message part 1 (text/plain, inline)]

Hello Peter,

Peter Mikkelsen <peter <at> alaok.org> writes:

> Date: Tue, 19 Jun 2018 21:19:44 +0200
> User-agent: mu4e 1.0; emacs 26.1
> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable

[...]
  
> +(define-public emacs-atom-one-dark-theme
> +  (package
> +   (name "emacs-atom-one-dark-theme")
> +   (version "20180607.1638")
> +   (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "https://melpa.org/packages/atom-one-dark-theme-"
> +                   version ".el"))

Could you change this to use a git checkout or release tarball instead?
MELPA does not preserve old versions, so this version might not be
around for long.

> +             (sha256
> +              (base32
> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
> +   (build-system emacs-build-system)
> +   (home-page
> +    "https://github.com/jonathanchu/atom-one-dark-theme")
> +   (synopsis "Atom One Dark color theme for Emacs")
> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
> +   (license license:gpl3)))

This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
an updated patch please?

Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31914 <at> debbugs.gnu.org (full text, mbox):

From: Peter Mikkelsen <peter <at> alaok.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31914 <at> debbugs.gnu.org
Subject: Re: [bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.
Date: Fri, 29 Jun 2018 12:54:29 +0200

[Message part 1 (text/plain, inline)]

Hi, sorry for the delay

Marius Bakke writes:

> Hello Peter,
>
> Peter Mikkelsen <peter <at> alaok.org> writes:
>
>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>> User-agent: mu4e 1.0; emacs 26.1
>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>
> [...]
>   
>> +(define-public emacs-atom-one-dark-theme
>> +  (package
>> +   (name "emacs-atom-one-dark-theme")
>> +   (version "20180607.1638")
>> +   (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "https://melpa.org/packages/atom-one-dark-theme-"
>> +                   version ".el"))
>
> Could you change this to use a git checkout or release tarball instead?
> MELPA does not preserve old versions, so this version might not be
> around for long.

I didn't know that, but since the last release is quite old, I decided
to use a git checkout.

>> +             (sha256
>> +              (base32
>> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>> +   (build-system emacs-build-system)
>> +   (home-page
>> +    "https://github.com/jonathanchu/atom-one-dark-theme")
>> +   (synopsis "Atom One Dark color theme for Emacs")
>> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>> +   (license license:gpl3)))
>
> This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
> an updated patch please?

I have attached an updated patch :)
Thanks

[0001-gnu-Add-emacs-atom-one-dark-theme.patch (text/x-patch, attachment)]

Message #16 received at 31914-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Peter Mikkelsen <peter <at> alaok.org>
Cc: 31914-done <at> debbugs.gnu.org
Subject: Re: [bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.
Date: Tue, 03 Jul 2018 15:30:59 +0200

[Message part 1 (text/plain, inline)]

Peter Mikkelsen <peter <at> alaok.org> writes:

> Hi, sorry for the delay
>
> Marius Bakke writes:
>
>> Hello Peter,
>>
>> Peter Mikkelsen <peter <at> alaok.org> writes:
>>
>>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>>> User-agent: mu4e 1.0; emacs 26.1
>>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>>
>> [...]
>>   
>>> +(define-public emacs-atom-one-dark-theme
>>> +  (package
>>> +   (name "emacs-atom-one-dark-theme")
>>> +   (version "20180607.1638")
>>> +   (source (origin
>>> +             (method url-fetch)
>>> +             (uri (string-append
>>> +                   "https://melpa.org/packages/atom-one-dark-theme-"
>>> +                   version ".el"))
>>
>> Could you change this to use a git checkout or release tarball instead?
>> MELPA does not preserve old versions, so this version might not be
>> around for long.
>
> I didn't know that, but since the last release is quite old, I decided
> to use a git checkout.
>
>>> +             (sha256
>>> +              (base32
>>> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>>> +   (build-system emacs-build-system)
>>> +   (home-page
>>> +    "https://github.com/jonathanchu/atom-one-dark-theme")
>>> +   (synopsis "Atom One Dark color theme for Emacs")
>>> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>>> +   (license license:gpl3)))
>>
>> This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
>> an updated patch please?
>
> I have attached an updated patch :)

Thank you!  I've applied the patch, with one modification: the latest
git tag is "0.4.0"; and the same version number appears in the
commentary of atom-one-dark-theme.el, so it seemed more accurate than
"0.1".

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.