GNU bug report logs - #31933
[PATCH 1/2] gnu: emacs-emms-player-simple-mpv: Deprecate in favor of Emms 5.0+.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Thu, 21 Jun 2018 17:16:05 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31933 in the body.
You can then email your comments to 31933 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Thu, 21 Jun 2018 17:16:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre Neidhardt <ambrevar <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 21 Jun 2018 17:16:05 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: emacs-emms-player-simple-mpv: Deprecate in favor of
 Emms 5.0+.
Date: Thu, 21 Jun 2018 19:15:18 +0200
* gnu/packages/emacs.scm (emacs-emms-player-simple-mpv): Deprecate.
---
 gnu/packages/emacs.scm | 27 ++-------------------------
 1 file changed, 2 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cdd72ec55..27728b9ea 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -9656,31 +9656,8 @@ time is being spent during Emacs startup in order to optimize startup time.")
     (license license:gpl3+)))
 
 (define-public emacs-emms-player-simple-mpv
-  (let ((commit "101d120ccdee1c2c213fd2f0423c858b21649c00")
-        (revision "1"))
-    (package
-      (name "emacs-emms-player-simple-mpv")
-      (version (string-append "0.4.0" "-" revision "."
-                              (string-take commit 7)))
-
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/momomo5717/emms-player-simple-mpv.git")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "1i6rxkm0ra0jbkkwgkwxg3vk5xfl794h1gkgnlpscynz0v94b6ll"))))
-      (build-system emacs-build-system)
-      (propagated-inputs
-       `(("emacs-emms" ,emms)))
-      (home-page "https://github.com/momomo5717/emms-player-simple-mpv")
-      (synopsis "Extension of @file{emms-player-simple.el} for mpv JSON IPC")
-      (description "@code{emms-player-simple-mpv} provides macros and
-functions for defining emms simple players of mpv.")
-      (license license:gpl3+))))
+  ;; A new mpv backend is included in Emms from 5.0.
+  (deprecated-package "emacs-emms-player-simple-mpv" emms))
 
 (define-public emacs-magit-org-todos-el
   (let ((commit "df206287737b9671f2e36ae7b1474ebbe9940d2a"))
-- 
2.17.1





Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Thu, 21 Jun 2018 17:20:01 GMT) Full text and rfc822 format available.

Message #8 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 31933 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: emacs-emms-player-mpv: Deprecate in favor of Emms
 5.0+.
Date: Thu, 21 Jun 2018 19:19:19 +0200
* gnu/packages/emacs.scm (emacs-emms-player-mpv): Deprecate.
---
 gnu/packages/emacs.scm | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 27728b9ea..ccb2393b7 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1022,27 +1022,8 @@ light user interface.")
     (license license:gpl3+)))
 
 (define-public emacs-emms-player-mpv
-  (package
-    (name "emacs-emms-player-mpv")
-    (version "0.1.0")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "https://github.com/dochang/emms-player-mpv/archive/"
-                           version ".tar.gz"))
-       (file-name (string-append name "-" version ".tar.gz"))
-       (sha256
-        (base32
-         "05qwbagc4i7yn7i94r1hdgj6wc5xijy1pxqv08pwsmli9rqj51n9"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emms" ,emms)))
-    (home-page "https://github.com/dochang/emms-player-mpv/")
-    (synopsis "Mpv support for EMMS")
-    (description
-     "This package provides an EMMS player that uses mpv.  It supports pause
-and seeking.")
-    (license license:gpl3+)))
+  ;; A new mpv backend is included in Emms from 5.0.
+  (deprecated-package "emacs-emms-player-mpv" emms))
 
 (define-public emacs-emms-mode-line-cycle
   (package
-- 
2.17.1





Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Mon, 25 Jun 2018 19:58:02 GMT) Full text and rfc822 format available.

Notification sent to Pierre Neidhardt <ambrevar <at> gmail.com>:
bug acknowledged by developer. (Mon, 25 Jun 2018 19:58:02 GMT) Full text and rfc822 format available.

Message #13 received at 31933-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31933-done <at> debbugs.gnu.org
Subject: Re: [bug#31933] [PATCH 1/2] gnu: emacs-emms-player-simple-mpv:
 Deprecate in favor of Emms 5.0+.
Date: Mon, 25 Jun 2018 21:56:52 +0200
Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-emms-player-simple-mpv): Deprecate.

[...]

> * gnu/packages/emacs.scm (emacs-emms-player-mpv): Deprecate.

Applied both, thanks!

Ludo'.




Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Mon, 25 Jun 2018 22:58:02 GMT) Full text and rfc822 format available.

Message #16 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31933 <at> debbugs.gnu.org
Subject: Re: [bug#31933] ‘emacs-emms-player-simple-mpv’ is not ‘emms-player-mpv.el’
Date: Tue, 26 Jun 2018 01:57:17 +0300
[Message part 1 (text/plain, inline)]
Hello Pierre,

First of all thank for your work on Emms in Guix.

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> * gnu/packages/emacs.scm (emacs-emms-player-simple-mpv): Deprecate.
> ---
>  gnu/packages/emacs.scm | 27 ++-------------------------
>  1 file changed, 2 insertions(+), 25 deletions(-)

[…]

> +  ;; A new mpv backend is included in Emms from 5.0.
> +  (deprecated-package "emacs-emms-player-simple-mpv" emms))

Did something change since our last discussion?  :-)

- https://lists.gnu.org/archive/html/guix-devel/2018-05/msg00048.html
- https://lists.gnu.org/archive/html/guix-devel/2018-05/msg00049.html

I took a fast look on
/gnu/store/…-emacs-emms-5.0/share/emacs/site-lisp/emms-player-mpv.el but
I don't see any “json” there.

[…]

Thanks,
Oleg.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Tue, 26 Jun 2018 09:50:01 GMT) Full text and rfc822 format available.

Message #19 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31933 <at> debbugs.gnu.org
Subject: Re: [bug#31933] ‘emacs-emms-player-simple-mpv’ is not ‘emms-player-mpv.el’
Date: Tue, 26 Jun 2018 11:49:15 +0200
[Message part 1 (text/plain, inline)]
Indeed!  Since our discussion, Mike worked on a new implementation from scratch
(yes, a 3rd version) which supported IPC, was backward compatible and which
implementation was much simpler than the not-so-simple emms-player-simple-mpv.

I don't know about JSON.  Can you tell me which feature you are looking for?
I'll look into it.

If there is something we should work on with the mpv player, we can discuss this
further on the Emms mailing list.

Cheers!

-- 
Pierre Neidhardt

Recursion n.:
	See Recursion.
		-- Random Shack Data Processing Dictionary
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Wed, 27 Jun 2018 02:01:01 GMT) Full text and rfc822 format available.

Message #22 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31933 <at> debbugs.gnu.org
Subject: Re: [bug#31933] ‘emacs-emms-player-simple-mpv’ is not ‘emms-player-mpv.el’
Date: Wed, 27 Jun 2018 04:59:58 +0300
[Message part 1 (text/plain, inline)]
Hello Pierre,

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> Indeed!  Since our discussion, Mike worked on a new implementation from scratch
> (yes, a 3rd version) which supported IPC

I don't see any major or minor versions changes of emacs-emms package
from our previous discussion.  It's 5.0 still.  So our previous
discussion should still be relevant.  Do I miss something?

> , was backward compatible and which
> implementation was much simpler than the not-so-simple emms-player-simple-mpv.

That's why I've told you about 1936 lines in emms-player-simple-mpv
package.  :-) Emms MPV implementation has only about 200 lines.

> I don't know about JSON.  Can you tell me which feature you are
> looking for?

[…]

I want Emacs Emms to handle a single process as ‘emms-player-simple-mpv’
does but ‘emacs-emms’ 5.0 doesn't.  I tried ‘emacs-emms’ with following
configuration, but I didn't succeeded to get a single process:

     (require 'emms-setup)
     (emms-all)
     (emms-default-players)

Selecting next or previous item in a playlist will kill and spawn a new
‘mpv’ process.

> If there is something we should work on with the mpv player, we can discuss this
> further on the Emms mailing list.

I don't think I want to discuss anything further currently on the Emms
mailing list, because Emms mailing list is not responsible for
emacs-emms-player-simple-mpv package in Guix.

Do you have anything to prevent a revert of the change until emacs-emms
5.x will provide single process handling via JSON or another RPC?

Regards,
Oleg.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Wed, 27 Jun 2018 09:24:02 GMT) Full text and rfc822 format available.

Message #25 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31933 <at> debbugs.gnu.org
Subject: Re: [bug#31933] ‘emacs-emms-player-simple-mpv’ is not ‘emms-player-mpv.el’
Date: Wed, 27 Jun 2018 11:23:02 +0200
[Message part 1 (text/plain, inline)]
O my, I'm so sorry, I got terribly confused with all the updates happening and
got carried away into thinking that a new version of Emms had been released
since 5.0! :/

The changes I was referring to are still on master but there is no new release
since 5.0.  That 3rd implementation of the mpv backend should answer all your
needs regarding the single-process RPC.

So now:

- Either we upgrade Emms to current master.  There is no urgent need for it as
  far as Guix is concerned.

- Or we revert my patch.  We can re-apply it later once a new version of Emms
  has been released.

Sorry for the mess! :p

-- 
Pierre Neidhardt

Trust everybody, but cut the cards.
		-- Finlay Peter Dunne, "Mr. Dooley's Philosophy"
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Wed, 27 Jun 2018 12:38:01 GMT) Full text and rfc822 format available.

Message #28 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31933 <at> debbugs.gnu.org
Subject: Re: [bug#31933] ‘emacs-emms-next’
 supports JSON RPC
Date: Wed, 27 Jun 2018 15:37:06 +0300
[Message part 1 (text/plain, inline)]
Hello Pierre,

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> O my, I'm so sorry, I got terribly confused with all the updates happening and
> got carried away into thinking that a new version of Emms had been released
> since 5.0! :/

No problem, :-)

> The changes I was referring to are still on master but there is no new release
> since 5.0.

Ah, now I see.  Thank you for pointing on this.  Seems that Yoni Rabkin
recent patch series beginning are what I'm asking for.

http://git.savannah.gnu.org/cgit/emms.git/commit/?id=55c83369162231b31433cd404466e5641cd90353

> That 3rd implementation of the mpv backend should answer all your
> needs regarding the single-process RPC.
>
> So now:
>
> - Either we upgrade Emms to current master.  There is no urgent need for it as
>   far as Guix is concerned.
>
> - Or we revert my patch.  We can re-apply it later once a new version of Emms
>   has been released.

A third option is to have emacs-emms-next package builded from a master
branch, but we have a policy to stick to release versions.  I'll use the
following package recipe for myself unless somebody wants to have it in
Guix package collection, too.  Fill free to take and push it.

(define-public emms-next
  (let ((commit "9f9a9b81f741692f2d188d1b46e72f2b6db8a9a1"))
    (package
      (inherit emms)
      (name (string-append (package-name emms) "-next"))
      (version (git-version (package-version emms) "1" commit))
      (source
       (origin
         (inherit (package-source emms))
         (uri (string-append
               "https://git.savannah.gnu.org/cgit/emms.git/snapshot/emms-"
               commit ".tar.gz"))
         (sha256
          (base32
           "1wg00dr35h9shs6782s20nds8razqibys9ipzi9aa2kb3yhkdp6q")))))))


Thanks,
Oleg.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31933; Package guix-patches. (Wed, 27 Jun 2018 13:53:01 GMT) Full text and rfc822 format available.

Message #31 received at 31933 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31933 <at> debbugs.gnu.org
Subject: Re: [bug#31933] ‘emacs-emms-next’
 supports JSON RPC
Date: Wed, 27 Jun 2018 15:52:03 +0200
[Message part 1 (text/plain, inline)]
> Ah, now I see.  Thank you for pointing on this.  Seems that Yoni Rabkin
> recent patch series beginning are what I'm asking for.
> 
> http://git.savannah.gnu.org/cgit/emms.git/commit/?id=55c83369162231b31433cd404466e5641cd90353

Minor correction: It's Mike's patchset (the one I mentioned above), he deserve
most of the credits! :)

-- 
Pierre Neidhardt

My darling wife was always glum.
I drowned her in a cask of rum,
And so made sure that she would stay
In better spirits night and day.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 26 Jul 2018 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 248 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.