GNU bug report logs - #31965
[PATCH] gnu: Add gaupol.

Previous Next

Package: guix-patches;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Mon, 25 Jun 2018 15:24:02 UTC

Severity: normal

Tags: patch

Done: Pierre Neidhardt <mail <at> ambrevar.xyz>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31965 in the body.
You can then email your comments to 31965 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#31965; Package guix-patches. (Mon, 25 Jun 2018 15:24:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre Neidhardt <ambrevar <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 25 Jun 2018 15:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add gaupol.
Date: Mon, 25 Jun 2018 17:22:49 +0200
* gnu/packages/video.scm (gaupol): New variable.
---
 gnu/packages/video.scm | 67 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ff0555708..bbac4361e 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2967,3 +2967,70 @@ format and some of its derived file formats, including MP4.  It operates as a
 multiplexer and demultiplexer, and can mux video and audio in several formats
 using standalone executable files.")
     (license license:isc)))
+
+(define-public gaupol
+  (package
+    (name "gaupol")
+    (version "1.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/otsaloma/gaupol/archive/"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "12hy5x6s5xk81r75x0z4n6wpq8ygsxc4mbr47qcr0kq55kbvp6jj"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("gettext" ,gettext-minimal)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("python-pygobject" ,python-pygobject)
+       ("gtk+" ,gtk+)
+       ("python-pycairo" ,python-pycairo) ; Required or else clicking on a subtitle line fails.
+       ("python-chardet" ,python-chardet) ; Optional: Character encoding detection.
+       ("gtkspell3" ,gtkspell3)           ; Optional: Inline spell-checking.
+       ("iso-codes" ,iso-codes)           ; Optional: Translations.
+       ("gstreamer" ,gstreamer)
+       ("gst-libav" ,gst-libav)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gst-plugins-good" ,gst-plugins-good)
+       ("gst-plugins-bad" ,gst-plugins-bad)
+       ("gst-plugins-ugly" ,gst-plugins-ugly)))
+    (arguments
+     `(#:tests? #f                      ; Tests seem to require networking.
+       #:phases
+       (modify-phases %standard-phases
+         ;; gaupol's setup.py script does not support one of the Python build
+         ;; system's default flags, "--single-version-externally-managed".
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (invoke "python" "setup.py" "install"
+                     (string-append "--prefix=" (assoc-ref outputs "out"))
+                     "--root=/")))
+         (add-after 'install 'wrap-gaupol
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))
+                   (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
+               (wrap-program (string-append out "/bin/gaupol")
+                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))
+                 `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
+             #t))
+         (add-after 'install 'patch-data-dir
+           ;; Fix some path variables that setup.py seems to garble.
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* (string-append out "/lib/python3.6/site-packages/aeidon/paths.py")
+                 (("^DATA_DIR = .*$")
+                  (string-append "DATA_DIR = '" out "/share/gaupol'\n"))
+                 (("^LOCALE_DIR = .*$")
+                  (string-append "LOCALE_DIR = '" out "/share/locale'\n"))))
+             #t)))))
+    (synopsis "Editor for text-based subtitles")
+    (description
+     "Gaupol supports multiple subtitle file formats and provides means of
+creating subtitles, editing texts and timing subtitles to match video.  The
+user interface features a builtin video player and is designed with attention
+to convenience of translating and batch processing of multiple documents.")
+    (home-page "http://otsaloma.io/gaupol/")
+    (license license:gpl3+)))
-- 
2.17.1





Information forwarded to guix-patches <at> gnu.org:
bug#31965; Package guix-patches. (Mon, 25 Jun 2018 15:28:02 GMT) Full text and rfc822 format available.

Message #8 received at 31965 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 31965 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add gaupol.
Date: Mon, 25 Jun 2018 17:27:14 +0200
[Message part 1 (text/plain, inline)]
Gaupol seems to work fine except that I can't get the embedded video
player to work.

According to upstream

	https://github.com/otsaloma/gaupol/issues/87

we need gtksink, which normally is to be bound in gst-plugins-good.
When guilx builds it, we can see that that it compiles it:


  CC       gtksink-gtksink.o
  ...
  CCLD     gtksink

However there is no further trace of it during the install phase.  It is
skipped for some reason.

Anyone?

-- 
Pierre Neidhardt
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#31965; Package guix-patches. (Thu, 12 Jul 2018 21:21:01 GMT) Full text and rfc822 format available.

Message #11 received at 31965 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31965 <at> debbugs.gnu.org
Subject: Re: [bug#31965] [PATCH] gnu: Add gaupol.
Date: Thu, 12 Jul 2018 23:20:16 +0200
Hello Pierre!

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/video.scm (gaupol): New variable.

[...]

> +         (add-after 'install 'patch-data-dir
> +           ;; Fix some path variables that setup.py seems to garble.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* (string-append out "/lib/python3.6/site-packages/aeidon/paths.py")

This could break silently the day we switch to Python 3.7.  Instead, I
think you can write:

  (substitute* (find-files out "^paths\\.py$")
    …)

There’s possibly another issue: if there exists a ‘paths.pyc’ file, it
becomes outdated once we’ve modified ‘paths.py’.

Perhaps we should move this phase before the build phase?

Otherwise LGTM, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#31965; Package guix-patches. (Thu, 12 Jul 2018 21:22:02 GMT) Full text and rfc822 format available.

Message #14 received at 31965 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31965 <at> debbugs.gnu.org
Subject: Re: [bug#31965] [PATCH] gnu: Add gaupol.
Date: Thu, 12 Jul 2018 23:21:43 +0200
Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> Gaupol seems to work fine except that I can't get the embedded video
> player to work.
>
> According to upstream
>
> 	https://github.com/otsaloma/gaupol/issues/87
>
> we need gtksink, which normally is to be bound in gst-plugins-good.
> When guilx builds it, we can see that that it compiles it:
>
>
>   CC       gtksink-gtksink.o
>   ...
>   CCLD     gtksink
>
> However there is no further trace of it during the install phase.  It is
> skipped for some reason.

No idea, but I suspect this is not intended.

Ludo’.




bug closed, send any further explanations to 31965 <at> debbugs.gnu.org and Pierre Neidhardt <ambrevar <at> gmail.com> Request was from Pierre Neidhardt <mail <at> ambrevar.xyz> to control <at> debbugs.gnu.org. (Sat, 16 Mar 2019 15:58:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 14 Apr 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 350 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.