GNU bug report logs - #31974
If a phase returns #f, a warning is issued, but the build continues

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Severity: important; Reported by: Mark H Weaver <mhw@HIDDEN>; dated Tue, 26 Jun 2018 03:15:01 UTC; Maintainer for guix is bug-guix@HIDDEN.
Severity set to 'important' from 'normal' Request was from ludo@HIDDEN (Ludovic Courtès) to control <at> debbugs.gnu.org. Full text available.

Message received at 31974 <at> debbugs.gnu.org:


Received: (at 31974) by debbugs.gnu.org; 27 Jun 2018 20:15:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 27 16:15:06 2018
Received: from localhost ([127.0.0.1]:37895 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1fYGqI-0008O9-1z
	for submit <at> debbugs.gnu.org; Wed, 27 Jun 2018 16:15:06 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40402)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1fYGqH-0008NP-4i
 for 31974 <at> debbugs.gnu.org; Wed, 27 Jun 2018 16:15:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1fYGqB-0006uK-Ce
 for 31974 <at> debbugs.gnu.org; Wed, 27 Jun 2018 16:15:00 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54592)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1fYGqB-0006u3-8o; Wed, 27 Jun 2018 16:14:59 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44588 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1fYGqA-0006U4-NA; Wed, 27 Jun 2018 16:14:58 -0400
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: Mark H Weaver <mhw@HIDDEN>
Subject: Re: bug#31974: If a phase returns #f, a warning is issued,
 but the build continues
References: <87efgu8clc.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 9 Messidor an 226 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Wed, 27 Jun 2018 22:14:57 +0200
In-Reply-To: <87efgu8clc.fsf@HIDDEN> (Mark H. Weaver's message of "Mon, 25
 Jun 2018 23:13:03 -0400")
Message-ID: <87bmbwx9z2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 31974
Cc: 31974 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

Mark H Weaver <mhw@HIDDEN> skribis:

> I just noticed that I made a mistake in commit
> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in
> (guix build gnu-build-system) to issue a warning if a phase returns a
> value other than #t.
>
> The result is that if a phase returns a value other than #t, a warning
> is issued, but the build nonetheless continues to the next phase, and
> the build could ultimately "succeed" even some phases returned #f.
>
> In other words, the return values of phases are effectively ignored,
> except for the warning, so the only way to cause a build with phases to
> fail is to raise an exception.

Thanks for the heads-up.  In practice, I suppose many builds would
eventually fail anyway, but we=E2=80=99ll have to keep an eye on it.

Ludo=E2=80=99.




Information forwarded to bug-guix@HIDDEN:
bug#31974; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 26 Jun 2018 03:14:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 25 23:14:34 2018
Received: from localhost ([127.0.0.1]:35511 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1fXeR7-0005Jd-Sd
	for submit <at> debbugs.gnu.org; Mon, 25 Jun 2018 23:14:34 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50033)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mhw@HIDDEN>) id 1fXeR5-0005JQ-CX
 for submit <at> debbugs.gnu.org; Mon, 25 Jun 2018 23:14:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mhw@HIDDEN>) id 1fXeQz-0007Q2-Bi
 for submit <at> debbugs.gnu.org; Mon, 25 Jun 2018 23:14:26 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:44705)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mhw@HIDDEN>) id 1fXeQz-0007Py-8E
 for submit <at> debbugs.gnu.org; Mon, 25 Jun 2018 23:14:25 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40997)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <mhw@HIDDEN>) id 1fXeQy-000730-6Y
 for bug-guix@HIDDEN; Mon, 25 Jun 2018 23:14:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mhw@HIDDEN>) id 1fXeQu-0007Oh-SF
 for bug-guix@HIDDEN; Mon, 25 Jun 2018 23:14:24 -0400
Received: from world.peace.net ([64.112.178.59]:42294)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mhw@HIDDEN>) id 1fXeQu-0007OR-O7
 for bug-guix@HIDDEN; Mon, 25 Jun 2018 23:14:20 -0400
Received: from mhw by world.peace.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <mhw@HIDDEN>)
 id 1fXeQt-0001iq-IB; Mon, 25 Jun 2018 23:14:19 -0400
From: Mark H Weaver <mhw@HIDDEN>
To: bug-guix@HIDDEN
Subject: If a phase returns #f, a warning is issued, but the build continues
Date: Mon, 25 Jun 2018 23:13:03 -0400
Message-ID: <87efgu8clc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

I just noticed that I made a mistake in commit
d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in
(guix build gnu-build-system) to issue a warning if a phase returns a
value other than #t.

The result is that if a phase returns a value other than #t, a warning
is issued, but the build nonetheless continues to the next phase, and
the build could ultimately "succeed" even some phases returned #f.

In other words, the return values of phases are effectively ignored,
except for the warning, so the only way to cause a build with phases to
fail is to raise an exception.

We can't fix this problem without a full rebuild.  Sorry about that :-(

The only good news here is that I've already fixed all of the core
packages to return #t from all phases and to report errors using
exceptions.  Ditto for all of the packages that I use on my GNOME
desktop.  The remaining packages that might return #f from a phase could
be fixed in 'master'.

      Mark




Acknowledgement sent to Mark H Weaver <mhw@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#31974; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 27 Jun 2018 21:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.