GNU bug report logs - #32088
Python >=3.5 test suite failures

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32088 in the body.
You can then email your comments to 32088 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lukas Fleischer <lfleischer <at> lfos.de>
To: bug-automake <at> gnu.org
Cc: Lukas Fleischer <lfleischer <at> lfos.de>
Subject: Python >=3.5 test suite failures
Date: Sat, 07 Jul 2018 21:35:28 +0200

Hi,

Currently, the automake test suite fails with recent Python versions. I
submitted two patches to address these issues to the automake-patches
mailing list ~7 weeks ago. Any chance we can get these bugs fixed
anytime soon?

Regards,
Lukas

[1] http://lists.gnu.org/archive/html/automake-patches/2018-05/msg00001.html

Message #8 received at 32088 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: Lukas Fleischer <lfleischer <at> lfos.de>
Cc: 32088 <at> debbugs.gnu.org
Subject: Re: bug#32088: Python >=3.5 test suite failures
Date: Sat, 07 Jul 2018 23:35:47 +0200

Hello Lukas,

Lukas Fleischer <lfleischer <at> lfos.de> writes:

> Currently, the automake test suite fails with recent Python versions. I
> submitted two patches to address these issues to the automake-patches
> mailing list ~7 weeks ago. Any chance we can get these bugs fixed
> anytime soon?
>
> [1] http://lists.gnu.org/archive/html/automake-patches/2018-05/msg00001.html

I am going to review those.

Thanks for reminding us about that.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Message #11 received at 32088 <at> debbugs.gnu.org (full text, mbox):

From: "Andreas K. Huettel" <dilfridge <at> gentoo.org>
To: 32088 <at> debbugs.gnu.org
Cc: base-system <at> gentoo.org, Lukas Fleischer <lfleischer <at> lfos.de>,
 Mathieu Lirzin <mthl <at> gnu.org>, mgorny <at> gentoo.org
Subject: Re: bug#32088: Python >=3.5 test suite failures
Date: Mon, 20 Jan 2020 06:05:27 +0100

[Message part 1 (text/plain, inline)]

> > Currently, the automake test suite fails with recent Python versions. I
> > submitted two patches to address these issues to the automake-patches
> > mailing list ~7 weeks ago. Any chance we can get these bugs fixed
> > anytime soon?
> > 
> > [1]
> > http://lists.gnu.org/archive/html/automake-patches/2018-05/msg00001.ht
> > ml> 
> I am going to review those.
> 
> Thanks for reminding us about that.

Any news here? I mean, Python 2 is going away (if not already gone)...

I've reviewed both patches and added them to the Gentoo version of 
automake.

That said, compatibility with recent python isn't complete then.

1) With the second patch I hit the command line length limit in t/instmany-
python.sh, which then fails (no wonder if every file gets prepended 
__pycache__/ ...). I've worked around that by increasing the limit in t/
instmany-python.sh from the somewhat arbitrary 2500 to 3200. Neverthlesss, 
maybe a more elegant solution is possible.

2) The fix/patch of bug #38043 (Incorrect Python byte-compiling for Python 
3 and PyPy3), which we also carry, interferes with t/py-compile-basedir.sh; 
the number of generated files (line 47 there) is then (only for recent 
Python 3) 6, not 4.

-- 
Andreas K. Hüttel
dilfridge <at> gentoo.org
Gentoo Linux developer 
(council, toolchain, base-system, perl, libreoffice)

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 32088 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: dilfridge <at> gentoo.org
Cc: mgorny <at> gentoo.org, lfleischer <at> lfos.de, base-system <at> gentoo.org, mthl <at> gnu.org,
 32088 <at> debbugs.gnu.org
Subject: Re: bug#32088: Python >=3.5 test suite failures
Date: Mon, 20 Jan 2020 16:16:20 -0700

    instmany-python.sh from the somewhat arbitrary 2500 to 3200. Neverthlesss, 
    maybe a more elegant solution is possible.

Seems fine to me. Thanks for finding the workaround.

    2) The fix/patch of bug #38043 (Incorrect Python byte-compiling for
    Python 3 and PyPy3), which we also carry, interferes with
    t/py-compile-basedir.sh; the number of generated files (line 47
    there) is then (only for recent Python 3) 6, not 4.

People will surely be running make check on older machines.

Maybe the simplest way is just to accept either 4 or 6 in the stated
 test $(echo "$files" | wc -l) -eq 4
as long as those are the only results ... so far ...

Jim, wdyt? --thanks, karl.

Message #17 received at 32088 <at> debbugs.gnu.org (full text, mbox):

From: "Andreas K. Huettel" <dilfridge <at> gentoo.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: mgorny <at> gentoo.org, lfleischer <at> lfos.de, base-system <at> gentoo.org, mthl <at> gnu.org,
 32088 <at> debbugs.gnu.org
Subject: Re: bug#32088: Python >=3.5 test suite failures
Date: Tue, 21 Jan 2020 01:42:02 +0100

>     2) The fix/patch of bug #38043 (Incorrect Python byte-compiling for
>     Python 3 and PyPy3), which we also carry, interferes with
>     t/py-compile-basedir.sh; the number of generated files (line 47
>     there) is then (only for recent Python 3) 6, not 4.
> 
> People will surely be running make check on older machines.
> 
> Maybe the simplest way is just to accept either 4 or 6 in the stated
>  test $(echo "$files" | wc -l) -eq 4
> as long as those are the only results ... so far ...

Yep, precisely. This is what I've used:
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-devel/automake/files/
automake-1.16.1-py3-compile-test.patch

diff -ruN automake-1.16.1.orig/t/py-compile-basedir.sh automake-1.16.1/t/
py-compile-basedir.sh
--- automake-1.16.1.orig/t/py-compile-basedir.sh        2020-01-20 
05:07:12.915260159 +0100
+++ automake-1.16.1/t/py-compile-basedir.sh     2020-01-20 
05:07:45.827074984 +0100
@@ -42,7 +42,7 @@
   py_installed "$d2/$f.pyc"
   py_installed "$d2/sub/$f.pyc"
   files=$(find "$d2" | grep '\.py[co]$')
-  test $(echo "$files" | wc -l) -eq 4
+  test $(echo "$files" | wc -l) -eq 4 -o $(echo "$files" | wc -l) -eq 6
   case $d2 in
     .|..) rm -f $files;;
        *) rm -rf "$d2";;



-- 
Andreas K. Hüttel
dilfridge <at> gentoo.org
Gentoo Linux developer 
(council, toolchain, base-system, perl, libreoffice)

Message #20 received at 32088 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: dilfridge <at> gentoo.org
Cc: mgorny <at> gentoo.org, lfleischer <at> lfos.de, base-system <at> gentoo.org, mthl <at> gnu.org,
 32088 <at> debbugs.gnu.org
Subject: Re: bug#32088: Python >=3.5 test suite failures
Date: Sat, 1 Feb 2020 19:14:49 -0700

Hi Andreas, Lukas, and all - I have pushed Lukas's two patches, tweaked
per Andreas's subsequent fixes, and also adjusted for the current sources.
Hope it flies, please reopen if problems. Thanks to all! --karl

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.