GNU bug report logs - #32136
26.1; Provide a customize variable to turn off spell-checking literal strings in flyspell-prog-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32136 in the body.
You can then email your comments to 32136 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "R. Diez" <rdiezmail-emacs <at> yahoo.de>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 26.1; Provide a customize variable to turn off spell-checking
 literal strings in flyspell-prog-mode
Date: Thu, 12 Jul 2018 22:06:01 +0000 (UTC)

I wish I could easily turn off spell-checking of literal strings in flyspell-prog-mode . Some customize variable would probably be the best way.

I mentioned it on the help-gnu-emacs mailing list here:


https://lists.gnu.org/archive/html/help-gnu-emacs/2018-07/msg00100.html

This is an excerpt from that discussion:

> it checks 
> literal strings too, even the filenames inside C's #include <blah/blah-h> 
> preprocessor directives, littering too much source code with error marks.

They are strings, aren't they?  How should Flyspell know that some
string is a file name?

> Trying to limit spell checking to just source-code comments is hard. I found 
> this page that explains how to do it:
> 
> http://blog.binchen.org/posts/effective-spell-check-in-emacs.html
> 
> But I haven't quite understood it yet (I am no Lisp expert). How about adding 
> a simple customizable variable to turn literal string checking on and off?

Message #8 received at 32136 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "R. Diez" <rdiezmail-emacs <at> yahoo.de>
Cc: 32136 <at> debbugs.gnu.org
Subject: Re: bug#32136: 26.1; Provide a customize variable to turn off
 spell-checking literal strings in flyspell-prog-mode
Date: Thu, 27 Aug 2020 13:08:24 -0700

[Message part 1 (text/plain, inline)]

tags 32136 + patch
thanks

"R. Diez" <rdiezmail-emacs <at> yahoo.de> writes:

> I wish I could easily turn off spell-checking of literal strings in
> flyspell-prog-mode . Some customize variable would probably be the
> best way.

Makes sense to me.  How about the attached patch?

With it, you can just:

   M-x customize-option RET flyspell-prog-text-faces RET

Best regards,
Stefan Kangas

[0001-Make-flyspell-prog-text-faces-into-defcustom.patch (text/x-diff, attachment)]

Message #13 received at 32136 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "R. Diez" <rdiezmail-emacs <at> yahoo.de>
Cc: 32136 <at> debbugs.gnu.org
Subject: Re: bug#32136: 26.1; Provide a customize variable to turn off
 spell-checking literal strings in flyspell-prog-mode
Date: Wed, 9 Sep 2020 11:11:20 -0700

close 32136 28.1
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

>> I wish I could easily turn off spell-checking of literal strings in
>> flyspell-prog-mode . Some customize variable would probably be the
>> best way.
>
> Makes sense to me.  How about the attached patch?
>
> With it, you can just:
>
>    M-x customize-option RET flyspell-prog-text-faces RET

No further comments within 2 weeks.

Pushed to master as commit fab443827a, and I'm closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.