GNU bug report logs - #32565
[PATCH] Add python-falcon.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Wed, 29 Aug 2018 04:11:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32565 in the body.
You can then email your comments to 32565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Wed, 29 Aug 2018 04:11:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 29 Aug 2018 04:11:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] Add python-falcon.
Date: Wed, 29 Aug 2018 00:10:01 -0400
[Message part 1 (text/plain, inline)]
Hello,

This adds Falcon, a Python library for creating web APIs.

Thank you,

Maxim

[0001-gnu-python-mimeparse-Update-to-1.6.0.patch (text/x-patch, attachment)]
[0002-gnu-Add-python-falcon.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Wed, 29 Aug 2018 04:37:01 GMT) Full text and rfc822 format available.

Message #8 received at 32565 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 32565 <at> debbugs.gnu.org
Subject: bug#32565: [PATCH] Add python-falcon-cors.
Date: Wed, 29 Aug 2018 00:36:41 -0400
[Message part 1 (text/plain, inline)]
Hi again,

I'm adding this python-falcon-cors package here as well, since it
depends on the previous python-falcon patch.

Maxim

[0003-gnu-Add-python-falcon-cors.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Thu, 30 Aug 2018 13:30:01 GMT) Full text and rfc822 format available.

Message #11 received at 32565 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32565 <at> debbugs.gnu.org
Subject: Re: [bug#32565] [PATCHv2] Add python-falcon and python-falcon-cors.
Date: Thu, 30 Aug 2018 09:29:15 -0400
[Message part 1 (text/plain, inline)]
Hello,

I've noticed we had a python-web.scm module, so I've moved python-falcon
and python-falcon-cors there instead of in python.scm.

The mimeparse patch can be kept as-is.

Thank you!

[0001-gnu-Add-python-falcon.patch (text/x-patch, attachment)]
[0002-gnu-Add-python-falcon-cors.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Sun, 02 Sep 2018 19:57:02 GMT) Full text and rfc822 format available.

Message #14 received at 32565 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 32565 <at> debbugs.gnu.org
Subject: Re: bug#32565: [PATCHv3] Add python-falcon, python-falcon-cors.
Date: Sun, 02 Sep 2018 15:55:58 -0400
[Message part 1 (text/plain, inline)]
Hello again,

Hopefully the last update to the python-falcon, python-falcon-cors
packages. I had moved the packages to python-web.scm, but failed to
notice the license field should be adapted to use license:asl2.0 rather
than l:asl2.0.

Don't forget to merge the patch "gnu: python-mimeparse: Update to
1.6.0." in my original mail as well, as it is required for Falcon to
work properly.

Thank you,

Maxim

[0001-gnu-Add-python-falcon.patch (text/x-patch, attachment)]
[0002-gnu-Add-python-falcon-cors.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Sun, 16 Sep 2018 20:33:02 GMT) Full text and rfc822 format available.

Message #17 received at 32565 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32565 <at> debbugs.gnu.org
Subject: Re: [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
Date: Sun, 16 Sep 2018 22:31:55 +0200
Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Wed, 29 Aug 2018 00:06:28 -0400
> Subject: [PATCH 1/2] gnu: Add python-falcon.
>
> * gnu/packages/python-web.scm (python-falcon): New variable.

[...]

> +    (home-page "https://falconframework.org")
> +    (synopsis
> +     "Unladen web framework for building APIs and app backends")
> +    (description
> +     "Falcon is a bare-metal Python web API framework for building
> +high-performance microservices, app backends, and higher-level frameworks.")

If you could make it a bit less catchy and more concrete (giving example
of actual features), that would be great.  :-)

>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Wed, 29 Aug 2018 00:33:17 -0400
> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>
> * gnu/packages/python-web.scm (python-falcon-cors): New variable.

[...]

> +    (home-page
> +     "https://github.com/lwcolton/falcon-cors")
> +    (synopsis "Falcon CORS middlware")
                                  ^^
Typo.

What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?

> +    (description "This middleware provides CORS support for Falcon.")

Ditto here, and bonus points if you add a couple of sentences to explain
what it does concretely.  :-)

Last point: unless you need them, you can remove the “python2-” variants
since Python 2.x is reaching end-of-life.

OK to push with changes along these lines.

Thank you!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Fri, 12 Oct 2018 13:19:02 GMT) Full text and rfc822 format available.

Message #20 received at 32565 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32565 <at> debbugs.gnu.org
Subject: Re: [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
Date: Fri, 12 Oct 2018 15:18:18 +0200
Ping!  :-)

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>>>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Wed, 29 Aug 2018 00:06:28 -0400
>> Subject: [PATCH 1/2] gnu: Add python-falcon.
>>
>> * gnu/packages/python-web.scm (python-falcon): New variable.
>
> [...]
>
>> +    (home-page "https://falconframework.org")
>> +    (synopsis
>> +     "Unladen web framework for building APIs and app backends")
>> +    (description
>> +     "Falcon is a bare-metal Python web API framework for building
>> +high-performance microservices, app backends, and higher-level frameworks.")
>
> If you could make it a bit less catchy and more concrete (giving example
> of actual features), that would be great.  :-)
>
>>>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Wed, 29 Aug 2018 00:33:17 -0400
>> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>>
>> * gnu/packages/python-web.scm (python-falcon-cors): New variable.
>
> [...]
>
>> +    (home-page
>> +     "https://github.com/lwcolton/falcon-cors")
>> +    (synopsis "Falcon CORS middlware")
>                                   ^^
> Typo.
>
> What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?
>
>> +    (description "This middleware provides CORS support for Falcon.")
>
> Ditto here, and bonus points if you add a couple of sentences to explain
> what it does concretely.  :-)
>
> Last point: unless you need them, you can remove the “python2-” variants
> since Python 2.x is reaching end-of-life.
>
> OK to push with changes along these lines.
>
> Thank you!
>
> Ludo’.




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Mon, 15 Oct 2018 02:59:02 GMT) Full text and rfc822 format available.

Notification sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
bug acknowledged by developer. (Mon, 15 Oct 2018 02:59:02 GMT) Full text and rfc822 format available.

Message #25 received at 32565-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32565-done <at> debbugs.gnu.org
Subject: Re: [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
Date: Sun, 14 Oct 2018 22:58:05 -0400
[Message part 1 (text/plain, inline)]
Hello Ludovic,

Sorry for keeping you waiting this long, and thank you for the friendly
ping! I've addressed the points of your review below.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Wed, 29 Aug 2018 00:06:28 -0400
>> Subject: [PATCH 1/2] gnu: Add python-falcon.
>>
>> * gnu/packages/python-web.scm (python-falcon): New variable.
>
> [...]
>
>> +    (home-page "https://falconframework.org")
>> +    (synopsis
>> +     "Unladen web framework for building APIs and app backends")
>> +    (description
>> +     "Falcon is a bare-metal Python web API framework for building
>> +high-performance microservices, app backends, and higher-level frameworks.")
>
> If you could make it a bit less catchy and more concrete (giving example
> of actual features), that would be great.  :-)

I've modified it like so:

--8<---------------cut here---------------start------------->8---
-     "Unladen web framework for building APIs and app backends")
+     "Web framework for building APIs and application backends")
     (description
-     "Falcon is a bare-metal Python web API framework for building
-high-performance microservices, app backends, and higher-level frameworks.")
+     "Falcon is a web API framework for building microservices, application
+backends and higher-level frameworks.  Among its features are:
+@itemize
+@item Optimized and extensible code base
+@item Routing via URI templates and REST-inspired resource
+classes
+@item Access to headers and bodies through request and response
+classes
+@item Request processing via middleware components and hooks
+@item Idiomatic HTTP error responses
+@item Straightforward exception handling
+@item Unit testing support through WSGI helpers and mocks
+@item Compatible with both CPython and PyPy
+@item Cython support for better performance when used with CPython
+@end itemize")
     (license license:asl2.0)))
--8<---------------cut here---------------end--------------->8---

I mostly took the feature list from their home page and removed some
extraneous adjectives that made it sound overly catchy.

>>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Wed, 29 Aug 2018 00:33:17 -0400
>> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>>
>> * gnu/packages/python-web.scm (python-falcon-cors): New variable.
>
> [...]
>
>> +    (home-page
>> +     "https://github.com/lwcolton/falcon-cors")
>> +    (synopsis "Falcon CORS middlware")
>                                   ^^
> Typo.

Fixed.

> What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?

Good idea.

>> +    (description "This middleware provides CORS support for Falcon.")
>
> Ditto here, and bonus points if you add a couple of sentences to explain
> what it does concretely.  :-)

I tried doing so like here:

--8<---------------cut here---------------start------------->8---
-    (synopsis "Falcon CORS middlware")
-    (description "This middleware provides CORS support for Falcon.")
+    (synopsis "Falcon @dfn{cross-origin resource sharing} (CORS) library")
+    (description "This middleware provides @dfn{cross-origin resource
+sharing} (CORS) support for Falcon.  It allows applying a specially crafted
+CORS object to the incoming requests, enabling the ability to serve resources
+over a different origin than that of the web application.")
--8<---------------cut here---------------end--------------->8---

To go further than this would require explaining what CORS is about, which is
not the right place in my opinion :).

> Last point: unless you need them, you can remove the “python2-” variants
> since Python 2.x is reaching end-of-life.

Sadly, yes, I need them.

> OK to push with changes along these lines.

Pushed as 66a9f08bb9c9ba2d7cd4ee3c2d48ea9a8e41c2c4.

Thank you for the review :)

Maxim
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#32565; Package guix-patches. (Mon, 15 Oct 2018 07:56:01 GMT) Full text and rfc822 format available.

Message #28 received at 32565-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32565-done <at> debbugs.gnu.org
Subject: Re: [bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.
Date: Mon, 15 Oct 2018 09:55:31 +0200
Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Pushed as 66a9f08bb9c9ba2d7cd4ee3c2d48ea9a8e41c2c4.

Awesome, thank you!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 12 Nov 2018 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 138 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.