GNU bug report logs - #32799
26; `(mouse-)tear-off-window'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32799 in the body.
You can then email your comments to 32799 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26; `(mouse-)tear-off-window'
Date: Fri, 21 Sep 2018 14:06:36 -0700 (PDT)

In Emacs 24.4 apparently (though there was nothing in NEWS about it)
command `mouse-tear-off-window' was renamed to `tear-off-window'.

Why?  There are lots of commands whose prefix is `mouse-' and that can
be bound only to a mouse event - like this one.

Please either: (1) make it possible to bind this command also or
alternatively to a keyboard key sequence or (2) rename this mouse-only
command back to `mouse-tear-off-window' and create a new command
`tear-off-window' that can be bound to keyboard keys.

In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Message #8 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 32799 <at> debbugs.gnu.org
Subject: Re: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sat, 22 Sep 2018 13:34:46 +0300

> Date: Fri, 21 Sep 2018 14:06:36 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> In Emacs 24.4 apparently (though there was nothing in NEWS about it)
> command `mouse-tear-off-window' was renamed to `tear-off-window'.
> 
> Why?

The comment to the change (made in July 2014) says:

  Rename from mouse-tear-off-window since it also makes sense to bind
  it to a non-mouse event.

> There are lots of commands whose prefix is `mouse-' and that can
> be bound only to a mouse event - like this one.

The alias mouse-tear-off-window is still there, no?

Message #11 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>, Stefan
 Monnier <monnier <at> iro.umontreal.ca>
Cc: 32799 <at> debbugs.gnu.org
Subject: RE: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sat, 22 Sep 2018 08:56:44 -0700 (PDT)

> The comment to the change (made in July 2014) says:
>   Rename from mouse-tear-off-window since it also makes sense to bind
>   it to a non-mouse event.

Can it in fact be bound to a non-mouse event?
If I thought it could then I would not have filed this bug.

emacs -Q

Evaluate (global-set-key "\C-o" 'tear-off-window), then try C-o.
I get this error:

command-execute: tear-off-window must be bound to an event with parameters

Same thing (naturally) if I bind a keyboard key to the alias.

If I'm missing something and this can be bound to keyboard keys then please let me know how and close the ticket.

GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30

Message #14 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 32799 <at> debbugs.gnu.org
Subject: Re: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sat, 22 Sep 2018 15:12:10 -0400

> Evaluate (global-set-key "\C-o" 'tear-off-window), then try C-o.
> I get this error:
>
> command-execute: tear-off-window must be bound to an event with parameters

Fixed with the patch below,


        Stefan


diff --git a/lisp/mouse.el b/lisp/mouse.el
index 0fe4932085..d3c953e68e 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -333,7 +333,7 @@ mouse-select-window
 (define-obsolete-function-alias 'mouse-tear-off-window 'tear-off-window "24.4")
 (defun tear-off-window (click)
   "Delete the selected window, and create a new frame displaying its buffer."
-  (interactive "e")
+  (interactive (list last-nonmenu-event))
   (mouse-minibuffer-check click)
   (let* ((window (posn-window (event-start click)))
 	 (buf (window-buffer window))

Message #17 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 32799 <at> debbugs.gnu.org
Subject: RE: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sat, 22 Sep 2018 15:47:24 -0700 (PDT)

> > Evaluate (global-set-key "\C-o" 'tear-off-window), then try C-o.
> > I get this error:
> >
> > command-execute: tear-off-window must be bound to an event with
> parameters
> 
> Fixed with the patch below,

Thanks. What Emacs release will this fix be in, so I can adjust my code accordingly?

Message #20 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: monnier <at> iro.umontreal.ca, 32799 <at> debbugs.gnu.org
Subject: Re: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sun, 23 Sep 2018 08:59:25 +0300

> Date: Sat, 22 Sep 2018 15:47:24 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 32799 <at> debbugs.gnu.org
> 
> > Fixed with the patch below,
> 
> Thanks. What Emacs release will this fix be in, so I can adjust my code accordingly?

Emacs 26.2.

Message #23 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: monnier <at> iro.umontreal.ca, 32799 <at> debbugs.gnu.org
Subject: RE: bug#32799: 26; `(mouse-)tear-off-window'
Date: Sun, 23 Sep 2018 08:32:04 -0700 (PDT)

> > > Fixed with the patch below,
> >
> > Thanks. What Emacs release will this fix be in, so I can adjust my code
> > accordingly?
> 
> Emacs 26.2.

Thanks. Actually, I decided to keep my version anyway,
even for later releases. The only difference is that it does
this at the end: It doesn't try to delete WINDOW if it is
alone in its frame. This just avoids the message "Attempt
to delete minibuffer or sole ordinary window". Minor
difference. I also have a variant which, instead of doing
nothing in that case, shows the message "Sole window
in frame".

I mention this only in case Emacs might want to do
something similar.

Message #26 received at 32799 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>,
 32799 <at> debbugs.gnu.org
Subject: Re: bug#32799: 26; `(mouse-)tear-off-window'
Date: Fri, 21 Aug 2020 04:41:01 -0700

close 32799 26.2
thanks

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> Evaluate (global-set-key "\C-o" 'tear-off-window), then try C-o.
>> I get this error:
>>
>> command-execute: tear-off-window must be bound to an event with parameters
>
> Fixed with the patch below,

The patch which fixed this issue was installed and shipped in 26.2, but
the bug was never closed.  I'm therefore closing this bug report.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.