GNU bug report logs - #32872
[PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32872 in the body.
You can then email your comments to 32872 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
Date: Sat, 29 Sep 2018 08:56:50 -0400

Without this, LibreOffice crashes on a foreign distro when the "file
open" dialog is launched. I think there *must* be a better solution but
until we identify it, we should fix the crash. I'm Currently building
this to test it.

* gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program'
phase.
---
 gnu/packages/libreoffice.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 35d49b021..198d4a625 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -1087,7 +1087,18 @@ converting QuarkXPress file format.  It supports versions 3.1 to 4.1.")
                  (mkdir-p (string-append out "/share/icons/hicolor"))
                  (copy-recursively "sysui/desktop/icons/hicolor"
                                    (string-append out "/share/icons/hicolor")))
-               #t)))
+               #t))
+           (add-after 'bin-and-desktop-install 'wrap-programs
+             (lambda* (#:key inputs outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (bin (string-append out "/bin")))
+                        (for-each (lambda (file)
+                                    (wrap-program file
+                                      `("GSETTINGS_SCHEMA_DIR" =
+                                        (,(string-append (assoc-ref inputs "gtk+")
+                                                         "/share/glib-2.0/schemas"))))
+                                    (find-files bin)))
+                        #t))))
        #:configure-flags
         (list
           "--enable-release-build"
-- 
2.19.0

Message #8 received at 32872 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 32872 <at> debbugs.gnu.org, 30642 <at> debbugs.gnu.org
Subject: Re: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
Date: Sun, 30 Sep 2018 00:05:56 +0200

Hi!

Leo Famulari <leo <at> famulari.name> skribis:

> Without this, LibreOffice crashes on a foreign distro when the "file
> open" dialog is launched. I think there *must* be a better solution but
> until we identify it, we should fix the crash. I'm Currently building
> this to test it.
>
> * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Add 'wrap-program'
> phase.

You could mention <https://bugs.gnu.org/30642> in the log.

One option discussed at the time was to use ‘glib-or-gtk-build-system’,
which should have an effect similar to the patch you posted.  Perhaps we
should just do that?

> +           (add-after 'bin-and-desktop-install 'wrap-programs
> +             (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))

Nitpick: the lambda’s body is too indented.  :-)

Thank you!

Ludo’.

Message #11 received at 32872 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 32872 <at> debbugs.gnu.org, 30642 <at> debbugs.gnu.org
Subject: Re: [bug#32872] [PATCH] gnu: LibreOffice: Fix GtkFileChooserDialog.
Date: Sun, 30 Sep 2018 07:42:51 -0400

[Message part 1 (text/plain, inline)]

On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote:
> You could mention <https://bugs.gnu.org/30642> in the log.

Right, thanks.

> One option discussed at the time was to use ‘glib-or-gtk-build-system’,
> which should have an effect similar to the patch you posted.  Perhaps we
> should just do that?

I tried this, and the build crashed in the
bin-and-desktop-install-phase. I'm currently rebuilding with
--keep-failed to learn more, but it takes several hours on my fastest
computer. Could I try building it on Bayfront to speed up the iteration
time?

> Nitpick: the lambda’s body is too indented.  :-)

It turned out to be completely malformed, but I've fixed it locally.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 32872-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 32872-done <at> debbugs.gnu.org, 30642-done <at> debbugs.gnu.org
Subject: Re: bug#30642: [bug#32872] [PATCH] gnu: LibreOffice: Fix
 GtkFileChooserDialog.
Date: Tue, 04 Dec 2018 22:29:18 +0100

Leo Famulari <leo <at> famulari.name> skribis:

> On Sun, Sep 30, 2018 at 12:05:56AM +0200, Ludovic Courtès wrote:
>> You could mention <https://bugs.gnu.org/30642> in the log.
>
> Right, thanks.

This fix was pushed in 994bccd9443032141accede0e403cbfb62f6c63e,
closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.