GNU bug report logs - #33021
nsterm.m: missing two (2) closing parentheses ...

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33021 in the body.
You can then email your comments to 33021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Keith David Bershatsky <esq <at> lawlist.com>
To: Emacs Bug Reports <bug-gnu-emacs <at> gnu.org>
Subject: nsterm.m:  missing two (2) closing parentheses ...
Date: Thu, 11 Oct 2018 18:14:54 -0700

At the convenience of the Emacs team, please add two (2) closing parentheses to nsterm.m.  While it is possible to build Emacs, working on the functions is difficult because Emacs cannot narrow properly to a defun ....  Thanks.

      if ([child parentWindow] != nil)
        {
          [[child parentWindow] removeChildWindow:child];
#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 101000
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101000

/* *** HERE *** */

          if ([child respondsToSelector:@selector(setAccessibilitySubrole:)]
#endif
              [child setAccessibilitySubrole:NSAccessibilityStandardWindowSubrole];
#endif
        }

      if (!NILP (new_value))
        {
          parent = [FRAME_NS_VIEW (p) window];

          [parent addChildWindow: child
                         ordered: NSWindowAbove];
#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 101000
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101000

/* *** HERE *** */

          if ([child respondsToSelector:@selector(setAccessibilitySubrole:)]
#endif
              [child setAccessibilitySubrole:NSAccessibilityFloatingWindowSubrole];
#endif
        }

Message #8 received at 33021 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Keith David Bershatsky <esq <at> lawlist.com>
Cc: 33021 <at> debbugs.gnu.org
Subject: Re: bug#33021: nsterm.m:  missing two (2) closing parentheses ...
Date: Thu, 11 Jul 2019 17:39:52 +0200

Keith David Bershatsky <esq <at> lawlist.com> writes:

> At the convenience of the Emacs team, please add two (2) closing parentheses to nsterm.m.  While it is possible to build Emacs, working on the functions is difficult because Emacs cannot narrow properly to a defun ....  Thanks.

Could you send a patch for this?  I'm not quite sure what you're
referring to here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 33021 <at> debbugs.gnu.org (full text, mbox):

From: Keith David Bershatsky <esq <at> lawlist.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 33021 <at> debbugs.gnu.org
Subject: Re: bug#33021: nsterm.m:  missing two (2) closing parentheses ...
Date: Thu, 11 Jul 2019 11:00:44 -0700

It looks like Alan fixed it on 12/01/2018 with 4b176eb86361cff94a223225e8b852adb1accc50.

Both "if" statements to:

if ([child respondsToSelector:@selector(setAccessibilitySubrole:)]

were missing a closing parenthesis, and *accc50 fixed that problem.

As such, it would be appropriate to close out bug 33021 at your convenience.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

> Date: [07-11-2019 08:39:52] <11 Jul 2019 17:39:52 +0200>
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> To: Keith David Bershatsky <esq <at> lawlist.com>
> Cc: 33021 <at> debbugs.gnu.org
> Subject: Re: bug#33021: nsterm.m:  missing two (2) closing parentheses ...
> 
> Keith David Bershatsky <esq <at> lawlist.com> writes:
> 
> > At the convenience of the Emacs team, please add two (2) closing parentheses to nsterm.m.  While it is possible to build Emacs, working on the functions is difficult because Emacs cannot narrow properly to a defun ....  Thanks.
> 
> Could you send a patch for this?  I'm not quite sure what you're
> referring to here.
> 
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.